Eccube\Controller\Admin\Store\OwnerStoreController::apiInstall()

Complexity

Conditions	8
Paths	246

Size

Total Lines	95
Code Lines	67

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	72

Importance

Changes	5
Bugs	0	Features	1

<?php
    public function apiInstall(Application $app, Request $request, $pluginCode, $eccubeVersion, $version)
    {
        // Check plugin code
        $url = $this->appConfig['package_repo_url'].'/search/packages.json'.'?eccube_version='.$eccubeVersion.'&plugin_code='.$pluginCode.'&version='.$version;
        list($json, $info) = $this->getRequestApi($url);

The assignment to $info is unused. Consider omitting it like so list($first,,$third).

        $existFlg = false;
        $data = json_decode($json, true);
        if (isset($data['item']) && !empty($data['item'])) {
            $existFlg = $this->pluginService->checkPluginExist($data['item'], $pluginCode);
        }
        if ($existFlg === false) {
            log_info(sprintf('%s plugin not found!', $pluginCode));
            $app->addError('admin.plugin.not.found', 'admin');

            return $app->redirect($app->url('admin_store_plugin_owners_search'));
        }

        $items = $data['item'];
        $plugin = $this->pluginService->buildInfo($items, $pluginCode);
        $dependents[] = $plugin;

$dependents was never initialized. Although not strictly required by PHP, it is generally a good practice to add $dependents = array(); before regardless.

        $dependents = $this->pluginService->getDependency($items, $plugin, $dependents);

It seems like $plugin defined by $this->pluginService->buildInfo($items, $pluginCode) on line 239 can also be of type null; however, Eccube\Service\PluginService::getDependency() does only seem to accept array, maybe add an additional type check?

        // Unset first param
        unset($dependents[0]);

        $dependentModifier = [];
        $packageNames = '';
        if (!empty($dependents)) {
            foreach ($dependents as $key => $item) {
                $pluginItem = [
                    "product_code" => $item['product_code'],
                    "version" => $item['version'],
                ];
                $dependentModifier[] = $pluginItem;
                // Re-format plugin code
                $dependents[$key]['product_code'] = self::$vendorName.'/'.$item['product_code'];
            }
            $packages = array_column($dependents, 'version', 'product_code');
            $packageNames = $this->pluginService->parseToComposerCommand($packages);
        }
        $packageNames .= ' '.self::$vendorName.'/'.$pluginCode.':'.$version;

        // Upgrade plugin backup
        $isUpgrade = $request->get('is_upgrade', false);

$isUpgrade is not used, you could remove the assignment.

        $updateData = $dependentModifier;
        $updateData[] = [
            'product_code' => $pluginCode,
            'version' => $version,
        ];
        $this->pluginService->doBackup($updateData);

        $reportData = array(
            'code' => $pluginCode,
            'version' => $version,
            'core_version' => $eccubeVersion,
            'php_version' => phpversion(),
            'db_version' => $this->systemService->getDbversion(),
            'os' => php_uname('s').' '.php_uname('r').' '.php_uname('v'),
            'host' => $request->getHost(),
            'web_server' => $request->server->get("SERVER_SOFTWARE"),
            'composer_version' => $this->composerService->composerVersion(),
            'composer_execute_mode' => $this->composerService->getMode(),
            'dependents' => json_encode($dependentModifier),
        );
        try {
            $this->composerService->execRequire($packageNames);
            // Do report to package repo
            $url = $this->appConfig['package_repo_url'].'/report';
            $this->postRequestApi($url, $reportData);
            $app->addSuccess('admin.plugin.install.complete', 'admin');

            return $app->redirect($app->url('admin_store_plugin'));
        } catch (\Exception $exception) {
            log_error($exception->getMessage());
            // Do rollback when error
            $this->pluginService->doRollback($updateData);
        } finally {
            // Remove temp files
            $pluginTempRealDir = $this->appConfig['plugin_temp_realdir'];
            $dirs = [
                $pluginTempRealDir.'/composer.json',
                $pluginTempRealDir.'/composer.lock',
            ];
            foreach ($updateData as $value) {
                $dirs[] = $pluginTempRealDir.'/'.$value['product_code'];
            }
            $this->pluginService->deleteDirs($dirs);
        }

        // Do report to package repo
        $url = $this->appConfig['package_repo_url'].'/report/fail';
        $this->postRequestApi($url, $reportData);
        $app->addError('admin.plugin.install.fail', 'admin');

        return $app->redirect($app->url('admin_store_plugin_owners_search'));
    }