Completed
Pull Request — experimental/sf (#3269)
by k-yamamura
37:12 queued 29:26
created
codeception/_support/Page/Front/ShoppingLoginPage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -27,6 +27,9 @@
 block discarded – undo
27 27
 class ShoppingLoginPage extends AbstractFrontPage
28 28
 {
29 29
 
30
+    /**
31
+     * @param \AcceptanceTester $I
32
+     */
30 33
     public static function at($I)
31 34
     {
32 35
         $page = new self($I);
Please login to merge, or discard this patch.
codeception/acceptance/AA0PluginInstallerCest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,5 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-use Codeception\Util\Fixtures;
4 3
 use Page\Admin\OwnersPluginPage;
5 4
 
6 5
 /**
Please login to merge, or discard this patch.
codeception/acceptance/EA01TopCest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -1,7 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3 3
 use Codeception\Util\Fixtures;
4
-use Page\Admin\CustomerManagePage;
5 4
 use Page\Admin\OrderManagePage;
6 5
 use Page\Admin\TopPage;
7 6
 
Please login to merge, or discard this patch.
codeception/acceptance/EA02AuthenticationCest.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -1,7 +1,5 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-use Codeception\Util\Fixtures;
4
-
5 3
 /**
6 4
  * @group admin
7 5
  * @group admin01
Please login to merge, or discard this patch.
codeception/acceptance/EA07BasicinfoCest.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -1,8 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-use Codeception\Util\Fixtures;
4 3
 use Page\Admin\CsvSettingsPage;
5
-use Page\Admin\CustomerAgreementSettingPage;
6 4
 use Page\Admin\DeliveryEditPage;
7 5
 use Page\Admin\DeliveryManagePage;
8 6
 use Page\Admin\MailSettingsPage;
@@ -10,7 +8,6 @@  discard block
 block discarded – undo
10 8
 use Page\Admin\PaymentManagePage;
11 9
 use Page\Admin\ShopSettingPage;
12 10
 use Page\Admin\TaxManagePage;
13
-use Page\Admin\TradelawSettingPage;
14 11
 
15 12
 /**
16 13
  * @group admin
Please login to merge, or discard this patch.
codeception/acceptance/EA09ShippingCest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use Page\Admin\ShippingManagePage;
6 6
 use Page\Admin\ShippingEditPage;
7 7
 use Page\Admin\OrderEditPage;
8
-use Eccube\Entity\Master\ShippingStatus;
9 8
 
10 9
 /**
11 10
  * @group admin
Please login to merge, or discard this patch.
codeception/acceptance/EF06OtherCest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -1,7 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3 3
 use Codeception\Util\Fixtures;
4
-use Eccube\Entity\Master\CustomerStatus;
5 4
 
6 5
 /**
7 6
  * @group front
Please login to merge, or discard this patch.
src/Eccube/Controller/AbstractController.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -153,6 +153,9 @@  discard block
 block discarded – undo
153 153
         $this->addWarning('admin.delete.warning', 'admin');
154 154
     }
155 155
 
156
+    /**
157
+     * @param string $targetPath
158
+     */
156 159
     public function setLoginTargetPath($targetPath, $namespace = null)
157 160
     {
158 161
         if (is_null($namespace)) {
@@ -169,7 +172,7 @@  discard block
 block discarded – undo
169 172
      * @param array  $path An array of path parameters
170 173
      * @param array  $query An array of query parameters
171 174
      *
172
-     * @return Response A Response instance
175
+     * @return \Symfony\Component\HttpFoundation\Response A Response instance
173 176
      */
174 177
     public function forwardToRoute($route, array $path = [], array $query = [])
175 178
     {
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/AdminController.php 1 patch
Doc Comments   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -334,10 +334,10 @@  discard block
 block discarded – undo
334 334
     }
335 335
 
336 336
     /**
337
-     * @param $em
337
+     * @param \Doctrine\ORM\EntityManagerInterface $em
338 338
      * @param array $excludes
339 339
      *
340
-     * @return array
340
+     * @return null|Request
341 341
      */
342 342
     protected function findOrderStatus($em, array $excludes)
343 343
     {
@@ -354,10 +354,10 @@  discard block
 block discarded – undo
354 354
     }
355 355
 
356 356
     /**
357
-     * @param $em
357
+     * @param \Doctrine\ORM\EntityManagerInterface $em
358 358
      * @param array $excludes
359 359
      *
360
-     * @return array
360
+     * @return null|Request
361 361
      */
362 362
     protected function getOrderEachStatus($em, array $excludes)
363 363
     {
@@ -387,11 +387,11 @@  discard block
 block discarded – undo
387 387
     }
388 388
 
389 389
     /**
390
-     * @param $em
391
-     * @param $dateTime
390
+     * @param \Doctrine\ORM\EntityManagerInterface $em
391
+     * @param \DateTime $dateTime
392 392
      * @param array $excludes
393 393
      *
394
-     * @return array
394
+     * @return null|Request
395 395
      */
396 396
     protected function getSalesByMonth($em, $dateTime, array $excludes)
397 397
     {
@@ -425,11 +425,11 @@  discard block
 block discarded – undo
425 425
     }
426 426
 
427 427
     /**
428
-     * @param $em
429
-     * @param $dateTime
428
+     * @param \Doctrine\ORM\EntityManagerInterface $em
429
+     * @param \DateTime $dateTime
430 430
      * @param array $excludes
431 431
      *
432
-     * @return array
432
+     * @return null|Request
433 433
      */
434 434
     protected function getSalesByDay($em, $dateTime, array $excludes)
435 435
     {
@@ -463,9 +463,9 @@  discard block
 block discarded – undo
463 463
     }
464 464
 
465 465
     /**
466
-     * @param $em
466
+     * @param \Doctrine\ORM\EntityManagerInterface $em
467 467
      *
468
-     * @return mixed
468
+     * @return null|Request
469 469
      *
470 470
      * @throws NoResultException
471 471
      * @throws \Doctrine\ORM\NonUniqueResultException
@@ -486,9 +486,9 @@  discard block
 block discarded – undo
486 486
     }
487 487
 
488 488
     /**
489
-     * @param $em
489
+     * @param \Doctrine\ORM\EntityManagerInterface $em
490 490
      *
491
-     * @return mixed
491
+     * @return null|Request
492 492
      *
493 493
      * @throws NoResultException
494 494
      * @throws \Doctrine\ORM\NonUniqueResultException
Please login to merge, or discard this patch.