Eccube\Form\Type\Admin\SecurityType

Complexity

Total Complexity

5

Size/Duplication

Total Lines	66
Duplicated Lines	24.24 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getName()	0	4	1
B	buildForm()	16	43	3

<?php
/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */


namespace Eccube\Form\Type\Admin;

use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\Form\FormError;
use Symfony\Component\Form\FormEvents;
use Symfony\Component\Validator\Constraints as Assert;

class SecurityType extends AbstractType

Missing class doc comment

{
    private $app;
    private $config;

    public function __construct($app)

Missing function doc comment

    {
        $this->app = $app;
        $this->config = $app['config'];
    }

    /**
     * {@inheritdoc}
     */
    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $app = $this->app;
        $builder
            ->add('admin_route_dir', 'text', array(
                'label' => 'ディレクトリ名',
                'constraints' => array(
                    new Assert\NotBlank(),
                    new Assert\Length(array('max' => $this->config['stext_len'])),
                    new Assert\Regex(array(
                       'pattern' => "/^[0-9a-zA-Z]+$/",

This line of the multi-line function call does not seem to be indented correctly. Expected 24 spaces, but found 23.

                   )),

This line of the multi-line function call does not seem to be indented correctly. Expected 20 spaces, but found 19.

                ),
            ))
            ->add('admin_allow_host', 'textarea', array(
                'required' => false,
                'label' => 'IP制限',
                'constraints' => array(
                    new Assert\Length(array('max' => $this->config['stext_len'])),
                ),
            ))
            ->add('force_ssl', 'checkbox', array(
                'label' => 'SSLを強制',
                'required' => false,
            ))
            ->addEventListener(FormEvents::POST_SUBMIT, function ($event) use($app) {

This code seems to be duplicated across your project.

Expected 1 space after USE keyword; found 0

                $form = $event->getForm();
                $data = $form->getData();

                $ips = preg_split("/\R/", $data['admin_allow_host'], null, PREG_SPLIT_NO_EMPTY);

                foreach($ips as $ip) {
                    $errors = $app['validator']->validateValue($ip, array(
                            new Assert\Ip(),
                        )
                    );
                    if ($errors->count() != 0) {
                        $form['admin_allow_host']->addError(new FormError($ip . 'はIPv4アドレスではありません。'));

Concat operator must not be surrounded by spaces

                    }
                }
            })
        ;
    }

    /**
     * {@inheritdoc}
     */
    public function getName()
    {
        return 'admin_security';
    }
}