Dumkaaa\BxOptimize\Handler\ImageHandler::handleQueue()

Complexity

Conditions	9
Paths	20

Size

Total Lines	37
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function handleQueue()
    {
        $handlers = [];
        foreach ($this->validExt as $ext) {
            $handlers[$ext] = HandlerTools::getBinaryHandler($ext);
        }

        foreach ($this->files as $file) {

            $command = false;

            $ext = strtolower(pathinfo($file, PATHINFO_EXTENSION));

            if($handlers[$ext]) {

                echo get_class()." обрабатывает файл: $file\n";


                switch ($ext) {
                    case 'png':
                        $command = sprintf($this->args[$ext], escapeshellarg($file));
                        break;
                    case 'jpg':
                    case 'jpeg':
                        $command =  sprintf($this->args[$ext], escapeshellarg($file), escapeshellarg($file . ".original"));
                        break;
                }
                if (!file_exists($file . ".original") && $command) {

The expression $command of type string|false is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== false instead.

                    copy($file, $file . ".original");
                    exec($handlers[$ext]  . $command);
                }

            } else {
                echo "Не найден бинарный обработчик для файла: $file\n";
            }
        }
    }
}