Dumkaaa\BxOptimize\Optimizer

Complexity

Total Complexity

9

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	1	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	optimize()	0	6	1
A	setQueue()	0	13	4
A	handleQueue()	0	7	2
A	findFiles()	0	4	1

<?php

namespace Dumkaaa\BxOptimize;

use Dumkaaa\BxOptimize\Handler\HandlerInterface;

class Optimizer implements OptimizerInterface
{
    /** @var Finder\FinderInterface null */
    protected $finder = null;

    /** @var Handler\HandlerInterface */
    protected $handlers;

    /** @var array Массив найденных файлов для обработки */
    private $files = [];

    /**
     * {@inheritdoc}
     */
    public function __construct(Finder\FinderInterface $finder = null, Handler\HandlerProcessor $handler = null)
    {
        $this->finder = $finder;
        $this->handlers = $handler->getHandlers();

It seems like $handler is not always an object, but can also be of type null. Maybe add an additional type check?

    }

    /**
     * {@inheritdoc}
     */
    public function optimize()
    {
        $this->findFiles();
        $this->setQueue();
        $this->handleQueue();
    }

    private function setQueue()
    {
        /** @var HandlerInterface $handler */
        foreach ($this->handlers as $handler) {

The expression $this->handlers of type object<Dumkaaa\BxOptimize\Handler\HandlerInterface> is not traversable.

            foreach ($this->files as $file) {
                if (!$handler->canHandleFile($file)) {
                    continue;
                } else {
                    $handler->queueFile($file);
                }
            }
        }
    }

    private function handleQueue()
    {
        /** @var HandlerInterface $handler */
        foreach ($this->handlers as $handler) {

The expression $this->handlers of type object<Dumkaaa\BxOptimize\Handler\HandlerInterface> is not traversable.

            $handler->handleQueue();
        }
    }

    private function findFiles()
    {
        $this->files = $this->finder->findFiles();
    }
}