Dumkaaa\BxOptimize\Handler\ImageHandler

Complexity

Total Complexity

9

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
D	handleQueue()	0	34	9

<?php

namespace Dumkaaa\BxOptimize\Handler;

class ImageHandler extends Handler
{
    /** {@inheritdoc} */
    protected $validExt = [
        'png',
        'jpeg',
        'jpg',
    ];
    protected $args = [
        'png' => ' -o7 %s',
        'jpg' => ' -progressive -copy none -optimize -outfile %s %s', // dest, src
        'jpeg' => ' -progressive -copy none -optimize -outfile %s %s', // dest, src
    ];

    /**
     * {@inheritdoc}
     */
    public function handleQueue()
    {
        $handlers = [];
        foreach ($this->validExt as $ext) {
            $handlers[$ext] = HandlerTools::getBinaryHandler($ext);
        }

        foreach ($this->files as $file) {

            $command = false;

            $ext = strtolower(pathinfo($file, PATHINFO_EXTENSION));

            if ($handlers[$ext]) {

                switch ($ext) {
                    case 'png':
                        $command = sprintf($this->args[$ext], escapeshellarg($file));
                        break;
                    case 'jpg':
                    case 'jpeg':
                        $command = sprintf($this->args[$ext], escapeshellarg($file), escapeshellarg($file . ".original"));
                        break;
                }
                if (!file_exists($file . ".original") && $command) {

The expression $command of type string|false is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== false instead.

                    copy($file, $file . ".original");
                    exec($handlers[$ext] . $command);
                }

            } else {
                echo "Не найден бинарный обработчик для файла: $file\n";
            }
        }
    }
}