DucCnzj\Ip\Strategies\TaobaoIp::send()

Complexity

Conditions	4
Paths	13

Size

Total Lines	21
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	4

Importance

Changes

0

<?php
    public function send(ClientInterface $httpClient, string $ip):array
    {
        try {
            $originalStr = $httpClient->request('get', $this->url . '?ip=' . $ip)
                ->getBody();

            $result = json_decode($originalStr, true);

            if ($result['code'] !== 0) {
                throw new ServerErrorException();
            }

            $data['ip'] = $ip;

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

            $data = $this->formatResult($data, $result);

            return $data;
        } catch (ServerException $e) {
            throw new ServerErrorException();
        } catch (ClientException $e) {
            throw new ServerErrorException();
        }