DucCnzj\Ip\Strategies\TaobaoIp

Complexity

Total Complexity

5

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	3
Bugs	1	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	formatResult()	0	11	1
A	send()	0	21	4

<?php

namespace DucCnzj\Ip\Strategies;

use DucCnzj\Ip\Imp\IpImp;
use GuzzleHttp\ClientInterface;
use GuzzleHttp\Exception\ClientException;
use GuzzleHttp\Exception\ServerException;
use DucCnzj\Ip\Exceptions\ServerErrorException;

class TaobaoIp implements IpImp
{
    protected $url = 'http://ip.taobao.com/service/getIpInfo.php';

    /**
     * @param ClientInterface $httpClient
     *
     * @param string $ip
     *
     * @return array
     * @throws ServerErrorException
     * @throws \GuzzleHttp\Exception\GuzzleException
     * @author duc <1025434218@qq.com>
     */
    public function send(ClientInterface $httpClient, string $ip):array
    {
        try {
            $originalStr = $httpClient->request('get', $this->url . '?ip=' . $ip)
                ->getBody();

            $result = json_decode($originalStr, true);

            if ($result['code'] !== 0) {
                throw new ServerErrorException();
            }

            $data['ip'] = $ip;

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

            $data = $this->formatResult($data, $result);

            return $data;
        } catch (ServerException $e) {
            throw new ServerErrorException();
        } catch (ClientException $e) {
            throw new ServerErrorException();
        }
    }

    /**
     * @param array $result
     * @param array $data
     *
     * @return array
     *
     * @author duc <1025434218@qq.com>
     */
    public function formatResult(array $data, array $result)
    {
        $data['country'] = $result['data']['country'];
        $data['region'] = $result['data']['region'];
        $data['city'] = $result['data']['city'];
        $data['address'] = $data['country'] . $data['region'] . $data['city'];
        $data['point_x'] = '';
        $data['point_y'] = '';
        $data['isp'] = $result['data']['isp'];

        return $data;
    }
}