Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 7 | class IssueField implements \JsonSerializable |
||
| 8 | { |
||
| 9 | /** |
||
| 10 | * @var string |
||
| 11 | */ |
||
| 12 | public $summary; |
||
| 13 | |||
| 14 | /** |
||
| 15 | * @var array |
||
| 16 | */ |
||
| 17 | public $progress; |
||
| 18 | |||
| 19 | /** |
||
| 20 | * @var \JiraRestApi\Issue\TimeTracking |
||
| 21 | */ |
||
| 22 | public $timeTracking; |
||
| 23 | |||
| 24 | /** |
||
| 25 | * @var \JiraRestApi\Issue\IssueType |
||
| 26 | */ |
||
| 27 | public $issuetype; |
||
| 28 | |||
| 29 | /** |
||
| 30 | * @var string|null |
||
| 31 | */ |
||
| 32 | public $timespent; |
||
| 33 | |||
| 34 | /** |
||
| 35 | * @var \JiraRestApi\Issue\Reporter|null |
||
| 36 | */ |
||
| 37 | public $reporter; |
||
| 38 | |||
| 39 | /** |
||
| 40 | * @var \DateTime |
||
| 41 | */ |
||
| 42 | public $created; |
||
| 43 | |||
| 44 | /** |
||
| 45 | * @var \DateTime |
||
| 46 | */ |
||
| 47 | public $updated; |
||
| 48 | |||
| 49 | /** |
||
| 50 | * @var string|null |
||
| 51 | */ |
||
| 52 | public $description; |
||
| 53 | |||
| 54 | /** |
||
| 55 | * @var \JiraRestApi\Issue\Priority |
||
| 56 | */ |
||
| 57 | public $priority; |
||
| 58 | |||
| 59 | /** |
||
| 60 | * @var object |
||
| 61 | */ |
||
| 62 | public $status; |
||
| 63 | |||
| 64 | /** |
||
| 65 | * @var array |
||
| 66 | */ |
||
| 67 | public $labels; |
||
| 68 | |||
| 69 | /** |
||
| 70 | * @var \JiraRestApi\Project\Project |
||
| 71 | */ |
||
| 72 | public $project; |
||
| 73 | |||
| 74 | /** |
||
| 75 | * @var string|null |
||
| 76 | */ |
||
| 77 | public $environment; |
||
| 78 | |||
| 79 | /** |
||
| 80 | * @var array |
||
| 81 | */ |
||
| 82 | public $components; |
||
| 83 | |||
| 84 | /** |
||
| 85 | * @var \JiraRestApi\Issue\Comments |
||
| 86 | */ |
||
| 87 | public $comment; |
||
| 88 | |||
| 89 | /** |
||
| 90 | * @var object |
||
| 91 | */ |
||
| 92 | public $votes; |
||
| 93 | |||
| 94 | /** |
||
| 95 | * @var object|null |
||
| 96 | */ |
||
| 97 | public $resolution; |
||
| 98 | |||
| 99 | /** |
||
| 100 | * @var array |
||
| 101 | */ |
||
| 102 | public $fixVersions; |
||
| 103 | |||
| 104 | /** |
||
| 105 | * @var \JiraRestApi\Issue\Reporter |
||
| 106 | */ |
||
| 107 | public $creator; |
||
| 108 | |||
| 109 | /** |
||
| 110 | * @var object |
||
| 111 | */ |
||
| 112 | public $watches; |
||
| 113 | |||
| 114 | /** |
||
| 115 | * @var object |
||
| 116 | */ |
||
| 117 | public $worklog; |
||
| 118 | |||
| 119 | /** |
||
| 120 | * @var \JiraRestApi\Issue\Reporter|null |
||
| 121 | */ |
||
| 122 | public $assignee; |
||
| 123 | |||
| 124 | /** |
||
| 125 | * @var \JiraRestApi\Issue\Version[] |
||
| 126 | */ |
||
| 127 | public $versions; |
||
| 128 | |||
| 129 | /** |
||
| 130 | * @var \JiraRestApi\Issue\Attachment[] |
||
| 131 | */ |
||
| 132 | public $attachment; |
||
| 133 | |||
| 134 | /** |
||
| 135 | * @var string|null |
||
| 136 | */ |
||
| 137 | public $aggregatetimespent; |
||
| 138 | |||
| 139 | /** |
||
| 140 | * @var string|null |
||
| 141 | */ |
||
| 142 | public $timeestimate; |
||
| 143 | |||
| 144 | /** |
||
| 145 | * @var string|null |
||
| 146 | */ |
||
| 147 | public $aggregatetimeoriginalestimate; |
||
| 148 | |||
| 149 | /** |
||
| 150 | * @var string|null |
||
| 151 | */ |
||
| 152 | public $resolutiondate; |
||
| 153 | |||
| 154 | /** |
||
| 155 | * @var \DateTime|null |
||
| 156 | */ |
||
| 157 | public $duedate; |
||
| 158 | |||
| 159 | /** |
||
| 160 | * @var array |
||
| 161 | */ |
||
| 162 | public $issuelinks; |
||
| 163 | |||
| 164 | /** |
||
| 165 | * @var array |
||
| 166 | */ |
||
| 167 | public $subtasks; |
||
| 168 | |||
| 169 | /** |
||
| 170 | * @var int|null |
||
| 171 | */ |
||
| 172 | public $workratio; |
||
| 173 | |||
| 174 | /** |
||
| 175 | * @var object|null |
||
| 176 | */ |
||
| 177 | public $aggregatetimeestimate; |
||
| 178 | |||
| 179 | /** |
||
| 180 | * @var object|null |
||
| 181 | */ |
||
| 182 | public $aggregateprogress; |
||
| 183 | |||
| 184 | /** |
||
| 185 | * @var object|null |
||
| 186 | */ |
||
| 187 | public $lastViewed; |
||
| 188 | |||
| 189 | /** |
||
| 190 | * @var object|null |
||
| 191 | */ |
||
| 192 | public $timeoriginalestimate; |
||
| 193 | |||
| 194 | /** |
||
| 195 | * IssueField constructor. |
||
| 196 | * @param bool $updateIssue |
||
| 197 | */ |
||
| 198 | public function __construct($updateIssue = false) |
||
| 210 | |||
| 211 | public function jsonSerialize() |
||
| 215 | |||
| 216 | public function getProjectKey() |
||
| 220 | |||
| 221 | public function getProjectId() |
||
| 225 | |||
| 226 | public function getIssueType() |
||
| 230 | |||
| 231 | View Code Duplication | public function setProjectKey($key) |
|
| 241 | |||
| 242 | View Code Duplication | public function setProjectId($id) |
|
| 252 | |||
| 253 | public function setSummary($summary) |
||
| 259 | |||
| 260 | /** |
||
| 261 | * @param string|null $description |
||
| 262 | * |
||
| 263 | * @return $this |
||
| 264 | */ |
||
| 265 | public function setDescription($description) |
||
| 271 | |||
| 272 | public function setReporterName($name) |
||
| 282 | |||
| 283 | public function setAssigneeName($name) |
||
| 293 | |||
| 294 | View Code Duplication | public function setPriorityId($id) |
|
| 304 | |||
| 305 | View Code Duplication | public function setPriorityName($name) |
|
| 315 | |||
| 316 | public function addVersion($name) |
||
| 329 | |||
| 330 | public function addComment($comment) |
||
| 340 | |||
| 341 | public function addLabel($label) |
||
| 351 | |||
| 352 | View Code Duplication | public function setIssueTypeName($name) |
|
| 362 | |||
| 363 | View Code Duplication | public function setIssueTypeId($id) |
|
| 373 | } |
||
| 374 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.