DorsetDigital\Elements\ImageTextElement

Complexity

Total Complexity

2

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Importance

Changes	3
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getType()	0	3	1
A	getCMSFields()	0	17	1

<?php
namespace DorsetDigital\Elements;

use DNADesign\Elemental\Models\BaseElement;
use SilverStripe\AssetAdmin\Forms\UploadField;
use SilverStripe\Assets\Image;
use SilverStripe\Forms\DropdownField;
use SilverStripe\Forms\HTMLEditor\HTMLEditorField;
use SilverStripe\Forms\TextField;
use SilverStripe\ORM\FieldType\DBField;


class ImageTextElement extends BaseElement
{

    private static $singular_name = 'Text & Image Block';

The private property $singular_name is not used, and could be removed.

    private static $plural_name = 'Text & Image Blocks';

The private property $plural_name is not used, and could be removed.

    private static $description = 'Adds a block of text with accompanying image';

The private property $description is not used, and could be removed.

    private static $table_name = 'DorsetDigital_Elements_ImageText';

The private property $table_name is not used, and could be removed.

    private static $db = [

The private property $db is not used, and could be removed.

        'Content' => 'HTMLText',

This array key does not seem to be aligned correctly; expected 26 spaces, but found 8.

        'ImagePosition' => 'Varchar(10)',

This array key does not seem to be aligned correctly; expected 26 spaces, but found 8.

        'ImageAlt' => 'Varchar(255)',

This array key does not seem to be aligned correctly; expected 26 spaces, but found 8.

        'ImageWidth' => 'Varchar(10)'

This array key does not seem to be aligned correctly; expected 26 spaces, but found 8.

    ];

The closing parenthesis does not seem to be aligned correctly; expected 25 space(s), but found 4.

    private static $many_many = [

The private property $many_many is not used, and could be removed.

        'Image' => Image::class

This array key does not seem to be aligned correctly; expected 33 spaces, but found 8.

    ];

The closing parenthesis does not seem to be aligned correctly; expected 32 space(s), but found 4.

    private static $owns = [

The private property $owns is not used, and could be removed.

Multi-line array contains a single value; use single-line array instead

        'Image'
    ];

The closing parenthesis does not seem to be aligned correctly; expected 27 space(s), but found 4.

    private static $inline_editable = false;

The private property $inline_editable is not used, and could be removed.

    private static $sizes = [

The private property $sizes is not used, and could be removed.

        'half' => '1/2 page width',

This array key does not seem to be aligned correctly; expected 29 spaces, but found 8.

        'third' => '1/3 page width',

This array key does not seem to be aligned correctly; expected 29 spaces, but found 8.

        'quarter' => '1/4 page width',

This array key does not seem to be aligned correctly; expected 29 spaces, but found 8.

        'sixth' => '1/6 page width'

This array key does not seem to be aligned correctly; expected 29 spaces, but found 8.

    ];

The closing parenthesis does not seem to be aligned correctly; expected 28 space(s), but found 4.

    public function getCMSFields()

This method is not in camel caps format.

    {
        $fields = parent::getCMSFields();
        $fields->addFieldsToTab('Root.Main', [
            HTMLEditorField::create('Content'),

This array value does not seem to be aligned correcty; expected 46 spaces, but found 12.

            UploadField::create('Image')

This array value does not seem to be aligned correcty; expected 46 spaces, but found 12.

                ->setAllowedFileCategories('image/supported')
                ->setFolderName('pageimages')
                ->setAllowedMaxFileNumber(1),
            DropdownField::create('ImagePosition')

This array value does not seem to be aligned correcty; expected 46 spaces, but found 12.

                ->setSource([ 'after' => 'After Content', 'before' => 'Before Content' ]),
            TextField::create('ImageAlt')->setTitle('Alt text for the image'),

This array value does not seem to be aligned correcty; expected 46 spaces, but found 12.

            DropdownField::create('ImageWidth')
                ->setSource($this->config()->get('sizes'))
                ->setDescription('Relative image size on larger screens.  On smaller screens the image will flow before or after the text content, instead of sitting next to it.')

There should be a trailing comma after the last value of an array declaration.

        ]);

The closing parenthesis does not seem to be aligned correctly; expected 45 space(s), but found 8.

        return $fields;
    }

Expected 2 blank lines after function; 1 found

    public function getType()
    {
        return 'Image & Text';
    }


}