Conditions | 1 |
Paths | 1 |
Total Lines | 52 |
Code Lines | 33 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
113 | protected function processAddPermissionToRoles($auth, $roles = [], $permissions = []) |
||
114 | { |
||
115 | // ROLE_SUPER_ADMIN |
||
116 | $auth->addChild( |
||
117 | ArrayHelper::getValue($roles, Role::ROLE_SUPER_ADMIN), |
||
118 | ArrayHelper::getValue($permissions, Permission::PERMISSION_VIEW_ADMIN_PAGE) |
||
119 | ); |
||
120 | $auth->addChild( |
||
121 | ArrayHelper::getValue($roles, Role::ROLE_SUPER_ADMIN), |
||
122 | ArrayHelper::getValue($permissions, Permission::PERMISSION_MANAGER_POST) |
||
123 | ); |
||
124 | $auth->addChild( |
||
125 | ArrayHelper::getValue($roles, Role::ROLE_SUPER_ADMIN), |
||
126 | ArrayHelper::getValue($permissions, Permission::PERMISSION_MANAGER_USERS) |
||
127 | ); |
||
128 | $auth->addChild( |
||
129 | ArrayHelper::getValue($roles, Role::ROLE_SUPER_ADMIN), |
||
130 | ArrayHelper::getValue($permissions, Permission::PERMISSION_MANAGER_RBAC) |
||
131 | ); |
||
132 | |||
133 | // ROLE_ADMIN |
||
134 | $auth->addChild( |
||
135 | ArrayHelper::getValue($roles, Role::ROLE_ADMIN), |
||
136 | ArrayHelper::getValue($permissions, Permission::PERMISSION_VIEW_ADMIN_PAGE) |
||
137 | ); |
||
138 | $auth->addChild( |
||
139 | ArrayHelper::getValue($roles, Role::ROLE_ADMIN), |
||
140 | ArrayHelper::getValue($permissions, Permission::PERMISSION_MANAGER_POST) |
||
141 | ); |
||
142 | $auth->addChild( |
||
143 | ArrayHelper::getValue($roles, Role::ROLE_ADMIN), |
||
144 | ArrayHelper::getValue($permissions, Permission::PERMISSION_MANAGER_USERS) |
||
145 | ); |
||
146 | |||
147 | // ROLE_MANAGER |
||
148 | $auth->addChild( |
||
149 | ArrayHelper::getValue($roles, Role::ROLE_MANAGER), |
||
150 | ArrayHelper::getValue($permissions, Permission::PERMISSION_VIEW_ADMIN_PAGE) |
||
151 | ); |
||
152 | $auth->addChild( |
||
153 | ArrayHelper::getValue($roles, Role::ROLE_MANAGER), |
||
154 | ArrayHelper::getValue($permissions, Permission::PERMISSION_MANAGER_POST) |
||
155 | ); |
||
156 | |||
157 | // ROLE_EDITOR |
||
158 | $auth->addChild( |
||
159 | ArrayHelper::getValue($roles, Role::ROLE_EDITOR), |
||
160 | ArrayHelper::getValue($permissions, Permission::PERMISSION_VIEW_ADMIN_PAGE) |
||
161 | ); |
||
162 | $auth->addChild( |
||
163 | ArrayHelper::getValue($roles, Role::ROLE_EDITOR), |
||
164 | ArrayHelper::getValue($permissions, Permission::PERMISSION_UPDATE_OWN_POST) |
||
165 | ); |
||
232 |