DefaultController::actionResetPassword() - Code Metrics - Inspection of "Refactoring" - Dominus77/yii2-advanced-start - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 55e0f0...d0f882 )

by Alexey

created 2018-01-19 16:07 UTC

DefaultController::actionResetPassword() B

↳ Parent: DefaultController

Complexity

Conditions	5
Paths	3

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	17
rs	8.8571
c	0
b	0
f	0
cc	5
eloc	10
nc	3
nop	1

<?php
namespace modules\users\controllers\frontend;

use Yii;
use yii\web\Controller;
use modules\users\models\User;
use modules\users\models\SignupForm;
use modules\users\models\LoginForm;
use modules\users\models\EmailConfirmForm;
use modules\users\models\ResetPasswordForm;
use modules\users\models\PasswordResetRequestForm;
use yii\base\InvalidParamException;
use yii\web\BadRequestHttpException;
use yii\filters\VerbFilter;
use yii\web\NotFoundHttpException;
use modules\users\Module;

/**
 * Class DefaultController
 * @package modules\users\controllers\frontend
 */
class DefaultController extends Controller
{
    /**
     * @return array
     */
    public function behaviors()
    {
        return [
            'verbs' => [
                'class' => VerbFilter::className(),
                'actions' => [
                    'logout' => ['post'],
                    'delete' => ['post'],
                ],
            ],
        ];
    }

    /**
     * @return string
     * @throws NotFoundHttpException
     */
    public function actionIndex()
    {
        return $this->render('index', [
            'model' => $this->findModel(),
        ]);
    }

    /**
     * Logs in a user.
     *
     * @return mixed
     */
    public function actionLogin()
    {
        if (!Yii::$app->user->isGuest) {
            return $this->goHome();
        }

        $model = new LoginForm();
        if ($model->load(Yii::$app->request->post()) && $model->login()) {
            return $this->goBack();
        } else {
            return $this->render('login', [
                'model' => $model,
            ]);
        }
    }

    /**
     * Logs out the current user.
     *
     * @return mixed
     */
    public function actionLogout()
    {
        Yii::$app->user->logout();

        return $this->goHome();
    }

    /**
     * Signs user up.
     *
     * @return mixed
     */
    public function actionSignup()
    {
        $model = new SignupForm();
        if ($model->load(Yii::$app->request->post())) {
            if ($user = $model->signup()) {
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                Yii::$app->getSession()->setFlash('success', Module::t('module', 'It remains to activate the account.'));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                return $this->goHome();
            }
        }
        return $this->render('signup', [
            'model' => $model,
        ]);
    }

    /**
     * @param $token
     * @return \yii\web\Response
     * @throws BadRequestHttpException
     */
    public function actionEmailConfirm($token)
    {
        try {
            $model = new EmailConfirmForm($token);
        } catch (InvalidParamException $e) {
            throw new BadRequestHttpException($e->getMessage());
        }

        if ($model->confirmEmail()) {
            Yii::$app->getSession()->setFlash('success', Module::t('module', 'Thank you for registering!'));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        } else {
            Yii::$app->getSession()->setFlash('error', Module::t('module', 'Error sending message!'));
        }

        return $this->goHome();
    }

    /**
     * Requests password reset.
     *
     * @return mixed
     */
    public function actionRequestPasswordReset()
    {
        $model = new PasswordResetRequestForm();
        if ($model->load(Yii::$app->request->post()) && $model->validate()) {
            if ($model->sendEmail()) {
                Yii::$app->session->setFlash('success', Module::t('module', 'Check your email for further instructions.'));

                return $this->goHome();
            } else {
                Yii::$app->session->setFlash('error', Module::t('module', 'Sorry, we are unable to reset password.'));
            }
        }

        return $this->render('requestPasswordResetToken', [
            'model' => $model,
        ]);
    }

    /**
     * Resets password.
     *
     * @param string $token
     * @return mixed
     * @throws BadRequestHttpException
     */
    public function actionResetPassword($token)
    {
        try {
            $model = new ResetPasswordForm($token);
        } catch (InvalidParamException $e) {
            throw new BadRequestHttpException($e->getMessage());
        }

        if ($model->load(Yii::$app->request->post()) && $model->validate() && $model->resetPassword()) {
            Yii::$app->session->setFlash('success', Module::t('module', 'Password changed successfully.'));
            return $this->goHome();
        }

        return $this->render('resetPassword', [
            'model' => $model,
        ]);
    }

    /**
     * Finds the User model based on its primary key value.
     * If the model is not found, a 404 HTTP exception will be thrown.
     * @return User the loaded model
     * @throws NotFoundHttpException if the model cannot be found
     */
    protected function findModel()
    {
        $id = Yii::$app->user->identity->getId();
        if (($model = User::findOne($id)) !== null) {

            return $model;
        } else {
            throw new NotFoundHttpException(Module::t('module', 'The requested page does not exist.'));
        }
    }
}


1			<?php
2			namespace modules\users\controllers\frontend;
3
4			use Yii;
5			use yii\web\Controller;
6			use modules\users\models\User;
7			use modules\users\models\SignupForm;
8			use modules\users\models\LoginForm;
9			use modules\users\models\EmailConfirmForm;
10			use modules\users\models\ResetPasswordForm;
11			use modules\users\models\PasswordResetRequestForm;
12			use yii\base\InvalidParamException;
13			use yii\web\BadRequestHttpException;
14			use yii\filters\VerbFilter;
15			use yii\web\NotFoundHttpException;
16			use modules\users\Module;
17
18			/**
19			* Class DefaultController
20			* @package modules\users\controllers\frontend
21			*/
22			class DefaultController extends Controller
23			{
24			/**
25			* @return array
26			*/
27			public function behaviors()
28			{
29			return [
30			'verbs' => [
31			'class' => VerbFilter::className(),
32			'actions' => [
33			'logout' => ['post'],
34			'delete' => ['post'],
35			],
36			],
37			];
38			}
39
40			/**
41			* @return string
42			* @throws NotFoundHttpException
43			*/
44			public function actionIndex()
45			{
46			return $this->render('index', [
47			'model' => $this->findModel(),
48			]);
49			}
50
51			/**
52			* Logs in a user.
53			*
54			* @return mixed
55			*/
56			public function actionLogin()
57			{
58			if (!Yii::$app->user->isGuest) {
59			return $this->goHome();
60			}
61
62			$model = new LoginForm();
63			if ($model->load(Yii::$app->request->post()) && $model->login()) {
64			return $this->goBack();
65			} else {
66			return $this->render('login', [
67			'model' => $model,
68			]);
69			}
70			}
71
72			/**
73			* Logs out the current user.
74			*
75			* @return mixed
76			*/
77			public function actionLogout()
78			{
79			Yii::$app->user->logout();
80
81			return $this->goHome();
82			}
83
84			/**
85			* Signs user up.
86			*
87			* @return mixed
88			*/
89			public function actionSignup()
90			{
91			$model = new SignupForm();
92			if ($model->load(Yii::$app->request->post())) {
93			if ($user = $model->signup()) {
			0 ignored issues – show Unused Code introduced 2018-01-17 18:30 UTC by Report Bug Copy Issue Report `$user` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
94			Yii::$app->getSession()->setFlash('success', Module::t('module', 'It remains to activate the account.'));
			0 ignored issues – show Bug introduced 2018-01-17 18:30 UTC by Report Bug Copy Issue Report The method `getSession` does only exist in `yii\web\Application`, but not in `yii\console\Application`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
95			return $this->goHome();
96			}
97			}
98			return $this->render('signup', [
99			'model' => $model,
100			]);
101			}
102
103			/**
104			* @param $token
105			* @return \yii\web\Response
106			* @throws BadRequestHttpException
107			*/
108			public function actionEmailConfirm($token)
109			{
110			try {
111			$model = new EmailConfirmForm($token);
112			} catch (InvalidParamException $e) {
113			throw new BadRequestHttpException($e->getMessage());
114			}
115
116			if ($model->confirmEmail()) {
117			Yii::$app->getSession()->setFlash('success', Module::t('module', 'Thank you for registering!'));
			0 ignored issues – show Bug introduced 2018-01-17 18:30 UTC by Report Bug Copy Issue Report The method `getSession` does only exist in `yii\web\Application`, but not in `yii\console\Application`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
118			} else {
119			Yii::$app->getSession()->setFlash('error', Module::t('module', 'Error sending message!'));
120			}
121
122			return $this->goHome();
123			}
124
125			/**
126			* Requests password reset.
127			*
128			* @return mixed
129			*/
130			public function actionRequestPasswordReset()
131			{
132			$model = new PasswordResetRequestForm();
133			if ($model->load(Yii::$app->request->post()) && $model->validate()) {
134			if ($model->sendEmail()) {
135			Yii::$app->session->setFlash('success', Module::t('module', 'Check your email for further instructions.'));
136
137			return $this->goHome();
138			} else {
139			Yii::$app->session->setFlash('error', Module::t('module', 'Sorry, we are unable to reset password.'));
140			}
141			}
142
143			return $this->render('requestPasswordResetToken', [
144			'model' => $model,
145			]);
146			}
147
148			/**
149			* Resets password.
150			*
151			* @param string $token
152			* @return mixed
153			* @throws BadRequestHttpException
154			*/
155			public function actionResetPassword($token)
156			{
157			try {
158			$model = new ResetPasswordForm($token);
159			} catch (InvalidParamException $e) {
160			throw new BadRequestHttpException($e->getMessage());
161			}
162
163			if ($model->load(Yii::$app->request->post()) && $model->validate() && $model->resetPassword()) {
164			Yii::$app->session->setFlash('success', Module::t('module', 'Password changed successfully.'));
165			return $this->goHome();
166			}
167
168			return $this->render('resetPassword', [
169			'model' => $model,
170			]);
171			}
172
173			/**
174			* Finds the User model based on its primary key value.
175			* If the model is not found, a 404 HTTP exception will be thrown.
176			* @return User the loaded model
177			* @throws NotFoundHttpException if the model cannot be found
178			*/
179			protected function findModel()
180			{
181			$id = Yii::$app->user->identity->getId();
182			if (($model = User::findOne($id)) !== null) {
			0 ignored issues – show Bug Compatibility introduced 2018-01-19 16:18 UTC by Report Bug Copy Issue Report The expression `\modules\users\models\User::findOne($id);` of type `yii\db\ActiveRecordInterface\|array\|null` adds the type `array` to the return on line 183 which is incompatible with the return type documented by `modules\users\controller...ltController::findModel` of type `modules\users\models\User`. Loading history...
183			return $model;
184			} else {
185			throw new NotFoundHttpException(Module::t('module', 'The requested page does not exist.'));
186			}
187			}
188			}
189

Dominus77 / yii2-advanced-start

Push — master ( 55e0f0...d0f882 )

DefaultController::actionResetPassword() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like