Dominus77 /
yii2-advanced-start
| Conditions | 2 |
| Paths | 2 |
| Total Lines | 80 |
| Code Lines | 46 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 88 | public function registerAsset() |
||
| 89 | { |
||
| 90 | $view = $this->getView(); |
||
| 91 | FlotAsset::register($view); |
||
| 92 | $clientData = Json::encode($this->getClientData()); |
||
| 93 | $clientOptions = Json::encode($this->getClientOptions()); |
||
| 94 | $script = " |
||
| 95 | let plot_{$this->id} = $.plot('#{$this->id}', {$clientData}, {$clientOptions}); |
||
| 96 | "; |
||
| 97 | $view->registerJs($script); |
||
| 98 | |||
| 99 | // Realtime |
||
| 100 | if ($this->realtime['on'] === true) { |
||
| 101 | $dataUrl = $this->realtime['dataUrl']; |
||
| 102 | $btnGroupId = $this->realtime['btnGroupId']; |
||
| 103 | $btnDefault = $this->realtime['btnDefault']; |
||
| 104 | $updateInterval = $this->realtime['updateInterval']; |
||
| 105 | $on = self::REALTIME_ON; |
||
| 106 | $off = self::REALTIME_OFF; |
||
| 107 | $script = " |
||
| 108 | let url_{$this->id} = '$dataUrl', |
||
| 109 | data_{$this->id} = (plot_{$this->id}.getData().length === 0) ? [plot_{$this->id}.getData()] : |
||
| 110 | plot_{$this->id}.getData()[0].data, |
||
| 111 | updateInterval_{$this->id} = {$updateInterval}, |
||
| 112 | realtime_{$this->id} = '{$btnDefault}', |
||
| 113 | btnRealtime_{$this->id} = $('#{$btnGroupId} .btn'); |
||
| 114 | |||
| 115 | // GET DATA AJAX |
||
| 116 | function getDataAjax_{$this->id}() { |
||
| 117 | $.ajax({ |
||
| 118 | url: url_{$this->id}, |
||
| 119 | dataType: 'json', |
||
| 120 | type: 'post', |
||
| 121 | data: {data: data_{$this->id}}, |
||
| 122 | }).done(function (response) { |
||
| 123 | data_{$this->id} = response.result; |
||
| 124 | }).fail(function (response) { |
||
| 125 | console.log(response.result); |
||
| 126 | }); |
||
| 127 | return data_{$this->id}; |
||
| 128 | } |
||
| 129 | |||
| 130 | // UPDATE |
||
| 131 | function update_{$this->id}() { |
||
| 132 | plot_{$this->id}.setData([getDataAjax_{$this->id}()]); |
||
| 133 | plot_{$this->id}.setupGrid(); |
||
| 134 | // Since the axes don't change, we don't need to call plot.setupGrid() |
||
| 135 | plot_{$this->id}.draw(); |
||
| 136 | if (realtime_{$this->id} === '{$on}') { |
||
| 137 | setTimeout(update_{$this->id}, updateInterval_{$this->id}); |
||
| 138 | } |
||
| 139 | } |
||
| 140 | |||
| 141 | // INITIALIZE REALTIME DATA FETCHING |
||
| 142 | if (realtime_{$this->id} === '{$on}') { |
||
| 143 | update_{$this->id}(); |
||
| 144 | } |
||
| 145 | |||
| 146 | // REALTIME TOGGLE |
||
| 147 | btnRealtime_{$this->id}.click(function () { |
||
| 148 | btnRealtime_{$this->id}.addClass('btn-default'); |
||
| 149 | $(this).removeClass('btn-default'); |
||
| 150 | if ($(this).data('toggle') === '{$on}') { |
||
| 151 | if(realtime_{$this->id} !== '{$on}') { |
||
| 152 | realtime_{$this->id} = '{$on}'; |
||
| 153 | btnRealtime_{$this->id}.removeClass('btn-danger'); |
||
| 154 | $(this).addClass('btn-success'); |
||
| 155 | update_{$this->id}(); |
||
| 156 | } |
||
| 157 | } else { |
||
| 158 | if(realtime_{$this->id} !== '{$off}') { |
||
| 159 | realtime_{$this->id} = '{$off}'; |
||
| 160 | btnRealtime_{$this->id}.removeClass('btn-success'); |
||
| 161 | $(this).addClass('btn-danger'); |
||
| 162 | update_{$this->id}(); |
||
| 163 | } |
||
| 164 | } |
||
| 165 | }); |
||
| 166 | "; |
||
| 167 | $view->registerJs($script); |
||
| 168 | } |
||
| 171 |
