Period::intersects() - Code Metrics - Inspection of "Refactor exception and add missing test for Period..." - Domi202/period - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ef5814...749211 )

by Dominique

created 2019-04-22 10:36 UTC

Period::intersects() B

↳ Parent: Period

Complexity

Conditions	7
Paths	4

Size

Total Lines	21
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	7

Importance

Changes

Metric	Value
cc	7
eloc	10
nc	4
nop	1
dl	0
loc	21
ccs	11
cts	11
cp	1
crap	7
rs	8.8333
c	0
b	0
f	0

<?php
declare(strict_types=1);
namespace Kreemers\Period;

use DateTime;
use Kreemers\Period\Exception\EndBeforeStartException;

class Period
{
    /**
     * @var DateTime
     */
    private $start;

    /**
     * @var DateTime
     */
    private $end;

    private function __construct(
        DateTime $start,
        DateTime $end
    ) {
        $this->start = clone $start;
        $this->end = clone $end;
    }

    public static function create(
        DateTime $start,
        DateTime $end
    ) {
        if ($start > $end) {
            throw new EndBeforeStartException();
        }

        return new static(
            $start,
            $end
        );
    }

    public function getStart(): DateTime
    {
        return $this->start;
    }

    public function getEnd(): DateTime
    {
        return $this->end;
    }

    public function equals(Period $period): bool
    {
        return $this->getStart() == $period->getStart()
            && $this->getEnd() == $period->getEnd();
    }

    public function in(Period $period): bool
    {
        if ($this->getStart() >= $period->getStart()
            && $this->getStart() <= $period->getEnd()
            && $this->getEnd() >= $period->getStart()
            && $this->getEnd() <= $period->getEnd()
        ) {
            return true;
        }

        return false;
    }

    public function encloses(Period $period): bool
    {
        if ($this->getStart() <= $period->getStart()
            && $this->getEnd() >= $period->getEnd()
        ) {
            return true;
        }

        return false;
    }

    public function intersects(Period $period): bool
    {
        if ($this->getStart() >= $period->getStart()
            && $this->getStart() <= $period->getEnd()
        ) {
            return true;
        }

        if ($this->getEnd() <= $period->getEnd()
            && $this->getEnd() >= $period->getStart()
        ) {
            return true;
        }

        if ($this->in($period)
            || $this->encloses($period)
        ) {
            return true;
        }

        return false;
    }
}

1		<?php
2		declare(strict_types=1);
3		namespace Kreemers\Period;
4
5		use DateTime;
6		use Kreemers\Period\Exception\EndBeforeStartException;
7
8		class Period
9		{
10		/**
11		* @var DateTime
12		*/
13		private $start;
14
15		/**
16		* @var DateTime
17		*/
18		private $end;
19
20	1	private function __construct(
21		DateTime $start,
22		DateTime $end
23		) {
24	1	$this->start = clone $start;
25	1	$this->end = clone $end;
26	1	}
27
28	2	public static function create(
29		DateTime $start,
30		DateTime $end
31		) {
32	2	if ($start > $end) {
33	1	throw new EndBeforeStartException();
34		}
35
36	1	return new static(
37	1	$start,
38		$end
39		);
40		}
41
42	1	public function getStart(): DateTime
43		{
44	1	return $this->start;
45		}
46
47	1	public function getEnd(): DateTime
48		{
49	1	return $this->end;
50		}
51
52	3	public function equals(Period $period): bool
53		{
54	3	return $this->getStart() == $period->getStart()
55	3	&& $this->getEnd() == $period->getEnd();
56		}
57
58	2	public function in(Period $period): bool
59		{
60	2	if ($this->getStart() >= $period->getStart()
61	2	&& $this->getStart() <= $period->getEnd()
62	2	&& $this->getEnd() >= $period->getStart()
63	2	&& $this->getEnd() <= $period->getEnd()
64		) {
65	1	return true;
66		}
67
68	1	return false;
69		}
70
71	2	public function encloses(Period $period): bool
72		{
73	2	if ($this->getStart() <= $period->getStart()
74	2	&& $this->getEnd() >= $period->getEnd()
75		) {
76	1	return true;
77		}
78
79	1	return false;
80		}
81
82	5	public function intersects(Period $period): bool
83		{
84	5	if ($this->getStart() >= $period->getStart()
85	5	&& $this->getStart() <= $period->getEnd()
86		) {
87	2	return true;
88		}
89
90	3	if ($this->getEnd() <= $period->getEnd()
91	3	&& $this->getEnd() >= $period->getStart()
92		) {
93	1	return true;
94		}
95
96	2	if ($this->in($period)
97	2	\|\| $this->encloses($period)
98		) {
99	1	return true;
100		}
101
102	1	return false;
103		}
104		}

Domi202 / period

Push — master ( ef5814...749211 )

Period::intersects() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like