Inspection of "Daily Inspection: Implement a TODO for possible pe..." - Dolibarr/dolibarr - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop (1a651a)

unknown

created 2024-09-11 16:47 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -235,7 +235,7 @@
 block discarded – undo
 				$this->dateh          = $this->db->jdate($obj->dateh);
 				$this->datef          = $this->db->jdate($obj->datef);
 				$this->amount         = $obj->subscription;
-				$this->note           = $obj->note_public;	// deprecated
+				$this->note           = $obj->note_public; // deprecated
 				$this->note_public    = $obj->note_public;
 				$this->fk_bank        = $obj->fk_bank;
 				return 1;

Please login to merge, or discard this patch.

htdocs/recruitment/admin/setup.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -68,7 +68,7 @@
 block discarded – undo
 // Parameters
 $action = GETPOST('action', 'aZ09');
 $backtopage = GETPOST('backtopage', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $value = GETPOST('value', 'alpha');
 $label = GETPOST('label', 'alpha');

Please login to merge, or discard this patch.

htdocs/install/check.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -421,7 +421,7 @@
 block discarded – undo
 			$allowupgrade = true;
 		}
 
-		$dir = DOL_DOCUMENT_ROOT."/install/mysql/migration/";	// We use mysql migration scripts whatever is database driver
+		$dir = DOL_DOCUMENT_ROOT."/install/mysql/migration/"; // We use mysql migration scripts whatever is database driver
 		dolibarr_install_syslog("Scan sql files for migration files in ".$dir);
 
 		// Get files list of migration file x.y.z-a.b.c.sql into /install/mysql/migration

Please login to merge, or discard this patch.

htdocs/recruitment/admin/setup_candidatures.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -68,7 +68,7 @@
 block discarded – undo
 // Parameters
 $action = GETPOST('action', 'aZ09');
 $backtopage = GETPOST('backtopage', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $value = GETPOST('value', 'alpha');
 $label = GETPOST('label', 'alpha');

Please login to merge, or discard this patch.

htdocs/admin/agenda_reminder.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -36,7 +36,7 @@
 block discarded – undo
 
 $action = GETPOST('action', 'aZ09');
 $value = GETPOST('value', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $param = GETPOST('param', 'alpha');
 $cancel = GETPOST('cancel', 'alpha');

Please login to merge, or discard this patch.

htdocs/admin/bom.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -46,7 +46,7 @@
 block discarded – undo
 
 $action = GETPOST('action', 'aZ09');
 $value = GETPOST('value', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $label = GETPOST('label', 'alpha');
 $scandir = GETPOST('scan_dir', 'alpha');

Please login to merge, or discard this patch.

htdocs/admin/import.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -41,7 +41,7 @@
 block discarded – undo
 
 $action = GETPOST('action', 'aZ09');
 $value = GETPOST('value', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 
 /*

Please login to merge, or discard this patch.

htdocs/admin/agenda_other.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -36,7 +36,7 @@
 block discarded – undo
 
 $action = GETPOST('action', 'aZ09');
 $value = GETPOST('value', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $param = GETPOST('param', 'alpha');
 $cancel = GETPOST('cancel', 'alpha');

Please login to merge, or discard this patch.

htdocs/core/lib/tax.lib.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -801,7 +801,7 @@  discard block
 block discarded – undo
 			while ($assoc = $db->fetch_array($resql)) {
 				$rate_key = $assoc['rate'];
 				if ($f_rate == 'tva_tx' && !empty($assoc['vat_src_code']) && !preg_match('/\(/', $rate_key)) {
-					$rate_key .= ' (' . $assoc['vat_src_code'] . ')';
+					$rate_key .= ' ('.$assoc['vat_src_code'].')';
 				}
 
 				// Code to avoid warnings when array entry not defined
@@ -986,7 +986,7 @@  discard block
 block discarded – undo
 			while ($assoc = $db->fetch_array($resql)) {
 				$rate_key = $assoc['rate'];
 				if ($f_rate == 'tva_tx' && !empty($assoc['vat_src_code']) && !preg_match('/\(/', $rate_key)) {
-					$rate_key .= ' (' . $assoc['vat_src_code'] . ')';
+					$rate_key .= ' ('.$assoc['vat_src_code'].')';
 				}
 
 				// Code to avoid warnings when array entry not defined
@@ -1113,7 +1113,7 @@  discard block
 block discarded – undo
 				while ($assoc = $db->fetch_array($resql)) {
 					$rate_key = $assoc['rate'];
 					if ($f_rate == 'tva_tx' && !empty($assoc['vat_src_code']) && !preg_match('/\(/', $rate_key)) {
-						$rate_key .= ' (' . $assoc['vat_src_code'] . ')';
+						$rate_key .= ' ('.$assoc['vat_src_code'].')';
 					}
 
 					// Code to avoid warnings when array entry not defined

Please login to merge, or discard this patch.

		@@ -68,7 +68,7 @@
		block discarded – undo
68	68	// Parameters
69	69	$action = GETPOST('action', 'aZ09');
70	70	$backtopage = GETPOST('backtopage', 'alpha');
71		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	71	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
72	72
73	73	$value = GETPOST('value', 'alpha');
74	74	$label = GETPOST('label', 'alpha');

		@@ -421,7 +421,7 @@
		block discarded – undo
421	421	$allowupgrade = true;
422	422	}
423	423
424		- $dir = DOL_DOCUMENT_ROOT."/install/mysql/migration/"; // We use mysql migration scripts whatever is database driver
	424	+ $dir = DOL_DOCUMENT_ROOT."/install/mysql/migration/"; // We use mysql migration scripts whatever is database driver
425	425	dolibarr_install_syslog("Scan sql files for migration files in ".$dir);
426	426
427	427	// Get files list of migration file x.y.z-a.b.c.sql into /install/mysql/migration

		@@ -68,7 +68,7 @@
		block discarded – undo
68	68	// Parameters
69	69	$action = GETPOST('action', 'aZ09');
70	70	$backtopage = GETPOST('backtopage', 'alpha');
71		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	71	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
72	72
73	73	$value = GETPOST('value', 'alpha');
74	74	$label = GETPOST('label', 'alpha');

		@@ -801,7 +801,7 @@ discard block
		block discarded – undo
801	801	while ($assoc = $db->fetch_array($resql)) {
802	802	$rate_key = $assoc['rate'];
803	803	if ($f_rate == 'tva_tx' && !empty($assoc['vat_src_code']) && !preg_match('/\(/', $rate_key)) {
804		- $rate_key .= ' (' . $assoc['vat_src_code'] . ')';
	804	+ $rate_key .= ' ('.$assoc['vat_src_code'].')';
805	805	}
806	806
807	807	// Code to avoid warnings when array entry not defined
		@@ -986,7 +986,7 @@ discard block
		block discarded – undo
986	986	while ($assoc = $db->fetch_array($resql)) {
987	987	$rate_key = $assoc['rate'];
988	988	if ($f_rate == 'tva_tx' && !empty($assoc['vat_src_code']) && !preg_match('/\(/', $rate_key)) {
989		- $rate_key .= ' (' . $assoc['vat_src_code'] . ')';
	989	+ $rate_key .= ' ('.$assoc['vat_src_code'].')';
990	990	}
991	991
992	992	// Code to avoid warnings when array entry not defined
		@@ -1113,7 +1113,7 @@ discard block
		block discarded – undo
1113	1113	while ($assoc = $db->fetch_array($resql)) {
1114	1114	$rate_key = $assoc['rate'];
1115	1115	if ($f_rate == 'tva_tx' && !empty($assoc['vat_src_code']) && !preg_match('/\(/', $rate_key)) {
1116		- $rate_key .= ' (' . $assoc['vat_src_code'] . ')';
	1116	+ $rate_key .= ' ('.$assoc['vat_src_code'].')';
1117	1117	}
1118	1118
1119	1119	// Code to avoid warnings when array entry not defined

		@@ -235,7 +235,7 @@
		block discarded – undo
235	235	$this->dateh = $this->db->jdate($obj->dateh);
236	236	$this->datef = $this->db->jdate($obj->datef);
237	237	$this->amount = $obj->subscription;
238		- $this->note = $obj->note_public; // deprecated
	238	+ $this->note = $obj->note_public; // deprecated
239	239	$this->note_public = $obj->note_public;
240	240	$this->fk_bank = $obj->fk_bank;
241	241	return 1;

		@@ -36,7 +36,7 @@
		block discarded – undo
36	36
37	37	$action = GETPOST('action', 'aZ09');
38	38	$value = GETPOST('value', 'alpha');
39		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	39	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
40	40
41	41	$param = GETPOST('param', 'alpha');
42	42	$cancel = GETPOST('cancel', 'alpha');

		@@ -46,7 +46,7 @@
		block discarded – undo
46	46
47	47	$action = GETPOST('action', 'aZ09');
48	48	$value = GETPOST('value', 'alpha');
49		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	49	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
50	50
51	51	$label = GETPOST('label', 'alpha');
52	52	$scandir = GETPOST('scan_dir', 'alpha');

		@@ -41,7 +41,7 @@
		block discarded – undo
41	41
42	42	$action = GETPOST('action', 'aZ09');
43	43	$value = GETPOST('value', 'alpha');
44		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	44	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
45	45
46	46
47	47	/*

Dolibarr / dolibarr

Branch — develop (1a651a)

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch