Inspection of "Daily Inspection: Fix phan" - Dolibarr/dolibarr - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop (eb876f)

unknown

created 2024-09-29 16:53 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -23,7 +23,7 @@
 block discarded – undo
  *  \ingroup    workstation
  *  \brief      File of class to manage Workstation numbering rules standard
  */
-require_once DOL_DOCUMENT_ROOT . '/core/modules/workstation/modules_workstation.php';
+require_once DOL_DOCUMENT_ROOT.'/core/modules/workstation/modules_workstation.php';
 
 /**
  * Class to manage the Standard numbering rule for Workstation

Please login to merge, or discard this patch.

htdocs/core/modules/mailings/thirdparties_services_expired.modules.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -135,8 +135,8 @@
 block discarded – undo
 					'lastname' => $obj->name, // For thirdparties, lastname must be name
 					'firstname' => '', // For thirdparties, firstname is ''
 					'other' =>
-					('DateStart='.dol_print_date($this->db->jdate($obj->date_start_real), 'day')).';'.	// date start real
-					('DateEnd='.dol_print_date($this->db->jdate($obj->date_end), 'day')).';'.			// date end planned
+					('DateStart='.dol_print_date($this->db->jdate($obj->date_start_real), 'day')).';'.// date start real
+					('DateEnd='.dol_print_date($this->db->jdate($obj->date_end), 'day')).';'.// date end planned
 					('Contract='.$obj->fk_contrat).';'.
 					('ContactLine='.$obj->cdid),
 					'source_url' => $this->url($obj->id),

Please login to merge, or discard this patch.

htdocs/hrm/job_note.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -29,8 +29,8 @@  discard block
 block discarded – undo
 // Load Dolibarr environment
 require '../main.inc.php';
 
-require_once DOL_DOCUMENT_ROOT . '/hrm/class/job.class.php';
-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_job.lib.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/class/job.class.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_job.lib.php';
 
 // Load translation files required by the page
 $langs->loadLangs(array('hrm', 'companies'));
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
 	$linkback = '<a href="'.dol_buildpath('/hrm/job_list.php', 1).'?restore_lastsearch_values=1'.(!empty($socid) ? '&socid='.$socid : '').'">'.$langs->trans("BackToList").'</a>';
 
 	$morehtmlref = '<div class="refid">';
-	$morehtmlref.= $object->label;
+	$morehtmlref .= $object->label;
 	$morehtmlref .= '</div>';
 
 

Please login to merge, or discard this patch.

htdocs/hrm/skill_note.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -29,8 +29,8 @@  discard block
 block discarded – undo
 // Load Dolibarr environment
 require '../main.inc.php';
 
-require_once DOL_DOCUMENT_ROOT . '/hrm/class/skill.class.php';
-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_skill.lib.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/class/skill.class.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_skill.lib.php';
 
 // Load translation files required by the page
 $langs->loadLangs(array('hrm', 'companies'));
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
 	$linkback = '<a href="'.DOL_URL_ROOT.'/hrm/skill_list.php?restore_lastsearch_values=1'.(!empty($socid) ? '&socid='.$socid : '').'">'.$langs->trans("BackToList").'</a>';
 
 	$morehtmlref = '<div class="refid">';
-	$morehtmlref.= $object->label;
+	$morehtmlref .= $object->label;
 	$morehtmlref .= '</div>';
 
 

Please login to merge, or discard this patch.

htdocs/hrm/skill_document.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -33,8 +33,8 @@  discard block
 block discarded – undo
 require_once DOL_DOCUMENT_ROOT.'/core/lib/files.lib.php';
 require_once DOL_DOCUMENT_ROOT.'/core/lib/images.lib.php';
 require_once DOL_DOCUMENT_ROOT.'/core/class/html.formfile.class.php';
-require_once DOL_DOCUMENT_ROOT . '/hrm/class/skill.class.php';
-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_skill.lib.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/class/skill.class.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_skill.lib.php';
 
 // Load translation files required by the page
 $langs->loadLangs(array('hrm', 'companies', 'other', 'mails'));
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
 	$linkback = '<a href="'.DOL_URL_ROOT.'/hrm/skill_list.php?restore_lastsearch_values=1'.(!empty($socid) ? '&socid='.$socid : '').'">'.$langs->trans("BackToList").'</a>';
 
 	$morehtmlref = '<div class="refid">';
-	$morehtmlref.= $object->label;
+	$morehtmlref .= $object->label;
 	$morehtmlref .= '</div>';
 
 	dol_banner_tab($object, 'id', $linkback, 1, 'rowid', 'rowid', $morehtmlref);

Please login to merge, or discard this patch.

htdocs/hrm/job_document.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -32,8 +32,8 @@  discard block
 block discarded – undo
 require_once DOL_DOCUMENT_ROOT.'/core/lib/files.lib.php';
 require_once DOL_DOCUMENT_ROOT.'/core/lib/images.lib.php';
 require_once DOL_DOCUMENT_ROOT.'/core/class/html.formfile.class.php';
-require_once DOL_DOCUMENT_ROOT . '/hrm/class/job.class.php';
-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_job.lib.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/class/job.class.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_job.lib.php';
 
 // Load translation files required by the page
 $langs->loadLangs(array('hrm', 'companies', 'other', 'mails'));
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
 	$linkback = '<a href="'.dol_buildpath('/hrm/job_list.php', 1).'?restore_lastsearch_values=1'.(!empty($socid) ? '&socid='.$socid : '').'">'.$langs->trans("BackToList").'</a>';
 
 	$morehtmlref = '<div class="refid">';
-	$morehtmlref.= $object->label;
+	$morehtmlref .= $object->label;
 	$morehtmlref .= '</div>';
 
 	dol_banner_tab($object, 'id', $linkback, 1, 'rowid', 'rowid', $morehtmlref);

Please login to merge, or discard this patch.

htdocs/hrm/lib/hrm.lib.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -44,7 +44,7 @@  discard block
 block discarded – undo
 
 	$h = 0;
 	$head = array();
-	$head[$h][0] = DOL_URL_ROOT . "/admin/hrm.php";
+	$head[$h][0] = DOL_URL_ROOT."/admin/hrm.php";
 	$head[$h][1] = $langs->trans("Settings");
 	$head[$h][2] = 'settings';
 	$h++;
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
 	$head[$h][2] = 'establishments';
 	$h++;
 
-	$head[$h][0] = DOL_URL_ROOT . '/hrm/admin/skill_extrafields.php';
+	$head[$h][0] = DOL_URL_ROOT.'/hrm/admin/skill_extrafields.php';
 	$head[$h][1] = $langs->trans("SkillsExtraFields");
 	$nbExtrafields = $extrafields->attributes['hrm_skill']['count'];
 	if ($nbExtrafields > 0) {
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
 	$head[$h][2] = 'skillsAttributes';
 	$h++;
 
-	$head[$h][0] = DOL_URL_ROOT . '/hrm/admin/job_extrafields.php';
+	$head[$h][0] = DOL_URL_ROOT.'/hrm/admin/job_extrafields.php';
 	$head[$h][1] = $langs->trans("JobsExtraFields");
 	$nbExtrafields = $extrafields->attributes['hrm_job']['count'];
 	if ($nbExtrafields > 0) {
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
 	$head[$h][2] = 'jobsAttributes';
 	$h++;
 
-	$head[$h][0] = DOL_URL_ROOT . '/hrm/admin/evaluation_extrafields.php';
+	$head[$h][0] = DOL_URL_ROOT.'/hrm/admin/evaluation_extrafields.php';
 	$head[$h][1] = $langs->trans("EvaluationsExtraFields");
 	$nbExtrafields = $extrafields->attributes['hrm_evaluation']['count'];
 	if ($nbExtrafields > 0) {

Please login to merge, or discard this patch.

htdocs/variants/ajax/orderAttribute.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -37,7 +37,7 @@  discard block
 block discarded – undo
 
 // Load Dolibarr environment
 require '../../main.inc.php';
-require DOL_DOCUMENT_ROOT . '/variants/class/ProductAttribute.class.php';
+require DOL_DOCUMENT_ROOT.'/variants/class/ProductAttribute.class.php';
 
 // Security check
 if (!isModEnabled('variants')) {
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
 if (GETPOST('roworder', 'alpha', 3)) {
 	$roworder = GETPOST('roworder', 'alpha', 3);
 
-	dol_syslog("AjaxOrderAttribute roworder=" . $roworder, LOG_DEBUG);
+	dol_syslog("AjaxOrderAttribute roworder=".$roworder, LOG_DEBUG);
 
 	$rowordertab = explode(',', $roworder);
 	$newrowordertab = array();

Please login to merge, or discard this patch.

htdocs/commande/document.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -73,7 +73,7 @@
 block discarded – undo
 
 $object = new Commande($db);
 
-$usercancreate  =  $user->hasRight("commande", "creer");
+$usercancreate = $user->hasRight("commande", "creer");
 $permissiontoadd = $usercancreate;
 
 // Security check

Please login to merge, or discard this patch.

		@@ -23,7 +23,7 @@
		block discarded – undo
23	23	* \ingroup workstation
24	24	* \brief File of class to manage Workstation numbering rules standard
25	25	*/
26		-require_once DOL_DOCUMENT_ROOT . '/core/modules/workstation/modules_workstation.php';
	26	+require_once DOL_DOCUMENT_ROOT.'/core/modules/workstation/modules_workstation.php';
27	27
28	28	/**
29	29	* Class to manage the Standard numbering rule for Workstation

		@@ -135,8 +135,8 @@
		block discarded – undo
135	135	'lastname' => $obj->name, // For thirdparties, lastname must be name
136	136	'firstname' => '', // For thirdparties, firstname is ''
137	137	'other' =>
138		- ('DateStart='.dol_print_date($this->db->jdate($obj->date_start_real), 'day')).';'. // date start real
139		- ('DateEnd='.dol_print_date($this->db->jdate($obj->date_end), 'day')).';'. // date end planned
	138	+ ('DateStart='.dol_print_date($this->db->jdate($obj->date_start_real), 'day')).';'.// date start real
	139	+ ('DateEnd='.dol_print_date($this->db->jdate($obj->date_end), 'day')).';'.// date end planned
140	140	('Contract='.$obj->fk_contrat).';'.
141	141	('ContactLine='.$obj->cdid),
142	142	'source_url' => $this->url($obj->id),

		@@ -29,8 +29,8 @@ discard block
		block discarded – undo
29	29	// Load Dolibarr environment
30	30	require '../main.inc.php';
31	31
32		-require_once DOL_DOCUMENT_ROOT . '/hrm/class/job.class.php';
33		-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_job.lib.php';
	32	+require_once DOL_DOCUMENT_ROOT.'/hrm/class/job.class.php';
	33	+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_job.lib.php';
34	34
35	35	// Load translation files required by the page
36	36	$langs->loadLangs(array('hrm', 'companies'));
		@@ -106,7 +106,7 @@ discard block
		block discarded – undo
106	106	$linkback = '<a href="'.dol_buildpath('/hrm/job_list.php', 1).'?restore_lastsearch_values=1'.(!empty($socid) ? '&socid='.$socid : '').'">'.$langs->trans("BackToList").'</a>';
107	107
108	108	$morehtmlref = '<div class="refid">';
109		- $morehtmlref.= $object->label;
	109	+ $morehtmlref .= $object->label;
110	110	$morehtmlref .= '</div>';
111	111
112	112

		@@ -33,8 +33,8 @@ discard block
		block discarded – undo
33	33	require_once DOL_DOCUMENT_ROOT.'/core/lib/files.lib.php';
34	34	require_once DOL_DOCUMENT_ROOT.'/core/lib/images.lib.php';
35	35	require_once DOL_DOCUMENT_ROOT.'/core/class/html.formfile.class.php';
36		-require_once DOL_DOCUMENT_ROOT . '/hrm/class/skill.class.php';
37		-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_skill.lib.php';
	36	+require_once DOL_DOCUMENT_ROOT.'/hrm/class/skill.class.php';
	37	+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_skill.lib.php';
38	38
39	39	// Load translation files required by the page
40	40	$langs->loadLangs(array('hrm', 'companies', 'other', 'mails'));
		@@ -131,7 +131,7 @@ discard block
		block discarded – undo
131	131	$linkback = '<a href="'.DOL_URL_ROOT.'/hrm/skill_list.php?restore_lastsearch_values=1'.(!empty($socid) ? '&socid='.$socid : '').'">'.$langs->trans("BackToList").'</a>';
132	132
133	133	$morehtmlref = '<div class="refid">';
134		- $morehtmlref.= $object->label;
	134	+ $morehtmlref .= $object->label;
135	135	$morehtmlref .= '</div>';
136	136
137	137	dol_banner_tab($object, 'id', $linkback, 1, 'rowid', 'rowid', $morehtmlref);

		@@ -32,8 +32,8 @@ discard block
		block discarded – undo
32	32	require_once DOL_DOCUMENT_ROOT.'/core/lib/files.lib.php';
33	33	require_once DOL_DOCUMENT_ROOT.'/core/lib/images.lib.php';
34	34	require_once DOL_DOCUMENT_ROOT.'/core/class/html.formfile.class.php';
35		-require_once DOL_DOCUMENT_ROOT . '/hrm/class/job.class.php';
36		-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_job.lib.php';
	35	+require_once DOL_DOCUMENT_ROOT.'/hrm/class/job.class.php';
	36	+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_job.lib.php';
37	37
38	38	// Load translation files required by the page
39	39	$langs->loadLangs(array('hrm', 'companies', 'other', 'mails'));
		@@ -131,7 +131,7 @@ discard block
		block discarded – undo
131	131	$linkback = '<a href="'.dol_buildpath('/hrm/job_list.php', 1).'?restore_lastsearch_values=1'.(!empty($socid) ? '&socid='.$socid : '').'">'.$langs->trans("BackToList").'</a>';
132	132
133	133	$morehtmlref = '<div class="refid">';
134		- $morehtmlref.= $object->label;
	134	+ $morehtmlref .= $object->label;
135	135	$morehtmlref .= '</div>';
136	136
137	137	dol_banner_tab($object, 'id', $linkback, 1, 'rowid', 'rowid', $morehtmlref);

		@@ -44,7 +44,7 @@ discard block
		block discarded – undo
44	44
45	45	$h = 0;
46	46	$head = array();
47		- $head[$h][0] = DOL_URL_ROOT . "/admin/hrm.php";
	47	+ $head[$h][0] = DOL_URL_ROOT."/admin/hrm.php";
48	48	$head[$h][1] = $langs->trans("Settings");
49	49	$head[$h][2] = 'settings';
50	50	$h++;
		@@ -54,7 +54,7 @@ discard block
		block discarded – undo
54	54	$head[$h][2] = 'establishments';
55	55	$h++;
56	56
57		- $head[$h][0] = DOL_URL_ROOT . '/hrm/admin/skill_extrafields.php';
	57	+ $head[$h][0] = DOL_URL_ROOT.'/hrm/admin/skill_extrafields.php';
58	58	$head[$h][1] = $langs->trans("SkillsExtraFields");
59	59	$nbExtrafields = $extrafields->attributes['hrm_skill']['count'];
60	60	if ($nbExtrafields > 0) {
		@@ -63,7 +63,7 @@ discard block
		block discarded – undo
63	63	$head[$h][2] = 'skillsAttributes';
64	64	$h++;
65	65
66		- $head[$h][0] = DOL_URL_ROOT . '/hrm/admin/job_extrafields.php';
	66	+ $head[$h][0] = DOL_URL_ROOT.'/hrm/admin/job_extrafields.php';
67	67	$head[$h][1] = $langs->trans("JobsExtraFields");
68	68	$nbExtrafields = $extrafields->attributes['hrm_job']['count'];
69	69	if ($nbExtrafields > 0) {
		@@ -72,7 +72,7 @@ discard block
		block discarded – undo
72	72	$head[$h][2] = 'jobsAttributes';
73	73	$h++;
74	74
75		- $head[$h][0] = DOL_URL_ROOT . '/hrm/admin/evaluation_extrafields.php';
	75	+ $head[$h][0] = DOL_URL_ROOT.'/hrm/admin/evaluation_extrafields.php';
76	76	$head[$h][1] = $langs->trans("EvaluationsExtraFields");
77	77	$nbExtrafields = $extrafields->attributes['hrm_evaluation']['count'];
78	78	if ($nbExtrafields > 0) {

		@@ -37,7 +37,7 @@ discard block
		block discarded – undo
37	37
38	38	// Load Dolibarr environment
39	39	require '../../main.inc.php';
40		-require DOL_DOCUMENT_ROOT . '/variants/class/ProductAttribute.class.php';
	40	+require DOL_DOCUMENT_ROOT.'/variants/class/ProductAttribute.class.php';
41	41
42	42	// Security check
43	43	if (!isModEnabled('variants')) {
		@@ -61,7 +61,7 @@ discard block
		block discarded – undo
61	61	if (GETPOST('roworder', 'alpha', 3)) {
62	62	$roworder = GETPOST('roworder', 'alpha', 3);
63	63
64		- dol_syslog("AjaxOrderAttribute roworder=" . $roworder, LOG_DEBUG);
	64	+ dol_syslog("AjaxOrderAttribute roworder=".$roworder, LOG_DEBUG);
65	65
66	66	$rowordertab = explode(',', $roworder);
67	67	$newrowordertab = array();

		@@ -73,7 +73,7 @@
		block discarded – undo
73	73
74	74	$object = new Commande($db);
75	75
76		-$usercancreate = $user->hasRight("commande", "creer");
	76	+$usercancreate = $user->hasRight("commande", "creer");
77	77	$permissiontoadd = $usercancreate;
78	78
79	79	// Security check

Dolibarr / dolibarr

Branch — develop (eb876f)

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch