Inspection of "Daily Inspection: Debug v21" - Dolibarr/dolibarr - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop (4d02ec)

unknown

created 2024-12-31 16:02 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -39,7 +39,7 @@
 block discarded – undo
 
 // Get Parameters
 $action = GETPOST('action', 'aZ09');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 
 /*

Please login to merge, or discard this patch.

htdocs/admin/tools/dolibarr_import.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -22,8 +22,8 @@
 block discarded – undo
  * 		\brief      Page to import database
  */
 
-if (! defined('CSRFCHECK_WITH_TOKEN')) {
-	define('CSRFCHECK_WITH_TOKEN', '1');		// Force use of CSRF protection with tokens even for GET
+if (!defined('CSRFCHECK_WITH_TOKEN')) {
+	define('CSRFCHECK_WITH_TOKEN', '1'); // Force use of CSRF protection with tokens even for GET
 }
 
 // Load Dolibarr environment

Please login to merge, or discard this patch.

htdocs/admin/tools/purge.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -21,8 +21,8 @@
 block discarded – undo
  *		\brief      Page to purge files (temporary or not)
  */
 
-if (! defined('CSRFCHECK_WITH_TOKEN')) {
-	define('CSRFCHECK_WITH_TOKEN', '1');		// Force use of CSRF protection with tokens even for GET
+if (!defined('CSRFCHECK_WITH_TOKEN')) {
+	define('CSRFCHECK_WITH_TOKEN', '1'); // Force use of CSRF protection with tokens even for GET
 }
 
 // Load Dolibarr environment

Please login to merge, or discard this patch.

htdocs/admin/tools/listsessions.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -22,8 +22,8 @@
 block discarded – undo
  *      \brief      List of PHP sessions
  */
 
-if (! defined('CSRFCHECK_WITH_TOKEN')) {
-	define('CSRFCHECK_WITH_TOKEN', '1');		// Force use of CSRF protection with tokens even for GET
+if (!defined('CSRFCHECK_WITH_TOKEN')) {
+	define('CSRFCHECK_WITH_TOKEN', '1'); // Force use of CSRF protection with tokens even for GET
 }
 
 // Load Dolibarr environment

Please login to merge, or discard this patch.

htdocs/admin/tools/export_files.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -23,8 +23,8 @@
 block discarded – undo
  *		\brief      Page to export documents into a compressed file
  */
 
-if (! defined('CSRFCHECK_WITH_TOKEN')) {
-	define('CSRFCHECK_WITH_TOKEN', '1');		// Force use of CSRF protection with tokens even for GET
+if (!defined('CSRFCHECK_WITH_TOKEN')) {
+	define('CSRFCHECK_WITH_TOKEN', '1'); // Force use of CSRF protection with tokens even for GET
 }
 
 // Load Dolibarr environment

Please login to merge, or discard this patch.

htdocs/core/tpl/commonfields_view.tpl.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -155,7 +155,7 @@  discard block
 block discarded – undo
 	if ($val['type'] == 'text' || $val['type'] == 'html') {
 		$rightpart .= ' tdtop';
 	}
-	$rightpart.= '">';
+	$rightpart .= '">';
 	$labeltoshow = '';
 	if (!empty($val['help'])) {
 		$labeltoshow .= $form->textwithpicto($langs->trans($val['label']), $langs->trans($val['help']));
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
 				$out = $object->showOutputField($val, $key, $value, '', '', '', 0);
 				$rightpart .= showValueWithClipboardCPButton($out, 0, $out);
 			} else {
-				$rightpart.= $object->showOutputField($val, $key, $value, '', '', '', 0);
+				$rightpart .= $object->showOutputField($val, $key, $value, '', '', '', 0);
 			}
 		}
 		if (preg_match('/^(text|html)/', $val['type'])) {

Please login to merge, or discard this patch.

htdocs/core/actions_setmoduleoptions.inc.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -78,19 +78,19 @@  discard block
 block discarded – undo
 
 	$listofdir = explode(',', preg_replace('/[\r\n]+/', ',', trim(getDolGlobalString($keyforuploaddir))));
 	foreach ($listofdir as $key => $tmpdir) {
-		$tmpdir = preg_replace('/DOL_DATA_ROOT\/*/', '', $tmpdir);	// Clean string if we found a hardcoded DOL_DATA_ROOT
+		$tmpdir = preg_replace('/DOL_DATA_ROOT\/*/', '', $tmpdir); // Clean string if we found a hardcoded DOL_DATA_ROOT
 		if (!$tmpdir) {
 			unset($listofdir[$key]);
 			continue;
 		}
-		$tmpdir = DOL_DATA_ROOT.'/'.$tmpdir;	// Complete with DOL_DATA_ROOT. Only files into DOL_DATA_ROOT can be reach/set
+		$tmpdir = DOL_DATA_ROOT.'/'.$tmpdir; // Complete with DOL_DATA_ROOT. Only files into DOL_DATA_ROOT can be reach/set
 		if (!is_dir($tmpdir)) {
 			if (empty($nomessageinsetmoduleoptions)) {
 				setEventMessages($langs->trans("ErrorDirNotFound", $tmpdir), null, 'warnings');
 			}
 		} else {
 			$upload_dir = $tmpdir;
-			break;	// So we take the first directory found into setup $conf->global->$keyforuploaddir
+			break; // So we take the first directory found into setup $conf->global->$keyforuploaddir
 		}
 	}
 
@@ -130,19 +130,19 @@  discard block
 block discarded – undo
 
 		foreach ($listofdir as $key => $tmpdir) {
 			$tmpdir = trim($tmpdir);
-			$tmpdir = preg_replace('/DOL_DATA_ROOT\/*/', '', $tmpdir);	// Clean string if we found a hardcoded DOL_DATA_ROOT
+			$tmpdir = preg_replace('/DOL_DATA_ROOT\/*/', '', $tmpdir); // Clean string if we found a hardcoded DOL_DATA_ROOT
 			if (!$tmpdir) {
 				unset($listofdir[$key]);
 				continue;
 			}
-			$tmpdir = DOL_DATA_ROOT.'/'.$tmpdir;	// Complete with DOL_DATA_ROOT. Only files into DOL_DATA_ROOT can be reach/set
+			$tmpdir = DOL_DATA_ROOT.'/'.$tmpdir; // Complete with DOL_DATA_ROOT. Only files into DOL_DATA_ROOT can be reach/set
 			if (!is_dir($tmpdir)) {
 				if (empty($nomessageinsetmoduleoptions)) {
 					setEventMessages($langs->trans("ErrorDirNotFound", $tmpdir), null, 'warnings');
 				}
 			} else {
 				$upload_dir = $tmpdir;
-				break;	// So we take the first directory found into setup $conf->global->$keyforuploaddir
+				break; // So we take the first directory found into setup $conf->global->$keyforuploaddir
 			}
 		}
 

Please login to merge, or discard this patch.

htdocs/core/modules/workstation/mod_workstation_standard.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -23,7 +23,7 @@
 block discarded – undo
  *  \ingroup    workstation
  *  \brief      File of class to manage Workstation numbering rules standard
  */
-require_once DOL_DOCUMENT_ROOT . '/core/modules/workstation/modules_workstation.php';
+require_once DOL_DOCUMENT_ROOT.'/core/modules/workstation/modules_workstation.php';
 
 /**
  * Class to manage the Standard numbering rule for Workstation

Please login to merge, or discard this patch.

htdocs/core/modules/mailings/thirdparties_services_expired.modules.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -135,8 +135,8 @@
 block discarded – undo
 					'lastname' => $obj->name, // For thirdparties, lastname must be name
 					'firstname' => '', // For thirdparties, firstname is ''
 					'other' =>
-					('DateStart='.dol_print_date($this->db->jdate($obj->date_start_real), 'day')).';'.	// date start real
-					('DateEnd='.dol_print_date($this->db->jdate($obj->date_end), 'day')).';'.			// date end planned
+					('DateStart='.dol_print_date($this->db->jdate($obj->date_start_real), 'day')).';'.// date start real
+					('DateEnd='.dol_print_date($this->db->jdate($obj->date_end), 'day')).';'.// date end planned
 					('Contract='.$obj->fk_contrat).';'.
 					('ContactLine='.$obj->cdid),
 					'source_url' => $this->url($obj->id),

Please login to merge, or discard this patch.

		@@ -39,7 +39,7 @@
		block discarded – undo
39	39
40	40	// Get Parameters
41	41	$action = GETPOST('action', 'aZ09');
42		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	42	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
43	43
44	44
45	45	/*

		@@ -155,7 +155,7 @@ discard block
		block discarded – undo
155	155	if ($val['type'] == 'text' \|\| $val['type'] == 'html') {
156	156	$rightpart .= ' tdtop';
157	157	}
158		- $rightpart.= '">';
	158	+ $rightpart .= '">';
159	159	$labeltoshow = '';
160	160	if (!empty($val['help'])) {
161	161	$labeltoshow .= $form->textwithpicto($langs->trans($val['label']), $langs->trans($val['help']));
		@@ -195,7 +195,7 @@ discard block
		block discarded – undo
195	195	$out = $object->showOutputField($val, $key, $value, '', '', '', 0);
196	196	$rightpart .= showValueWithClipboardCPButton($out, 0, $out);
197	197	} else {
198		- $rightpart.= $object->showOutputField($val, $key, $value, '', '', '', 0);
	198	+ $rightpart .= $object->showOutputField($val, $key, $value, '', '', '', 0);
199	199	}
200	200	}
201	201	if (preg_match('/^(text\|html)/', $val['type'])) {

		@@ -78,19 +78,19 @@ discard block
		block discarded – undo
78	78
79	79	$listofdir = explode(',', preg_replace('/[\r\n]+/', ',', trim(getDolGlobalString($keyforuploaddir))));
80	80	foreach ($listofdir as $key => $tmpdir) {
81		- $tmpdir = preg_replace('/DOL_DATA_ROOT\/*/', '', $tmpdir); // Clean string if we found a hardcoded DOL_DATA_ROOT
	81	+ $tmpdir = preg_replace('/DOL_DATA_ROOT\/*/', '', $tmpdir); // Clean string if we found a hardcoded DOL_DATA_ROOT
82	82	if (!$tmpdir) {
83	83	unset($listofdir[$key]);
84	84	continue;
85	85	}
86		- $tmpdir = DOL_DATA_ROOT.'/'.$tmpdir; // Complete with DOL_DATA_ROOT. Only files into DOL_DATA_ROOT can be reach/set
	86	+ $tmpdir = DOL_DATA_ROOT.'/'.$tmpdir; // Complete with DOL_DATA_ROOT. Only files into DOL_DATA_ROOT can be reach/set
87	87	if (!is_dir($tmpdir)) {
88	88	if (empty($nomessageinsetmoduleoptions)) {
89	89	setEventMessages($langs->trans("ErrorDirNotFound", $tmpdir), null, 'warnings');
90	90	}
91	91	} else {
92	92	$upload_dir = $tmpdir;
93		- break; // So we take the first directory found into setup $conf->global->$keyforuploaddir
	93	+ break; // So we take the first directory found into setup $conf->global->$keyforuploaddir
94	94	}
95	95	}
96	96
		@@ -130,19 +130,19 @@ discard block
		block discarded – undo
130	130
131	131	foreach ($listofdir as $key => $tmpdir) {
132	132	$tmpdir = trim($tmpdir);
133		- $tmpdir = preg_replace('/DOL_DATA_ROOT\/*/', '', $tmpdir); // Clean string if we found a hardcoded DOL_DATA_ROOT
	133	+ $tmpdir = preg_replace('/DOL_DATA_ROOT\/*/', '', $tmpdir); // Clean string if we found a hardcoded DOL_DATA_ROOT
134	134	if (!$tmpdir) {
135	135	unset($listofdir[$key]);
136	136	continue;
137	137	}
138		- $tmpdir = DOL_DATA_ROOT.'/'.$tmpdir; // Complete with DOL_DATA_ROOT. Only files into DOL_DATA_ROOT can be reach/set
	138	+ $tmpdir = DOL_DATA_ROOT.'/'.$tmpdir; // Complete with DOL_DATA_ROOT. Only files into DOL_DATA_ROOT can be reach/set
139	139	if (!is_dir($tmpdir)) {
140	140	if (empty($nomessageinsetmoduleoptions)) {
141	141	setEventMessages($langs->trans("ErrorDirNotFound", $tmpdir), null, 'warnings');
142	142	}
143	143	} else {
144	144	$upload_dir = $tmpdir;
145		- break; // So we take the first directory found into setup $conf->global->$keyforuploaddir
	145	+ break; // So we take the first directory found into setup $conf->global->$keyforuploaddir
146	146	}
147	147	}
148	148

		@@ -22,8 +22,8 @@
		block discarded – undo
22	22	* \brief Page to import database
23	23	*/
24	24
25		-if (! defined('CSRFCHECK_WITH_TOKEN')) {
26		- define('CSRFCHECK_WITH_TOKEN', '1'); // Force use of CSRF protection with tokens even for GET
	25	+if (!defined('CSRFCHECK_WITH_TOKEN')) {
	26	+ define('CSRFCHECK_WITH_TOKEN', '1'); // Force use of CSRF protection with tokens even for GET
27	27	}
28	28
29	29	// Load Dolibarr environment

		@@ -21,8 +21,8 @@
		block discarded – undo
21	21	* \brief Page to purge files (temporary or not)
22	22	*/
23	23
24		-if (! defined('CSRFCHECK_WITH_TOKEN')) {
25		- define('CSRFCHECK_WITH_TOKEN', '1'); // Force use of CSRF protection with tokens even for GET
	24	+if (!defined('CSRFCHECK_WITH_TOKEN')) {
	25	+ define('CSRFCHECK_WITH_TOKEN', '1'); // Force use of CSRF protection with tokens even for GET
26	26	}
27	27
28	28	// Load Dolibarr environment

		@@ -22,8 +22,8 @@
		block discarded – undo
22	22	* \brief List of PHP sessions
23	23	*/
24	24
25		-if (! defined('CSRFCHECK_WITH_TOKEN')) {
26		- define('CSRFCHECK_WITH_TOKEN', '1'); // Force use of CSRF protection with tokens even for GET
	25	+if (!defined('CSRFCHECK_WITH_TOKEN')) {
	26	+ define('CSRFCHECK_WITH_TOKEN', '1'); // Force use of CSRF protection with tokens even for GET
27	27	}
28	28
29	29	// Load Dolibarr environment

		@@ -23,8 +23,8 @@
		block discarded – undo
23	23	* \brief Page to export documents into a compressed file
24	24	*/
25	25
26		-if (! defined('CSRFCHECK_WITH_TOKEN')) {
27		- define('CSRFCHECK_WITH_TOKEN', '1'); // Force use of CSRF protection with tokens even for GET
	26	+if (!defined('CSRFCHECK_WITH_TOKEN')) {
	27	+ define('CSRFCHECK_WITH_TOKEN', '1'); // Force use of CSRF protection with tokens even for GET
28	28	}
29	29
30	30	// Load Dolibarr environment

		@@ -23,7 +23,7 @@
		block discarded – undo
23	23	* \ingroup workstation
24	24	* \brief File of class to manage Workstation numbering rules standard
25	25	*/
26		-require_once DOL_DOCUMENT_ROOT . '/core/modules/workstation/modules_workstation.php';
	26	+require_once DOL_DOCUMENT_ROOT.'/core/modules/workstation/modules_workstation.php';
27	27
28	28	/**
29	29	* Class to manage the Standard numbering rule for Workstation

		@@ -135,8 +135,8 @@
		block discarded – undo
135	135	'lastname' => $obj->name, // For thirdparties, lastname must be name
136	136	'firstname' => '', // For thirdparties, firstname is ''
137	137	'other' =>
138		- ('DateStart='.dol_print_date($this->db->jdate($obj->date_start_real), 'day')).';'. // date start real
139		- ('DateEnd='.dol_print_date($this->db->jdate($obj->date_end), 'day')).';'. // date end planned
	138	+ ('DateStart='.dol_print_date($this->db->jdate($obj->date_start_real), 'day')).';'.// date start real
	139	+ ('DateEnd='.dol_print_date($this->db->jdate($obj->date_end), 'day')).';'.// date end planned
140	140	('Contract='.$obj->fk_contrat).';'.
141	141	('ContactLine='.$obj->cdid),
142	142	'source_url' => $this->url($obj->id),

Dolibarr / dolibarr

Branch — develop (4d02ec)

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch