Inspection of "Daily Inspection: Qual: Add AbstractRestApiTest cl..." - Dolibarr/dolibarr - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop (cec3a6)

unknown

created 2024-02-28 16:43 UTC

Status

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -225,7 +225,7 @@  discard block
 block discarded – undo
 
 $title = $object->ref;
 if (!empty($withproject)) {
-	$title .= ' | ' . $langs->trans("Project") . (!empty($projectstatic->ref) ? ': '.$projectstatic->ref : '')  ;
+	$title .= ' | '.$langs->trans("Project").(!empty($projectstatic->ref) ? ': '.$projectstatic->ref : '');
 }
 $help_url = '';
 
@@ -266,7 +266,7 @@  discard block
 block discarded – undo
 		// Title
 		$morehtmlref .= $projectstatic->title;
 		// Thirdparty
-		if (!empty($projectstatic->thirdparty->id) &&$projectstatic->thirdparty->id > 0) {
+		if (!empty($projectstatic->thirdparty->id) && $projectstatic->thirdparty->id > 0) {
 			$morehtmlref .= '<br>'.$projectstatic->thirdparty->getNomUrl(1, 'project');
 		}
 		$morehtmlref .= '</div>';

Please login to merge, or discard this patch.

htdocs/hrm/job_note.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -29,8 +29,8 @@  discard block
 block discarded – undo
 // Load Dolibarr environment
 require '../main.inc.php';
 
-require_once DOL_DOCUMENT_ROOT . '/hrm/class/job.class.php';
-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_job.lib.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/class/job.class.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_job.lib.php';
 
 // Load translation files required by the page
 $langs->loadLangs(array('hrm', 'companies'));
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
 	$linkback = '<a href="'.dol_buildpath('/hrm/job_list.php', 1).'?restore_lastsearch_values=1'.(!empty($socid) ? '&socid='.$socid : '').'">'.$langs->trans("BackToList").'</a>';
 
 	$morehtmlref = '<div class="refid">';
-	$morehtmlref.= $object->label;
+	$morehtmlref .= $object->label;
 	$morehtmlref .= '</div>';
 
 

Please login to merge, or discard this patch.

htdocs/hrm/skill_note.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -29,8 +29,8 @@  discard block
 block discarded – undo
 // Load Dolibarr environment
 require '../main.inc.php';
 
-require_once DOL_DOCUMENT_ROOT . '/hrm/class/skill.class.php';
-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_skill.lib.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/class/skill.class.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_skill.lib.php';
 
 // Load translation files required by the page
 $langs->loadLangs(array('hrm', 'companies'));
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
 	$linkback = '<a href="'.DOL_URL_ROOT.'/hrm/skill_list.php?restore_lastsearch_values=1'.(!empty($socid) ? '&socid='.$socid : '').'">'.$langs->trans("BackToList").'</a>';
 
 	$morehtmlref = '<div class="refid">';
-	$morehtmlref.= $object->label;
+	$morehtmlref .= $object->label;
 	$morehtmlref .= '</div>';
 
 

Please login to merge, or discard this patch.

htdocs/hrm/skill_agenda.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -29,11 +29,11 @@  discard block
 block discarded – undo
 // Load Dolibarr environment
 require '../main.inc.php';
 
-require_once DOL_DOCUMENT_ROOT . '/contact/class/contact.class.php';
-require_once DOL_DOCUMENT_ROOT . '/core/lib/company.lib.php';
-require_once DOL_DOCUMENT_ROOT . '/core/lib/functions2.lib.php';
-require_once DOL_DOCUMENT_ROOT . '/hrm/class/skill.class.php';
-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_skill.lib.php';
+require_once DOL_DOCUMENT_ROOT.'/contact/class/contact.class.php';
+require_once DOL_DOCUMENT_ROOT.'/core/lib/company.lib.php';
+require_once DOL_DOCUMENT_ROOT.'/core/lib/functions2.lib.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/class/skill.class.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_skill.lib.php';
 
 
 // Load translation files required by the page
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
 	$linkback = '<a href="'.DOL_URL_ROOT.'/hrm/skill_list.php?restore_lastsearch_values=1'.(!empty($socid) ? '&socid='.$socid : '').'">'.$langs->trans("BackToList").'</a>';
 
 	$morehtmlref = '<div class="refid">';
-	$morehtmlref.= $object->label;
+	$morehtmlref .= $object->label;
 	$morehtmlref .= '</div>';
 
 

Please login to merge, or discard this patch.

htdocs/hrm/skill_document.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -33,8 +33,8 @@  discard block
 block discarded – undo
 require_once DOL_DOCUMENT_ROOT.'/core/lib/files.lib.php';
 require_once DOL_DOCUMENT_ROOT.'/core/lib/images.lib.php';
 require_once DOL_DOCUMENT_ROOT.'/core/class/html.formfile.class.php';
-require_once DOL_DOCUMENT_ROOT . '/hrm/class/skill.class.php';
-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_skill.lib.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/class/skill.class.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_skill.lib.php';
 
 // Load translation files required by the page
 $langs->loadLangs(array('hrm', 'companies', 'other', 'mails'));
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
 	$linkback = '<a href="'.DOL_URL_ROOT.'/hrm/skill_list.php?restore_lastsearch_values=1'.(!empty($socid) ? '&socid='.$socid : '').'">'.$langs->trans("BackToList").'</a>';
 
 	$morehtmlref = '<div class="refid">';
-	$morehtmlref.= $object->label;
+	$morehtmlref .= $object->label;
 	$morehtmlref .= '</div>';
 
 	dol_banner_tab($object, 'id', $linkback, 1, 'rowid', 'rowid', $morehtmlref);

Please login to merge, or discard this patch.

htdocs/hrm/job_document.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -32,8 +32,8 @@  discard block
 block discarded – undo
 require_once DOL_DOCUMENT_ROOT.'/core/lib/files.lib.php';
 require_once DOL_DOCUMENT_ROOT.'/core/lib/images.lib.php';
 require_once DOL_DOCUMENT_ROOT.'/core/class/html.formfile.class.php';
-require_once DOL_DOCUMENT_ROOT . '/hrm/class/job.class.php';
-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_job.lib.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/class/job.class.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_job.lib.php';
 
 // Load translation files required by the page
 $langs->loadLangs(array('hrm', 'companies', 'other', 'mails'));
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
 	$linkback = '<a href="'.dol_buildpath('/hrm/job_list.php', 1).'?restore_lastsearch_values=1'.(!empty($socid) ? '&socid='.$socid : '').'">'.$langs->trans("BackToList").'</a>';
 
 	$morehtmlref = '<div class="refid">';
-	$morehtmlref.= $object->label;
+	$morehtmlref .= $object->label;
 	$morehtmlref .= '</div>';
 
 	dol_banner_tab($object, 'id', $linkback, 1, 'rowid', 'rowid', $morehtmlref);

Please login to merge, or discard this patch.

htdocs/hrm/lib/hrm.lib.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -44,7 +44,7 @@  discard block
 block discarded – undo
 
 	$h = 0;
 	$head = array();
-	$head[$h][0] = DOL_URL_ROOT . "/admin/hrm.php";
+	$head[$h][0] = DOL_URL_ROOT."/admin/hrm.php";
 	$head[$h][1] = $langs->trans("Settings");
 	$head[$h][2] = 'settings';
 	$h++;
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
 	$head[$h][2] = 'establishments';
 	$h++;
 
-	$head[$h][0] = DOL_URL_ROOT . '/hrm/admin/skill_extrafields.php';
+	$head[$h][0] = DOL_URL_ROOT.'/hrm/admin/skill_extrafields.php';
 	$head[$h][1] = $langs->trans("SkillsExtraFields");
 	$nbExtrafields = $extrafields->attributes['hrm_skill']['count'];
 	if ($nbExtrafields > 0) {
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
 	$head[$h][2] = 'skillsAttributes';
 	$h++;
 
-	$head[$h][0] = DOL_URL_ROOT . '/hrm/admin/job_extrafields.php';
+	$head[$h][0] = DOL_URL_ROOT.'/hrm/admin/job_extrafields.php';
 	$head[$h][1] = $langs->trans("JobsExtraFields");
 	$nbExtrafields = $extrafields->attributes['hrm_job']['count'];
 	if ($nbExtrafields > 0) {
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
 	$head[$h][2] = 'jobsAttributes';
 	$h++;
 
-	$head[$h][0] = DOL_URL_ROOT . '/hrm/admin/evaluation_extrafields.php';
+	$head[$h][0] = DOL_URL_ROOT.'/hrm/admin/evaluation_extrafields.php';
 	$head[$h][1] = $langs->trans("EvaluationsExtraFields");
 	$nbExtrafields = $extrafields->attributes['hrm_evaluation']['count'];
 	if ($nbExtrafields > 0) {

Please login to merge, or discard this patch.

htdocs/variants/ajax/orderAttribute.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -37,7 +37,7 @@  discard block
 block discarded – undo
 
 // Load Dolibarr environment
 require '../../main.inc.php';
-require DOL_DOCUMENT_ROOT . '/variants/class/ProductAttribute.class.php';
+require DOL_DOCUMENT_ROOT.'/variants/class/ProductAttribute.class.php';
 
 // Security check
 if (!isModEnabled('variants')) {
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
 if (GETPOST('roworder', 'alpha', 3)) {
 	$roworder = GETPOST('roworder', 'alpha', 3);
 
-	dol_syslog("AjaxOrderAttribute roworder=" . $roworder, LOG_DEBUG);
+	dol_syslog("AjaxOrderAttribute roworder=".$roworder, LOG_DEBUG);
 
 	$rowordertab = explode(',', $roworder);
 	$newrowordertab = array();

Please login to merge, or discard this patch.

htdocs/commande/document.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -73,7 +73,7 @@
 block discarded – undo
 
 $object = new Commande($db);
 
-$usercancreate  =  $user->hasRight("commande", "creer");
+$usercancreate = $user->hasRight("commande", "creer");
 $permissiontoadd = $usercancreate;
 
 // Security check

Please login to merge, or discard this patch.

		@@ -225,7 +225,7 @@ discard block
		block discarded – undo
225	225
226	226	$title = $object->ref;
227	227	if (!empty($withproject)) {
228		- $title .= ' \| ' . $langs->trans("Project") . (!empty($projectstatic->ref) ? ': '.$projectstatic->ref : '') ;
	228	+ $title .= ' \| '.$langs->trans("Project").(!empty($projectstatic->ref) ? ': '.$projectstatic->ref : '');
229	229	}
230	230	$help_url = '';
231	231
		@@ -266,7 +266,7 @@ discard block
		block discarded – undo
266	266	// Title
267	267	$morehtmlref .= $projectstatic->title;
268	268	// Thirdparty
269		- if (!empty($projectstatic->thirdparty->id) &&$projectstatic->thirdparty->id > 0) {
	269	+ if (!empty($projectstatic->thirdparty->id) && $projectstatic->thirdparty->id > 0) {
270	270	$morehtmlref .= '<br>'.$projectstatic->thirdparty->getNomUrl(1, 'project');
271	271	}
272	272	$morehtmlref .= '</div>';

		@@ -73,7 +73,7 @@
		block discarded – undo
73	73
74	74	$object = new Commande($db);
75	75
76		-$usercancreate = $user->hasRight("commande", "creer");
	76	+$usercancreate = $user->hasRight("commande", "creer");
77	77	$permissiontoadd = $usercancreate;
78	78
79	79	// Security check

		@@ -29,8 +29,8 @@ discard block
		block discarded – undo
29	29	// Load Dolibarr environment
30	30	require '../main.inc.php';
31	31
32		-require_once DOL_DOCUMENT_ROOT . '/hrm/class/job.class.php';
33		-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_job.lib.php';
	32	+require_once DOL_DOCUMENT_ROOT.'/hrm/class/job.class.php';
	33	+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_job.lib.php';
34	34
35	35	// Load translation files required by the page
36	36	$langs->loadLangs(array('hrm', 'companies'));
		@@ -106,7 +106,7 @@ discard block
		block discarded – undo
106	106	$linkback = '<a href="'.dol_buildpath('/hrm/job_list.php', 1).'?restore_lastsearch_values=1'.(!empty($socid) ? '&socid='.$socid : '').'">'.$langs->trans("BackToList").'</a>';
107	107
108	108	$morehtmlref = '<div class="refid">';
109		- $morehtmlref.= $object->label;
	109	+ $morehtmlref .= $object->label;
110	110	$morehtmlref .= '</div>';
111	111
112	112

		@@ -29,11 +29,11 @@ discard block
		block discarded – undo
29	29	// Load Dolibarr environment
30	30	require '../main.inc.php';
31	31
32		-require_once DOL_DOCUMENT_ROOT . '/contact/class/contact.class.php';
33		-require_once DOL_DOCUMENT_ROOT . '/core/lib/company.lib.php';
34		-require_once DOL_DOCUMENT_ROOT . '/core/lib/functions2.lib.php';
35		-require_once DOL_DOCUMENT_ROOT . '/hrm/class/skill.class.php';
36		-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_skill.lib.php';
	32	+require_once DOL_DOCUMENT_ROOT.'/contact/class/contact.class.php';
	33	+require_once DOL_DOCUMENT_ROOT.'/core/lib/company.lib.php';
	34	+require_once DOL_DOCUMENT_ROOT.'/core/lib/functions2.lib.php';
	35	+require_once DOL_DOCUMENT_ROOT.'/hrm/class/skill.class.php';
	36	+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_skill.lib.php';
37	37
38	38
39	39	// Load translation files required by the page
		@@ -152,7 +152,7 @@ discard block
		block discarded – undo
152	152	$linkback = '<a href="'.DOL_URL_ROOT.'/hrm/skill_list.php?restore_lastsearch_values=1'.(!empty($socid) ? '&socid='.$socid : '').'">'.$langs->trans("BackToList").'</a>';
153	153
154	154	$morehtmlref = '<div class="refid">';
155		- $morehtmlref.= $object->label;
	155	+ $morehtmlref .= $object->label;
156	156	$morehtmlref .= '</div>';
157	157
158	158

		@@ -33,8 +33,8 @@ discard block
		block discarded – undo
33	33	require_once DOL_DOCUMENT_ROOT.'/core/lib/files.lib.php';
34	34	require_once DOL_DOCUMENT_ROOT.'/core/lib/images.lib.php';
35	35	require_once DOL_DOCUMENT_ROOT.'/core/class/html.formfile.class.php';
36		-require_once DOL_DOCUMENT_ROOT . '/hrm/class/skill.class.php';
37		-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_skill.lib.php';
	36	+require_once DOL_DOCUMENT_ROOT.'/hrm/class/skill.class.php';
	37	+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_skill.lib.php';
38	38
39	39	// Load translation files required by the page
40	40	$langs->loadLangs(array('hrm', 'companies', 'other', 'mails'));
		@@ -131,7 +131,7 @@ discard block
		block discarded – undo
131	131	$linkback = '<a href="'.DOL_URL_ROOT.'/hrm/skill_list.php?restore_lastsearch_values=1'.(!empty($socid) ? '&socid='.$socid : '').'">'.$langs->trans("BackToList").'</a>';
132	132
133	133	$morehtmlref = '<div class="refid">';
134		- $morehtmlref.= $object->label;
	134	+ $morehtmlref .= $object->label;
135	135	$morehtmlref .= '</div>';
136	136
137	137	dol_banner_tab($object, 'id', $linkback, 1, 'rowid', 'rowid', $morehtmlref);

		@@ -32,8 +32,8 @@ discard block
		block discarded – undo
32	32	require_once DOL_DOCUMENT_ROOT.'/core/lib/files.lib.php';
33	33	require_once DOL_DOCUMENT_ROOT.'/core/lib/images.lib.php';
34	34	require_once DOL_DOCUMENT_ROOT.'/core/class/html.formfile.class.php';
35		-require_once DOL_DOCUMENT_ROOT . '/hrm/class/job.class.php';
36		-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_job.lib.php';
	35	+require_once DOL_DOCUMENT_ROOT.'/hrm/class/job.class.php';
	36	+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_job.lib.php';
37	37
38	38	// Load translation files required by the page
39	39	$langs->loadLangs(array('hrm', 'companies', 'other', 'mails'));
		@@ -131,7 +131,7 @@ discard block
		block discarded – undo
131	131	$linkback = '<a href="'.dol_buildpath('/hrm/job_list.php', 1).'?restore_lastsearch_values=1'.(!empty($socid) ? '&socid='.$socid : '').'">'.$langs->trans("BackToList").'</a>';
132	132
133	133	$morehtmlref = '<div class="refid">';
134		- $morehtmlref.= $object->label;
	134	+ $morehtmlref .= $object->label;
135	135	$morehtmlref .= '</div>';
136	136
137	137	dol_banner_tab($object, 'id', $linkback, 1, 'rowid', 'rowid', $morehtmlref);

		@@ -44,7 +44,7 @@ discard block
		block discarded – undo
44	44
45	45	$h = 0;
46	46	$head = array();
47		- $head[$h][0] = DOL_URL_ROOT . "/admin/hrm.php";
	47	+ $head[$h][0] = DOL_URL_ROOT."/admin/hrm.php";
48	48	$head[$h][1] = $langs->trans("Settings");
49	49	$head[$h][2] = 'settings';
50	50	$h++;
		@@ -54,7 +54,7 @@ discard block
		block discarded – undo
54	54	$head[$h][2] = 'establishments';
55	55	$h++;
56	56
57		- $head[$h][0] = DOL_URL_ROOT . '/hrm/admin/skill_extrafields.php';
	57	+ $head[$h][0] = DOL_URL_ROOT.'/hrm/admin/skill_extrafields.php';
58	58	$head[$h][1] = $langs->trans("SkillsExtraFields");
59	59	$nbExtrafields = $extrafields->attributes['hrm_skill']['count'];
60	60	if ($nbExtrafields > 0) {
		@@ -63,7 +63,7 @@ discard block
		block discarded – undo
63	63	$head[$h][2] = 'skillsAttributes';
64	64	$h++;
65	65
66		- $head[$h][0] = DOL_URL_ROOT . '/hrm/admin/job_extrafields.php';
	66	+ $head[$h][0] = DOL_URL_ROOT.'/hrm/admin/job_extrafields.php';
67	67	$head[$h][1] = $langs->trans("JobsExtraFields");
68	68	$nbExtrafields = $extrafields->attributes['hrm_job']['count'];
69	69	if ($nbExtrafields > 0) {
		@@ -72,7 +72,7 @@ discard block
		block discarded – undo
72	72	$head[$h][2] = 'jobsAttributes';
73	73	$h++;
74	74
75		- $head[$h][0] = DOL_URL_ROOT . '/hrm/admin/evaluation_extrafields.php';
	75	+ $head[$h][0] = DOL_URL_ROOT.'/hrm/admin/evaluation_extrafields.php';
76	76	$head[$h][1] = $langs->trans("EvaluationsExtraFields");
77	77	$nbExtrafields = $extrafields->attributes['hrm_evaluation']['count'];
78	78	if ($nbExtrafields > 0) {

		@@ -37,7 +37,7 @@ discard block
		block discarded – undo
37	37
38	38	// Load Dolibarr environment
39	39	require '../../main.inc.php';
40		-require DOL_DOCUMENT_ROOT . '/variants/class/ProductAttribute.class.php';
	40	+require DOL_DOCUMENT_ROOT.'/variants/class/ProductAttribute.class.php';
41	41
42	42	// Security check
43	43	if (!isModEnabled('variants')) {
		@@ -61,7 +61,7 @@ discard block
		block discarded – undo
61	61	if (GETPOST('roworder', 'alpha', 3)) {
62	62	$roworder = GETPOST('roworder', 'alpha', 3);
63	63
64		- dol_syslog("AjaxOrderAttribute roworder=" . $roworder, LOG_DEBUG);
	64	+ dol_syslog("AjaxOrderAttribute roworder=".$roworder, LOG_DEBUG);
65	65
66	66	$rowordertab = explode(',', $roworder);
67	67	$newrowordertab = array();

Dolibarr / dolibarr

Branch — develop (cec3a6)

Status

Category

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch