Inspection of "Daily Inspection: Close TODO" - Dolibarr/dolibarr - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop (aac48b)

unknown

created 2025-11-22 16:35 UTC

Status

Braces +6 added lines, -2 removed lines patch added patch discarded remove patch

@@ -54,7 +54,9 @@  discard block
 block discarded – undo
 		$size = (int) $fieldInfos->size;
 		$moreCss = $this->getInputCss($fieldInfos, $moreCss);
 		$moreAttrib = trim((string) $moreAttrib);
-		if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
+		if (empty($moreAttrib)) {
+			$moreAttrib = ' ' . $moreAttrib;
+		}
 		$value = (int) $value;
 		$htmlName = $keyPrefix . $key . $keySuffix;
 
@@ -84,7 +86,9 @@  discard block
 block discarded – undo
 		$size = (int) $fieldInfos->size;
 		$moreCss = $this->getInputCss($fieldInfos, $moreCss);
 		$moreAttrib = trim((string) $moreAttrib);
-		if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
+		if (empty($moreAttrib)) {
+			$moreAttrib = ' ' . $moreAttrib;
+		}
 		$autoFocus = $fieldInfos->inputAutofocus ? ' autofocus' : '';
 		$value = (int) $value;
 		$htmlName = $keyPrefix . $key . $keySuffix;

Please login to merge, or discard this patch.

htdocs/core/class/fields/textfield.class.php 1 patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -72,7 +72,9 @@
 block discarded – undo
 	{
 		$moreCss = $this->getInputCss($fieldInfos, $moreCss);
 		$moreAttrib = trim((string) $moreAttrib);
-		if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
+		if (empty($moreAttrib)) {
+			$moreAttrib = ' ' . $moreAttrib;
+		}
 		$htmlName = $keyPrefix . $key . $keySuffix;
 
 		return self::$form->inputText($htmlName, (string) $value, $moreCss, $moreAttrib, $fieldInfos->options);

Please login to merge, or discard this patch.

htdocs/core/class/fields/radiofield.class.php 1 patch

Braces +6 added lines, -2 removed lines patch added patch discarded remove patch

@@ -53,7 +53,9 @@  discard block
 block discarded – undo
 
 		$moreCss = $this->getInputCss($fieldInfos, $moreCss);
 		$moreAttrib = trim((string) $moreAttrib);
-		if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
+		if (empty($moreAttrib)) {
+			$moreAttrib = ' ' . $moreAttrib;
+		}
 		$htmlName = $keyPrefix . $key . $keySuffix;
 		$value = $this->isEmptyValue($fieldInfos, $value) ? array() : (is_string($value) ? explode(',', $value) : (is_array($value) ? $value: array($value)));
 
@@ -82,7 +84,9 @@  discard block
 block discarded – undo
 	{
 		$moreCss = $this->getInputCss($fieldInfos, $moreCss);
 		$moreAttrib = trim((string) $moreAttrib);
-		if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
+		if (empty($moreAttrib)) {
+			$moreAttrib = ' ' . $moreAttrib;
+		}
 		$htmlName = $keyPrefix . $key . $keySuffix;
 
 		$selectedValue = $this->isEmptyValue($fieldInfos, $value) ? '' : (string) $value;

Please login to merge, or discard this patch.

htdocs/core/class/fields/sellistfield.class.php 1 patch

Braces +9 added lines, -3 removed lines patch added patch discarded remove patch

@@ -53,7 +53,9 @@  discard block
 block discarded – undo
 
 		$moreCss = $this->getInputCss($fieldInfos, $moreCss);
 		$moreAttrib = trim((string) $moreAttrib);
-		if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
+		if (empty($moreAttrib)) {
+			$moreAttrib = ' ' . $moreAttrib;
+		}
 		$htmlName = $keyPrefix . $key . $keySuffix;
 
 		$optionsList = array();
@@ -83,9 +85,13 @@  discard block
 block discarded – undo
 
 		$moreCss = $this->getInputCss($fieldInfos, $moreCss);
 		$moreAttrib = trim((string) $moreAttrib);
-		if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
+		if (empty($moreAttrib)) {
+			$moreAttrib = ' ' . $moreAttrib;
+		}
 		$placeHolder = $fieldInfos->inputPlaceholder;
-		if (!empty($placeHolder)) $placeHolder = ' placeholder="' . dolPrintHTMLForAttribute($placeHolder) . '"';
+		if (!empty($placeHolder)) {
+			$placeHolder = ' placeholder="' . dolPrintHTMLForAttribute($placeHolder) . '"';
+		}
 		$autoFocus = $fieldInfos->inputAutofocus ? ' autofocus' : '';
 		$htmlName = $keyPrefix . $key . $keySuffix;
 		$selectedValue = is_null($value) || $this->isEmptyValue($fieldInfos, $value) ? '' : (string) $value;

Please login to merge, or discard this patch.

htdocs/core/class/fields/booleanfield.class.php 1 patch

Braces +9 added lines, -3 removed lines patch added patch discarded remove patch

@@ -70,7 +70,9 @@  discard block
 block discarded – undo
 	{
 		$moreCss = $this->getInputCss($fieldInfos, $moreCss);
 		$moreAttrib = trim((string) $moreAttrib);
-		if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
+		if (empty($moreAttrib)) {
+			$moreAttrib = ' ' . $moreAttrib;
+		}
 		$checked = empty($value) ? '' : ' checked="checked"';
 		$htmlName = $keyPrefix . $key . $keySuffix;
 
@@ -97,7 +99,9 @@  discard block
 block discarded – undo
 		if (getDolGlobalInt('MAIN_OPTIMIZEFORTEXTBROWSER') < 2) {
 			$moreCss = $this->getInputCss($fieldInfos, $moreCss);
 			$moreAttrib = trim((string) $moreAttrib);
-			if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
+			if (empty($moreAttrib)) {
+				$moreAttrib = ' ' . $moreAttrib;
+			}
 			$checked = empty($value) ? '' : ' checked="checked"';
 			$value = self::$form->inputType('checkbox', '', '1', '', $moreCss, $checked . $moreAttrib . ' readonly disabled');
 		} else {
@@ -118,7 +122,9 @@  discard block
 block discarded – undo
 	 */
 	public function getInputCss($fieldInfos, $moreCss = '', $defaultCss = '')
 	{
-		if (empty($moreCss)) $moreCss = $defaultCss;
+		if (empty($moreCss)) {
+			$moreCss = $defaultCss;
+		}
 		$moreCss = trim((string) $moreCss);
 
 		return empty($moreCss) ? '' : ' ' . $moreCss;

Please login to merge, or discard this patch.

htdocs/core/class/fields/selectfield.class.php 1 patch

Braces +9 added lines, -3 removed lines patch added patch discarded remove patch

@@ -53,7 +53,9 @@  discard block
 block discarded – undo
 
 		$moreCss = $this->getInputCss($fieldInfos, $moreCss);
 		$moreAttrib = trim((string) $moreAttrib);
-		if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
+		if (empty($moreAttrib)) {
+			$moreAttrib = ' ' . $moreAttrib;
+		}
 		$htmlName = $keyPrefix . $key . $keySuffix;
 		$value = $this->isEmptyValue($fieldInfos, $value) ? array() : (is_string($value) ? explode(',', $value) : (is_array($value) ? $value: array($value)));
 
@@ -82,9 +84,13 @@  discard block
 block discarded – undo
 	{
 		$moreCss = $this->getInputCss($fieldInfos, $moreCss);
 		$moreAttrib = trim((string) $moreAttrib);
-		if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
+		if (empty($moreAttrib)) {
+			$moreAttrib = ' ' . $moreAttrib;
+		}
 		$placeHolder = $fieldInfos->inputPlaceholder;
-		if (!empty($placeHolder)) $placeHolder = ' placeholder="' . dolPrintHTMLForAttribute($placeHolder) . '"';
+		if (!empty($placeHolder)) {
+			$placeHolder = ' placeholder="' . dolPrintHTMLForAttribute($placeHolder) . '"';
+		}
 		$autoFocus = $fieldInfos->inputAutofocus ? ' autofocus' : '';
 		$htmlName = $keyPrefix . $key . $keySuffix;
 

Please login to merge, or discard this patch.

htdocs/core/class/fields/commonsellistfield.class.php 1 patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -128,7 +128,9 @@
 block discarded – undo
 			$labelAlias[] = $tmp['alias'];
 		}
 		$keyField = (string) ($InfoFieldList[2] ?? '');
-		if (empty($keyField)) $keyField = 'rowid';
+		if (empty($keyField)) {
+			$keyField = 'rowid';
+		}
 		$keyFieldParent = (string) ($InfoFieldList[3] ?? '');
 		$tmp = array_map('trim', explode('|', $keyFieldParent));
 		$parentName = (string) ($tmp[0] ?? '');

Please login to merge, or discard this patch.

htdocs/core/class/fields/htmlfield.class.php 1 patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -73,7 +73,9 @@
 block discarded – undo
 	{
 		$moreCss = $this->getInputCss($fieldInfos, $moreCss);
 		$moreAttrib = trim((string) $moreAttrib);
-		if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
+		if (empty($moreAttrib)) {
+			$moreAttrib = ' ' . $moreAttrib;
+		}
 		$htmlName = $keyPrefix . $key . $keySuffix;
 
 		return self::$form->inputHtml($htmlName, $value, $moreCss, $moreAttrib);

Please login to merge, or discard this patch.

htdocs/core/class/fields/pricecyfield.class.php 1 patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -242,7 +242,9 @@
 block discarded – undo
 	{
 		$filterValue = $value['value'] ?? '';
 		$filterCurrency = $value['currency'] ?? '';
-		if ($filterCurrency == '-1') $filterCurrency = '';
+		if ($filterCurrency == '-1') {
+			$filterCurrency = '';
+		}
 
 		$tmp = $this->getPriceAndCurrencyAliasAndField($fieldInfos, $key);
 		$aliasPrice = $tmp['aliasPrice'];

Please login to merge, or discard this patch.

		@@ -128,7 +128,9 @@
		block discarded – undo
128	128	$labelAlias[] = $tmp['alias'];
129	129	}
130	130	$keyField = (string) ($InfoFieldList[2] ?? '');
131		- if (empty($keyField)) $keyField = 'rowid';
	131	+ if (empty($keyField)) {
	132	+ $keyField = 'rowid';
	133	+ }
132	134	$keyFieldParent = (string) ($InfoFieldList[3] ?? '');
133	135	$tmp = array_map('trim', explode('\|', $keyFieldParent));
134	136	$parentName = (string) ($tmp[0] ?? '');

		@@ -73,7 +73,9 @@
		block discarded – undo
73	73	{
74	74	$moreCss = $this->getInputCss($fieldInfos, $moreCss);
75	75	$moreAttrib = trim((string) $moreAttrib);
76		- if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
	76	+ if (empty($moreAttrib)) {
	77	+ $moreAttrib = ' ' . $moreAttrib;
	78	+ }
77	79	$htmlName = $keyPrefix . $key . $keySuffix;
78	80
79	81	return self::$form->inputHtml($htmlName, $value, $moreCss, $moreAttrib);

		@@ -242,7 +242,9 @@
		block discarded – undo
242	242	{
243	243	$filterValue = $value['value'] ?? '';
244	244	$filterCurrency = $value['currency'] ?? '';
245		- if ($filterCurrency == '-1') $filterCurrency = '';
	245	+ if ($filterCurrency == '-1') {
	246	+ $filterCurrency = '';
	247	+ }
246	248
247	249	$tmp = $this->getPriceAndCurrencyAliasAndField($fieldInfos, $key);
248	250	$aliasPrice = $tmp['aliasPrice'];

		@@ -54,7 +54,9 @@ discard block
		block discarded – undo
54	54	$size = (int) $fieldInfos->size;
55	55	$moreCss = $this->getInputCss($fieldInfos, $moreCss);
56	56	$moreAttrib = trim((string) $moreAttrib);
57		- if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
	57	+ if (empty($moreAttrib)) {
	58	+ $moreAttrib = ' ' . $moreAttrib;
	59	+ }
58	60	$value = (int) $value;
59	61	$htmlName = $keyPrefix . $key . $keySuffix;
60	62
		@@ -84,7 +86,9 @@ discard block
		block discarded – undo
84	86	$size = (int) $fieldInfos->size;
85	87	$moreCss = $this->getInputCss($fieldInfos, $moreCss);
86	88	$moreAttrib = trim((string) $moreAttrib);
87		- if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
	89	+ if (empty($moreAttrib)) {
	90	+ $moreAttrib = ' ' . $moreAttrib;
	91	+ }
88	92	$autoFocus = $fieldInfos->inputAutofocus ? ' autofocus' : '';
89	93	$value = (int) $value;
90	94	$htmlName = $keyPrefix . $key . $keySuffix;

		@@ -72,7 +72,9 @@
		block discarded – undo
72	72	{
73	73	$moreCss = $this->getInputCss($fieldInfos, $moreCss);
74	74	$moreAttrib = trim((string) $moreAttrib);
75		- if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
	75	+ if (empty($moreAttrib)) {
	76	+ $moreAttrib = ' ' . $moreAttrib;
	77	+ }
76	78	$htmlName = $keyPrefix . $key . $keySuffix;
77	79
78	80	return self::$form->inputText($htmlName, (string) $value, $moreCss, $moreAttrib, $fieldInfos->options);

		@@ -53,7 +53,9 @@ discard block
		block discarded – undo
53	53
54	54	$moreCss = $this->getInputCss($fieldInfos, $moreCss);
55	55	$moreAttrib = trim((string) $moreAttrib);
56		- if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
	56	+ if (empty($moreAttrib)) {
	57	+ $moreAttrib = ' ' . $moreAttrib;
	58	+ }
57	59	$htmlName = $keyPrefix . $key . $keySuffix;
58	60	$value = $this->isEmptyValue($fieldInfos, $value) ? array() : (is_string($value) ? explode(',', $value) : (is_array($value) ? $value: array($value)));
59	61
		@@ -82,7 +84,9 @@ discard block
		block discarded – undo
82	84	{
83	85	$moreCss = $this->getInputCss($fieldInfos, $moreCss);
84	86	$moreAttrib = trim((string) $moreAttrib);
85		- if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
	87	+ if (empty($moreAttrib)) {
	88	+ $moreAttrib = ' ' . $moreAttrib;
	89	+ }
86	90	$htmlName = $keyPrefix . $key . $keySuffix;
87	91
88	92	$selectedValue = $this->isEmptyValue($fieldInfos, $value) ? '' : (string) $value;

		@@ -70,7 +70,9 @@ discard block
		block discarded – undo
70	70	{
71	71	$moreCss = $this->getInputCss($fieldInfos, $moreCss);
72	72	$moreAttrib = trim((string) $moreAttrib);
73		- if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
	73	+ if (empty($moreAttrib)) {
	74	+ $moreAttrib = ' ' . $moreAttrib;
	75	+ }
74	76	$checked = empty($value) ? '' : ' checked="checked"';
75	77	$htmlName = $keyPrefix . $key . $keySuffix;
76	78
		@@ -97,7 +99,9 @@ discard block
		block discarded – undo
97	99	if (getDolGlobalInt('MAIN_OPTIMIZEFORTEXTBROWSER') < 2) {
98	100	$moreCss = $this->getInputCss($fieldInfos, $moreCss);
99	101	$moreAttrib = trim((string) $moreAttrib);
100		- if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
	102	+ if (empty($moreAttrib)) {
	103	+ $moreAttrib = ' ' . $moreAttrib;
	104	+ }
101	105	$checked = empty($value) ? '' : ' checked="checked"';
102	106	$value = self::$form->inputType('checkbox', '', '1', '', $moreCss, $checked . $moreAttrib . ' readonly disabled');
103	107	} else {
		@@ -118,7 +122,9 @@ discard block
		block discarded – undo
118	122	*/
119	123	public function getInputCss($fieldInfos, $moreCss = '', $defaultCss = '')
120	124	{
121		- if (empty($moreCss)) $moreCss = $defaultCss;
	125	+ if (empty($moreCss)) {
	126	+ $moreCss = $defaultCss;
	127	+ }
122	128	$moreCss = trim((string) $moreCss);
123	129
124	130	return empty($moreCss) ? '' : ' ' . $moreCss;

Dolibarr / dolibarr

Branch — develop (aac48b)

Status

Category

Braces +6 added lines, -2 removed lines patch added patch discarded remove patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

Braces +6 added lines, -2 removed lines patch added patch discarded remove patch

Braces +9 added lines, -3 removed lines patch added patch discarded remove patch

Braces +9 added lines, -3 removed lines patch added patch discarded remove patch

Braces +9 added lines, -3 removed lines patch added patch discarded remove patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch