Dolibarr / dolibarr

dev/tools/test/namespacemig/bbb.class.php

Spacing +3 added lines, -3 removed lines

@@ -18,7 +18,7 @@ 
  */
 class Bbb
 {
-	const BBB='bbb';
+	const BBB = 'bbb';
 
 	/**
 	 * do
@@ -29,7 +29,7 @@ 
 	{
 		global $globalaaa, $globalbbb;
 		echo 'dobbb'."\n";
-		$globalaaa.='+bbb';
-		$globalbbb.='+bbb';
+		$globalaaa .= '+bbb';
+		$globalbbb .= '+bbb';
 	}
 }

Braces +3 added lines, -1 removed lines

@@ -25,9 +25,11 @@
 	 *
 	 * @return void
 	 */
-	public function do()
+	public function do {
+		()
 	{
 		global $globalaaa, $globalbbb;
+	}
 		echo 'dobbb'."\n";
 		$globalaaa.='+bbb';
 		$globalbbb.='+bbb';

dev/tools/test/namespacemig/aaa.class.php

Spacing +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
  */
 class Aaa
 {
-	const AAA='aaa';
+	const AAA = 'aaa';
 
 	/**
 	 * do

Braces +3 added lines, -1 removed lines

@@ -27,8 +27,10 @@
 	 *
 	 * @return void
 	 */
-	public function do()
+	public function do {
+		()
 	{
 		echo 'doaaa'."\n";
 	}
+	}
 }

dev/tools/test/testtcpdf.php

Spacing +5 added lines, -5 removed lines

@@ -65,11 +65,11 @@
  - To convert pfx certificate to pem: openssl pkcs12 -in tcpdf.pfx -out tcpdf.crt -nodes
 
 */
-$permissions=array('copy');
-$user_pass='aaa';
-$owner_pass=null;
-$mode=0;
-$pubkeys=null;
+$permissions = array('copy');
+$user_pass = 'aaa';
+$owner_pass = null;
+$mode = 0;
+$pubkeys = null;
 $pdf->SetProtection($permissions, $user_pass, $owner_pass, $mode, $pubkeys);
 
 // Example with public-key

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -123,7 +123,7 @@
 Encryption Example
 
 Consult the source code documentation for the SetProtection() method.
-EOD;
+eod;
 
 // print a block of text using Write()
 $pdf->Write(0, $txt, '', 0, 'L', true, 0, false, false, 0);

dev/translation/autotranslator.php

Spacing +10 added lines, -10 removed lines

@@ -28,7 +28,7 @@ 
 
 $sapi_type = php_sapi_name();
 $script_file = basename(__FILE__);
-$path=dirname(__FILE__).'/';
+$path = dirname(__FILE__).'/';
 
 // Test if batch mode
 if (substr($sapi_type, 0, 3) == 'cgi') {
@@ -45,17 +45,17 @@ 
 $langs->load("main");
 
 // Global variables
-$version='1.14';
-$error=0;
+$version = '1.14';
+$error = 0;
 
 
 // -------------------- START OF YOUR CODE HERE --------------------
 @set_time_limit(0);
 print "***** ".$script_file." (".$version.") *****\n";
-$dir=DOL_DOCUMENT_ROOT."/langs";
+$dir = DOL_DOCUMENT_ROOT."/langs";
 
 // Check parameters
-if (! isset($argv[3])) {
+if (!isset($argv[3])) {
 	print "Usage:   ".$script_file."  lang_code_src lang_code_dest|all APIKEY [langfile.lang]\n";
 	print "Example: ".$script_file."  en_US         pt_PT              123456\n";
 	print "Rem:     lang_code to use can be found on https://translate.google.com\n";
@@ -66,18 +66,18 @@ 
 print 'Argument 1='.$argv[1]."\n";
 print 'Argument 2='.$argv[2]."\n";
 print 'Argument 3='.$argv[3]."\n";
-$file='';
+$file = '';
 if (isset($argv[4])) {
-	$file=$argv[4];
+	$file = $argv[4];
 	print 'Argument 4='.$argv[4]."\n";
 }
 print 'Files will be generated/updated in directory '.$dir."\n";
 
 if ($argv[2] != 'all') {
-	if (! is_dir($dir.'/'.$argv[2])) {
+	if (!is_dir($dir.'/'.$argv[2])) {
 		print 'Create directory '.$dir.'/'.$argv[2]."\n";
-		$result=mkdir($dir.'/'.$argv[2]);
-		if (! $result) {
+		$result = mkdir($dir.'/'.$argv[2]);
+		if (!$result) {
 			$db->close();
 			return -1;
 		}

dev/initdata/generate-thirdparty.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -105,7 +105,7 @@
 
 print "Generates ".GEN_NUMBER_SOCIETE." companies\n";
 for ($s = 0; $s < GEN_NUMBER_SOCIETE; $s++) {
-	print "Company $s\n";
+	print "company $s\n";
 	$soc = new Societe($db);
 	$soc->name = "Company num ".time()."$s";
 	$soc->town = $listoftown[mt_rand(0, count($listoftown)-1)];

Spacing +21 added lines, -21 removed lines

@@ -26,7 +26,7 @@ 
 
 $sapi_type = php_sapi_name();
 $script_file = basename(__FILE__);
-$path=dirname(__FILE__).'/';
+$path = dirname(__FILE__).'/';
 
 // Test si mode batch
 $sapi_type = php_sapi_name();
@@ -37,7 +37,7 @@ 
 
 // Recupere root dolibarr
 //$path=preg_replace('/generate-societe.php/i','',$_SERVER["PHP_SELF"]);
-require __DIR__. '/../../htdocs/master.inc.php';
+require __DIR__.'/../../htdocs/master.inc.php';
 include_once DOL_DOCUMENT_ROOT.'/societe/class/societe.class.php';
 include_once DOL_DOCUMENT_ROOT.'/contact/class/contact.class.php';
 include_once DOL_DOCUMENT_ROOT.'/compta/facture/class/facture.class.php';
@@ -45,8 +45,8 @@ 
 include_once DOL_DOCUMENT_ROOT.'/compta/paiement/class/paiement.class.php';
 include_once DOL_DOCUMENT_ROOT.'/contrat/class/contrat.class.php';
 
-$listoftown = array("Auray","Baden","Vannes","Pirouville","Haguenau","Souffelweiersheim","Illkirch-Graffenstaden","Lauterbourg","Picauville","Sainte-Mère Eglise","Le Bono");
-$listoflastname = array("Joe","Marc","Steve","Laurent","Nico","Isabelle","Dorothee","Saby","Brigitte","Karine","Jose-Anne","Celine","Virginie");
+$listoftown = array("Auray", "Baden", "Vannes", "Pirouville", "Haguenau", "Souffelweiersheim", "Illkirch-Graffenstaden", "Lauterbourg", "Picauville", "Sainte-Mère Eglise", "Le Bono");
+$listoflastname = array("Joe", "Marc", "Steve", "Laurent", "Nico", "Isabelle", "Dorothee", "Saby", "Brigitte", "Karine", "Jose-Anne", "Celine", "Virginie");
 
 
 /*
@@ -56,8 +56,8 @@ 
 define('GEN_NUMBER_SOCIETE', $argv[1] ?? 10);
 
 
-$ret=$user->fetch('', 'admin');
-if (! $ret > 0) {
+$ret = $user->fetch('', 'admin');
+if (!$ret > 0) {
 	print 'A user with login "admin" and all permissions must be created to use this script.'."\n";
 	exit;
 }
@@ -65,7 +65,7 @@ 
 
 
 $sql = "SELECT rowid FROM ".MAIN_DB_PREFIX."product"; $productsid = array();
-$resql=$db->query($sql);
+$resql = $db->query($sql);
 if ($resql) {
 	$num = $db->num_rows($resql);
 	$i = 0;
@@ -77,7 +77,7 @@ 
 }
 
 $sql = "SELECT rowid FROM ".MAIN_DB_PREFIX."societe"; $societesid = array();
-$resql=$db->query($sql);
+$resql = $db->query($sql);
 if ($resql) {
 	$num = $db->num_rows($resql);
 	$i = 0;
@@ -91,7 +91,7 @@ 
 }
 
 $sql = "SELECT rowid FROM ".MAIN_DB_PREFIX."commande"; $commandesid = array();
-$resql=$db->query($sql);
+$resql = $db->query($sql);
 if ($resql) {
 	$num = $db->num_rows($resql);
 	$i = 0;
@@ -111,18 +111,18 @@ 
 	print "Company $s\n";
 	$soc = new Societe($db);
 	$soc->name = "Company num ".time()."$s";
-	$soc->town = $listoftown[mt_rand(0, count($listoftown)-1)];
-	$soc->client = mt_rand(1, 2);		// Une societe sur 2 est prospect, l'autre client
-	$soc->fournisseur = mt_rand(0, 1);	// Une societe sur 2 est fournisseur
-	$soc->code_client='CU'.time()."$s";
-	$soc->code_fournisseur='SU'.time()."$s";
-	$soc->tva_assuj=1;
-	$soc->country_id=1;
-	$soc->country_code='FR';
+	$soc->town = $listoftown[mt_rand(0, count($listoftown) - 1)];
+	$soc->client = mt_rand(1, 2); // Une societe sur 2 est prospect, l'autre client
+	$soc->fournisseur = mt_rand(0, 1); // Une societe sur 2 est fournisseur
+	$soc->code_client = 'CU'.time()."$s";
+	$soc->code_fournisseur = 'SU'.time()."$s";
+	$soc->tva_assuj = 1;
+	$soc->country_id = 1;
+	$soc->country_code = 'FR';
 	// Un client sur 3 a une remise de 5%
-	$user_remise=mt_rand(1, 3);
-	if ($user_remise==3) {
-		$soc->remise_percent=5;
+	$user_remise = mt_rand(1, 3);
+	if ($user_remise == 3) {
+		$soc->remise_percent = 5;
 	}
 	print "> client=".$soc->client.", fournisseur=".$soc->fournisseur.", remise=".$soc->remise_percent."\n";
 	$soc->note_private = 'Company created by the script generate-societe.php';
@@ -135,7 +135,7 @@ 
 			$contact = new Contact($db);
 			$contact->socid = $soc->id;
 			$contact->lastname = "Lastname".$c;
-			$contact->firstname = $listoflastname[mt_rand(0, count($listoflastname)-1)];
+			$contact->firstname = $listoflastname[mt_rand(0, count($listoflastname) - 1)];
 			if ($contact->create($user)) {
 			}
 		}

dev/initdata/purge-data.php

Spacing +21 added lines, -21 removed lines

@@ -26,7 +26,7 @@ 
 
 $sapi_type = php_sapi_name();
 $script_file = basename(__FILE__);
-$path=__DIR__.'/';
+$path = __DIR__.'/';
 
 // Test si mode batch
 if (substr($sapi_type, 0, 3) == 'cgi') {
@@ -35,7 +35,7 @@ 
 }
 
 // Recupere root dolibarr
-$path=preg_replace('/purge-data.php/i', '', $_SERVER["PHP_SELF"]);
+$path = preg_replace('/purge-data.php/i', '', $_SERVER["PHP_SELF"]);
 require $path."../../htdocs/master.inc.php";
 include_once DOL_DOCUMENT_ROOT.'/societe/class/societe.class.php';
 include_once DOL_DOCUMENT_ROOT.'/contact/class/contact.class.php';
@@ -47,11 +47,11 @@ 
 $langs->loadLangs(array("main", "errors"));
 
 // Global variables
-$version=DOL_VERSION;
-$error=0;
+$version = DOL_VERSION;
+$error = 0;
 
 // List of sql to execute
-$sqls=array(
+$sqls = array(
 	'user'=>array(
 		"DELETE FROM ".MAIN_DB_PREFIX."user_rights WHERE fk_user IN (SELECT rowid FROM ".MAIN_DB_PREFIX."user WHERE admin = 0 and login != 'admin') AND fk_user IN (select rowid FROM ".MAIN_DB_PREFIX."user where datec < '__DATE__')",
 		"DELETE FROM ".MAIN_DB_PREFIX."user WHERE admin = 0 and login != 'admin' AND datec < '__DATE__'",
@@ -182,7 +182,7 @@ 
 $option = $argv[2];
 $date = $argv[3];
 
-if (empty($mode) || ! in_array($mode, array('test','confirm'))) {
+if (empty($mode) || !in_array($mode, array('test', 'confirm'))) {
 	print "Usage:  $script_file (test|confirm) (all|option) (all|YYYY-MM-DD) [dbtype dbhost dbuser dbpassword dbname dbport]\n";
 	print "\n";
 	print "option can be ".implode(',', array_keys($sqls))."\n";
@@ -195,9 +195,9 @@ 
 	exit(-1);
 }
 if ($option != 'all') {
-	$listofoptions=explode(',', $option);
+	$listofoptions = explode(',', $option);
 	foreach ($listofoptions as $cursoroption) {
-		if (! in_array($cursoroption, array_keys($sqls))) {
+		if (!in_array($cursoroption, array_keys($sqls))) {
 			print "Usage:  $script_file (test|confirm) (all|option) (all|YYYY-MM-DD) [dbtype dbhost dbuser dbpassword dbname dbport]\n";
 			print "\n";
 			print "option '".$cursoroption."' must be in list ".implode(',', array_keys($sqls))."\n";
@@ -206,7 +206,7 @@ 
 	}
 }
 
-if (empty($date) || (! preg_match('/\d\d\d\d\-\d\d\-\d\d$/', $date) && $date != 'all')) {
+if (empty($date) || (!preg_match('/\d\d\d\d\-\d\d\-\d\d$/', $date) && $date != 'all')) {
 	print "Usage:  $script_file (test|confirm) (all|option) (all|YYYY-MM-DD) [dbtype dbhost dbuser dbpassword dbname dbport]\n";
 	print "\n";
 	print "date can be 'all' or 'YYYY-MM-DD' to delete record before YYYY-MM-DD\n";
@@ -221,13 +221,13 @@ 
 if (!empty($argv[4])) {
 	$db->close();
 	unset($db);
-	$db=getDoliDBInstance($argv[4], $argv[5], $argv[6], $argv[7], $argv[8], $argv[9]);
-	$user=new User($db);
+	$db = getDoliDBInstance($argv[4], $argv[5], $argv[6], $argv[7], $argv[8], $argv[9]);
+	$user = new User($db);
 }
 
 //var_dump($user->db->database_name);
-$ret=$user->fetch('', 'admin');
-if (! $ret > 0) {
+$ret = $user->fetch('', 'admin');
+if (!$ret > 0) {
 	print 'An admin user with login "admin" must exists to use this script.'."\n";
 	exit;
 }
@@ -242,7 +242,7 @@ 
 print "User = ".$db->database_user."\n";
 print "\n";
 
-if (! $confirmed) {
+if (!$confirmed) {
 	print "Hit Enter to continue or CTRL+C to stop...\n";
 	$input = trim(fgets(STDIN));
 }
@@ -259,10 +259,10 @@ 
 {
 	global $db, $sqls;
 
-	$error=0;
+	$error = 0;
 	foreach ($sqls[$family] as $sql) {
 		if (preg_match('/^@/', $sql)) {
-			$newfamily=preg_replace('/@/', '', $sql);
+			$newfamily = preg_replace('/@/', '', $sql);
 			processfamily($newfamily, $date);
 			continue;
 		}
@@ -271,8 +271,8 @@ 
 
 		print "Run sql: ".$sql."\n";
 
-		$resql=$db->query($sql);
-		if (! $resql) {
+		$resql = $db->query($sql);
+		if (!$resql) {
 			if ($db->errno() != 'DB_ERROR_NOSUCHTABLE') {
 				$error++;
 			}
@@ -295,9 +295,9 @@ 
 
 $db->begin();
 
-$listofoptions=explode(',', $option);
+$listofoptions = explode(',', $option);
 foreach ($listofoptions as $cursoroption) {
-	$oldfamily='';
+	$oldfamily = '';
 	foreach ($sqls as $family => $familysql) {
 		if ($cursoroption && $cursoroption != 'all' && $cursoroption != $family) {
 			continue;
@@ -308,7 +308,7 @@ 
 		}
 		$oldfamily = $family;
 
-		$result=processfamily($family, $date);
+		$result = processfamily($family, $date);
 		if ($result < 0) {
 			$error++;
 			break;

dev/initdata/generate-product.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -106,7 +106,7 @@
 	$produit->tva_tx = "20.0";
 	$ret=$produit->create($user);
 	if ($ret < 0) {
-		print "Error $ret - ".$produit->error."\n";
+		print "error $ret - ".$produit->error."\n";
 	} else {
 		print " OK with ref ".$produit->ref."\n";
 	}

Spacing +8 added lines, -8 removed lines

@@ -26,7 +26,7 @@ 
 
 $sapi_type = php_sapi_name();
 $script_file = basename(__FILE__);
-$path=dirname(__FILE__).'/';
+$path = dirname(__FILE__).'/';
 
 // Test si mode batch
 $sapi_type = php_sapi_name();
@@ -37,7 +37,7 @@ 
 
 // Recupere root dolibarr
 //$path=preg_replace('/generate-produit.php/i','',$_SERVER["PHP_SELF"]);
-require __DIR__. '/../../htdocs/master.inc.php';
+require __DIR__.'/../../htdocs/master.inc.php';
 include_once DOL_DOCUMENT_ROOT.'/societe/class/societe.class.php';
 include_once DOL_DOCUMENT_ROOT.'/contact/class/contact.class.php';
 include_once DOL_DOCUMENT_ROOT.'/compta/facture/class/facture.class.php';
@@ -53,8 +53,8 @@ 
 define('GEN_NUMBER_PRODUIT', $argv[1] ?? 100);
 
 
-$ret=$user->fetch('', 'admin');
-if (! $ret > 0) {
+$ret = $user->fetch('', 'admin');
+if (!$ret > 0) {
 	print 'A user with login "admin" and all permissions must be created to use this script.'."\n";
 	exit;
 }
@@ -62,7 +62,7 @@ 
 
 
 $sql = "SELECT rowid FROM ".MAIN_DB_PREFIX."product"; $productsid = array();
-$resql=$db->query($sql);
+$resql = $db->query($sql);
 if ($resql) {
 	$num = $db->num_rows($resql);
 	$i = 0;
@@ -74,7 +74,7 @@ 
 }
 
 $sql = "SELECT rowid FROM ".MAIN_DB_PREFIX."societe"; $societesid = array();
-$resql=$db->query($sql);
+$resql = $db->query($sql);
 if ($resql) {
 	$num = $db->num_rows($resql);
 	$i = 0;
@@ -88,7 +88,7 @@ 
 }
 
 $sql = "SELECT rowid FROM ".MAIN_DB_PREFIX."commande"; $commandesid = array();
-$resql=$db->query($sql);
+$resql = $db->query($sql);
 if ($resql) {
 	$num = $db->num_rows($resql);
 	$i = 0;
@@ -113,7 +113,7 @@ 
 	$produit->description = 'Description '.time().$s;
 	$produit->price = mt_rand(1, 999.99);
 	$produit->tva_tx = "20.0";
-	$ret=$produit->create($user);
+	$ret = $produit->create($user);
 	if ($ret < 0) {
 		print "Error $ret - ".$produit->error."\n";
 	} else {

htdocs/contact/document.php

Spacing +1 added lines, -1 removed lines

@@ -94,7 +94,7 @@
 }
 $result = restrictedArea($user, 'contact', $id, 'socpeople&societe', '', '', 'rowid', 0); // If we create a contact with no company (shared contacts), no check on write permission
 
-$permissiontoadd = $user->hasRight('societe', 'contact', 'creer');	// Used by the include of actions_dellink.inc.php
+$permissiontoadd = $user->hasRight('societe', 'contact', 'creer'); // Used by the include of actions_dellink.inc.php
 
 
 /*

htdocs/contact/perso.php

Spacing +1 added lines, -1 removed lines

@@ -197,7 +197,7 @@
 		$maxfilesizearray = getMaxFileSizeArray();
 		$maxmin = $maxfilesizearray['maxmin'];
 		if ($maxmin > 0) {
-			print '<input type="hidden" name="MAX_FILE_SIZE" value="'.($maxmin * 1024).'">';	// MAX_FILE_SIZE must precede the field type=file
+			print '<input type="hidden" name="MAX_FILE_SIZE" value="'.($maxmin * 1024).'">'; // MAX_FILE_SIZE must precede the field type=file
 		}
 		print '<input type="file" class="flat" name="photo" id="photoinput">';
 		print '</td></tr>';