Inspection of "Daily Inspection: Merge branch '20.0' of git@githu..." - Dolibarr/dolibarr - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop (8f5b98)

unknown

created 2024-06-25 16:24 UTC

Status

Spacing +76 added lines, -76 removed lines patch added patch discarded remove patch

@@ -83,12 +83,12 @@  discard block
 block discarded – undo
 	'bom' => 'Bom',
 	'bookcal' => 'BookCal',
 	'bookmark' => 'Bookmark',
-	'cashdesk' => null,  // TODO: fill in proper class
+	'cashdesk' => null, // TODO: fill in proper class
 	'category' => 'Categorie',
 	'clicktodial' => 'ClickToDial',
 	'collab' => 'Collab',
 	'comptabilite' => 'Comptabilite',
-	'contact' => null,  // TODO: fill in proper class
+	'contact' => null, // TODO: fill in proper class
 	'contract' => 'Contrat',
 	'cron' => 'Cron',
 	'datapolicy' => 'DataPolicy',
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
 	'don' => 'Don',
 	'dynamicprices' => 'DynamicPrices',
 	'ecm' => 'ECM',
-	'ecotax' => null,  // TODO: External module ?
+	'ecotax' => null, // TODO: External module ?
 	'emailcollector' => 'EmailCollector',
 	'eventorganization' => 'EventOrganization',
 	'expensereport' => 'ExpenseReport',
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
 	'fournisseur' => 'Fournisseur',
 	'ftp' => 'FTP',
 	'geoipmaxmind' => 'GeoIPMaxmind',
-	'google' => null,  // External ?
+	'google' => null, // External ?
 	'gravatar' => 'Gravatar',
 	'holiday' => 'Holiday',
 	'hrm' => 'HRM',
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
 	'ldap' => 'Ldap',
 	'loan' => 'Loan',
 	'mailing' => 'Mailing',
-	'mailman' => null,  // Same module as mailmanspip -> MailmanSpip ??
+	'mailman' => null, // Same module as mailmanspip -> MailmanSpip ??
 	'mailmanspip' => 'MailmanSpip',
 	'margin' => 'Margin',
 	'member' => 'Adherent',
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
 	'notification' => 'Notification',
 	'numberwords' => null, // Not provided by default, no module tests
 	'oauth' => 'Oauth',
-	'openstreetmap' => null,  // External module?
+	'openstreetmap' => null, // External module?
 	'opensurvey' => 'OpenSurvey',
 	'order' => 'Commande',
 	'partnership' => 'Partnership',
@@ -165,8 +165,8 @@  discard block
 block discarded – undo
 	'stock' => 'Stock',
 	'stocktransfer' => 'StockTransfer',
 	'stripe' => 'Stripe',
-	'supplier_invoice' => null,  // Special case, uses invoice
-	'supplier_order' => null,  // Special case, uses invoice
+	'supplier_invoice' => null, // Special case, uses invoice
+	'supplier_order' => null, // Special case, uses invoice
 	'supplier_proposal' => 'SupplierProposal',
 	'syslog' => 'Syslog',
 	'takepos' => 'TakePos',
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
 	//	'processes' => 6,
 	'backward_compatibility_checks' => false,
 	'simplify_ast' => true,
-	'analyzed_file_extensions' => ['php','inc'],
+	'analyzed_file_extensions' => ['php', 'inc'],
 	'globals_type_map' => [
 		'action' => 'string',
 		'actioncode' => 'string',
@@ -273,12 +273,12 @@  discard block
 block discarded – undo
 		'menumanager' => '\MenuManager',
 		'mysoc' => '\Societe',
 		'nblines' => '\int',
-		'obj' => '\CommonObject',     // Deprecated
+		'obj' => '\CommonObject', // Deprecated
 		'object_rights' => 'int|stdClass',
 		'objectoffield' => '\CommonObject',
 		'senderissupplier' => 'int<0,2>',
 		'user' => '\User',
-		'website' => 'string',  // See discussion https://github.com/Dolibarr/dolibarr/pull/28891#issuecomment-2002268334  // Disable because Phan infers Website type
+		'website' => 'string', // See discussion https://github.com/Dolibarr/dolibarr/pull/28891#issuecomment-2002268334  // Disable because Phan infers Website type
 		'websitepage' => '\WebSitePage',
 		'websitepagefile' => 'string',
 		// 'object' => '\CommonObject',  // Deprecated, not enabled because conflicts with $object assignments
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
 	// your application should be included in this list.
 	'directory_list' => [
 		'htdocs',
-		PHAN_DIR . '/stubs/',
+		PHAN_DIR.'/stubs/',
 	],
 
 	// A directory list that defines files that will be excluded
@@ -320,7 +320,7 @@  discard block
 block discarded – undo
 		'htdocs/includes/',
 		'htdocs/install/doctemplates/websites/',
 		'htdocs/core/class/lessc.class.php', // External library
-		PHAN_DIR . '/stubs/',
+		PHAN_DIR.'/stubs/',
 	],
 	//'exclude_file_regex' => '@^vendor/.*/(tests?|Tests?)/@',
 	'exclude_file_regex' => '@^('  // @phpstan-ignore-line
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
 		.'|htdocs/includes/stripe/.*'  // @phpstan-ignore-line
 		.'|htdocs/conf/conf.php'  // @phpstan-ignore-line
 		// .'|htdocs/[^h].*/.*'  // For testing @phpstan-ignore-line
-		.')@',  // @phpstan-ignore-line
+		.')@', // @phpstan-ignore-line
 
 	// A list of plugin files to execute.
 	// Plugins which are bundled with Phan can be added here by providing their name
@@ -351,14 +351,14 @@  discard block
 block discarded – undo
 		'/^isModEnabled$/' => [0, $moduleNameRegex, 'UnknownModuleName'],
 		// Note: trick to have different key for same regex:
 		'/^isModEnable[d]$/' => [0, $deprecatedModuleNameRegex, "DeprecatedModuleName"],
-		'/^sanitizeVal$/' => [1, $sanitizeRegex,"UnknownSanitizeType"],
-		'/^checkVal$/' => [1, $sanitizeRegex,"UnknownCheckValSanitizeType"],
-		'/^\\\\ExtraFields::addExtraField$/' => [2, $extraFieldTypeRegex,"UnknownExtrafieldTypeBack"],
-		'/^dol_now$/' => [0, '{^(?:auto|gmt|tz(?:server|ref|user(?:rel)?))$}',"InvalidDolNowArgument"],  // '', 0, 1 match bool and int values
-		'/^dol_mktime$/' => [6, '{^(?:|0|1|auto|gmt|tz(?:server|ref|user(?:rel)?|,[+a-zA-Z-/]+))$}',"InvalidDolMktimeArgument"],  // '', 0, 1 match bool and int values
-		'/^dol_print_date$/' => [2, '{^(?:|0|1|auto|gmt|tz(?:server|user(?:rel)?))$}',"InvalidDolMktimeArgument"],
-		'/^GETPOSTFLOAT$/' => [1, '{^(?:|M[UTS]|C[UT]|\d+)$}',"InvalidGetPostFloatRounding"],
-		'/^price2num$/' => [1, '{^(?:|M[UTS]|C[UT]|\d+)$}',"InvalidPrice2NumRounding"],
+		'/^sanitizeVal$/' => [1, $sanitizeRegex, "UnknownSanitizeType"],
+		'/^checkVal$/' => [1, $sanitizeRegex, "UnknownCheckValSanitizeType"],
+		'/^\\\\ExtraFields::addExtraField$/' => [2, $extraFieldTypeRegex, "UnknownExtrafieldTypeBack"],
+		'/^dol_now$/' => [0, '{^(?:auto|gmt|tz(?:server|ref|user(?:rel)?))$}', "InvalidDolNowArgument"], // '', 0, 1 match bool and int values
+		'/^dol_mktime$/' => [6, '{^(?:|0|1|auto|gmt|tz(?:server|ref|user(?:rel)?|,[+a-zA-Z-/]+))$}', "InvalidDolMktimeArgument"], // '', 0, 1 match bool and int values
+		'/^dol_print_date$/' => [2, '{^(?:|0|1|auto|gmt|tz(?:server|user(?:rel)?))$}', "InvalidDolMktimeArgument"],
+		'/^GETPOSTFLOAT$/' => [1, '{^(?:|M[UTS]|C[UT]|\d+)$}', "InvalidGetPostFloatRounding"],
+		'/^price2num$/' => [1, '{^(?:|M[UTS]|C[UT]|\d+)$}', "InvalidPrice2NumRounding"],
 	],
 	'plugins' => [
 		__DIR__.'/plugins/NoVarDumpPlugin.php',
@@ -419,40 +419,40 @@  discard block
 block discarded – undo
 		// Dolibarr uses a lot of internal deprecated stuff, not reporting
 		'PhanDeprecatedProperty',
 
-		'PhanCompatibleNegativeStringOffset',	// return false positive
-		'PhanPluginConstantVariableBool',		// a lot of false positive, in most cases, we want to keep the code as it is
-		'PhanTypeArraySuspiciousNullable',		// this option costs more time to be supported than it solves time
-		'PhanTypeInvalidDimOffset',				// this option costs more time to be supported than it solves time
+		'PhanCompatibleNegativeStringOffset', // return false positive
+		'PhanPluginConstantVariableBool', // a lot of false positive, in most cases, we want to keep the code as it is
+		'PhanTypeArraySuspiciousNullable', // this option costs more time to be supported than it solves time
+		'PhanTypeInvalidDimOffset', // this option costs more time to be supported than it solves time
 		'PhanTypeObjectUnsetDeclaredProperty',
-		'PhanTypePossiblyInvalidDimOffset',			// a lot of false positive, in most cases, we want to keep the code as it is
-		'PhanPluginUnknownArrayFunctionReturnType',	// a lot of false positive, in most cases, we want to keep the code as it is
+		'PhanTypePossiblyInvalidDimOffset', // a lot of false positive, in most cases, we want to keep the code as it is
+		'PhanPluginUnknownArrayFunctionReturnType', // a lot of false positive, in most cases, we want to keep the code as it is
 
-		'PhanPluginWhitespaceTab',		// Dolibarr used tabs
-		'PhanPluginCanUsePHP71Void',	// Dolibarr is maintaining 7.0 compatibility
-		'PhanPluginShortArray',			// Dolibarr uses array()
-		'PhanPluginShortArrayList',		// Dolibarr uses array()
+		'PhanPluginWhitespaceTab', // Dolibarr used tabs
+		'PhanPluginCanUsePHP71Void', // Dolibarr is maintaining 7.0 compatibility
+		'PhanPluginShortArray', // Dolibarr uses array()
+		'PhanPluginShortArrayList', // Dolibarr uses array()
 		// Fixers From PHPDocToRealTypesPlugin:
-		'PhanPluginCanUseParamType',			// Fixer - Report/Add types in the function definition (function abc(string $var) (adds string)
-		'PhanPluginCanUseReturnType',			// Fixer - Report/Add return types in the function definition (function abc(string $var) (adds string)
-		'PhanPluginCanUseNullableParamType',	// Fixer - Report/Add nullable parameter types in the function definition
-		'PhanPluginCanUseNullableReturnType',	// Fixer - Report/Add nullable return types in the function definition
+		'PhanPluginCanUseParamType', // Fixer - Report/Add types in the function definition (function abc(string $var) (adds string)
+		'PhanPluginCanUseReturnType', // Fixer - Report/Add return types in the function definition (function abc(string $var) (adds string)
+		'PhanPluginCanUseNullableParamType', // Fixer - Report/Add nullable parameter types in the function definition
+		'PhanPluginCanUseNullableReturnType', // Fixer - Report/Add nullable return types in the function definition
 
-		'PhanPluginNonBoolBranch',			// Not essential - 31240+ occurrences
-		'PhanPluginNumericalComparison',	// Not essential - 19870+ occurrences
-		'PhanTypeMismatchArgument',			// Not essential - 12300+ occurrences
-		'PhanPluginNonBoolInLogicalArith',	// Not essential - 11040+ occurrences
-		'PhanPluginConstantVariableScalar',	// Not essential - 5180+ occurrences
+		'PhanPluginNonBoolBranch', // Not essential - 31240+ occurrences
+		'PhanPluginNumericalComparison', // Not essential - 19870+ occurrences
+		'PhanTypeMismatchArgument', // Not essential - 12300+ occurrences
+		'PhanPluginNonBoolInLogicalArith', // Not essential - 11040+ occurrences
+		'PhanPluginConstantVariableScalar', // Not essential - 5180+ occurrences
 		'PhanPluginDuplicateAdjacentStatement',
-		'PhanPluginDuplicateConditionalTernaryDuplication',		// 2750+ occurrences
-		'PhanPluginDuplicateConditionalNullCoalescing',	// Not essential - 990+ occurrences
-		'PhanPluginRedundantAssignmentInGlobalScope',	// Not essential, a lot of false warning
-		'PhanPluginRedundantAssignment',				// Not essential, useless
-		'PhanPluginDuplicateCatchStatementBody',  // Requires PHP7.1 - 50+ occurrences
+		'PhanPluginDuplicateConditionalTernaryDuplication', // 2750+ occurrences
+		'PhanPluginDuplicateConditionalNullCoalescing', // Not essential - 990+ occurrences
+		'PhanPluginRedundantAssignmentInGlobalScope', // Not essential, a lot of false warning
+		'PhanPluginRedundantAssignment', // Not essential, useless
+		'PhanPluginDuplicateCatchStatementBody', // Requires PHP7.1 - 50+ occurrences
 
-		'PhanPluginUnknownArrayMethodParamType',	// Too many troubles to manage. Is enabled into config_extended only.
-		'PhanPluginUnknownArrayMethodReturnType',	// Too many troubles to manage. Is enabled into config_extended only.
-		'PhanUndeclaredGlobalVariable',			// Too many false positives on .tpl.php files. Is enabled into config_extended only.
-		'PhanPluginUnknownObjectMethodCall',	// False positive for some class. Is enabled into config_extended only.
+		'PhanPluginUnknownArrayMethodParamType', // Too many troubles to manage. Is enabled into config_extended only.
+		'PhanPluginUnknownArrayMethodReturnType', // Too many troubles to manage. Is enabled into config_extended only.
+		'PhanUndeclaredGlobalVariable', // Too many false positives on .tpl.php files. Is enabled into config_extended only.
+		'PhanPluginUnknownObjectMethodCall', // False positive for some class. Is enabled into config_extended only.
 	],
 	// You can put relative paths to internal stubs in this config option.
 	// Phan will continue using its detailed type annotations,
@@ -471,31 +471,31 @@  discard block
 block discarded – undo
 		//'xdebug'	=> 'vendor/phan/phan/.phan/internal_stubs/xdebug.phan_php',
 		//'memcached'  => PHAN_DIR . '/your_internal_stubs_folder_name/memcached.phan_php',
 		//'PDO'  => PHAN_DIR . '/stubs/PDO.phan_php',
-		'brotli'  => PHAN_DIR . '/stubs/brotli.phan_php',
-		'curl'  => PHAN_DIR . '/stubs/curl.phan_php',
-		'calendar'  => PHAN_DIR . '/stubs/calendar.phan_php',
-		'fileinfo'  => PHAN_DIR . '/stubs/fileinfo.phan_php',
-		'ftp'  => PHAN_DIR . '/stubs/ftp.phan_php',
-		'gd'  => PHAN_DIR . '/stubs/gd.phan_php',
-		'geoip'  => PHAN_DIR . '/stubs/geoip.phan_php',
-		'imagick'  => PHAN_DIR . '/stubs/imagick.phan_php',
-		'imap'  => PHAN_DIR . '/stubs/imap.phan_php',
-		'intl'  => PHAN_DIR . '/stubs/intl.phan_php',
-		'ldap'  => PHAN_DIR . '/stubs/ldap.phan_php',
-		'mcrypt'  => PHAN_DIR . '/stubs/mcrypt.phan_php',
-		'memcache'  => PHAN_DIR . '/stubs/memcache.phan_php',
-		'memcached' => PHAN_DIR . '/stubs/memcached.phan_php',
-		'mysqli'  => PHAN_DIR . '/stubs/mysqli.phan_php',
-		'pdo_cubrid'  => PHAN_DIR . '/stubs/pdo_cubrid.phan_php',
-		'pdo_mysql'  => PHAN_DIR . '/stubs/pdo_mysql.phan_php',
-		'pdo_pgsql'  => PHAN_DIR . '/stubs/pdo_pgsql.phan_php',
-		'pdo_sqlite'  => PHAN_DIR . '/stubs/pdo_sqlite.phan_php',
-		'pgsql'  => PHAN_DIR . '/stubs/pgsql.phan_php',
-		'session'  => PHAN_DIR . '/stubs/session.phan_php',
-		'simplexml'  => PHAN_DIR . '/stubs/SimpleXML.phan_php',
-		'soap'  => PHAN_DIR . '/stubs/soap.phan_php',
-		'sockets'  => PHAN_DIR . '/stubs/sockets.phan_php',
-		'tidy'  => PHAN_DIR . '/stubs/tidy.phan_php',
-		'zip'  => PHAN_DIR . '/stubs/zip.phan_php',
+		'brotli'  => PHAN_DIR.'/stubs/brotli.phan_php',
+		'curl'  => PHAN_DIR.'/stubs/curl.phan_php',
+		'calendar'  => PHAN_DIR.'/stubs/calendar.phan_php',
+		'fileinfo'  => PHAN_DIR.'/stubs/fileinfo.phan_php',
+		'ftp'  => PHAN_DIR.'/stubs/ftp.phan_php',
+		'gd'  => PHAN_DIR.'/stubs/gd.phan_php',
+		'geoip'  => PHAN_DIR.'/stubs/geoip.phan_php',
+		'imagick'  => PHAN_DIR.'/stubs/imagick.phan_php',
+		'imap'  => PHAN_DIR.'/stubs/imap.phan_php',
+		'intl'  => PHAN_DIR.'/stubs/intl.phan_php',
+		'ldap'  => PHAN_DIR.'/stubs/ldap.phan_php',
+		'mcrypt'  => PHAN_DIR.'/stubs/mcrypt.phan_php',
+		'memcache'  => PHAN_DIR.'/stubs/memcache.phan_php',
+		'memcached' => PHAN_DIR.'/stubs/memcached.phan_php',
+		'mysqli'  => PHAN_DIR.'/stubs/mysqli.phan_php',
+		'pdo_cubrid'  => PHAN_DIR.'/stubs/pdo_cubrid.phan_php',
+		'pdo_mysql'  => PHAN_DIR.'/stubs/pdo_mysql.phan_php',
+		'pdo_pgsql'  => PHAN_DIR.'/stubs/pdo_pgsql.phan_php',
+		'pdo_sqlite'  => PHAN_DIR.'/stubs/pdo_sqlite.phan_php',
+		'pgsql'  => PHAN_DIR.'/stubs/pgsql.phan_php',
+		'session'  => PHAN_DIR.'/stubs/session.phan_php',
+		'simplexml'  => PHAN_DIR.'/stubs/SimpleXML.phan_php',
+		'soap'  => PHAN_DIR.'/stubs/soap.phan_php',
+		'sockets'  => PHAN_DIR.'/stubs/sockets.phan_php',
+		'tidy'  => PHAN_DIR.'/stubs/tidy.phan_php',
+		'zip'  => PHAN_DIR.'/stubs/zip.phan_php',
 	],
 ];

Please login to merge, or discard this patch.

dev/tools/phan/config_extended.php 1 patch

Spacing +24 added lines, -24 removed lines patch added patch discarded remove patch

@@ -64,35 +64,35 @@
 block discarded – undo
 		// Dolibarr uses a lot of internal deprecated stuff, not reporting
 		'PhanDeprecatedProperty',
 
-		'PhanCompatibleNegativeStringOffset',	// return false positive
-		'PhanPluginConstantVariableBool',		// a lot of false positive, in most cases, we want to keep the code as it is
-		'PhanTypeArraySuspiciousNullable',		// this option costs more time to be supported than it solves time
-		'PhanTypeInvalidDimOffset',				// this option costs more time to be supported than it solves time
+		'PhanCompatibleNegativeStringOffset', // return false positive
+		'PhanPluginConstantVariableBool', // a lot of false positive, in most cases, we want to keep the code as it is
+		'PhanTypeArraySuspiciousNullable', // this option costs more time to be supported than it solves time
+		'PhanTypeInvalidDimOffset', // this option costs more time to be supported than it solves time
 		'PhanTypeObjectUnsetDeclaredProperty',
-		'PhanTypePossiblyInvalidDimOffset',		// a lot of false positive, in most cases, we want to keep the code as it is
-		'PhanPluginUnknownArrayFunctionReturnType',	// a lot of false positive, in most cases, we want to keep the code as it is
+		'PhanTypePossiblyInvalidDimOffset', // a lot of false positive, in most cases, we want to keep the code as it is
+		'PhanPluginUnknownArrayFunctionReturnType', // a lot of false positive, in most cases, we want to keep the code as it is
 
-		'PhanPluginWhitespaceTab',		// Dolibarr used tabs
-		'PhanPluginCanUsePHP71Void',	// Dolibarr is maintaining 7.0 compatibility
-		'PhanPluginShortArray',			// Dolibarr uses array()
-		'PhanPluginShortArrayList',		// Dolibarr uses array()
+		'PhanPluginWhitespaceTab', // Dolibarr used tabs
+		'PhanPluginCanUsePHP71Void', // Dolibarr is maintaining 7.0 compatibility
+		'PhanPluginShortArray', // Dolibarr uses array()
+		'PhanPluginShortArrayList', // Dolibarr uses array()
 		// Fixers From PHPDocToRealTypesPlugin:
-		'PhanPluginCanUseParamType',			// Fixer - Report/Add types in the function definition (function abc(string $var) (adds string)
-		'PhanPluginCanUseReturnType',			// Fixer - Report/Add return types in the function definition (function abc(string $var) (adds string)
-		'PhanPluginCanUseNullableParamType',	// Fixer - Report/Add nullable parameter types in the function definition
-		'PhanPluginCanUseNullableReturnType',	// Fixer - Report/Add nullable return types in the function definition
+		'PhanPluginCanUseParamType', // Fixer - Report/Add types in the function definition (function abc(string $var) (adds string)
+		'PhanPluginCanUseReturnType', // Fixer - Report/Add return types in the function definition (function abc(string $var) (adds string)
+		'PhanPluginCanUseNullableParamType', // Fixer - Report/Add nullable parameter types in the function definition
+		'PhanPluginCanUseNullableReturnType', // Fixer - Report/Add nullable return types in the function definition
 
-		'PhanPluginNonBoolBranch',			// Not essential - 31240+ occurrences
-		'PhanPluginNumericalComparison',	// Not essential - 19870+ occurrences
-		'PhanTypeMismatchArgument',			// Not essential - 12300+ occurrences
-		'PhanPluginNonBoolInLogicalArith',	// Not essential - 11040+ occurrences
-		'PhanPluginConstantVariableScalar',	// Not essential - 5180+ occurrences
+		'PhanPluginNonBoolBranch', // Not essential - 31240+ occurrences
+		'PhanPluginNumericalComparison', // Not essential - 19870+ occurrences
+		'PhanTypeMismatchArgument', // Not essential - 12300+ occurrences
+		'PhanPluginNonBoolInLogicalArith', // Not essential - 11040+ occurrences
+		'PhanPluginConstantVariableScalar', // Not essential - 5180+ occurrences
 		'PhanPluginDuplicateAdjacentStatement',
-		'PhanPluginDuplicateConditionalTernaryDuplication',		// 2750+ occurrences
-		'PhanPluginDuplicateConditionalNullCoalescing',	// Not essential - 990+ occurrences
-		'PhanPluginRedundantAssignmentInGlobalScope',	// Not essential, a lot of false warning
-		'PhanPluginRedundantAssignment',				// Not essential, useless
-		'PhanPluginDuplicateCatchStatementBody',  // Requires PHP7.1 - 50+ occurrences
+		'PhanPluginDuplicateConditionalTernaryDuplication', // 2750+ occurrences
+		'PhanPluginDuplicateConditionalNullCoalescing', // Not essential - 990+ occurrences
+		'PhanPluginRedundantAssignmentInGlobalScope', // Not essential, a lot of false warning
+		'PhanPluginRedundantAssignment', // Not essential, useless
+		'PhanPluginDuplicateCatchStatementBody', // Requires PHP7.1 - 50+ occurrences
 ];
 
 return $config;

Please login to merge, or discard this patch.

		@@ -83,12 +83,12 @@ discard block
		block discarded – undo
83	83	'bom' => 'Bom',
84	84	'bookcal' => 'BookCal',
85	85	'bookmark' => 'Bookmark',
86		- 'cashdesk' => null, // TODO: fill in proper class
	86	+ 'cashdesk' => null, // TODO: fill in proper class
87	87	'category' => 'Categorie',
88	88	'clicktodial' => 'ClickToDial',
89	89	'collab' => 'Collab',
90	90	'comptabilite' => 'Comptabilite',
91		- 'contact' => null, // TODO: fill in proper class
	91	+ 'contact' => null, // TODO: fill in proper class
92	92	'contract' => 'Contrat',
93	93	'cron' => 'Cron',
94	94	'datapolicy' => 'DataPolicy',
		@@ -100,7 +100,7 @@ discard block
		block discarded – undo
100	100	'don' => 'Don',
101	101	'dynamicprices' => 'DynamicPrices',
102	102	'ecm' => 'ECM',
103		- 'ecotax' => null, // TODO: External module ?
	103	+ 'ecotax' => null, // TODO: External module ?
104	104	'emailcollector' => 'EmailCollector',
105	105	'eventorganization' => 'EventOrganization',
106	106	'expensereport' => 'ExpenseReport',
		@@ -111,7 +111,7 @@ discard block
		block discarded – undo
111	111	'fournisseur' => 'Fournisseur',
112	112	'ftp' => 'FTP',
113	113	'geoipmaxmind' => 'GeoIPMaxmind',
114		- 'google' => null, // External ?
	114	+ 'google' => null, // External ?
115	115	'gravatar' => 'Gravatar',
116	116	'holiday' => 'Holiday',
117	117	'hrm' => 'HRM',
		@@ -125,7 +125,7 @@ discard block
		block discarded – undo
125	125	'ldap' => 'Ldap',
126	126	'loan' => 'Loan',
127	127	'mailing' => 'Mailing',
128		- 'mailman' => null, // Same module as mailmanspip -> MailmanSpip ??
	128	+ 'mailman' => null, // Same module as mailmanspip -> MailmanSpip ??
129	129	'mailmanspip' => 'MailmanSpip',
130	130	'margin' => 'Margin',
131	131	'member' => 'Adherent',
		@@ -138,7 +138,7 @@ discard block
		block discarded – undo
138	138	'notification' => 'Notification',
139	139	'numberwords' => null, // Not provided by default, no module tests
140	140	'oauth' => 'Oauth',
141		- 'openstreetmap' => null, // External module?
	141	+ 'openstreetmap' => null, // External module?
142	142	'opensurvey' => 'OpenSurvey',
143	143	'order' => 'Commande',
144	144	'partnership' => 'Partnership',
		@@ -165,8 +165,8 @@ discard block
		block discarded – undo
165	165	'stock' => 'Stock',
166	166	'stocktransfer' => 'StockTransfer',
167	167	'stripe' => 'Stripe',
168		- 'supplier_invoice' => null, // Special case, uses invoice
169		- 'supplier_order' => null, // Special case, uses invoice
	168	+ 'supplier_invoice' => null, // Special case, uses invoice
	169	+ 'supplier_order' => null, // Special case, uses invoice
170	170	'supplier_proposal' => 'SupplierProposal',
171	171	'syslog' => 'Syslog',
172	172	'takepos' => 'TakePos',
		@@ -228,7 +228,7 @@ discard block
		block discarded – undo
228	228	// 'processes' => 6,
229	229	'backward_compatibility_checks' => false,
230	230	'simplify_ast' => true,
231		- 'analyzed_file_extensions' => ['php','inc'],
	231	+ 'analyzed_file_extensions' => ['php', 'inc'],
232	232	'globals_type_map' => [
233	233	'action' => 'string',
234	234	'actioncode' => 'string',
		@@ -273,12 +273,12 @@ discard block
		block discarded – undo
273	273	'menumanager' => '\MenuManager',
274	274	'mysoc' => '\Societe',
275	275	'nblines' => '\int',
276		- 'obj' => '\CommonObject', // Deprecated
	276	+ 'obj' => '\CommonObject', // Deprecated
277	277	'object_rights' => 'int\|stdClass',
278	278	'objectoffield' => '\CommonObject',
279	279	'senderissupplier' => 'int<0,2>',
280	280	'user' => '\User',
281		- 'website' => 'string', // See discussion https://github.com/Dolibarr/dolibarr/pull/28891#issuecomment-2002268334 // Disable because Phan infers Website type
	281	+ 'website' => 'string', // See discussion https://github.com/Dolibarr/dolibarr/pull/28891#issuecomment-2002268334 // Disable because Phan infers Website type
282	282	'websitepage' => '\WebSitePage',
283	283	'websitepagefile' => 'string',
284	284	// 'object' => '\CommonObject', // Deprecated, not enabled because conflicts with $object assignments
		@@ -302,7 +302,7 @@ discard block
		block discarded – undo
302	302	// your application should be included in this list.
303	303	'directory_list' => [
304	304	'htdocs',
305		- PHAN_DIR . '/stubs/',
	305	+ PHAN_DIR.'/stubs/',
306	306	],
307	307
308	308	// A directory list that defines files that will be excluded
		@@ -320,7 +320,7 @@ discard block
		block discarded – undo
320	320	'htdocs/includes/',
321	321	'htdocs/install/doctemplates/websites/',
322	322	'htdocs/core/class/lessc.class.php', // External library
323		- PHAN_DIR . '/stubs/',
	323	+ PHAN_DIR.'/stubs/',
324	324	],
325	325	//'exclude_file_regex' => '@^vendor/.*/(tests?\|Tests?)/@',
326	326	'exclude_file_regex' => '@^(' // @phpstan-ignore-line
		@@ -335,7 +335,7 @@ discard block
		block discarded – undo
335	335	.'\|htdocs/includes/stripe/.*' // @phpstan-ignore-line
336	336	.'\|htdocs/conf/conf.php' // @phpstan-ignore-line
337	337	// .'\|htdocs/[^h]./.' // For testing @phpstan-ignore-line
338		- .')@', // @phpstan-ignore-line
	338	+ .')@', // @phpstan-ignore-line
339	339
340	340	// A list of plugin files to execute.
341	341	// Plugins which are bundled with Phan can be added here by providing their name
		@@ -351,14 +351,14 @@ discard block
		block discarded – undo
351	351	'/^isModEnabled$/' => [0, $moduleNameRegex, 'UnknownModuleName'],
352	352	// Note: trick to have different key for same regex:
353	353	'/^isModEnable[d]$/' => [0, $deprecatedModuleNameRegex, "DeprecatedModuleName"],
354		- '/^sanitizeVal$/' => [1, $sanitizeRegex,"UnknownSanitizeType"],
355		- '/^checkVal$/' => [1, $sanitizeRegex,"UnknownCheckValSanitizeType"],
356		- '/^\\\\ExtraFields::addExtraField$/' => [2, $extraFieldTypeRegex,"UnknownExtrafieldTypeBack"],
357		- '/^dol_now$/' => [0, '{^(?:auto\|gmt\|tz(?:server\|ref\|user(?:rel)?))$}',"InvalidDolNowArgument"], // '', 0, 1 match bool and int values
358		- '/^dol_mktime$/' => [6, '{^(?:\|0\|1\|auto\|gmt\|tz(?:server\|ref\|user(?:rel)?\|,[+a-zA-Z-/]+))$}',"InvalidDolMktimeArgument"], // '', 0, 1 match bool and int values
359		- '/^dol_print_date$/' => [2, '{^(?:\|0\|1\|auto\|gmt\|tz(?:server\|user(?:rel)?))$}',"InvalidDolMktimeArgument"],
360		- '/^GETPOSTFLOAT$/' => [1, '{^(?:\|M[UTS]\|C[UT]\|\d+)$}',"InvalidGetPostFloatRounding"],
361		- '/^price2num$/' => [1, '{^(?:\|M[UTS]\|C[UT]\|\d+)$}',"InvalidPrice2NumRounding"],
	354	+ '/^sanitizeVal$/' => [1, $sanitizeRegex, "UnknownSanitizeType"],
	355	+ '/^checkVal$/' => [1, $sanitizeRegex, "UnknownCheckValSanitizeType"],
	356	+ '/^\\\\ExtraFields::addExtraField$/' => [2, $extraFieldTypeRegex, "UnknownExtrafieldTypeBack"],
	357	+ '/^dol_now$/' => [0, '{^(?:auto\|gmt\|tz(?:server\|ref\|user(?:rel)?))$}', "InvalidDolNowArgument"], // '', 0, 1 match bool and int values
	358	+ '/^dol_mktime$/' => [6, '{^(?:\|0\|1\|auto\|gmt\|tz(?:server\|ref\|user(?:rel)?\|,[+a-zA-Z-/]+))$}', "InvalidDolMktimeArgument"], // '', 0, 1 match bool and int values
	359	+ '/^dol_print_date$/' => [2, '{^(?:\|0\|1\|auto\|gmt\|tz(?:server\|user(?:rel)?))$}', "InvalidDolMktimeArgument"],
	360	+ '/^GETPOSTFLOAT$/' => [1, '{^(?:\|M[UTS]\|C[UT]\|\d+)$}', "InvalidGetPostFloatRounding"],
	361	+ '/^price2num$/' => [1, '{^(?:\|M[UTS]\|C[UT]\|\d+)$}', "InvalidPrice2NumRounding"],
362	362	],
363	363	'plugins' => [
364	364	__DIR__.'/plugins/NoVarDumpPlugin.php',
		@@ -419,40 +419,40 @@ discard block
		block discarded – undo
419	419	// Dolibarr uses a lot of internal deprecated stuff, not reporting
420	420	'PhanDeprecatedProperty',
421	421
422		- 'PhanCompatibleNegativeStringOffset', // return false positive
423		- 'PhanPluginConstantVariableBool', // a lot of false positive, in most cases, we want to keep the code as it is
424		- 'PhanTypeArraySuspiciousNullable', // this option costs more time to be supported than it solves time
425		- 'PhanTypeInvalidDimOffset', // this option costs more time to be supported than it solves time
	422	+ 'PhanCompatibleNegativeStringOffset', // return false positive
	423	+ 'PhanPluginConstantVariableBool', // a lot of false positive, in most cases, we want to keep the code as it is
	424	+ 'PhanTypeArraySuspiciousNullable', // this option costs more time to be supported than it solves time
	425	+ 'PhanTypeInvalidDimOffset', // this option costs more time to be supported than it solves time
426	426	'PhanTypeObjectUnsetDeclaredProperty',
427		- 'PhanTypePossiblyInvalidDimOffset', // a lot of false positive, in most cases, we want to keep the code as it is
428		- 'PhanPluginUnknownArrayFunctionReturnType', // a lot of false positive, in most cases, we want to keep the code as it is
	427	+ 'PhanTypePossiblyInvalidDimOffset', // a lot of false positive, in most cases, we want to keep the code as it is
	428	+ 'PhanPluginUnknownArrayFunctionReturnType', // a lot of false positive, in most cases, we want to keep the code as it is
429	429
430		- 'PhanPluginWhitespaceTab', // Dolibarr used tabs
431		- 'PhanPluginCanUsePHP71Void', // Dolibarr is maintaining 7.0 compatibility
432		- 'PhanPluginShortArray', // Dolibarr uses array()
433		- 'PhanPluginShortArrayList', // Dolibarr uses array()
	430	+ 'PhanPluginWhitespaceTab', // Dolibarr used tabs
	431	+ 'PhanPluginCanUsePHP71Void', // Dolibarr is maintaining 7.0 compatibility
	432	+ 'PhanPluginShortArray', // Dolibarr uses array()
	433	+ 'PhanPluginShortArrayList', // Dolibarr uses array()
434	434	// Fixers From PHPDocToRealTypesPlugin:
435		- 'PhanPluginCanUseParamType', // Fixer - Report/Add types in the function definition (function abc(string $var) (adds string)
436		- 'PhanPluginCanUseReturnType', // Fixer - Report/Add return types in the function definition (function abc(string $var) (adds string)
437		- 'PhanPluginCanUseNullableParamType', // Fixer - Report/Add nullable parameter types in the function definition
438		- 'PhanPluginCanUseNullableReturnType', // Fixer - Report/Add nullable return types in the function definition
	435	+ 'PhanPluginCanUseParamType', // Fixer - Report/Add types in the function definition (function abc(string $var) (adds string)
	436	+ 'PhanPluginCanUseReturnType', // Fixer - Report/Add return types in the function definition (function abc(string $var) (adds string)
	437	+ 'PhanPluginCanUseNullableParamType', // Fixer - Report/Add nullable parameter types in the function definition
	438	+ 'PhanPluginCanUseNullableReturnType', // Fixer - Report/Add nullable return types in the function definition
439	439
440		- 'PhanPluginNonBoolBranch', // Not essential - 31240+ occurrences
441		- 'PhanPluginNumericalComparison', // Not essential - 19870+ occurrences
442		- 'PhanTypeMismatchArgument', // Not essential - 12300+ occurrences
443		- 'PhanPluginNonBoolInLogicalArith', // Not essential - 11040+ occurrences
444		- 'PhanPluginConstantVariableScalar', // Not essential - 5180+ occurrences
	440	+ 'PhanPluginNonBoolBranch', // Not essential - 31240+ occurrences
	441	+ 'PhanPluginNumericalComparison', // Not essential - 19870+ occurrences
	442	+ 'PhanTypeMismatchArgument', // Not essential - 12300+ occurrences
	443	+ 'PhanPluginNonBoolInLogicalArith', // Not essential - 11040+ occurrences
	444	+ 'PhanPluginConstantVariableScalar', // Not essential - 5180+ occurrences
445	445	'PhanPluginDuplicateAdjacentStatement',
446		- 'PhanPluginDuplicateConditionalTernaryDuplication', // 2750+ occurrences
447		- 'PhanPluginDuplicateConditionalNullCoalescing', // Not essential - 990+ occurrences
448		- 'PhanPluginRedundantAssignmentInGlobalScope', // Not essential, a lot of false warning
449		- 'PhanPluginRedundantAssignment', // Not essential, useless
450		- 'PhanPluginDuplicateCatchStatementBody', // Requires PHP7.1 - 50+ occurrences
	446	+ 'PhanPluginDuplicateConditionalTernaryDuplication', // 2750+ occurrences
	447	+ 'PhanPluginDuplicateConditionalNullCoalescing', // Not essential - 990+ occurrences
	448	+ 'PhanPluginRedundantAssignmentInGlobalScope', // Not essential, a lot of false warning
	449	+ 'PhanPluginRedundantAssignment', // Not essential, useless
	450	+ 'PhanPluginDuplicateCatchStatementBody', // Requires PHP7.1 - 50+ occurrences
451	451
452		- 'PhanPluginUnknownArrayMethodParamType', // Too many troubles to manage. Is enabled into config_extended only.
453		- 'PhanPluginUnknownArrayMethodReturnType', // Too many troubles to manage. Is enabled into config_extended only.
454		- 'PhanUndeclaredGlobalVariable', // Too many false positives on .tpl.php files. Is enabled into config_extended only.
455		- 'PhanPluginUnknownObjectMethodCall', // False positive for some class. Is enabled into config_extended only.
	452	+ 'PhanPluginUnknownArrayMethodParamType', // Too many troubles to manage. Is enabled into config_extended only.
	453	+ 'PhanPluginUnknownArrayMethodReturnType', // Too many troubles to manage. Is enabled into config_extended only.
	454	+ 'PhanUndeclaredGlobalVariable', // Too many false positives on .tpl.php files. Is enabled into config_extended only.
	455	+ 'PhanPluginUnknownObjectMethodCall', // False positive for some class. Is enabled into config_extended only.
456	456	],
457	457	// You can put relative paths to internal stubs in this config option.
458	458	// Phan will continue using its detailed type annotations,
		@@ -471,31 +471,31 @@ discard block
		block discarded – undo
471	471	//'xdebug' => 'vendor/phan/phan/.phan/internal_stubs/xdebug.phan_php',
472	472	//'memcached' => PHAN_DIR . '/your_internal_stubs_folder_name/memcached.phan_php',
473	473	//'PDO' => PHAN_DIR . '/stubs/PDO.phan_php',
474		- 'brotli' => PHAN_DIR . '/stubs/brotli.phan_php',
475		- 'curl' => PHAN_DIR . '/stubs/curl.phan_php',
476		- 'calendar' => PHAN_DIR . '/stubs/calendar.phan_php',
477		- 'fileinfo' => PHAN_DIR . '/stubs/fileinfo.phan_php',
478		- 'ftp' => PHAN_DIR . '/stubs/ftp.phan_php',
479		- 'gd' => PHAN_DIR . '/stubs/gd.phan_php',
480		- 'geoip' => PHAN_DIR . '/stubs/geoip.phan_php',
481		- 'imagick' => PHAN_DIR . '/stubs/imagick.phan_php',
482		- 'imap' => PHAN_DIR . '/stubs/imap.phan_php',
483		- 'intl' => PHAN_DIR . '/stubs/intl.phan_php',
484		- 'ldap' => PHAN_DIR . '/stubs/ldap.phan_php',
485		- 'mcrypt' => PHAN_DIR . '/stubs/mcrypt.phan_php',
486		- 'memcache' => PHAN_DIR . '/stubs/memcache.phan_php',
487		- 'memcached' => PHAN_DIR . '/stubs/memcached.phan_php',
488		- 'mysqli' => PHAN_DIR . '/stubs/mysqli.phan_php',
489		- 'pdo_cubrid' => PHAN_DIR . '/stubs/pdo_cubrid.phan_php',
490		- 'pdo_mysql' => PHAN_DIR . '/stubs/pdo_mysql.phan_php',
491		- 'pdo_pgsql' => PHAN_DIR . '/stubs/pdo_pgsql.phan_php',
492		- 'pdo_sqlite' => PHAN_DIR . '/stubs/pdo_sqlite.phan_php',
493		- 'pgsql' => PHAN_DIR . '/stubs/pgsql.phan_php',
494		- 'session' => PHAN_DIR . '/stubs/session.phan_php',
495		- 'simplexml' => PHAN_DIR . '/stubs/SimpleXML.phan_php',
496		- 'soap' => PHAN_DIR . '/stubs/soap.phan_php',
497		- 'sockets' => PHAN_DIR . '/stubs/sockets.phan_php',
498		- 'tidy' => PHAN_DIR . '/stubs/tidy.phan_php',
499		- 'zip' => PHAN_DIR . '/stubs/zip.phan_php',
	474	+ 'brotli' => PHAN_DIR.'/stubs/brotli.phan_php',
	475	+ 'curl' => PHAN_DIR.'/stubs/curl.phan_php',
	476	+ 'calendar' => PHAN_DIR.'/stubs/calendar.phan_php',
	477	+ 'fileinfo' => PHAN_DIR.'/stubs/fileinfo.phan_php',
	478	+ 'ftp' => PHAN_DIR.'/stubs/ftp.phan_php',
	479	+ 'gd' => PHAN_DIR.'/stubs/gd.phan_php',
	480	+ 'geoip' => PHAN_DIR.'/stubs/geoip.phan_php',
	481	+ 'imagick' => PHAN_DIR.'/stubs/imagick.phan_php',
	482	+ 'imap' => PHAN_DIR.'/stubs/imap.phan_php',
	483	+ 'intl' => PHAN_DIR.'/stubs/intl.phan_php',
	484	+ 'ldap' => PHAN_DIR.'/stubs/ldap.phan_php',
	485	+ 'mcrypt' => PHAN_DIR.'/stubs/mcrypt.phan_php',
	486	+ 'memcache' => PHAN_DIR.'/stubs/memcache.phan_php',
	487	+ 'memcached' => PHAN_DIR.'/stubs/memcached.phan_php',
	488	+ 'mysqli' => PHAN_DIR.'/stubs/mysqli.phan_php',
	489	+ 'pdo_cubrid' => PHAN_DIR.'/stubs/pdo_cubrid.phan_php',
	490	+ 'pdo_mysql' => PHAN_DIR.'/stubs/pdo_mysql.phan_php',
	491	+ 'pdo_pgsql' => PHAN_DIR.'/stubs/pdo_pgsql.phan_php',
	492	+ 'pdo_sqlite' => PHAN_DIR.'/stubs/pdo_sqlite.phan_php',
	493	+ 'pgsql' => PHAN_DIR.'/stubs/pgsql.phan_php',
	494	+ 'session' => PHAN_DIR.'/stubs/session.phan_php',
	495	+ 'simplexml' => PHAN_DIR.'/stubs/SimpleXML.phan_php',
	496	+ 'soap' => PHAN_DIR.'/stubs/soap.phan_php',
	497	+ 'sockets' => PHAN_DIR.'/stubs/sockets.phan_php',
	498	+ 'tidy' => PHAN_DIR.'/stubs/tidy.phan_php',
	499	+ 'zip' => PHAN_DIR.'/stubs/zip.phan_php',
500	500	],
501	501	];

		@@ -64,35 +64,35 @@
		block discarded – undo
64	64	// Dolibarr uses a lot of internal deprecated stuff, not reporting
65	65	'PhanDeprecatedProperty',
66	66
67		- 'PhanCompatibleNegativeStringOffset', // return false positive
68		- 'PhanPluginConstantVariableBool', // a lot of false positive, in most cases, we want to keep the code as it is
69		- 'PhanTypeArraySuspiciousNullable', // this option costs more time to be supported than it solves time
70		- 'PhanTypeInvalidDimOffset', // this option costs more time to be supported than it solves time
	67	+ 'PhanCompatibleNegativeStringOffset', // return false positive
	68	+ 'PhanPluginConstantVariableBool', // a lot of false positive, in most cases, we want to keep the code as it is
	69	+ 'PhanTypeArraySuspiciousNullable', // this option costs more time to be supported than it solves time
	70	+ 'PhanTypeInvalidDimOffset', // this option costs more time to be supported than it solves time
71	71	'PhanTypeObjectUnsetDeclaredProperty',
72		- 'PhanTypePossiblyInvalidDimOffset', // a lot of false positive, in most cases, we want to keep the code as it is
73		- 'PhanPluginUnknownArrayFunctionReturnType', // a lot of false positive, in most cases, we want to keep the code as it is
	72	+ 'PhanTypePossiblyInvalidDimOffset', // a lot of false positive, in most cases, we want to keep the code as it is
	73	+ 'PhanPluginUnknownArrayFunctionReturnType', // a lot of false positive, in most cases, we want to keep the code as it is
74	74
75		- 'PhanPluginWhitespaceTab', // Dolibarr used tabs
76		- 'PhanPluginCanUsePHP71Void', // Dolibarr is maintaining 7.0 compatibility
77		- 'PhanPluginShortArray', // Dolibarr uses array()
78		- 'PhanPluginShortArrayList', // Dolibarr uses array()
	75	+ 'PhanPluginWhitespaceTab', // Dolibarr used tabs
	76	+ 'PhanPluginCanUsePHP71Void', // Dolibarr is maintaining 7.0 compatibility
	77	+ 'PhanPluginShortArray', // Dolibarr uses array()
	78	+ 'PhanPluginShortArrayList', // Dolibarr uses array()
79	79	// Fixers From PHPDocToRealTypesPlugin:
80		- 'PhanPluginCanUseParamType', // Fixer - Report/Add types in the function definition (function abc(string $var) (adds string)
81		- 'PhanPluginCanUseReturnType', // Fixer - Report/Add return types in the function definition (function abc(string $var) (adds string)
82		- 'PhanPluginCanUseNullableParamType', // Fixer - Report/Add nullable parameter types in the function definition
83		- 'PhanPluginCanUseNullableReturnType', // Fixer - Report/Add nullable return types in the function definition
	80	+ 'PhanPluginCanUseParamType', // Fixer - Report/Add types in the function definition (function abc(string $var) (adds string)
	81	+ 'PhanPluginCanUseReturnType', // Fixer - Report/Add return types in the function definition (function abc(string $var) (adds string)
	82	+ 'PhanPluginCanUseNullableParamType', // Fixer - Report/Add nullable parameter types in the function definition
	83	+ 'PhanPluginCanUseNullableReturnType', // Fixer - Report/Add nullable return types in the function definition
84	84
85		- 'PhanPluginNonBoolBranch', // Not essential - 31240+ occurrences
86		- 'PhanPluginNumericalComparison', // Not essential - 19870+ occurrences
87		- 'PhanTypeMismatchArgument', // Not essential - 12300+ occurrences
88		- 'PhanPluginNonBoolInLogicalArith', // Not essential - 11040+ occurrences
89		- 'PhanPluginConstantVariableScalar', // Not essential - 5180+ occurrences
	85	+ 'PhanPluginNonBoolBranch', // Not essential - 31240+ occurrences
	86	+ 'PhanPluginNumericalComparison', // Not essential - 19870+ occurrences
	87	+ 'PhanTypeMismatchArgument', // Not essential - 12300+ occurrences
	88	+ 'PhanPluginNonBoolInLogicalArith', // Not essential - 11040+ occurrences
	89	+ 'PhanPluginConstantVariableScalar', // Not essential - 5180+ occurrences
90	90	'PhanPluginDuplicateAdjacentStatement',
91		- 'PhanPluginDuplicateConditionalTernaryDuplication', // 2750+ occurrences
92		- 'PhanPluginDuplicateConditionalNullCoalescing', // Not essential - 990+ occurrences
93		- 'PhanPluginRedundantAssignmentInGlobalScope', // Not essential, a lot of false warning
94		- 'PhanPluginRedundantAssignment', // Not essential, useless
95		- 'PhanPluginDuplicateCatchStatementBody', // Requires PHP7.1 - 50+ occurrences
	91	+ 'PhanPluginDuplicateConditionalTernaryDuplication', // 2750+ occurrences
	92	+ 'PhanPluginDuplicateConditionalNullCoalescing', // Not essential - 990+ occurrences
	93	+ 'PhanPluginRedundantAssignmentInGlobalScope', // Not essential, a lot of false warning
	94	+ 'PhanPluginRedundantAssignment', // Not essential, useless
	95	+ 'PhanPluginDuplicateCatchStatementBody', // Requires PHP7.1 - 50+ occurrences
96	96	];
97	97
98	98	return $config;

Dolibarr / dolibarr

Branch — develop (8f5b98)

Status

Category

Spacing +76 added lines, -76 removed lines patch added patch discarded remove patch

Spacing +24 added lines, -24 removed lines patch added patch discarded remove patch