Dolibarr /
dolibarr
| Conditions | 40 |
| Paths | > 20000 |
| Total Lines | 180 |
| Code Lines | 94 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 87 | public function assign_values(&$action, $id) |
||
| 88 | { |
||
| 89 | // phpcs:enable |
||
| 90 | global $conf, $langs, $user, $canvas; |
||
| 91 | global $form, $formcompany, $objsoc; |
||
| 92 | |||
| 93 | if ($action == 'add' || $action == 'update') $this->assign_post(); |
||
| 94 | |||
| 95 | foreach($this->object as $key => $value) |
||
| 96 | { |
||
| 97 | $this->tpl[$key] = $value; |
||
| 98 | } |
||
| 99 | |||
| 100 | $this->tpl['error']=$this->error; |
||
| 101 | $this->tpl['errors']=$this->errors; |
||
| 102 | |||
| 103 | if ($action == 'create' || $action == 'edit') |
||
| 104 | { |
||
| 105 | if ($conf->use_javascript_ajax) |
||
| 106 | { |
||
| 107 | $this->tpl['ajax_selectcountry'] = "\n".'<script type="text/javascript" language="javascript"> |
||
| 108 | jQuery(document).ready(function () { |
||
| 109 | jQuery("#selectcountry_id").change(function() { |
||
| 110 | document.formsoc.action.value="'.$action.'"; |
||
| 111 | document.formsoc.canvas.value="'.$canvas.'"; |
||
| 112 | document.formsoc.submit(); |
||
| 113 | }); |
||
| 114 | }) |
||
| 115 | </script>'."\n"; |
||
| 116 | } |
||
| 117 | |||
| 118 | if (is_object($objsoc) && $objsoc->id > 0) |
||
| 119 | { |
||
| 120 | $this->tpl['company'] = $objsoc->getNomUrl(1); |
||
| 121 | $this->tpl['company_id'] = $objsoc->id; |
||
| 122 | } |
||
| 123 | else |
||
| 124 | { |
||
| 125 | $this->tpl['company'] = $form->select_company($this->object->socid, 'socid', '', 1); |
||
| 126 | } |
||
| 127 | |||
| 128 | // Civility |
||
| 129 | $this->tpl['select_civility'] = $formcompany->select_civility($this->object->civility_id); |
||
| 130 | |||
| 131 | // Predefined with third party |
||
| 132 | if ((isset($objsoc->typent_code) && $objsoc->typent_code == 'TE_PRIVATE') || ! empty($conf->global->CONTACT_USE_COMPANY_ADDRESS)) |
||
| 133 | { |
||
| 134 | if (dol_strlen(trim($this->object->address)) == 0) $this->tpl['address'] = $objsoc->address; |
||
| 135 | if (dol_strlen(trim($this->object->zip)) == 0) $this->object->zip = $objsoc->zip; |
||
| 136 | if (dol_strlen(trim($this->object->town)) == 0) $this->object->town = $objsoc->town; |
||
| 137 | if (dol_strlen(trim($this->object->phone_pro)) == 0) $this->object->phone_pro = $objsoc->phone; |
||
| 138 | if (dol_strlen(trim($this->object->fax)) == 0) $this->object->fax = $objsoc->fax; |
||
| 139 | if (dol_strlen(trim($this->object->email)) == 0) $this->object->email = $objsoc->email; |
||
| 140 | } |
||
| 141 | |||
| 142 | // Zip |
||
| 143 | $this->tpl['select_zip'] = $formcompany->select_ziptown($this->object->zip, 'zipcode', array('town','selectcountry_id','state_id'), 6); |
||
| 144 | |||
| 145 | // Town |
||
| 146 | $this->tpl['select_town'] = $formcompany->select_ziptown($this->object->town, 'town', array('zipcode','selectcountry_id','state_id')); |
||
| 147 | |||
| 148 | if (dol_strlen(trim($this->object->country_id)) == 0) $this->object->country_id = $objsoc->country_id; |
||
| 149 | |||
| 150 | // Country |
||
| 151 | $this->tpl['select_country'] = $form->select_country($this->object->country_id, 'country_id'); |
||
| 152 | $countrynotdefined = $langs->trans("ErrorSetACountryFirst").' ('.$langs->trans("SeeAbove").')'; |
||
| 153 | |||
| 154 | if ($user->admin) $this->tpl['info_admin'] = info_admin($langs->trans("YouCanChangeValuesForThisListFromDictionarySetup"), 1); |
||
| 155 | |||
| 156 | // State |
||
| 157 | if ($this->object->country_id) $this->tpl['select_state'] = $formcompany->select_state($this->object->state_id, $this->object->country_code); |
||
| 158 | else $this->tpl['select_state'] = $countrynotdefined; |
||
| 159 | |||
| 160 | // Public or private |
||
| 161 | $selectarray=array('0'=>$langs->trans("ContactPublic"),'1'=>$langs->trans("ContactPrivate")); |
||
| 162 | $this->tpl['select_visibility'] = $form->selectarray('priv', $selectarray, $this->object->priv, 0); |
||
| 163 | } |
||
| 164 | |||
| 165 | if ($action == 'view' || $action == 'edit' || $action == 'delete') |
||
| 166 | { |
||
| 167 | // Emailing |
||
| 168 | if (! empty($conf->mailing->enabled)) |
||
| 169 | { |
||
| 170 | $langs->load("mails"); |
||
| 171 | $this->tpl['nb_emailing'] = $this->object->getNbOfEMailings(); |
||
| 172 | } |
||
| 173 | |||
| 174 | // Linked element |
||
| 175 | $this->tpl['contact_element'] = array(); |
||
| 176 | $i=0; |
||
| 177 | |||
| 178 | $this->object->load_ref_elements(); |
||
| 179 | |||
| 180 | if (! empty($conf->commande->enabled)) |
||
| 181 | { |
||
| 182 | $this->tpl['contact_element'][$i]['linked_element_label'] = $langs->trans("ContactForOrders"); |
||
| 183 | $this->tpl['contact_element'][$i]['linked_element_value'] = $this->object->ref_commande?$this->object->ref_commande:$langs->trans("NoContactForAnyOrder"); |
||
| 184 | $i++; |
||
| 185 | } |
||
| 186 | if (! empty($conf->propal->enabled)) |
||
| 187 | { |
||
| 188 | $this->tpl['contact_element'][$i]['linked_element_label'] = $langs->trans("ContactForProposals"); |
||
| 189 | $this->tpl['contact_element'][$i]['linked_element_value'] = $this->object->ref_propal?$this->object->ref_propal:$langs->trans("NoContactForAnyProposal"); |
||
| 190 | $i++; |
||
| 191 | } |
||
| 192 | if (! empty($conf->contrat->enabled)) |
||
| 193 | { |
||
| 194 | $this->tpl['contact_element'][$i]['linked_element_label'] = $langs->trans("ContactForContracts"); |
||
| 195 | $this->tpl['contact_element'][$i]['linked_element_value'] = $this->object->ref_contrat?$this->object->ref_contrat:$langs->trans("NoContactForAnyContract"); |
||
| 196 | $i++; |
||
| 197 | } |
||
| 198 | if (! empty($conf->facture->enabled)) |
||
| 199 | { |
||
| 200 | $this->tpl['contact_element'][$i]['linked_element_label'] = $langs->trans("ContactForInvoices"); |
||
| 201 | $this->tpl['contact_element'][$i]['linked_element_value'] = $this->object->ref_facturation?$this->object->ref_facturation:$langs->trans("NoContactForAnyInvoice"); |
||
| 202 | $i++; |
||
| 203 | } |
||
| 204 | |||
| 205 | // Dolibarr user |
||
| 206 | if ($this->object->user_id) |
||
| 207 | { |
||
| 208 | $dolibarr_user=new User($this->db); |
||
| 209 | $result=$dolibarr_user->fetch($this->object->user_id); |
||
| 210 | $this->tpl['dolibarr_user'] = $dolibarr_user->getLoginUrl(1); |
||
| 211 | } |
||
| 212 | else $this->tpl['dolibarr_user'] = $langs->trans("NoDolibarrAccess"); |
||
| 213 | } |
||
| 214 | |||
| 215 | if ($action == 'view' || $action == 'delete') |
||
| 216 | { |
||
| 217 | $this->tpl['showrefnav'] = $form->showrefnav($this->object, 'id'); |
||
| 218 | |||
| 219 | if ($this->object->socid > 0) |
||
| 220 | { |
||
| 221 | $objsoc = new Societe($this->db); |
||
| 222 | |||
| 223 | $objsoc->fetch($this->object->socid); |
||
| 224 | $this->tpl['company'] = $objsoc->getNomUrl(1); |
||
| 225 | } |
||
| 226 | else |
||
| 227 | { |
||
| 228 | $this->tpl['company'] = $langs->trans("ContactNotLinkedToCompany"); |
||
| 229 | } |
||
| 230 | |||
| 231 | $this->tpl['civility'] = $this->object->getCivilityLabel(); |
||
| 232 | |||
| 233 | $this->tpl['address'] = dol_nl2br($this->object->address); |
||
| 234 | |||
| 235 | $this->tpl['zip'] = ($this->object->zip?$this->object->zip.' ':''); |
||
| 236 | |||
| 237 | $img=picto_from_langcode($this->object->country_code); |
||
| 238 | $this->tpl['country'] = ($img?$img.' ':'').$this->object->country; |
||
| 239 | |||
| 240 | $this->tpl['phone_pro'] = dol_print_phone($this->object->phone_pro, $this->object->country_code, 0, $this->object->id, 'AC_TEL'); |
||
| 241 | $this->tpl['phone_perso'] = dol_print_phone($this->object->phone_perso, $this->object->country_code, 0, $this->object->id, 'AC_TEL'); |
||
| 242 | $this->tpl['phone_mobile'] = dol_print_phone($this->object->phone_mobile, $this->object->country_code, 0, $this->object->id, 'AC_TEL'); |
||
| 243 | $this->tpl['fax'] = dol_print_phone($this->object->fax, $this->object->country_code, 0, $this->object->id, 'AC_FAX'); |
||
| 244 | $this->tpl['email'] = dol_print_email($this->object->email, 0, $this->object->id, 'AC_EMAIL'); |
||
| 245 | |||
| 246 | $this->tpl['visibility'] = $this->object->LibPubPriv($this->object->priv); |
||
| 247 | |||
| 248 | $this->tpl['note'] = nl2br($this->object->note); |
||
| 249 | } |
||
| 250 | |||
| 251 | if ($action == 'create_user') |
||
| 252 | { |
||
| 253 | // Full firstname and lastname separated with a dot : firstname.lastname |
||
| 254 | include_once DOL_DOCUMENT_ROOT.'/core/lib/functions2.lib.php'; |
||
| 255 | require_once DOL_DOCUMENT_ROOT.'/core/lib/security2.lib.php'; |
||
| 256 | $login=dol_buildlogin($this->object->lastname, $this->object->firstname); |
||
| 257 | |||
| 258 | $generated_password=getRandomPassword(false); |
||
| 259 | $password=$generated_password; |
||
| 260 | |||
| 261 | // Create a form array |
||
| 262 | $formquestion=array( |
||
| 263 | array('label' => $langs->trans("LoginToCreate"), 'type' => 'text', 'name' => 'login', 'value' => $login), |
||
| 264 | array('label' => $langs->trans("Password"), 'type' => 'text', 'name' => 'password', 'value' => $password)); |
||
| 265 | |||
| 266 | $this->tpl['action_create_user'] = $form->formconfirm($_SERVER["PHP_SELF"]."?id=".$this->object->id, $langs->trans("CreateDolibarrLogin"), $langs->trans("ConfirmCreateContact"), "confirm_create_user", $formquestion, 'no'); |
||
| 267 | } |
||
| 323 |
Loading history...