Inspection of "Daily Inspection: NEW #26668 [SQL] add SPL in dict..." - Dolibarr/dolibarr - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop (5f67a1)

unknown

created 2023-11-17 16:08 UTC

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -68,7 +68,7 @@
 block discarded – undo
 // Parameters
 $action = GETPOST('action', 'aZ09');
 $backtopage = GETPOST('backtopage', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $value = GETPOST('value', 'alpha');
 $label = GETPOST('label', 'alpha');

Please login to merge, or discard this patch.

htdocs/ticket/messaging.php 2 patches

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -61,7 +61,9 @@
 block discarded – undo
 
 // Security check
 $id = GETPOST("id", 'int');
-if ($user->socid > 0) $socid = $user->socid;
+if ($user->socid > 0) {
+	$socid = $user->socid;
+}
 $result = restrictedArea($user, 'ticket', $object->id, '');
 
 // restrict access for externals users

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -269,7 +269,7 @@
 block discarded – undo
 	$cachekey = 'count_events_ticket_'.$object->id;
 	$nbEvent = dol_getcache($cachekey);
 
-	$titlelist = $langs->trans("ActionsOnTicket").(is_numeric($nbEvent) ? '<span class="opacitymedium colorblack paddingleft">('.$nbEvent.')</span>': '');
+	$titlelist = $langs->trans("ActionsOnTicket").(is_numeric($nbEvent) ? '<span class="opacitymedium colorblack paddingleft">('.$nbEvent.')</span>' : '');
 
 	print_barre_liste($titlelist, 0, $_SERVER["PHP_SELF"], '', $sortfield, $sortorder, '', 0, -1, '', 0, $morehtmlright, '', 0, 1, 0);
 

Please login to merge, or discard this patch.

htdocs/admin/agenda_reminder.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -36,7 +36,7 @@
 block discarded – undo
 
 $action = GETPOST('action', 'aZ09');
 $value = GETPOST('value', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $param = GETPOST('param', 'alpha');
 $cancel = GETPOST('cancel', 'alpha');

Please login to merge, or discard this patch.

htdocs/admin/delivery.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -43,7 +43,7 @@
 block discarded – undo
 
 $action  = GETPOST('action', 'alpha');
 $value   = GETPOST('value', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $label   = GETPOST('label', 'alpha');
 $scandir = GETPOST('scan_dir', 'alpha');

Please login to merge, or discard this patch.

htdocs/admin/bom.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -46,7 +46,7 @@
 block discarded – undo
 
 $action = GETPOST('action', 'aZ09');
 $value = GETPOST('value', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $label = GETPOST('label', 'alpha');
 $scandir = GETPOST('scan_dir', 'alpha');

Please login to merge, or discard this patch.

htdocs/admin/holiday.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -46,7 +46,7 @@
 block discarded – undo
 
 $action = GETPOST('action', 'aZ09');
 $value = GETPOST('value', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $label = GETPOST('label', 'alpha');
 $scandir = GETPOST('scan_dir', 'alpha');

Please login to merge, or discard this patch.

htdocs/admin/fichinter.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -46,7 +46,7 @@
 block discarded – undo
 
 $action = GETPOST('action', 'aZ09');
 $value = GETPOST('value', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $label = GETPOST('label', 'alpha');
 $scandir = GETPOST('scan_dir', 'alpha');

Please login to merge, or discard this patch.

htdocs/admin/user.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -43,7 +43,7 @@
 block discarded – undo
 
 $action = GETPOST('action', 'aZ09');
 $backtopage = GETPOST('backtopage', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $value = GETPOST('value', 'alpha');
 $label = GETPOST('label', 'alpha');

Please login to merge, or discard this patch.

htdocs/admin/import.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -41,7 +41,7 @@
 block discarded – undo
 
 $action = GETPOST('action', 'aZ09');
 $value = GETPOST('value', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 
 /*

Please login to merge, or discard this patch.

		@@ -269,7 +269,7 @@
		block discarded – undo
269	269	$cachekey = 'count_events_ticket_'.$object->id;
270	270	$nbEvent = dol_getcache($cachekey);
271	271
272		- $titlelist = $langs->trans("ActionsOnTicket").(is_numeric($nbEvent) ? '<span class="opacitymedium colorblack paddingleft">('.$nbEvent.')</span>': '');
	272	+ $titlelist = $langs->trans("ActionsOnTicket").(is_numeric($nbEvent) ? '<span class="opacitymedium colorblack paddingleft">('.$nbEvent.')</span>' : '');
273	273
274	274	print_barre_liste($titlelist, 0, $_SERVER["PHP_SELF"], '', $sortfield, $sortorder, '', 0, -1, '', 0, $morehtmlright, '', 0, 1, 0);
275	275

		@@ -46,7 +46,7 @@
		block discarded – undo
46	46
47	47	$action = GETPOST('action', 'aZ09');
48	48	$value = GETPOST('value', 'alpha');
49		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	49	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
50	50
51	51	$label = GETPOST('label', 'alpha');
52	52	$scandir = GETPOST('scan_dir', 'alpha');

		@@ -46,7 +46,7 @@
		block discarded – undo
46	46
47	47	$action = GETPOST('action', 'aZ09');
48	48	$value = GETPOST('value', 'alpha');
49		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	49	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
50	50
51	51	$label = GETPOST('label', 'alpha');
52	52	$scandir = GETPOST('scan_dir', 'alpha');

		@@ -46,7 +46,7 @@
		block discarded – undo
46	46
47	47	$action = GETPOST('action', 'aZ09');
48	48	$value = GETPOST('value', 'alpha');
49		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	49	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
50	50
51	51	$label = GETPOST('label', 'alpha');
52	52	$scandir = GETPOST('scan_dir', 'alpha');

		@@ -68,7 +68,7 @@
		block discarded – undo
68	68	// Parameters
69	69	$action = GETPOST('action', 'aZ09');
70	70	$backtopage = GETPOST('backtopage', 'alpha');
71		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	71	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
72	72
73	73	$value = GETPOST('value', 'alpha');
74	74	$label = GETPOST('label', 'alpha');

		@@ -61,7 +61,9 @@
		block discarded – undo
61	61
62	62	// Security check
63	63	$id = GETPOST("id", 'int');
64		-if ($user->socid > 0) $socid = $user->socid;
	64	+if ($user->socid > 0) {
	65	+ $socid = $user->socid;
	66	+}
65	67	$result = restrictedArea($user, 'ticket', $object->id, '');
66	68
67	69	// restrict access for externals users

		@@ -36,7 +36,7 @@
		block discarded – undo
36	36
37	37	$action = GETPOST('action', 'aZ09');
38	38	$value = GETPOST('value', 'alpha');
39		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	39	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
40	40
41	41	$param = GETPOST('param', 'alpha');
42	42	$cancel = GETPOST('cancel', 'alpha');

		@@ -43,7 +43,7 @@
		block discarded – undo
43	43
44	44	$action = GETPOST('action', 'alpha');
45	45	$value = GETPOST('value', 'alpha');
46		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	46	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
47	47
48	48	$label = GETPOST('label', 'alpha');
49	49	$scandir = GETPOST('scan_dir', 'alpha');

		@@ -41,7 +41,7 @@
		block discarded – undo
41	41
42	42	$action = GETPOST('action', 'aZ09');
43	43	$value = GETPOST('value', 'alpha');
44		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	44	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
45	45
46	46
47	47	/*

Dolibarr / dolibarr

Branch — develop (5f67a1)

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch