View GitHub Repository dolibarr

Schedule Inspection
Subscribe
Completed
Branch — develop (c41794)
by
unknown
17:50
created
Status
Category
Toggle Patches
htdocs/hrm/evaluation_document.php 1 patch
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -136,8 +136,12 @@
 
 block discarded – undo
136 136 
 //if ($user->socid > 0) $socid = $user->socid;
137 137 
 //$isdraft = (($object->status == $object::STATUS_DRAFT) ? 1 : 0);
138 138 
 //restrictedArea($user, $object->element, $object->id, $object->table_element, '', 'fk_soc', 'rowid', $isdraft);
139 
-if (empty($conf->hrm->enabled)) accessforbidden();
140 
-if (!$permissiontoread) accessforbidden();
139 
+if (empty($conf->hrm->enabled)) {
140 
+	accessforbidden();
141 
+}
142 
+if (!$permissiontoread) {
143 
+	accessforbidden();
144 
+}
141 145
142 146
143 147 
 /*
Please login to merge, or discard this patch.
htdocs/hrm/skill_document.php 1 patch
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -136,8 +136,12 @@
 
 block discarded – undo
136 136 
 //if ($user->socid > 0) $socid = $user->socid;
137 137 
 //$isdraft = (($object->status == $object::STATUS_DRAFT) ? 1 : 0);
138 138 
 //restrictedArea($user, $object->element, $object->id, $object->table_element, '', 'fk_soc', 'rowid', $isdraft);
139 
-if (empty($conf->hrm->enabled)) accessforbidden();
140 
-if (!$permissiontoread) accessforbidden();
139 
+if (empty($conf->hrm->enabled)) {
140 
+	accessforbidden();
141 
+}
142 
+if (!$permissiontoread) {
143 
+	accessforbidden();
144 
+}
141 145
142 146
143 147 
 /*
Please login to merge, or discard this patch.
htdocs/hrm/job_agenda.php 1 patch
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -136,8 +136,12 @@
 
 block discarded – undo
136 136 
 //if ($user->socid > 0) $socid = $user->socid;
137 137 
 //$isdraft = (($object->status == $object::STATUS_DRAFT) ? 1 : 0);
138 138 
 //restrictedArea($user, $object->element, $object->id, $object->table_element, '', 'fk_soc', 'rowid', $isdraft);
139 
-if (empty($conf->hrm->enabled)) accessforbidden();
140 
-if (!$permissiontoread) accessforbidden();
139 
+if (empty($conf->hrm->enabled)) {
140 
+	accessforbidden();
141 
+}
142 
+if (!$permissiontoread) {
143 
+	accessforbidden();
144 
+}
141 145
142 146
143 147 
 /*
Please login to merge, or discard this patch.
htdocs/hrm/job_document.php 1 patch
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -136,8 +136,12 @@
 
 block discarded – undo
136 136 
 //if ($user->socid > 0) $socid = $user->socid;
137 137 
 //$isdraft = (($object->status == $object::STATUS_DRAFT) ? 1 : 0);
138 138 
 //restrictedArea($user, $object->element, $object->id, $object->table_element, '', 'fk_soc', 'rowid', $isdraft);
139 
-if (empty($conf->hrm->enabled)) accessforbidden();
140 
-if (!$permissiontoread) accessforbidden();
139 
+if (empty($conf->hrm->enabled)) {
140 
+	accessforbidden();
141 
+}
142 
+if (!$permissiontoread) {
143 
+	accessforbidden();
144 
+}
141 145
142 146
143 147 
 /*
Please login to merge, or discard this patch.
htdocs/hrm/position_note.php 1 patch
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -136,8 +136,12 @@
 
 block discarded – undo
136 136 
 //if ($user->socid > 0) $socid = $user->socid;
137 137 
 //$isdraft = (($object->status == $object::STATUS_DRAFT) ? 1 : 0);
138 138 
 //restrictedArea($user, $object->element, $object->id, $object->table_element, '', 'fk_soc', 'rowid', $isdraft);
139 
-if (empty($conf->hrm->enabled)) accessforbidden();
140 
-if (!$permissiontoread) accessforbidden();
139 
+if (empty($conf->hrm->enabled)) {
140 
+	accessforbidden();
141 
+}
142 
+if (!$permissiontoread) {
143 
+	accessforbidden();
144 
+}
141 145
142 146
143 147 
 /*
Please login to merge, or discard this patch.
htdocs/hrm/skill_note.php 1 patch
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -136,8 +136,12 @@
 
 block discarded – undo
136 136 
 //if ($user->socid > 0) $socid = $user->socid;
137 137 
 //$isdraft = (($object->status == $object::STATUS_DRAFT) ? 1 : 0);
138 138 
 //restrictedArea($user, $object->element, $object->id, $object->table_element, '', 'fk_soc', 'rowid', $isdraft);
139 
-if (empty($conf->hrm->enabled)) accessforbidden();
140 
-if (!$permissiontoread) accessforbidden();
139 
+if (empty($conf->hrm->enabled)) {
140 
+	accessforbidden();
141 
+}
142 
+if (!$permissiontoread) {
143 
+	accessforbidden();
144 
+}
141 145
142 146
143 147 
 /*
Please login to merge, or discard this patch.
htdocs/hrm/job_note.php 1 patch
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -136,8 +136,12 @@
 
 block discarded – undo
136 136 
 //if ($user->socid > 0) $socid = $user->socid;
137 137 
 //$isdraft = (($object->status == $object::STATUS_DRAFT) ? 1 : 0);
138 138 
 //restrictedArea($user, $object->element, $object->id, $object->table_element, '', 'fk_soc', 'rowid', $isdraft);
139 
-if (empty($conf->hrm->enabled)) accessforbidden();
140 
-if (!$permissiontoread) accessforbidden();
139 
+if (empty($conf->hrm->enabled)) {
140 
+	accessforbidden();
141 
+}
142 
+if (!$permissiontoread) {
143 
+	accessforbidden();
144 
+}
141 145
142 146
143 147 
 /*
Please login to merge, or discard this patch.
htdocs/hrm/position_agenda.php 1 patch
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -136,8 +136,12 @@
 
 block discarded – undo
136 136 
 //if ($user->socid > 0) $socid = $user->socid;
137 137 
 //$isdraft = (($object->status == $object::STATUS_DRAFT) ? 1 : 0);
138 138 
 //restrictedArea($user, $object->element, $object->id, $object->table_element, '', 'fk_soc', 'rowid', $isdraft);
139 
-if (empty($conf->hrm->enabled)) accessforbidden();
140 
-if (!$permissiontoread) accessforbidden();
139 
+if (empty($conf->hrm->enabled)) {
140 
+	accessforbidden();
141 
+}
142 
+if (!$permissiontoread) {
143 
+	accessforbidden();
144 
+}
141 145
142 146
143 147 
 /*
Please login to merge, or discard this patch.
htdocs/admin/hrm.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -81,7 +81,9 @@
 
 block discarded – undo
81 81 
 		$TAllSkills = $static_skill->fetchAll();
82 82 
 		if (is_array($TAllSkills)) {
83 83 
 			foreach ($TAllSkills as &$skill) {
84 
-				if (empty($skill->lines)) $skill->fetchLines();
84 
+				if (empty($skill->lines)) {
85 
+					$skill->fetchLines();
86 
+				}
85 87 
 				if (count($skill->lines) < $conf->global->HRM_MAXRANK) {
86 88 
 					$skill->createSkills(count($skill->lines) + 1);
87 89 
 				}
Please login to merge, or discard this patch.