Inspection of "66e4de628c286cbb08c0022b12e6014d5292282b" - Dolibarr/dolibarr - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — develop (66e4de)

by Laurent

created 2020-12-14 19:40 UTC

Status

Braces +2 added lines, -1 removed lines patch added patch discarded remove patch

@@ -28,8 +28,9 @@
 block discarded – undo
 // Load translation files required by the page
 $langs->loadLangs(array('banks', 'categories'));
 
-if (!$user->rights->banque->lire)
+if (!$user->rights->banque->lire) {
   accessforbidden();
+}
 
 
 /**

Please login to merge, or discard this patch.

htdocs/opensurvey/wizard/choix_autre.php 1 patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -28,7 +28,9 @@
 block discarded – undo
 require_once DOL_DOCUMENT_ROOT."/opensurvey/fonctions.php";
 
 // Security check
-if (!$user->rights->opensurvey->write) accessforbidden();
+if (!$user->rights->opensurvey->write) {
+	accessforbidden();
+}
 
 
 

Please login to merge, or discard this patch.

htdocs/core/modules/commande/modules_commande.php 1 patch

Braces +12 added lines, -4 removed lines patch added patch discarded remove patch

@@ -92,10 +92,18 @@
 block discarded – undo
 		global $langs;
 		$langs->load("admin");
 
-		if ($this->version == 'development') return $langs->trans("VersionDevelopment");
-		if ($this->version == 'experimental') return $langs->trans("VersionExperimental");
-		if ($this->version == 'dolibarr') return DOL_VERSION;
-		if ($this->version) return $this->version;
+		if ($this->version == 'development') {
+			return $langs->trans("VersionDevelopment");
+		}
+		if ($this->version == 'experimental') {
+			return $langs->trans("VersionExperimental");
+		}
+		if ($this->version == 'dolibarr') {
+			return DOL_VERSION;
+		}
+		if ($this->version) {
+			return $this->version;
+		}
 		return $langs->trans("NotAvailable");
 	}
 }

Please login to merge, or discard this patch.

htdocs/core/modules/facture/modules_facture.php 1 patch

Braces +11 added lines, -5 removed lines patch added patch discarded remove patch

@@ -143,10 +143,16 @@
 block discarded – undo
 		global $langs;
 		$langs->load("admin");
 
-		if ($this->version == 'development') return $langs->trans("VersionDevelopment");
-		elseif ($this->version == 'experimental') return $langs->trans("VersionExperimental");
-		elseif ($this->version == 'dolibarr') return DOL_VERSION;
-		elseif ($this->version) return $this->version;
-		else return $langs->trans("NotAvailable");
+		if ($this->version == 'development') {
+			return $langs->trans("VersionDevelopment");
+		} elseif ($this->version == 'experimental') {
+			return $langs->trans("VersionExperimental");
+		} elseif ($this->version == 'dolibarr') {
+			return DOL_VERSION;
+		} elseif ($this->version) {
+			return $this->version;
+		} else {
+			return $langs->trans("NotAvailable");
+		}
 	}
 }

Please login to merge, or discard this patch.

htdocs/core/modules/reception/modules_reception.php 1 patch

Braces +9 added lines, -4 removed lines patch added patch discarded remove patch

@@ -145,10 +145,15 @@
 block discarded – undo
 		global $langs;
 		$langs->load("admin");
 
-		if ($this->version == 'development') return $langs->trans("VersionDevelopment");
-		elseif ($this->version == 'experimental') return $langs->trans("VersionExperimental");
-		elseif ($this->version == 'dolibarr') return DOL_VERSION;
-		elseif ($this->version) return $this->version;
+		if ($this->version == 'development') {
+			return $langs->trans("VersionDevelopment");
+		} elseif ($this->version == 'experimental') {
+			return $langs->trans("VersionExperimental");
+		} elseif ($this->version == 'dolibarr') {
+			return DOL_VERSION;
+		} elseif ($this->version) {
+			return $this->version;
+		}
 		return $langs->trans("NotAvailable");
 	}
 }

Please login to merge, or discard this patch.

htdocs/core/modules/supplier_payment/modules_supplier_payment.php 1 patch

Braces +9 added lines, -4 removed lines patch added patch discarded remove patch

@@ -145,10 +145,15 @@
 block discarded – undo
 		global $langs;
 		$langs->load("admin");
 
-		if ($this->version == 'development') return $langs->trans("VersionDevelopment");
-		elseif ($this->version == 'experimental') return $langs->trans("VersionExperimental");
-		elseif ($this->version == 'dolibarr') return DOL_VERSION;
-		elseif ($this->version) return $this->version;
+		if ($this->version == 'development') {
+			return $langs->trans("VersionDevelopment");
+		} elseif ($this->version == 'experimental') {
+			return $langs->trans("VersionExperimental");
+		} elseif ($this->version == 'dolibarr') {
+			return DOL_VERSION;
+		} elseif ($this->version) {
+			return $this->version;
+		}
 		return $langs->trans("NotAvailable");
 	}
 }

Please login to merge, or discard this patch.

htdocs/core/modules/payment/modules_payment.php 1 patch

Braces +11 added lines, -5 removed lines patch added patch discarded remove patch

@@ -143,10 +143,16 @@
 block discarded – undo
 		global $langs;
 		$langs->load("admin");
 
-		if ($this->version == 'development') return $langs->trans("VersionDevelopment");
-		elseif ($this->version == 'experimental') return $langs->trans("VersionExperimental");
-		elseif ($this->version == 'dolibarr') return DOL_VERSION;
-		elseif ($this->version) return $this->version;
-		else return $langs->trans("NotAvailable");
+		if ($this->version == 'development') {
+			return $langs->trans("VersionDevelopment");
+		} elseif ($this->version == 'experimental') {
+			return $langs->trans("VersionExperimental");
+		} elseif ($this->version == 'dolibarr') {
+			return DOL_VERSION;
+		} elseif ($this->version) {
+			return $this->version;
+		} else {
+			return $langs->trans("NotAvailable");
+		}
 	}
 }

Please login to merge, or discard this patch.

htdocs/core/modules/bom/modules_bom.php 1 patch

Braces +12 added lines, -4 removed lines patch added patch discarded remove patch

@@ -92,10 +92,18 @@
 block discarded – undo
 		global $langs;
 		$langs->load("admin");
 
-		if ($this->version == 'development') return $langs->trans("VersionDevelopment");
-		if ($this->version == 'experimental') return $langs->trans("VersionExperimental");
-		if ($this->version == 'dolibarr') return DOL_VERSION;
-		if ($this->version) return $this->version;
+		if ($this->version == 'development') {
+			return $langs->trans("VersionDevelopment");
+		}
+		if ($this->version == 'experimental') {
+			return $langs->trans("VersionExperimental");
+		}
+		if ($this->version == 'dolibarr') {
+			return DOL_VERSION;
+		}
+		if ($this->version) {
+			return $this->version;
+		}
 		return $langs->trans("NotAvailable");
 	}
 }

Please login to merge, or discard this patch.

htdocs/core/modules/holiday/modules_holiday.php 1 patch

Braces +11 added lines, -5 removed lines patch added patch discarded remove patch

@@ -143,10 +143,16 @@
 block discarded – undo
 		global $langs;
 		$langs->load("admin");
 
-		if ($this->version == 'development') return $langs->trans("VersionDevelopment");
-		elseif ($this->version == 'experimental') return $langs->trans("VersionExperimental");
-		elseif ($this->version == 'dolibarr') return DOL_VERSION;
-		elseif ($this->version) return $this->version;
-		else return $langs->trans("NotAvailable");
+		if ($this->version == 'development') {
+			return $langs->trans("VersionDevelopment");
+		} elseif ($this->version == 'experimental') {
+			return $langs->trans("VersionExperimental");
+		} elseif ($this->version == 'dolibarr') {
+			return DOL_VERSION;
+		} elseif ($this->version) {
+			return $this->version;
+		} else {
+			return $langs->trans("NotAvailable");
+		}
 	}
 }

Please login to merge, or discard this patch.

		@@ -92,10 +92,18 @@
		block discarded – undo
92	92	global $langs;
93	93	$langs->load("admin");
94	94
95		- if ($this->version == 'development') return $langs->trans("VersionDevelopment");
96		- if ($this->version == 'experimental') return $langs->trans("VersionExperimental");
97		- if ($this->version == 'dolibarr') return DOL_VERSION;
98		- if ($this->version) return $this->version;
	95	+ if ($this->version == 'development') {
	96	+ return $langs->trans("VersionDevelopment");
	97	+ }
	98	+ if ($this->version == 'experimental') {
	99	+ return $langs->trans("VersionExperimental");
	100	+ }
	101	+ if ($this->version == 'dolibarr') {
	102	+ return DOL_VERSION;
	103	+ }
	104	+ if ($this->version) {
	105	+ return $this->version;
	106	+ }
99	107	return $langs->trans("NotAvailable");
100	108	}
101	109	}

		@@ -145,10 +145,15 @@
		block discarded – undo
145	145	global $langs;
146	146	$langs->load("admin");
147	147
148		- if ($this->version == 'development') return $langs->trans("VersionDevelopment");
149		- elseif ($this->version == 'experimental') return $langs->trans("VersionExperimental");
150		- elseif ($this->version == 'dolibarr') return DOL_VERSION;
151		- elseif ($this->version) return $this->version;
	148	+ if ($this->version == 'development') {
	149	+ return $langs->trans("VersionDevelopment");
	150	+ } elseif ($this->version == 'experimental') {
	151	+ return $langs->trans("VersionExperimental");
	152	+ } elseif ($this->version == 'dolibarr') {
	153	+ return DOL_VERSION;
	154	+ } elseif ($this->version) {
	155	+ return $this->version;
	156	+ }
152	157	return $langs->trans("NotAvailable");
153	158	}
154	159	}

		@@ -145,10 +145,15 @@
		block discarded – undo
145	145	global $langs;
146	146	$langs->load("admin");
147	147
148		- if ($this->version == 'development') return $langs->trans("VersionDevelopment");
149		- elseif ($this->version == 'experimental') return $langs->trans("VersionExperimental");
150		- elseif ($this->version == 'dolibarr') return DOL_VERSION;
151		- elseif ($this->version) return $this->version;
	148	+ if ($this->version == 'development') {
	149	+ return $langs->trans("VersionDevelopment");
	150	+ } elseif ($this->version == 'experimental') {
	151	+ return $langs->trans("VersionExperimental");
	152	+ } elseif ($this->version == 'dolibarr') {
	153	+ return DOL_VERSION;
	154	+ } elseif ($this->version) {
	155	+ return $this->version;
	156	+ }
152	157	return $langs->trans("NotAvailable");
153	158	}
154	159	}

		@@ -92,10 +92,18 @@
		block discarded – undo
92	92	global $langs;
93	93	$langs->load("admin");
94	94
95		- if ($this->version == 'development') return $langs->trans("VersionDevelopment");
96		- if ($this->version == 'experimental') return $langs->trans("VersionExperimental");
97		- if ($this->version == 'dolibarr') return DOL_VERSION;
98		- if ($this->version) return $this->version;
	95	+ if ($this->version == 'development') {
	96	+ return $langs->trans("VersionDevelopment");
	97	+ }
	98	+ if ($this->version == 'experimental') {
	99	+ return $langs->trans("VersionExperimental");
	100	+ }
	101	+ if ($this->version == 'dolibarr') {
	102	+ return DOL_VERSION;
	103	+ }
	104	+ if ($this->version) {
	105	+ return $this->version;
	106	+ }
99	107	return $langs->trans("NotAvailable");
100	108	}
101	109	}

		@@ -28,8 +28,9 @@
		block discarded – undo
28	28	// Load translation files required by the page
29	29	$langs->loadLangs(array('banks', 'categories'));
30	30
31		-if (!$user->rights->banque->lire)
	31	+if (!$user->rights->banque->lire) {
32	32	accessforbidden();
	33	+}
33	34
34	35
35	36	/**

		@@ -28,7 +28,9 @@
		block discarded – undo
28	28	require_once DOL_DOCUMENT_ROOT."/opensurvey/fonctions.php";
29	29
30	30	// Security check
31		-if (!$user->rights->opensurvey->write) accessforbidden();
	31	+if (!$user->rights->opensurvey->write) {
	32	+ accessforbidden();
	33	+}
32	34
33	35
34	36

		@@ -143,10 +143,16 @@
		block discarded – undo
143	143	global $langs;
144	144	$langs->load("admin");
145	145
146		- if ($this->version == 'development') return $langs->trans("VersionDevelopment");
147		- elseif ($this->version == 'experimental') return $langs->trans("VersionExperimental");
148		- elseif ($this->version == 'dolibarr') return DOL_VERSION;
149		- elseif ($this->version) return $this->version;
150		- else return $langs->trans("NotAvailable");
	146	+ if ($this->version == 'development') {
	147	+ return $langs->trans("VersionDevelopment");
	148	+ } elseif ($this->version == 'experimental') {
	149	+ return $langs->trans("VersionExperimental");
	150	+ } elseif ($this->version == 'dolibarr') {
	151	+ return DOL_VERSION;
	152	+ } elseif ($this->version) {
	153	+ return $this->version;
	154	+ } else {
	155	+ return $langs->trans("NotAvailable");
	156	+ }
151	157	}
152	158	}

Dolibarr / dolibarr

Branch — develop (66e4de)

Status

Category

Braces +2 added lines, -1 removed lines patch added patch discarded remove patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

Braces +12 added lines, -4 removed lines patch added patch discarded remove patch

Braces +11 added lines, -5 removed lines patch added patch discarded remove patch

Braces +9 added lines, -4 removed lines patch added patch discarded remove patch

Braces +9 added lines, -4 removed lines patch added patch discarded remove patch

Braces +11 added lines, -5 removed lines patch added patch discarded remove patch

Braces +12 added lines, -4 removed lines patch added patch discarded remove patch

Braces +11 added lines, -5 removed lines patch added patch discarded remove patch