Inspection of "Daily Inspection: fix default parameter (#27141)" - Dolibarr/dolibarr - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop (a4f94f)

unknown

created 2024-01-10 16:26 UTC

Status

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -225,7 +225,7 @@  discard block
 block discarded – undo
 
 $title = $object->ref;
 if (!empty($withproject)) {
-	$title .= ' | ' . $langs->trans("Project") . (!empty($projectstatic->ref) ? ': '.$projectstatic->ref : '')  ;
+	$title .= ' | '.$langs->trans("Project").(!empty($projectstatic->ref) ? ': '.$projectstatic->ref : '');
 }
 $help_url = '';
 
@@ -266,7 +266,7 @@  discard block
 block discarded – undo
 		// Title
 		$morehtmlref .= $projectstatic->title;
 		// Thirdparty
-		if (!empty($projectstatic->thirdparty->id) &&$projectstatic->thirdparty->id > 0) {
+		if (!empty($projectstatic->thirdparty->id) && $projectstatic->thirdparty->id > 0) {
 			$morehtmlref .= '<br>'.$projectstatic->thirdparty->getNomUrl(1, 'project');
 		}
 		$morehtmlref .= '</div>';

Please login to merge, or discard this patch.

htdocs/knowledgemanagement/knowledgerecord_card.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -44,7 +44,7 @@  discard block
 block discarded – undo
 $contextpage = GETPOST('contextpage', 'aZ') ? GETPOST('contextpage', 'aZ') : 'knowledgerecordcard'; // To manage different context of search
 $backtopage = GETPOST('backtopage', 'alpha');
 $backtopageforcancel = GETPOST('backtopageforcancel', 'alpha');
-$lineid   = GETPOST('lineid', 'int');
+$lineid = GETPOST('lineid', 'int');
 
 // Initialize technical objects
 $object = new KnowledgeRecord($db);
@@ -425,7 +425,7 @@  discard block
 block discarded – undo
 	print '<table class="border centpercent tableforfield">'."\n";
 
 	// Common attributes
-	$keyforbreak='fk_c_ticket_category';	// We change column just before this field
+	$keyforbreak = 'fk_c_ticket_category'; // We change column just before this field
 	//unset($object->fields['fk_project']);				// Hide field already shown in banner
 	//unset($object->fields['fk_soc']);					// Hide field already shown in banner
 	$object->fields['answer']['enabled'] = 0;

Please login to merge, or discard this patch.

htdocs/debugbar/class/DataCollector/DolPhpCollector.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -60,7 +60,7 @@  discard block
 block discarded – undo
 	{
 		$messages = $this->messages;
 
-		usort($messages, function ($itemA, $itemB) {
+		usort($messages, function($itemA, $itemB) {
 			if ($itemA['time'] === $itemB['time']) {
 				return 0;
 			}
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
 			if ($type = $severity & (2 ** $i)) {
 				$label = $this->friendlyErrorType($type);
 				$this->messages[] = [
-					'message' => $message . ' (' . $fileName . ':' . $line . ')',
+					'message' => $message.' ('.$fileName.':'.$line.')',
 					'message_html' => null,
 					'is_string' => true,
 					'label' => $label,

Please login to merge, or discard this patch.

htdocs/hrm/job_note.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -29,8 +29,8 @@  discard block
 block discarded – undo
 // Load Dolibarr environment
 require '../main.inc.php';
 
-require_once DOL_DOCUMENT_ROOT . '/hrm/class/job.class.php';
-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_job.lib.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/class/job.class.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_job.lib.php';
 
 // Load translation files required by the page
 $langs->loadLangs(array('hrm', 'companies'));
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
 	$linkback = '<a href="'.dol_buildpath('/hrm/job_list.php', 1).'?restore_lastsearch_values=1'.(!empty($socid) ? '&socid='.$socid : '').'">'.$langs->trans("BackToList").'</a>';
 
 	$morehtmlref = '<div class="refid">';
-	$morehtmlref.= $object->label;
+	$morehtmlref .= $object->label;
 	$morehtmlref .= '</div>';
 
 

Please login to merge, or discard this patch.

htdocs/hrm/skill_note.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -29,8 +29,8 @@  discard block
 block discarded – undo
 // Load Dolibarr environment
 require '../main.inc.php';
 
-require_once DOL_DOCUMENT_ROOT . '/hrm/class/skill.class.php';
-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_skill.lib.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/class/skill.class.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_skill.lib.php';
 
 // Load translation files required by the page
 $langs->loadLangs(array('hrm', 'companies'));
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
 	$linkback = '<a href="'.DOL_URL_ROOT.'/hrm/skill_list.php?restore_lastsearch_values=1'.(!empty($socid) ? '&socid='.$socid : '').'">'.$langs->trans("BackToList").'</a>';
 
 	$morehtmlref = '<div class="refid">';
-	$morehtmlref.= $object->label;
+	$morehtmlref .= $object->label;
 	$morehtmlref .= '</div>';
 
 

Please login to merge, or discard this patch.

htdocs/hrm/evaluation_note.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -28,9 +28,9 @@  discard block
 block discarded – undo
 // Load Dolibarr environment
 require '../main.inc.php';
 
-require_once DOL_DOCUMENT_ROOT . '/hrm/class/evaluation.class.php';
-require_once DOL_DOCUMENT_ROOT . '/hrm/class/job.class.php';
-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_evaluation.lib.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/class/evaluation.class.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/class/job.class.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_evaluation.lib.php';
 
 
 // Load translation files required by the page
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
 
 // Permissions
 $permissionnote   = $user->rights->hrm->evaluation->write; // Used by the include of actions_setnotes.inc.php
-$permissiontoread = $user->rights->hrm->evaluation->read;  // Used by the include of actions_addupdatedelete.inc.php
+$permissiontoread = $user->rights->hrm->evaluation->read; // Used by the include of actions_addupdatedelete.inc.php
 
 // Security check (enable the most restrictive one)
 //if ($user->socid > 0) accessforbidden();

Please login to merge, or discard this patch.

htdocs/hrm/skill_agenda.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -29,11 +29,11 @@  discard block
 block discarded – undo
 // Load Dolibarr environment
 require '../main.inc.php';
 
-require_once DOL_DOCUMENT_ROOT . '/contact/class/contact.class.php';
-require_once DOL_DOCUMENT_ROOT . '/core/lib/company.lib.php';
-require_once DOL_DOCUMENT_ROOT . '/core/lib/functions2.lib.php';
-require_once DOL_DOCUMENT_ROOT . '/hrm/class/skill.class.php';
-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_skill.lib.php';
+require_once DOL_DOCUMENT_ROOT.'/contact/class/contact.class.php';
+require_once DOL_DOCUMENT_ROOT.'/core/lib/company.lib.php';
+require_once DOL_DOCUMENT_ROOT.'/core/lib/functions2.lib.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/class/skill.class.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_skill.lib.php';
 
 
 // Load translation files required by the page
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
 	$linkback = '<a href="'.DOL_URL_ROOT.'/hrm/skill_list.php?restore_lastsearch_values=1'.(!empty($socid) ? '&socid='.$socid : '').'">'.$langs->trans("BackToList").'</a>';
 
 	$morehtmlref = '<div class="refid">';
-	$morehtmlref.= $object->label;
+	$morehtmlref .= $object->label;
 	$morehtmlref .= '</div>';
 
 

Please login to merge, or discard this patch.

htdocs/hrm/skill_document.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -33,8 +33,8 @@  discard block
 block discarded – undo
 require_once DOL_DOCUMENT_ROOT.'/core/lib/files.lib.php';
 require_once DOL_DOCUMENT_ROOT.'/core/lib/images.lib.php';
 require_once DOL_DOCUMENT_ROOT.'/core/class/html.formfile.class.php';
-require_once DOL_DOCUMENT_ROOT . '/hrm/class/skill.class.php';
-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_skill.lib.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/class/skill.class.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_skill.lib.php';
 
 // Load translation files required by the page
 $langs->loadLangs(array('hrm', 'companies', 'other', 'mails'));
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
 	$linkback = '<a href="'.DOL_URL_ROOT.'/hrm/skill_list.php?restore_lastsearch_values=1'.(!empty($socid) ? '&socid='.$socid : '').'">'.$langs->trans("BackToList").'</a>';
 
 	$morehtmlref = '<div class="refid">';
-	$morehtmlref.= $object->label;
+	$morehtmlref .= $object->label;
 	$morehtmlref .= '</div>';
 
 	dol_banner_tab($object, 'id', $linkback, 1, 'rowid', 'rowid', $morehtmlref);

Please login to merge, or discard this patch.

htdocs/hrm/job_document.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -32,8 +32,8 @@  discard block
 block discarded – undo
 require_once DOL_DOCUMENT_ROOT.'/core/lib/files.lib.php';
 require_once DOL_DOCUMENT_ROOT.'/core/lib/images.lib.php';
 require_once DOL_DOCUMENT_ROOT.'/core/class/html.formfile.class.php';
-require_once DOL_DOCUMENT_ROOT . '/hrm/class/job.class.php';
-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_job.lib.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/class/job.class.php';
+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_job.lib.php';
 
 // Load translation files required by the page
 $langs->loadLangs(array('hrm', 'companies', 'other', 'mails'));
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
 	$linkback = '<a href="'.dol_buildpath('/hrm/job_list.php', 1).'?restore_lastsearch_values=1'.(!empty($socid) ? '&socid='.$socid : '').'">'.$langs->trans("BackToList").'</a>';
 
 	$morehtmlref = '<div class="refid">';
-	$morehtmlref.= $object->label;
+	$morehtmlref .= $object->label;
 	$morehtmlref .= '</div>';
 
 	dol_banner_tab($object, 'id', $linkback, 1, 'rowid', 'rowid', $morehtmlref);

Please login to merge, or discard this patch.

		@@ -44,7 +44,7 @@ discard block
		block discarded – undo
44	44	$contextpage = GETPOST('contextpage', 'aZ') ? GETPOST('contextpage', 'aZ') : 'knowledgerecordcard'; // To manage different context of search
45	45	$backtopage = GETPOST('backtopage', 'alpha');
46	46	$backtopageforcancel = GETPOST('backtopageforcancel', 'alpha');
47		-$lineid = GETPOST('lineid', 'int');
	47	+$lineid = GETPOST('lineid', 'int');
48	48
49	49	// Initialize technical objects
50	50	$object = new KnowledgeRecord($db);
		@@ -425,7 +425,7 @@ discard block
		block discarded – undo
425	425	print '<table class="border centpercent tableforfield">'."\n";
426	426
427	427	// Common attributes
428		- $keyforbreak='fk_c_ticket_category'; // We change column just before this field
	428	+ $keyforbreak = 'fk_c_ticket_category'; // We change column just before this field
429	429	//unset($object->fields['fk_project']); // Hide field already shown in banner
430	430	//unset($object->fields['fk_soc']); // Hide field already shown in banner
431	431	$object->fields['answer']['enabled'] = 0;

		@@ -33,8 +33,8 @@ discard block
		block discarded – undo
33	33	require_once DOL_DOCUMENT_ROOT.'/core/lib/files.lib.php';
34	34	require_once DOL_DOCUMENT_ROOT.'/core/lib/images.lib.php';
35	35	require_once DOL_DOCUMENT_ROOT.'/core/class/html.formfile.class.php';
36		-require_once DOL_DOCUMENT_ROOT . '/hrm/class/skill.class.php';
37		-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_skill.lib.php';
	36	+require_once DOL_DOCUMENT_ROOT.'/hrm/class/skill.class.php';
	37	+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_skill.lib.php';
38	38
39	39	// Load translation files required by the page
40	40	$langs->loadLangs(array('hrm', 'companies', 'other', 'mails'));
		@@ -131,7 +131,7 @@ discard block
		block discarded – undo
131	131	$linkback = '<a href="'.DOL_URL_ROOT.'/hrm/skill_list.php?restore_lastsearch_values=1'.(!empty($socid) ? '&socid='.$socid : '').'">'.$langs->trans("BackToList").'</a>';
132	132
133	133	$morehtmlref = '<div class="refid">';
134		- $morehtmlref.= $object->label;
	134	+ $morehtmlref .= $object->label;
135	135	$morehtmlref .= '</div>';
136	136
137	137	dol_banner_tab($object, 'id', $linkback, 1, 'rowid', 'rowid', $morehtmlref);

		@@ -225,7 +225,7 @@ discard block
		block discarded – undo
225	225
226	226	$title = $object->ref;
227	227	if (!empty($withproject)) {
228		- $title .= ' \| ' . $langs->trans("Project") . (!empty($projectstatic->ref) ? ': '.$projectstatic->ref : '') ;
	228	+ $title .= ' \| '.$langs->trans("Project").(!empty($projectstatic->ref) ? ': '.$projectstatic->ref : '');
229	229	}
230	230	$help_url = '';
231	231
		@@ -266,7 +266,7 @@ discard block
		block discarded – undo
266	266	// Title
267	267	$morehtmlref .= $projectstatic->title;
268	268	// Thirdparty
269		- if (!empty($projectstatic->thirdparty->id) &&$projectstatic->thirdparty->id > 0) {
	269	+ if (!empty($projectstatic->thirdparty->id) && $projectstatic->thirdparty->id > 0) {
270	270	$morehtmlref .= '<br>'.$projectstatic->thirdparty->getNomUrl(1, 'project');
271	271	}
272	272	$morehtmlref .= '</div>';

		@@ -60,7 +60,7 @@ discard block
		block discarded – undo
60	60	{
61	61	$messages = $this->messages;
62	62
63		- usort($messages, function ($itemA, $itemB) {
	63	+ usort($messages, function($itemA, $itemB) {
64	64	if ($itemA['time'] === $itemB['time']) {
65	65	return 0;
66	66	}
		@@ -119,7 +119,7 @@ discard block
		block discarded – undo
119	119	if ($type = $severity & (2 ** $i)) {
120	120	$label = $this->friendlyErrorType($type);
121	121	$this->messages[] = [
122		- 'message' => $message . ' (' . $fileName . ':' . $line . ')',
	122	+ 'message' => $message.' ('.$fileName.':'.$line.')',
123	123	'message_html' => null,
124	124	'is_string' => true,
125	125	'label' => $label,

		@@ -29,8 +29,8 @@ discard block
		block discarded – undo
29	29	// Load Dolibarr environment
30	30	require '../main.inc.php';
31	31
32		-require_once DOL_DOCUMENT_ROOT . '/hrm/class/job.class.php';
33		-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_job.lib.php';
	32	+require_once DOL_DOCUMENT_ROOT.'/hrm/class/job.class.php';
	33	+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_job.lib.php';
34	34
35	35	// Load translation files required by the page
36	36	$langs->loadLangs(array('hrm', 'companies'));
		@@ -106,7 +106,7 @@ discard block
		block discarded – undo
106	106	$linkback = '<a href="'.dol_buildpath('/hrm/job_list.php', 1).'?restore_lastsearch_values=1'.(!empty($socid) ? '&socid='.$socid : '').'">'.$langs->trans("BackToList").'</a>';
107	107
108	108	$morehtmlref = '<div class="refid">';
109		- $morehtmlref.= $object->label;
	109	+ $morehtmlref .= $object->label;
110	110	$morehtmlref .= '</div>';
111	111
112	112

		@@ -28,9 +28,9 @@ discard block
		block discarded – undo
28	28	// Load Dolibarr environment
29	29	require '../main.inc.php';
30	30
31		-require_once DOL_DOCUMENT_ROOT . '/hrm/class/evaluation.class.php';
32		-require_once DOL_DOCUMENT_ROOT . '/hrm/class/job.class.php';
33		-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_evaluation.lib.php';
	31	+require_once DOL_DOCUMENT_ROOT.'/hrm/class/evaluation.class.php';
	32	+require_once DOL_DOCUMENT_ROOT.'/hrm/class/job.class.php';
	33	+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_evaluation.lib.php';
34	34
35	35
36	36	// Load translation files required by the page
		@@ -61,7 +61,7 @@ discard block
		block discarded – undo
61	61
62	62	// Permissions
63	63	$permissionnote = $user->rights->hrm->evaluation->write; // Used by the include of actions_setnotes.inc.php
64		-$permissiontoread = $user->rights->hrm->evaluation->read; // Used by the include of actions_addupdatedelete.inc.php
	64	+$permissiontoread = $user->rights->hrm->evaluation->read; // Used by the include of actions_addupdatedelete.inc.php
65	65
66	66	// Security check (enable the most restrictive one)
67	67	//if ($user->socid > 0) accessforbidden();

		@@ -29,11 +29,11 @@ discard block
		block discarded – undo
29	29	// Load Dolibarr environment
30	30	require '../main.inc.php';
31	31
32		-require_once DOL_DOCUMENT_ROOT . '/contact/class/contact.class.php';
33		-require_once DOL_DOCUMENT_ROOT . '/core/lib/company.lib.php';
34		-require_once DOL_DOCUMENT_ROOT . '/core/lib/functions2.lib.php';
35		-require_once DOL_DOCUMENT_ROOT . '/hrm/class/skill.class.php';
36		-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_skill.lib.php';
	32	+require_once DOL_DOCUMENT_ROOT.'/contact/class/contact.class.php';
	33	+require_once DOL_DOCUMENT_ROOT.'/core/lib/company.lib.php';
	34	+require_once DOL_DOCUMENT_ROOT.'/core/lib/functions2.lib.php';
	35	+require_once DOL_DOCUMENT_ROOT.'/hrm/class/skill.class.php';
	36	+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_skill.lib.php';
37	37
38	38
39	39	// Load translation files required by the page
		@@ -152,7 +152,7 @@ discard block
		block discarded – undo
152	152	$linkback = '<a href="'.DOL_URL_ROOT.'/hrm/skill_list.php?restore_lastsearch_values=1'.(!empty($socid) ? '&socid='.$socid : '').'">'.$langs->trans("BackToList").'</a>';
153	153
154	154	$morehtmlref = '<div class="refid">';
155		- $morehtmlref.= $object->label;
	155	+ $morehtmlref .= $object->label;
156	156	$morehtmlref .= '</div>';
157	157
158	158

		@@ -32,8 +32,8 @@ discard block
		block discarded – undo
32	32	require_once DOL_DOCUMENT_ROOT.'/core/lib/files.lib.php';
33	33	require_once DOL_DOCUMENT_ROOT.'/core/lib/images.lib.php';
34	34	require_once DOL_DOCUMENT_ROOT.'/core/class/html.formfile.class.php';
35		-require_once DOL_DOCUMENT_ROOT . '/hrm/class/job.class.php';
36		-require_once DOL_DOCUMENT_ROOT . '/hrm/lib/hrm_job.lib.php';
	35	+require_once DOL_DOCUMENT_ROOT.'/hrm/class/job.class.php';
	36	+require_once DOL_DOCUMENT_ROOT.'/hrm/lib/hrm_job.lib.php';
37	37
38	38	// Load translation files required by the page
39	39	$langs->loadLangs(array('hrm', 'companies', 'other', 'mails'));
		@@ -131,7 +131,7 @@ discard block
		block discarded – undo
131	131	$linkback = '<a href="'.dol_buildpath('/hrm/job_list.php', 1).'?restore_lastsearch_values=1'.(!empty($socid) ? '&socid='.$socid : '').'">'.$langs->trans("BackToList").'</a>';
132	132
133	133	$morehtmlref = '<div class="refid">';
134		- $morehtmlref.= $object->label;
	134	+ $morehtmlref .= $object->label;
135	135	$morehtmlref .= '</div>';
136	136
137	137	dol_banner_tab($object, 'id', $linkback, 1, 'rowid', 'rowid', $morehtmlref);

Dolibarr / dolibarr

Branch — develop (a4f94f)

Status

Category

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch