Inspection of "Daily Inspection: FIX Menu Create of project no wo..." - Dolibarr/dolibarr - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop (fe1b6c)

unknown

created 2023-12-20 16:20 UTC

Status

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -1,6 +1,6 @@  discard block
 block discarded – undo
 <?php // BEGIN PHP
-$websitekey=basename(__DIR__); if (empty($websitepagefile)) $websitepagefile=__FILE__;
-if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) {
+$websitekey = basename(__DIR__); if (empty($websitepagefile)) $websitepagefile = __FILE__;
+if (!defined('USEDOLIBARRSERVER') && !defined('USEDOLIBARREDITOR')) {
 	$pathdepth = count(explode('/', $_SERVER['SCRIPT_NAME'])) - 2;
 	require_once ($pathdepth ? str_repeat('../', $pathdepth) : './').'master.inc.php';
 } // Not already loaded
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
              $listofpages = getPagesFromSearchCriterias('page', 'meta', GETPOST('s', 'alphanohtml'));
              if ($listofpages['code'] == 'OK')
              {
-                 foreach($listofpages['list'] as $websitepagefound)
+                 foreach ($listofpages['list'] as $websitepagefound)
                  {
                     print '<div class="rowsearchresult"><a href="'.$websitepagefound->ref.'.php">'.$websitepagefound->title.'</a> - '.$websitepagefound->description.'</div>';
                  }

Please login to merge, or discard this patch.

doctemplates/websites/website_template-corporate/containers/page187.tpl.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -1,6 +1,6 @@  discard block
 block discarded – undo
 <?php // BEGIN PHP
-$websitekey=basename(__DIR__); if (empty($websitepagefile)) $websitepagefile=__FILE__;
-if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) {
+$websitekey = basename(__DIR__); if (empty($websitepagefile)) $websitepagefile = __FILE__;
+if (!defined('USEDOLIBARRSERVER') && !defined('USEDOLIBARREDITOR')) {
 	$pathdepth = count(explode('/', $_SERVER['SCRIPT_NAME'])) - 2;
 	require_once ($pathdepth ? str_repeat('../', $pathdepth) : './').'master.inc.php';
 } // Not already loaded
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
                     <div class="group-sm group-middle">
                       <p class="font-italic text-white">Follow Us:</p>
                       <ul class="list-inline">
-                          <?php foreach($mysoc->socialnetworks as $key => $value) {
+                          <?php foreach ($mysoc->socialnetworks as $key => $value) {
                             print '<li><a class="icon icon-xxs-smallest" href="'.(preg_match('/^http/', $value) ? $value : 'https://www.'.$key.'.com/'.$value).'"><span class="fab fa-'.$key.'" style="margin-left: 5px; font-size: 1.6em"></span></a></li>';
                           } ?>
                       </ul>

Please login to merge, or discard this patch.

doctemplates/websites/website_template-corporate/containers/page190.tpl.php 1 patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -1,6 +1,6 @@  discard block
 block discarded – undo
 <?php // BEGIN PHP
-$websitekey=basename(__DIR__); if (empty($websitepagefile)) $websitepagefile=__FILE__;
-if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) {
+$websitekey = basename(__DIR__); if (empty($websitepagefile)) $websitepagefile = __FILE__;
+if (!defined('USEDOLIBARRSERVER') && !defined('USEDOLIBARREDITOR')) {
 	$pathdepth = count(explode('/', $_SERVER['SCRIPT_NAME'])) - 2;
 	require_once ($pathdepth ? str_repeat('../', $pathdepth) : './').'master.inc.php';
 } // Not already loaded
@@ -63,17 +63,17 @@  discard block
 block discarded – undo
             $websitepage = new WebsitePage($db);
             $fuser = new User($db);
             $arrayofusers = array();
-            $MAXNB=10;
-            $sql='SELECT rowid FROM '.MAIN_DB_PREFIX.'user WHERE statut = 1 and fk_soc IS NULL ORDER BY fk_user DESC LIMIT '.$MAXNB;
+            $MAXNB = 10;
+            $sql = 'SELECT rowid FROM '.MAIN_DB_PREFIX.'user WHERE statut = 1 and fk_soc IS NULL ORDER BY fk_user DESC LIMIT '.$MAXNB;
             $resql = $db->query($sql);
-            if (! $resql) dol_print_error($db);
+            if (!$resql) dol_print_error($db);
             while ($obj = $db->fetch_object($resql))
             {
-                $arrayofusers[]=$obj->rowid;
+                $arrayofusers[] = $obj->rowid;
             }
            
             print '<div class="row justify-content-sm-center row-40">';
-            foreach($arrayofusers as $id)
+            foreach ($arrayofusers as $id)
             {
                 $fuser->fetch($id);
 

Please login to merge, or discard this patch.

doctemplates/websites/website_template-corporate/containers/page179.tpl.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -1,6 +1,6 @@  discard block
 block discarded – undo
 <?php // BEGIN PHP
-$websitekey=basename(__DIR__); if (empty($websitepagefile)) $websitepagefile=__FILE__;
-if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) {
+$websitekey = basename(__DIR__); if (empty($websitepagefile)) $websitepagefile = __FILE__;
+if (!defined('USEDOLIBARRSERVER') && !defined('USEDOLIBARREDITOR')) {
 	$pathdepth = count(explode('/', $_SERVER['SCRIPT_NAME'])) - 2;
 	require_once ($pathdepth ? str_repeat('../', $pathdepth) : './').'master.inc.php';
 } // Not already loaded
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
             $weblangs->load("main");
             $fuser = new User($db);
             $arrayofblogs = $websitepage->fetchAll($website->id, 'DESC', 'date_creation', 5, 0, array('type_container'=>'blogpost', 'status'=>1, 'lang'=>'null,'.$websitepage->lang));
-            foreach($arrayofblogs as $blog)
+            foreach ($arrayofblogs as $blog)
             {
                 print '<div class="row justify-content-sm-center row-40">';
                 print '<div class="container blog-box d-xl-inline-block margin-lr-30" style="padding: 20px; box-shadow: -1px 0px 10px 0px rgba(65, 65, 65, 0.12); transition: .3s all ease;">';

Please login to merge, or discard this patch.

doctemplates/websites/website_template-corporate/containers/index.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -1,7 +1,7 @@
 block discarded – undo
 <?php
 // BEGIN PHP File generated to provide an index.php as Home Page or alias redirector - DO NOT MODIFY - It is just a generated wrapper.
-$websitekey=basename(__DIR__); if (empty($websitepagefile)) $websitepagefile=__FILE__;
-if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) { require_once './master.inc.php'; } // Load master if not already loaded
+$websitekey = basename(__DIR__); if (empty($websitepagefile)) $websitepagefile = __FILE__;
+if (!defined('USEDOLIBARRSERVER') && !defined('USEDOLIBARREDITOR')) { require_once './master.inc.php'; } // Load master if not already loaded
 if (!empty($_GET['pageref']) || !empty($_GET['pagealiasalt']) || !empty($_GET['pageid'])) {
 	require_once DOL_DOCUMENT_ROOT.'/core/lib/website.lib.php';
 	require_once DOL_DOCUMENT_ROOT.'/core/website.inc.php';

Please login to merge, or discard this patch.

doctemplates/websites/website_template-corporate/containers/page182.tpl.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -1,6 +1,6 @@  discard block
 block discarded – undo
 <?php // BEGIN PHP
-$websitekey=basename(__DIR__); if (empty($websitepagefile)) $websitepagefile=__FILE__;
-if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) {
+$websitekey = basename(__DIR__); if (empty($websitepagefile)) $websitepagefile = __FILE__;
+if (!defined('USEDOLIBARRSERVER') && !defined('USEDOLIBARREDITOR')) {
 	$pathdepth = count(explode('/', $_SERVER['SCRIPT_NAME'])) - 2;
 	require_once ($pathdepth ? str_repeat('../', $pathdepth) : './').'master.inc.php';
 } // Not already loaded
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
             $fuser = new User($db);
             $arrayofrecord = $jobposition->fetchAll('DESC', 'date_creation', 5, 0, array('status'=>'1,3,9'));
             $weblangs->load("main");
-            foreach($arrayofrecord as $jobrecord)
+            foreach ($arrayofrecord as $jobrecord)
             {
                 print '<div class="row justify-content-sm-center row-40">';
                 print '<div class="container blog-box d-xl-inline-block" style="box-shadow: -1px 0px 10px 0px rgba(65, 65, 65, 0.12); transition: .3s all ease;">';

Please login to merge, or discard this patch.

doctemplates/websites/website_template-corporate/containers/page189.tpl.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -1,6 +1,6 @@  discard block
 block discarded – undo
 <?php // BEGIN PHP
-$websitekey=basename(__DIR__); if (empty($websitepagefile)) $websitepagefile=__FILE__;
-if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) {
+$websitekey = basename(__DIR__); if (empty($websitepagefile)) $websitepagefile = __FILE__;
+if (!defined('USEDOLIBARRSERVER') && !defined('USEDOLIBARREDITOR')) {
 	$pathdepth = count(explode('/', $_SERVER['SCRIPT_NAME'])) - 2;
 	require_once ($pathdepth ? str_repeat('../', $pathdepth) : './').'master.inc.php';
 } // Not already loaded
@@ -538,7 +538,7 @@  discard block
 block discarded – undo
             <?php 
             $MAXNEWS = 3;
             $arrayofblogs = $websitepage->fetchAll($website->id, 'DESC', 'date_creation', $MAXNEWS, 0, array('type_container'=>'blogpost', 'status'=>1, 'lang'=>'null,'.$websitepage->lang));
-            foreach($arrayofblogs as $blog)
+            foreach ($arrayofblogs as $blog)
             {
                 ?>
                 <div class="col-sm-8 col-md-7 col-lg-4">

Please login to merge, or discard this patch.

websites/website_template-homesubmenu/containers/page202.tpl.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -1,6 +1,6 @@  discard block
 block discarded – undo
 <?php // BEGIN PHP
-$websitekey=basename(__DIR__); if (empty($websitepagefile)) $websitepagefile=__FILE__;
-if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) {
+$websitekey = basename(__DIR__); if (empty($websitepagefile)) $websitepagefile = __FILE__;
+if (!defined('USEDOLIBARRSERVER') && !defined('USEDOLIBARREDITOR')) {
 	$pathdepth = count(explode('/', $_SERVER['SCRIPT_NAME'])) - 2;
 	require_once ($pathdepth ? str_repeat('../', $pathdepth) : './').'master.inc.php';
 } // Not already loaded
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
 <body id="bodywebsite" class="bodywebsite bodywebpage-index">
 <!-- Enter here your HTML content. Add a section with an id tag and tag contenteditable="true" if you want to use the inline editor for the content  -->
 <?php 
-    if (GETPOST('action') == 'sendmail')    {
+    if (GETPOST('action') == 'sendmail') {
     include_once DOL_DOCUMENT_ROOT.'/core/class/CMailFile.class.php';
     $from = GETPOST('email', 'alpha');
     $to = $mysoc->email;

Please login to merge, or discard this patch.

websites/website_template-onepageblackpurple/containers/page148.tpl.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -1,6 +1,6 @@  discard block
 block discarded – undo
 <?php // BEGIN PHP
-$websitekey=basename(__DIR__); if (empty($websitepagefile)) $websitepagefile=__FILE__;
-if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) {
+$websitekey = basename(__DIR__); if (empty($websitepagefile)) $websitepagefile = __FILE__;
+if (!defined('USEDOLIBARRSERVER') && !defined('USEDOLIBARREDITOR')) {
 	$pathdepth = count(explode('/', $_SERVER['SCRIPT_NAME'])) - 2;
 	require_once $pathdepth ? str_repeat('../', $pathdepth) : './'.'master.inc.php';
 } // Not already loaded
@@ -272,7 +272,7 @@  discard block
 block discarded – undo
 			  <!-- Section: Social media -->
 			  <section class="mb-4">
 				<?php foreach ($mysoc->socialnetworks as $key => $value) {
-					print '<a class="btn btn-perso2 btn-floating m-1" href="'. (preg_match('/^http/', $value) ? $value : 'https://www.'.$key.'.com/'.$value).'"><span class="fab fa-'.$key.'"></i></a>';
+					print '<a class="btn btn-perso2 btn-floating m-1" href="'.(preg_match('/^http/', $value) ? $value : 'https://www.'.$key.'.com/'.$value).'"><span class="fab fa-'.$key.'"></i></a>';
 				} ?>
 
 			  </section>

Please login to merge, or discard this patch.

		@@ -1,6 +1,6 @@ discard block
		block discarded – undo
1	1	<?php // BEGIN PHP
2		-$websitekey=basename(__DIR__); if (empty($websitepagefile)) $websitepagefile=__FILE__;
3		-if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) {
	2	+$websitekey = basename(__DIR__); if (empty($websitepagefile)) $websitepagefile = __FILE__;
	3	+if (!defined('USEDOLIBARRSERVER') && !defined('USEDOLIBARREDITOR')) {
4	4	$pathdepth = count(explode('/', $_SERVER['SCRIPT_NAME'])) - 2;
5	5	require_once ($pathdepth ? str_repeat('../', $pathdepth) : './').'master.inc.php';
6	6	} // Not already loaded
		@@ -80,7 +80,7 @@ discard block
		block discarded – undo
80	80	$listofpages = getPagesFromSearchCriterias('page', 'meta', GETPOST('s', 'alphanohtml'));
81	81	if ($listofpages['code'] == 'OK')
82	82	{
83		- foreach($listofpages['list'] as $websitepagefound)
	83	+ foreach ($listofpages['list'] as $websitepagefound)
84	84	{
85	85	print '<div class="rowsearchresult"><a href="'.$websitepagefound->ref.'.php">'.$websitepagefound->title.'</a> - '.$websitepagefound->description.'</div>';
86	86	}

		@@ -1,7 +1,7 @@
		block discarded – undo
1	1	<?php
2	2	// BEGIN PHP File generated to provide an index.php as Home Page or alias redirector - DO NOT MODIFY - It is just a generated wrapper.
3		-$websitekey=basename(__DIR__); if (empty($websitepagefile)) $websitepagefile=__FILE__;
4		-if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) { require_once './master.inc.php'; } // Load master if not already loaded
	3	+$websitekey = basename(__DIR__); if (empty($websitepagefile)) $websitepagefile = __FILE__;
	4	+if (!defined('USEDOLIBARRSERVER') && !defined('USEDOLIBARREDITOR')) { require_once './master.inc.php'; } // Load master if not already loaded
5	5	if (!empty($_GET['pageref']) \|\| !empty($_GET['pagealiasalt']) \|\| !empty($_GET['pageid'])) {
6	6	require_once DOL_DOCUMENT_ROOT.'/core/lib/website.lib.php';
7	7	require_once DOL_DOCUMENT_ROOT.'/core/website.inc.php';

Dolibarr / dolibarr

Branch — develop (fe1b6c)

Status

Category

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch