Inspection of "Fix qodana" - Dolibarr/dolibarr - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — develop (3f4b05)

by Laurent

created 2022-12-28 12:19 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -38,7 +38,7 @@
 block discarded – undo
 // Parameters
 $value = GETPOST('value', 'alpha');
 $action = GETPOST('action', 'aZ09');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $label = GETPOST('label', 'alpha');
 $scandir = GETPOST('scandir', 'alpha');

Please login to merge, or discard this patch.

htdocs/admin/supplier_payment.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -37,7 +37,7 @@
 block discarded – undo
 
 $action = GETPOST('action', 'aZ09');
 $value = GETPOST('value', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $label = GETPOST('label', 'alpha');
 $scandir = GETPOST('scandir', 'alpha');

Please login to merge, or discard this patch.

htdocs/admin/expensereport.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -43,7 +43,7 @@  discard block
 block discarded – undo
 
 $action = GETPOST('action', 'aZ09');
 $value = GETPOST('value', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $label = GETPOST('label', 'alpha');
 $scandir = GETPOST('scan_dir', 'alpha');
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
 	$amounts = GETPOST('EXPENSEREPORT_FORCE_LINE_AMOUNTS_INCLUDING_TAXES_ONLY', 'int');
 	$res5 = dolibarr_set_const($db, 'EXPENSEREPORT_FORCE_LINE_AMOUNTS_INCLUDING_TAXES_ONLY', intval($amounts), 'chaine', 0, '', $conf->entity);
 
-	if (!($res1 > 0) || !($res2 > 0) || !($res3 >= 0) || !($res4 >0) || !($res5 >0)) {
+	if (!($res1 > 0) || !($res2 > 0) || !($res3 >= 0) || !($res4 > 0) || !($res5 > 0)) {
 		$error++;
 	}
 

Please login to merge, or discard this patch.

htdocs/admin/expedition.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -46,7 +46,7 @@
 block discarded – undo
 
 $action = GETPOST('action', 'aZ09');
 $value = GETPOST('value', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $label = GETPOST('label', 'alpha');
 $scandir = GETPOST('scan_dir', 'alpha');

Please login to merge, or discard this patch.

htdocs/admin/mrp.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -46,7 +46,7 @@
 block discarded – undo
 
 $action = GETPOST('action', 'aZ09');
 $value = GETPOST('value', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $label = GETPOST('label', 'alpha');
 $scandir = GETPOST('scan_dir', 'alpha');

Please login to merge, or discard this patch.

htdocs/admin/reception_setup.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -46,7 +46,7 @@
 block discarded – undo
 
 $action = GETPOST('action', 'aZ09');
 $value = GETPOST('value', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $label = GETPOST('label', 'alpha');
 $scandir = GETPOST('scan_dir', 'alpha');

Please login to merge, or discard this patch.

htdocs/admin/facture_situation.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -51,7 +51,7 @@  discard block
 block discarded – undo
 
 $value = GETPOST('value', 'alpha');
 $label = GETPOST('label', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $scandir = GETPOST('scan_dir', 'alpha');
 $type = 'invoice';
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
 if ($action == 'edit') {
 	$item->fieldInputOverride = $form->selectarray('INVOICE_USE_RETAINED_WARRANTY', $arrayAvailableType, $conf->global->INVOICE_USE_RETAINED_WARRANTY, 1);
 } else {
-	$item->fieldOutputOverride= isset($arrayAvailableType[$conf->global->INVOICE_USE_RETAINED_WARRANTY])?$arrayAvailableType[$conf->global->INVOICE_USE_RETAINED_WARRANTY]:'';
+	$item->fieldOutputOverride = isset($arrayAvailableType[$conf->global->INVOICE_USE_RETAINED_WARRANTY]) ? $arrayAvailableType[$conf->global->INVOICE_USE_RETAINED_WARRANTY] : '';
 }
 
 //$item = $formSetup->newItem('INVOICE_RETAINED_WARRANTY_LIMITED_TO_SITUATION')->setAsYesNo();

Please login to merge, or discard this patch.

htdocs/admin/usergroup.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -42,7 +42,7 @@
 block discarded – undo
 
 $action = GETPOST('action', 'aZ09');
 $value = GETPOST('value', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $type = 'group';
 

Please login to merge, or discard this patch.

htdocs/admin/supplier_order.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -43,7 +43,7 @@
 block discarded – undo
 
 $type = GETPOST('type', 'alpha');
 $value = GETPOST('value', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $label = GETPOST('label', 'alpha');
 $action = GETPOST('action', 'aZ09');

Please login to merge, or discard this patch.

		@@ -43,7 +43,7 @@ discard block
		block discarded – undo
43	43
44	44	$action = GETPOST('action', 'aZ09');
45	45	$value = GETPOST('value', 'alpha');
46		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	46	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
47	47
48	48	$label = GETPOST('label', 'alpha');
49	49	$scandir = GETPOST('scan_dir', 'alpha');
		@@ -158,7 +158,7 @@ discard block
		block discarded – undo
158	158	$amounts = GETPOST('EXPENSEREPORT_FORCE_LINE_AMOUNTS_INCLUDING_TAXES_ONLY', 'int');
159	159	$res5 = dolibarr_set_const($db, 'EXPENSEREPORT_FORCE_LINE_AMOUNTS_INCLUDING_TAXES_ONLY', intval($amounts), 'chaine', 0, '', $conf->entity);
160	160
161		- if (!($res1 > 0) \|\| !($res2 > 0) \|\| !($res3 >= 0) \|\| !($res4 >0) \|\| !($res5 >0)) {
	161	+ if (!($res1 > 0) \|\| !($res2 > 0) \|\| !($res3 >= 0) \|\| !($res4 > 0) \|\| !($res5 > 0)) {
162	162	$error++;
163	163	}
164	164

		@@ -51,7 +51,7 @@ discard block
		block discarded – undo
51	51
52	52	$value = GETPOST('value', 'alpha');
53	53	$label = GETPOST('label', 'alpha');
54		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	54	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
55	55
56	56	$scandir = GETPOST('scan_dir', 'alpha');
57	57	$type = 'invoice';
		@@ -85,7 +85,7 @@ discard block
		block discarded – undo
85	85	if ($action == 'edit') {
86	86	$item->fieldInputOverride = $form->selectarray('INVOICE_USE_RETAINED_WARRANTY', $arrayAvailableType, $conf->global->INVOICE_USE_RETAINED_WARRANTY, 1);
87	87	} else {
88		- $item->fieldOutputOverride= isset($arrayAvailableType[$conf->global->INVOICE_USE_RETAINED_WARRANTY])?$arrayAvailableType[$conf->global->INVOICE_USE_RETAINED_WARRANTY]:'';
	88	+ $item->fieldOutputOverride = isset($arrayAvailableType[$conf->global->INVOICE_USE_RETAINED_WARRANTY]) ? $arrayAvailableType[$conf->global->INVOICE_USE_RETAINED_WARRANTY] : '';
89	89	}
90	90
91	91	//$item = $formSetup->newItem('INVOICE_RETAINED_WARRANTY_LIMITED_TO_SITUATION')->setAsYesNo();

		@@ -38,7 +38,7 @@
		block discarded – undo
38	38	// Parameters
39	39	$value = GETPOST('value', 'alpha');
40	40	$action = GETPOST('action', 'aZ09');
41		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	41	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
42	42
43	43	$label = GETPOST('label', 'alpha');
44	44	$scandir = GETPOST('scandir', 'alpha');

		@@ -37,7 +37,7 @@
		block discarded – undo
37	37
38	38	$action = GETPOST('action', 'aZ09');
39	39	$value = GETPOST('value', 'alpha');
40		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	40	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
41	41
42	42	$label = GETPOST('label', 'alpha');
43	43	$scandir = GETPOST('scandir', 'alpha');

		@@ -46,7 +46,7 @@
		block discarded – undo
46	46
47	47	$action = GETPOST('action', 'aZ09');
48	48	$value = GETPOST('value', 'alpha');
49		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	49	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
50	50
51	51	$label = GETPOST('label', 'alpha');
52	52	$scandir = GETPOST('scan_dir', 'alpha');

		@@ -42,7 +42,7 @@
		block discarded – undo
42	42
43	43	$action = GETPOST('action', 'aZ09');
44	44	$value = GETPOST('value', 'alpha');
45		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	45	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
46	46
47	47	$type = 'group';
48	48

		@@ -43,7 +43,7 @@
		block discarded – undo
43	43
44	44	$type = GETPOST('type', 'alpha');
45	45	$value = GETPOST('value', 'alpha');
46		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	46	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
47	47
48	48	$label = GETPOST('label', 'alpha');
49	49	$action = GETPOST('action', 'aZ09');

Dolibarr / dolibarr

Branch — develop (3f4b05)

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch