Inspection of "Daily Inspection: Debug v19" - Dolibarr/dolibarr - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop (236e96)

unknown

created 2023-12-05 16:14 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@
 block discarded – undo
 
 // Get parameters
 $id = GETPOST('id', 'int');
-$ref        = GETPOST('ref', 'alpha');
+$ref = GETPOST('ref', 'alpha');
 $action = GETPOST('action', 'aZ09');
 
 // Initialize technical objects

Please login to merge, or discard this patch.

htdocs/fichinter/card-rec.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -357,7 +357,7 @@
 block discarded – undo
 		if (isModEnabled('contrat')) {
 			$formcontract = new FormContract($db);
 			print "<tr><td>".$langs->trans("Contract")."</td><td>";
-			$contractid = GETPOST('contractid') ? GETPOST('contractid') : (!empty($object->fk_contract) ? $object->fk_contract : 0) ;
+			$contractid = GETPOST('contractid') ? GETPOST('contractid') : (!empty($object->fk_contract) ? $object->fk_contract : 0);
 			$numcontract = $formcontract->select_contract($object->thirdparty->id, $contractid, 'contracttid');
 			print "</td></tr>";
 		}

Please login to merge, or discard this patch.

htdocs/fourn/paiement/document.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -126,7 +126,7 @@
 block discarded – undo
 	$morehtmlref .= '<br>'.$object->thirdparty->getNomUrl(1);
 
 	// Amount
-	$morehtmlref .= '<br>'.$langs->trans('Amount').' : '. price($object->amount, '', $langs, 0, 0, -1, $conf->currency);
+	$morehtmlref .= '<br>'.$langs->trans('Amount').' : '.price($object->amount, '', $langs, 0, 0, -1, $conf->currency);
 
 	$allow_delete = 1;
 	// Bank account

Please login to merge, or discard this patch.

htdocs/supplier_proposal/list.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -74,7 +74,7 @@  discard block
 block discarded – undo
 $search_date_endday = GETPOST('search_date_endday', 'int');
 $search_date_endmonth = GETPOST('search_date_endmonth', 'int');
 $search_date_endyear = GETPOST('search_date_endyear', 'int');
-$search_date_start = dol_mktime(0, 0, 0, $search_date_startmonth, $search_date_startday, $search_date_startyear);	// Use tzserver
+$search_date_start = dol_mktime(0, 0, 0, $search_date_startmonth, $search_date_startday, $search_date_startyear); // Use tzserver
 $search_date_end = dol_mktime(23, 59, 59, $search_date_endmonth, $search_date_endday, $search_date_endyear);
 $search_date_valid_startday = GETPOST('search_date_valid_startday', 'int');
 $search_date_valid_startmonth = GETPOST('search_date_valid_startmonth', 'int');
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
 $search_date_valid_endday = GETPOST('search_date_valid_endday', 'int');
 $search_date_valid_endmonth = GETPOST('search_date_valid_endmonth', 'int');
 $search_date_valid_endyear = GETPOST('search_date_valid_endyear', 'int');
-$search_date_valid_start = dol_mktime(0, 0, 0, $search_date_valid_startmonth, $search_date_valid_startday, $search_date_valid_startyear);	// Use tzserver
+$search_date_valid_start = dol_mktime(0, 0, 0, $search_date_valid_startmonth, $search_date_valid_startday, $search_date_valid_startyear); // Use tzserver
 $search_date_valid_end = dol_mktime(23, 59, 59, $search_date_valid_endmonth, $search_date_valid_endday, $search_date_valid_endyear);
 $search_type_thirdparty = GETPOST("search_type_thirdparty", 'int');
 $search_montant_ht = GETPOST('search_montant_ht', 'alpha');
@@ -442,7 +442,7 @@  discard block
 block discarded – undo
 			if ($searchCategoryProductOperator == 0) {
 				$searchCategoryProductSqlList[] = " EXISTS (SELECT ck.fk_product FROM ".MAIN_DB_PREFIX."categorie_product as ck, ".MAIN_DB_PREFIX."supplier_proposaldet as sd WHERE sd.fk_supplier_proposal = sp.rowid AND sd.fk_product = ck.fk_product AND ck.fk_categorie = ".((int) $searchCategoryProduct).")";
 			} else {
-				$listofcategoryid .= ($listofcategoryid ? ', ' : '') .((int) $searchCategoryProduct);
+				$listofcategoryid .= ($listofcategoryid ? ', ' : '').((int) $searchCategoryProduct);
 			}
 		}
 	}

Please login to merge, or discard this patch.

htdocs/admin/barcode.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -39,7 +39,7 @@
 block discarded – undo
 
 // Get Parameters
 $action = GETPOST('action', 'aZ09');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 
 /*

Please login to merge, or discard this patch.

htdocs/admin/commande.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -43,7 +43,7 @@  discard block
 block discarded – undo
 
 $action = GETPOST('action', 'aZ09');
 $value = GETPOST('value', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $label = GETPOST('label', 'alpha');
 $scandir = GETPOST('scan_dir', 'alpha');
@@ -211,7 +211,7 @@  discard block
 block discarded – undo
 		setEventMessages($langs->trans('Error'), null, 'errors');
 	} else {
 		setEventMessages($langs->trans('SetupSaved'), null, 'mesgs');
-		header("Location: " . $_SERVER["PHP_SELF"]);
+		header("Location: ".$_SERVER["PHP_SELF"]);
 		exit();
 	}
 } elseif (preg_match('/del_(.*)/', $action, $reg)) {
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
 		setEventMessages($langs->trans('Error'), null, 'errors');
 	} else {
 		setEventMessages($langs->trans('SetupSaved'), null, 'mesgs');
-		header("Location: " . $_SERVER["PHP_SELF"]);
+		header("Location: ".$_SERVER["PHP_SELF"]);
 		exit();
 	}
 }

Please login to merge, or discard this patch.

htdocs/admin/tools/dolibarr_import.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -22,8 +22,8 @@
 block discarded – undo
  * 		\brief      Page to import database
  */
 
-if (! defined('CSRFCHECK_WITH_TOKEN')) {
-	define('CSRFCHECK_WITH_TOKEN', '1');		// Force use of CSRF protection with tokens even for GET
+if (!defined('CSRFCHECK_WITH_TOKEN')) {
+	define('CSRFCHECK_WITH_TOKEN', '1'); // Force use of CSRF protection with tokens even for GET
 }
 
 // Load Dolibarr environment

Please login to merge, or discard this patch.

htdocs/admin/tools/purge.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -21,8 +21,8 @@
 block discarded – undo
  *		\brief      Page to purge files (temporary or not)
  */
 
-if (! defined('CSRFCHECK_WITH_TOKEN')) {
-	define('CSRFCHECK_WITH_TOKEN', '1');		// Force use of CSRF protection with tokens even for GET
+if (!defined('CSRFCHECK_WITH_TOKEN')) {
+	define('CSRFCHECK_WITH_TOKEN', '1'); // Force use of CSRF protection with tokens even for GET
 }
 
 // Load Dolibarr environment

Please login to merge, or discard this patch.

htdocs/admin/tools/listsessions.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -22,8 +22,8 @@
 block discarded – undo
  *      \brief      List of PHP sessions
  */
 
-if (! defined('CSRFCHECK_WITH_TOKEN')) {
-	define('CSRFCHECK_WITH_TOKEN', '1');		// Force use of CSRF protection with tokens even for GET
+if (!defined('CSRFCHECK_WITH_TOKEN')) {
+	define('CSRFCHECK_WITH_TOKEN', '1'); // Force use of CSRF protection with tokens even for GET
 }
 
 // Load Dolibarr environment

Please login to merge, or discard this patch.

		@@ -357,7 +357,7 @@
		block discarded – undo
357	357	if (isModEnabled('contrat')) {
358	358	$formcontract = new FormContract($db);
359	359	print "<tr><td>".$langs->trans("Contract")."</td><td>";
360		- $contractid = GETPOST('contractid') ? GETPOST('contractid') : (!empty($object->fk_contract) ? $object->fk_contract : 0) ;
	360	+ $contractid = GETPOST('contractid') ? GETPOST('contractid') : (!empty($object->fk_contract) ? $object->fk_contract : 0);
361	361	$numcontract = $formcontract->select_contract($object->thirdparty->id, $contractid, 'contracttid');
362	362	print "</td></tr>";
363	363	}

		@@ -126,7 +126,7 @@
		block discarded – undo
126	126	$morehtmlref .= '<br>'.$object->thirdparty->getNomUrl(1);
127	127
128	128	// Amount
129		- $morehtmlref .= '<br>'.$langs->trans('Amount').' : '. price($object->amount, '', $langs, 0, 0, -1, $conf->currency);
	129	+ $morehtmlref .= '<br>'.$langs->trans('Amount').' : '.price($object->amount, '', $langs, 0, 0, -1, $conf->currency);
130	130
131	131	$allow_delete = 1;
132	132	// Bank account

		@@ -74,7 +74,7 @@ discard block
		block discarded – undo
74	74	$search_date_endday = GETPOST('search_date_endday', 'int');
75	75	$search_date_endmonth = GETPOST('search_date_endmonth', 'int');
76	76	$search_date_endyear = GETPOST('search_date_endyear', 'int');
77		-$search_date_start = dol_mktime(0, 0, 0, $search_date_startmonth, $search_date_startday, $search_date_startyear); // Use tzserver
	77	+$search_date_start = dol_mktime(0, 0, 0, $search_date_startmonth, $search_date_startday, $search_date_startyear); // Use tzserver
78	78	$search_date_end = dol_mktime(23, 59, 59, $search_date_endmonth, $search_date_endday, $search_date_endyear);
79	79	$search_date_valid_startday = GETPOST('search_date_valid_startday', 'int');
80	80	$search_date_valid_startmonth = GETPOST('search_date_valid_startmonth', 'int');
		@@ -82,7 +82,7 @@ discard block
		block discarded – undo
82	82	$search_date_valid_endday = GETPOST('search_date_valid_endday', 'int');
83	83	$search_date_valid_endmonth = GETPOST('search_date_valid_endmonth', 'int');
84	84	$search_date_valid_endyear = GETPOST('search_date_valid_endyear', 'int');
85		-$search_date_valid_start = dol_mktime(0, 0, 0, $search_date_valid_startmonth, $search_date_valid_startday, $search_date_valid_startyear); // Use tzserver
	85	+$search_date_valid_start = dol_mktime(0, 0, 0, $search_date_valid_startmonth, $search_date_valid_startday, $search_date_valid_startyear); // Use tzserver
86	86	$search_date_valid_end = dol_mktime(23, 59, 59, $search_date_valid_endmonth, $search_date_valid_endday, $search_date_valid_endyear);
87	87	$search_type_thirdparty = GETPOST("search_type_thirdparty", 'int');
88	88	$search_montant_ht = GETPOST('search_montant_ht', 'alpha');
		@@ -442,7 +442,7 @@ discard block
		block discarded – undo
442	442	if ($searchCategoryProductOperator == 0) {
443	443	$searchCategoryProductSqlList[] = " EXISTS (SELECT ck.fk_product FROM ".MAIN_DB_PREFIX."categorie_product as ck, ".MAIN_DB_PREFIX."supplier_proposaldet as sd WHERE sd.fk_supplier_proposal = sp.rowid AND sd.fk_product = ck.fk_product AND ck.fk_categorie = ".((int) $searchCategoryProduct).")";
444	444	} else {
445		- $listofcategoryid .= ($listofcategoryid ? ', ' : '') .((int) $searchCategoryProduct);
	445	+ $listofcategoryid .= ($listofcategoryid ? ', ' : '').((int) $searchCategoryProduct);
446	446	}
447	447	}
448	448	}

		@@ -43,7 +43,7 @@ discard block
		block discarded – undo
43	43
44	44	$action = GETPOST('action', 'aZ09');
45	45	$value = GETPOST('value', 'alpha');
46		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	46	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
47	47
48	48	$label = GETPOST('label', 'alpha');
49	49	$scandir = GETPOST('scan_dir', 'alpha');
		@@ -211,7 +211,7 @@ discard block
		block discarded – undo
211	211	setEventMessages($langs->trans('Error'), null, 'errors');
212	212	} else {
213	213	setEventMessages($langs->trans('SetupSaved'), null, 'mesgs');
214		- header("Location: " . $_SERVER["PHP_SELF"]);
	214	+ header("Location: ".$_SERVER["PHP_SELF"]);
215	215	exit();
216	216	}
217	217	} elseif (preg_match('/del_(.*)/', $action, $reg)) {
		@@ -226,7 +226,7 @@ discard block
		block discarded – undo
226	226	setEventMessages($langs->trans('Error'), null, 'errors');
227	227	} else {
228	228	setEventMessages($langs->trans('SetupSaved'), null, 'mesgs');
229		- header("Location: " . $_SERVER["PHP_SELF"]);
	229	+ header("Location: ".$_SERVER["PHP_SELF"]);
230	230	exit();
231	231	}
232	232	}

		@@ -33,7 +33,7 @@
		block discarded – undo
33	33
34	34	// Get parameters
35	35	$id = GETPOST('id', 'int');
36		-$ref = GETPOST('ref', 'alpha');
	36	+$ref = GETPOST('ref', 'alpha');
37	37	$action = GETPOST('action', 'aZ09');
38	38
39	39	// Initialize technical objects

		@@ -39,7 +39,7 @@
		block discarded – undo
39	39
40	40	// Get Parameters
41	41	$action = GETPOST('action', 'aZ09');
42		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	42	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
43	43
44	44
45	45	/*

		@@ -22,8 +22,8 @@
		block discarded – undo
22	22	* \brief Page to import database
23	23	*/
24	24
25		-if (! defined('CSRFCHECK_WITH_TOKEN')) {
26		- define('CSRFCHECK_WITH_TOKEN', '1'); // Force use of CSRF protection with tokens even for GET
	25	+if (!defined('CSRFCHECK_WITH_TOKEN')) {
	26	+ define('CSRFCHECK_WITH_TOKEN', '1'); // Force use of CSRF protection with tokens even for GET
27	27	}
28	28
29	29	// Load Dolibarr environment

		@@ -21,8 +21,8 @@
		block discarded – undo
21	21	* \brief Page to purge files (temporary or not)
22	22	*/
23	23
24		-if (! defined('CSRFCHECK_WITH_TOKEN')) {
25		- define('CSRFCHECK_WITH_TOKEN', '1'); // Force use of CSRF protection with tokens even for GET
	24	+if (!defined('CSRFCHECK_WITH_TOKEN')) {
	25	+ define('CSRFCHECK_WITH_TOKEN', '1'); // Force use of CSRF protection with tokens even for GET
26	26	}
27	27
28	28	// Load Dolibarr environment

		@@ -22,8 +22,8 @@
		block discarded – undo
22	22	* \brief List of PHP sessions
23	23	*/
24	24
25		-if (! defined('CSRFCHECK_WITH_TOKEN')) {
26		- define('CSRFCHECK_WITH_TOKEN', '1'); // Force use of CSRF protection with tokens even for GET
	25	+if (!defined('CSRFCHECK_WITH_TOKEN')) {
	26	+ define('CSRFCHECK_WITH_TOKEN', '1'); // Force use of CSRF protection with tokens even for GET
27	27	}
28	28
29	29	// Load Dolibarr environment

Dolibarr / dolibarr

Branch — develop (236e96)

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch