Dolibarr / dolibarr

dev/tools/github_pr_reviewers_webhook.php

Spacing +34 added lines, -34 removed lines

@@ -84,7 +84,7 @@ 
 define('GITHUB_API_VERSION', '2022-11-28');
 
 
-$config = @require_once __DIR__ . '/github_pr_reviewers_webhook.config.php';
+$config = @require_once __DIR__.'/github_pr_reviewers_webhook.config.php';
 
 if (false === $config) {
 	_error('Could not load config');
@@ -96,7 +96,7 @@ 
 	_error('Empty secret configuration');
 }
 
-$reviewers = $config['reviewers'] ?? [ ];
+$reviewers = $config['reviewers'] ?? [];
 
 if (empty($reviewers)) {
 	_error('Empty reviewers configuration');
@@ -122,20 +122,20 @@ 
 	_error('Message signature not found', 400);
 }
 
-$expectedSignature = 'sha256=' . hash_hmac('sha256', file_get_contents('php://input'), $secret);
+$expectedSignature = 'sha256='.hash_hmac('sha256', file_get_contents('php://input'), $secret);
 
-_debug('expectedSignature = ' . var_export($expectedSignature, true));
-_debug('signature = ' . var_export($signature, true));
+_debug('expectedSignature = '.var_export($expectedSignature, true));
+_debug('signature = '.var_export($signature, true));
 
 // Use `hash_equals()` instead of direct comparison to avoir timing attacks (@see https://www.php.net/manual/en/function.hash-equals.php)
-if (! hash_equals($signature, $expectedSignature)) {
+if (!hash_equals($signature, $expectedSignature)) {
 	_error('Invalid webhook signature', 401);
 }
 
-_debug('event = ' . var_export($event, true));
+_debug('event = '.var_export($event, true));
 
 if ('pull_request' !== $event) {
-	_out('Event ' . var_export($event, true) . ' not qualified');
+	_out('Event '.var_export($event, true).' not qualified');
 	exit;
 }
 
@@ -150,7 +150,7 @@ 
 $payload = json_decode($rawPayload, /* associative: */ true);
 
 if (null === $payload) {
-	_error('Could not decode payload, got ' . var_export($rawPayload, true) . ' in input');
+	_error('Could not decode payload, got '.var_export($rawPayload, true).' in input');
 }
 
 // _debug('payload = ' . var_export($payload, true));
@@ -162,26 +162,26 @@ 
 	_error('Target branch not in payload');
 }
 
-_debug('targetBranch = ' . var_export($targetBranch, true));
+_debug('targetBranch = '.var_export($targetBranch, true));
 
 
-if (! array_key_exists($targetBranch, $reviewers)) {
-	_out('Target branch ' . var_export($targetBranch, true) . ' not qualified');
+if (!array_key_exists($targetBranch, $reviewers)) {
+	_out('Target branch '.var_export($targetBranch, true).' not qualified');
 	exit;
 }
 
 $wantedReviewers = $reviewers[$targetBranch];
 
-if (! is_array($wantedReviewers) && ! is_string($wantedReviewers)) {
-	_error('Wanted reviewers incorrectly set in config for branch ' . var_export($targetBranch, true));
+if (!is_array($wantedReviewers) && !is_string($wantedReviewers)) {
+	_error('Wanted reviewers incorrectly set in config for branch '.var_export($targetBranch, true));
 }
 
-if (! is_array($wantedReviewers) && ! empty($wantedReviewers)) {
-	$wantedReviewers = [ $wantedReviewers ];
+if (!is_array($wantedReviewers) && !empty($wantedReviewers)) {
+	$wantedReviewers = [$wantedReviewers];
 }
 
 if (empty($wantedReviewers)) {
-	_out('Branch ' . var_export($targetBranch, true) . ' configured with no reviewers, not qualified');
+	_out('Branch '.var_export($targetBranch, true).' configured with no reviewers, not qualified');
 	exit;
 }
 
@@ -193,7 +193,7 @@ 
 
 
 if ('opened' !== $action && 'edited' !== $action && 'ready_for_review' !== $action) {
-	_out('Action ' . var_export($action, true) . ' not qualified');
+	_out('Action '.var_export($action, true).' not qualified');
 	exit;
 }
 
@@ -223,7 +223,7 @@ 
 }
 
 // GitHub API returns an error 422 if we try to add the author as a reviewer, we have to filter them out
-$reviewersToBeAdded = array_diff($wantedReviewers, $currentReviewers, empty($author) ? [ ] : [ $author ]);
+$reviewersToBeAdded = array_diff($wantedReviewers, $currentReviewers, empty($author) ? [] : [$author]);
 
 if (empty($reviewersToBeAdded)) {
 	_out('Reviewers already requested or author of the pull request : not qualified');
@@ -232,7 +232,7 @@ 
 
 
 _out('Webhook qualified');
-_debug('Adding reviewers: ' . implode(', ', $reviewersToBeAdded));
+_debug('Adding reviewers: '.implode(', ', $reviewersToBeAdded));
 
 
 $pullRequestUrl = $payload['pull_request']['url'] ?? null;
@@ -241,7 +241,7 @@ 
 	_error('Pull request API URL not in payload');
 }
 
-$c = curl_init($pullRequestUrl . '/requested_reviewers');
+$c = curl_init($pullRequestUrl.'/requested_reviewers');
 
 if (false === $c) {
 	_error('Could not init cURL');
@@ -251,24 +251,24 @@ 
 $setMethodReturn = curl_setopt($c, CURLOPT_CUSTOMREQUEST, 'POST');
 
 if (false === $setMethodReturn) {
-	_error('Could not set request method: ' . curl_error($c));
+	_error('Could not set request method: '.curl_error($c));
 }
 
 $setHeadersReturn = curl_setopt($c, CURLOPT_HTTPHEADER, [
 	'Accept: application/vnd.github+json',
-	'Authorization: Bearer ' . $token,
-	'X-GitHub-Api-Version: ' . GITHUB_API_VERSION,
+	'Authorization: Bearer '.$token,
+	'X-GitHub-Api-Version: '.GITHUB_API_VERSION,
 	'User-Agent: dolibarr-github-webhook-handler/1.0 dolibarr/20250616', // PHP cURL implementation has no default User-Agent yet, and GitHub REST API requires one
 	'Content-Type: application/json',
 ]);
 
 if (false === $setHeadersReturn) {
-	_error('Could not set request headers: ' . curl_error($c));
+	_error('Could not set request headers: '.curl_error($c));
 }
 
 $setBodyReturn = curl_setopt($c, CURLOPT_POSTFIELDS, json_encode([
 	'reviewers' => $reviewersToBeAdded,
-	'team_reviewers' => [ ], // TODO
+	'team_reviewers' => [], // TODO
 ]));
 
 
@@ -283,28 +283,28 @@ 
 $setReturnTransferReturn = curl_setopt($c, CURLOPT_RETURNTRANSFER, true);
 
 if (false === $setReturnTransferReturn) {
-	_error('Could not set return transfer: ' . curl_error($c));
+	_error('Could not set return transfer: '.curl_error($c));
 }
 
 $response = curl_exec($c);
 
 if (false === $response) {
-	_error('Error handling cURL request: ' . curl_error($c));
+	_error('Error handling cURL request: '.curl_error($c));
 }
 
 $responseCode = curl_getinfo($c, CURLINFO_RESPONSE_CODE);
 
 if (false === $responseCode) {
-	_error('Error getting response code: ' . curl_error($c));
+	_error('Error getting response code: '.curl_error($c));
 }
 
-_debug('responseCode = ' . $responseCode);
+_debug('responseCode = '.$responseCode);
 
 if ($responseCode < 200 || $responseCode > 399) {
-	_error('Error from GitHub API, code ' . $responseCode . ': ' . $response);
+	_error('Error from GitHub API, code '.$responseCode.': '.$response);
 }
 
-_out('Added the following reviewers: ' . implode(', ', $reviewersToBeAdded));
+_out('Added the following reviewers: '.implode(', ', $reviewersToBeAdded));
 
 curl_close($c);
 
@@ -317,7 +317,7 @@ 
  */
 function _out(string $message): void
 {
-	echo $message . PHP_EOL;
+	echo $message.PHP_EOL;
 }
 
 /**
@@ -343,6 +343,6 @@ 
 function _error(string $message, int $status = 500): void
 {
 	http_response_code($status);
-	_out('Error: ' . $message);
+	_out('Error: '.$message);
 	exit;
 }

htdocs/projet/card.php

Spacing +22 added lines, -22 removed lines

@@ -120,7 +120,7 @@ 
 
 $permissiontoadd = $user->hasRight('projet', 'creer');
 $permissiontodelete = $user->hasRight('projet', 'supprimer');
-$permissiondellink = $user->hasRight('projet', 'creer');	// Used by the include of actions_dellink.inc.php
+$permissiondellink = $user->hasRight('projet', 'creer'); // Used by the include of actions_dellink.inc.php
 $permissiontoeditextra = $permissiontoadd;
 if (GETPOST('attribute', 'aZ09') && isset($extrafields->attributes[$object->table_element]['perms'][GETPOST('attribute', 'aZ09')])) {
 	// For action 'update_extras', is there a specific permission set for the attribute to update
@@ -176,7 +176,7 @@ 
 		$action = '';
 	}
 
-	include DOL_DOCUMENT_ROOT.'/core/actions_dellink.inc.php';		// Must be 'include', not 'include_once'
+	include DOL_DOCUMENT_ROOT.'/core/actions_dellink.inc.php'; // Must be 'include', not 'include_once'
 
 	// Action setdraft object
 	if ($action == 'confirm_setdraft' && $confirm == 'yes' && $permissiontoadd) {
@@ -190,7 +190,7 @@ 
 		$action = '';
 
 		// For backward compatibility
-		$object->statut = $object::STATUS_DRAFT;	// this already set for $object->status by $object->setStatut()
+		$object->statut = $object::STATUS_DRAFT; // this already set for $object->status by $object->setStatut()
 	}
 
 	// Action add
@@ -320,7 +320,7 @@ 
 		$db->begin();
 		$old_start_date = 0;
 		if (!$error) {
-			$object->oldcopy = clone $object;  // @phan-suppress-current-line PhanTypeMismatchProperty
+			$object->oldcopy = clone $object; // @phan-suppress-current-line PhanTypeMismatchProperty
 
 			$old_start_date = $object->date_start;
 
@@ -337,7 +337,7 @@ 
 			$object->date_end_event   = (!GETPOST('date_end_event')) ? '' : $date_end_event;
 			$object->location     = $location;
 			if (GETPOSTISSET('opp_amount')) {
-				$object->opp_amount   = price2num(GETPOST('opp_amount', 'alpha'));
+				$object->opp_amount = price2num(GETPOST('opp_amount', 'alpha'));
 			}
 			if (GETPOSTISSET('budget_amount')) {
 				$object->budget_amount = price2num(GETPOST('budget_amount', 'alpha'));
@@ -524,7 +524,7 @@ 
 			if (!empty($_SESSION['pageforbacktolist']) && !empty($_SESSION['pageforbacktolist']['project'])) {
 				$tmpurl = $_SESSION['pageforbacktolist']['project'];
 				$tmpurl = preg_replace('/__SOCID__/', (string) $object->socid, $tmpurl);
-				$urlback = $tmpurl.(preg_match('/\?/', $tmpurl) ? '&' : '?'). 'restore_lastsearch_values=1';
+				$urlback = $tmpurl.(preg_match('/\?/', $tmpurl) ? '&' : '?').'restore_lastsearch_values=1';
 			} else {
 				$urlback = DOL_URL_ROOT.'/projet/list.php?restore_lastsearch_values=1';
 			}
@@ -563,7 +563,7 @@ 
 
 	// Quick edit for extrafields
 	if ($action == 'update_extras' && $permissiontoeditextra) {
-		$object->oldcopy = dol_clone($object, 2);  // @phan-suppress-current-line PhanTypeMismatchProperty
+		$object->oldcopy = dol_clone($object, 2); // @phan-suppress-current-line PhanTypeMismatchProperty
 
 		$attribute_name = GETPOST('attribute', 'aZ09');
 
@@ -995,7 +995,7 @@ 
 	$userDelete = $object->restrictedProjectArea($user, 'delete');
 	//print "userAccess=".$userAccess." userWrite=".$userWrite." userDelete=".$userDelete;
 
-	$formconfirm = "" ;
+	$formconfirm = "";
 
 	// Confirmation validation
 	if ($action == 'validate') {
@@ -1133,7 +1133,7 @@ 
 				print '<br>';
 			}
 			if (!getDolGlobalString('PROJECT_HIDE_TASKS')) {
-				print '<input type="checkbox" id="usage_task" name="usage_task"' . (GETPOSTISSET('usage_task') ? (GETPOST('usage_task', 'alpha') != '' ? ' checked="checked"' : '') : ($object->usage_task ? ' checked="checked"' : '')) . '> ';
+				print '<input type="checkbox" id="usage_task" name="usage_task"'.(GETPOSTISSET('usage_task') ? (GETPOST('usage_task', 'alpha') != '' ? ' checked="checked"' : '') : ($object->usage_task ? ' checked="checked"' : '')).'> ';
 				$htmltext = $langs->trans("ProjectFollowTasks");
 				print '<label for="usage_task">'.$form->textwithpicto($langs->trans("ProjectFollowTasks"), $htmltext).'</label>';
 				print '<script>';
@@ -1159,7 +1159,7 @@ 
 				print '<br>';
 			}
 			if (!getDolGlobalString('PROJECT_HIDE_TASKS') && getDolGlobalString('PROJECT_BILL_TIME_SPENT')) {
-				print '<input type="checkbox" id="usage_bill_time" name="usage_bill_time"' . (GETPOSTISSET('usage_bill_time') ? (GETPOST('usage_bill_time', 'alpha') != '' ? ' checked="checked"' : '') : ($object->usage_bill_time ? ' checked="checked"' : '')) . '> ';
+				print '<input type="checkbox" id="usage_bill_time" name="usage_bill_time"'.(GETPOSTISSET('usage_bill_time') ? (GETPOST('usage_bill_time', 'alpha') != '' ? ' checked="checked"' : '') : ($object->usage_bill_time ? ' checked="checked"' : '')).'> ';
 				$htmltext = $langs->trans("ProjectBillTimeDescription");
 				print '<label for="usage_bill_time">'.$form->textwithpicto($langs->trans("BillTime"), $htmltext).'</label>';
 				print '<script>';
@@ -1185,7 +1185,7 @@ 
 				print '<br>';
 			}
 			if (isModEnabled('eventorganization')) {
-				print '<input type="checkbox" id="usage_organize_event" name="usage_organize_event"'. (GETPOSTISSET('usage_organize_event') ? (GETPOST('usage_organize_event', 'alpha') != '' ? ' checked="checked"' : '') : ($object->usage_organize_event ? ' checked="checked"' : '')) . '> ';
+				print '<input type="checkbox" id="usage_organize_event" name="usage_organize_event"'.(GETPOSTISSET('usage_organize_event') ? (GETPOST('usage_organize_event', 'alpha') != '' ? ' checked="checked"' : '') : ($object->usage_organize_event ? ' checked="checked"' : '')).'> ';
 				$htmltext = $langs->trans("EventOrganizationDescriptionLong");
 				print '<label for="usage_organize_event">'.$form->textwithpicto($langs->trans("ManageOrganizeEvent"), $htmltext).'</label>';
 				print '<script>';
@@ -1357,7 +1357,7 @@ 
 		if (!empty($_SESSION['pageforbacktolist']) && !empty($_SESSION['pageforbacktolist']['project'])) {
 			$tmpurl = $_SESSION['pageforbacktolist']['project'];
 			$tmpurl = preg_replace('/__SOCID__/', (string) $object->socid, $tmpurl);
-			$linkback = '<a href="'.$tmpurl.(preg_match('/\?/', $tmpurl) ? '&' : '?'). 'restore_lastsearch_values=1">'.$langs->trans("BackToList").'</a>';
+			$linkback = '<a href="'.$tmpurl.(preg_match('/\?/', $tmpurl) ? '&' : '?').'restore_lastsearch_values=1">'.$langs->trans("BackToList").'</a>';
 		} else {
 			$linkback = '<a href="'.DOL_URL_ROOT.'/projet/list.php?restore_lastsearch_values=1">'.$langs->trans("BackToList").'</a>';
 		}
@@ -1434,8 +1434,8 @@ 
 				print '<a class="editfielda paddingtop" href="'.$_SERVER["PHP_SELF"].'?action=edit_opp_status&token='.newToken().'&id='.$object->id.'">'.img_edit($langs->transnoentitiesnoconv('Edit'), 1).'</a>';
 			}
 			print '</td><td>';
-			$html_name_status 	= ($action == 'edit_opp_status') ? 'opp_status' : 'none';
-			$html_name_percent 	= ($action == 'edit_opp_status') ? 'opp_percent' : 'none';
+			$html_name_status = ($action == 'edit_opp_status') ? 'opp_status' : 'none';
+			$html_name_percent = ($action == 'edit_opp_status') ? 'opp_percent' : 'none';
 			$percent_value = (GETPOSTISSET('opp_percent') ? GETPOSTINT('opp_percent') : (strcmp($object->opp_percent, '') ? vatrate($object->opp_percent) : ''));
 			$formproject->formOpportunityStatus($_SERVER['PHP_SELF'].'?socid='.$object->id, (string) $object->opp_status, $percent_value, $html_name_status, $html_name_percent);
 			print '</td></tr>';
@@ -1662,7 +1662,7 @@ 
 					if ($userWrite > 0) {
 						print dolGetButtonAction('', $langs->trans('SetToDraft'), 'default', $_SERVER["PHP_SELF"].'?action=confirm_setdraft&amp;confirm=yes&amp;token='.newToken().'&amp;id='.$object->id, '');
 					} else {
-						print dolGetButtonAction($langs->trans('NotOwnerOfProject'), $langs->trans('SetToDraft'), 'default', $_SERVER['PHP_SELF']. '#', '', false);
+						print dolGetButtonAction($langs->trans('NotOwnerOfProject'), $langs->trans('SetToDraft'), 'default', $_SERVER['PHP_SELF'].'#', '', false);
 					}
 				}
 			}
@@ -1672,7 +1672,7 @@ 
 				if ($userWrite > 0) {
 					print dolGetButtonAction('', $langs->trans('Modify'), 'default', $_SERVER["PHP_SELF"].'?action=edit&token='.newToken().'&id='.$object->id, '');
 				} else {
-					print dolGetButtonAction($langs->trans('NotOwnerOfProject'), $langs->trans('Modify'), 'default', $_SERVER['PHP_SELF']. '#', '', false);
+					print dolGetButtonAction($langs->trans('NotOwnerOfProject'), $langs->trans('Modify'), 'default', $_SERVER['PHP_SELF'].'#', '', false);
 				}
 			}
 
@@ -1682,7 +1682,7 @@ 
 					//print dolGetButtonAction('', $langs->trans('Validate'), 'default', $_SERVER["PHP_SELF"].'?action=validate&token='.newToken().'&id='.$object->id, '');
 					print dolGetButtonAction('', $langs->trans('Validate'), 'default', $_SERVER["PHP_SELF"].'?action=confirm_validate&confirm=yes&token='.newToken().'&id='.$object->id, '');
 				} else {
-					print dolGetButtonAction($langs->trans('NotOwnerOfProject'), $langs->trans('Validate'), 'default', $_SERVER['PHP_SELF']. '#', '', false);
+					print dolGetButtonAction($langs->trans('NotOwnerOfProject'), $langs->trans('Validate'), 'default', $_SERVER['PHP_SELF'].'#', '', false);
 				}
 			}
 
@@ -1692,7 +1692,7 @@ 
 					//print dolGetButtonAction('', $langs->trans('Close'), 'default', $_SERVER["PHP_SELF"].'?action=close&amp;token='.newToken().'&amp;id='.$object->id, '');
 					print dolGetButtonAction('', $langs->trans('Close'), 'default', $_SERVER["PHP_SELF"].'?action=confirm_close&confirm=yes&token='.newToken().'&id='.$object->id, '');
 				} else {
-					print dolGetButtonAction($langs->trans('NotOwnerOfProject'), $langs->trans('Close'), 'default', $_SERVER['PHP_SELF']. '#', '', false);
+					print dolGetButtonAction($langs->trans('NotOwnerOfProject'), $langs->trans('Close'), 'default', $_SERVER['PHP_SELF'].'#', '', false);
 				}
 			}
 
@@ -1701,7 +1701,7 @@ 
 				if ($userWrite > 0) {
 					print dolGetButtonAction('', $langs->trans('ReOpen'), 'default', $_SERVER["PHP_SELF"].'?action=reopen&amp;token='.newToken().'&amp;id='.$object->id, '');
 				} else {
-					print dolGetButtonAction($langs->trans('NotOwnerOfProject'), $langs->trans('ReOpen'), 'default', $_SERVER['PHP_SELF']. '#', '', false);
+					print dolGetButtonAction($langs->trans('NotOwnerOfProject'), $langs->trans('ReOpen'), 'default', $_SERVER['PHP_SELF'].'#', '', false);
 				}
 			}
 
@@ -1710,7 +1710,7 @@ 
 			if (!getDolGlobalString('PROJECT_HIDE_CREATE_OBJECT_BUTTON')) {
 				// We check the type of thirdparty
 				$is_customer_or_prospect = (!empty($object->thirdparty->prospect) || !empty($object->thirdparty->client));
-				$is_supplier_only= (!empty($object->thirdparty->fournisseur) && !$is_customer_or_prospect);
+				$is_supplier_only = (!empty($object->thirdparty->fournisseur) && !$is_customer_or_prospect);
 
 				$arrayforbutaction = array(
 					10 => array('lang'=>'propal', 'enabled' => (isModEnabled("propal") && !$is_customer_or_prospect), 'perm' => $user->hasRight('propal', 'creer') ? true : false, 'label' => 'AddProp', 'url'=>'/comm/propal/card.php?action=create&amp;projectid='.$object->id.'&amp;socid='.$object->socid),
@@ -1736,7 +1736,7 @@ 
 				if ($userWrite > 0) {
 					print dolGetButtonAction('', $langs->trans('ToClone'), 'default', $_SERVER["PHP_SELF"].'?action=clone&token='.newToken().'&id='.((int) $object->id), '');
 				} else {
-					print dolGetButtonAction($langs->trans('NotOwnerOfProject'), $langs->trans('ToClone'), 'default', $_SERVER['PHP_SELF']. '#', '', false);
+					print dolGetButtonAction($langs->trans('NotOwnerOfProject'), $langs->trans('ToClone'), 'default', $_SERVER['PHP_SELF'].'#', '', false);
 				}
 			}
 
@@ -1745,7 +1745,7 @@ 
 				if ($userDelete > 0 || ($object->status == Project::STATUS_DRAFT && $user->hasRight('projet', 'creer'))) {
 					print dolGetButtonAction('', $langs->trans('Delete'), 'delete', $_SERVER["PHP_SELF"].'?action=delete&token='.newToken().'&id='.$object->id, '');
 				} else {
-					print dolGetButtonAction($langs->trans('NotOwnerOfProject'), $langs->trans('Delete'), 'default', $_SERVER['PHP_SELF']. '#', '', false);
+					print dolGetButtonAction($langs->trans('NotOwnerOfProject'), $langs->trans('Delete'), 'default', $_SERVER['PHP_SELF'].'#', '', false);
 				}
 			}
 		}