+global\CommonObject::updateCommon()

Complexity

Conditions	11
Paths	90

Size

Total Lines	51
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
	public function updateCommon(User $user, $notrigger = false)
	{
		$error = 0;

		$fieldvalues = $this->set_save_query();
		unset($fieldvalues['rowid']);	// We don't update this field, it is the key to define which record to update.

		foreach ($fieldvalues as $k => $v) {
			if (is_array($key)){
				$i=array_search($k, $key);

The variable $key does not exist. Did you forget to declare it?

				if ( $i !== false) {
					$where[] = $key[$i].'=' . $this->quote($v, $this->fields[$k]);

$where was never initialized. Although not strictly required by PHP, it is generally a good practice to add $where = array(); before regardless.

					continue;
				}
			} else {
				if ( $k == $key) {
					$where[] = $k.'=' .$this->quote($v, $this->fields[$k]);

The variable $where does not seem to be defined for all execution paths leading up to this point.

					continue;
				}
			}
			$tmp[] = $k.'='.$this->quote($v, $this->fields[$k]);

$tmp was never initialized. Although not strictly required by PHP, it is generally a good practice to add $tmp = array(); before regardless.

		}
		$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element.' SET '.implode( ',', $tmp ).' WHERE rowid='.$this->id ;

The variable $tmp does not seem to be defined for all execution paths leading up to this point.

		$this->db->begin();
		if (! $error)
		{
			$res = $this->db->query($sql);
			if ($res===false)
			{
				$error++;
				$this->errors[] = $this->db->lasterror();
			}
		}

		if (! $error && ! $notrigger) {
			// Call triggers
			$result=$this->call_trigger(strtoupper(get_class($this)).'_MODIFY',$user);
			if ($result < 0) { $error++; } //Do also here what you must do to rollback action if trigger fail
			// End call triggers
		}

		// Commit or rollback
		if ($error) {
			$this->db->rollback();
			return -1;
		} else {
			$this->db->commit();
			return $this->id;
		}
	}