Dolibarr / dolibarr

htdocs/core/login/functions_http.php

Spacing +1 added lines, -1 removed lines

@@ -76,7 +76,7 @@
  */
 function decodeHttpBasicAuth($value)
 {
-	$encoded_basic_auth = substr($value, 6);	// Remove the "Basic " string
+	$encoded_basic_auth = substr($value, 6); // Remove the "Basic " string
 	$decoded_basic_auth = base64_decode($encoded_basic_auth);
 	$credentials_basic_auth = explode(':', $decoded_basic_auth);
 

htdocs/printing/admin/printing.php

Spacing +1 added lines, -1 removed lines

@@ -201,7 +201,7 @@
 			$i++;
 
 			if ($key['varname'] == 'PRINTGCP_TOKEN_ACCESS') {
-				$keyforprovider = '';	// @BUG This must be set
+				$keyforprovider = ''; // @BUG This must be set
 
 				// Token
 				print '<tr class="oddeven">';

htdocs/user/virtualcard.php

Spacing +2 added lines, -2 removed lines

@@ -288,7 +288,7 @@ 
 	print $langs->trans("Text");
 	print '</td><td>';
 	require_once DOL_DOCUMENT_ROOT.'/core/class/doleditor.class.php';
-	$extendededitor = 0;	// We force no WYSIWYG editor
+	$extendededitor = 0; // We force no WYSIWYG editor
 	$doleditor = new DolEditor('USER_PUBLIC_MORE', getDolUserString('USER_PUBLIC_MORE', '', $object), '', 160, 'dolibarr_notes', '', false, false, $extendededitor, ROWS_5, '90%');
 	$doleditor->Create();
 	print "</td></tr>\n";
@@ -302,7 +302,7 @@ 
 
 	print '<br>';
 
-	print '</div>';	// End hide/show
+	print '</div>'; // End hide/show
 
 	print '<br>';
 

dev/tools/dolibarr-postgres2mysql.php

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -61,7 +61,7 @@ 
  - If you're having problems creating your postgres dump, make sure you use "--format p --inserts"
  - Default output engine if not specified is InnoDB
 
-XHTML;
+xhtml;
 }
 
 /**
@@ -100,7 +100,7 @@ 
 function formatsize($s)
 {
 	if ($s < pow(2, 14)) {
-		return "{$s}B";
+		return "{$s}b";
 	} elseif ($s < pow(2, 20)) {
 		return sprintf("%.1f", round($s / 1024, 1)) . "K";
 	} elseif ($s < pow(2, 30)) {

Spacing +34 added lines, -34 removed lines

@@ -28,12 +28,12 @@ 
 
 $sapi_type = php_sapi_name();
 $script_file = basename(__FILE__);
-$path = dirname(__FILE__) . '/';
+$path = dirname(__FILE__).'/';
 
 // Test si mode batch
 $sapi_type = php_sapi_name();
 if (substr($sapi_type, 0, 3) == 'cgi') {
-	echo "Error: You are using PHP for CGI. To execute " . $script_file . " from command line, you must use PHP for CLI mode.\n";
+	echo "Error: You are using PHP for CGI. To execute ".$script_file." from command line, you must use PHP for CLI mode.\n";
 	exit();
 }
 
@@ -102,11 +102,11 @@ 
 	if ($s < pow(2, 14)) {
 		return "{$s}B";
 	} elseif ($s < pow(2, 20)) {
-		return sprintf("%.1f", round($s / 1024, 1)) . "K";
+		return sprintf("%.1f", round($s / 1024, 1))."K";
 	} elseif ($s < pow(2, 30)) {
-		return sprintf("%.1f", round($s / 1024 / 1024, 1)) . "M";
+		return sprintf("%.1f", round($s / 1024 / 1024, 1))."M";
 	} else {
-		return sprintf("%.1f", round($s / 1024 / 1024 / 1024, 1)) . "G";
+		return sprintf("%.1f", round($s / 1024 / 1024 / 1024, 1))."G";
 	}
 }
 
@@ -138,7 +138,7 @@ 
 	}
 
 	$fs = filesize($infilename);
-	echo "Filesize: " . formatsize($fs) . "\n";
+	echo "Filesize: ".formatsize($fs)."\n";
 
 	while ($instr = fgets($infp)) {
 		$linenum++;
@@ -215,13 +215,13 @@ 
 
 	fputs($outfp, "\n");
 
-	fputs($outfp, '/*!40101 SET SQL_MODE=@OLD_SQL_MODE */;' . "\n");
-	fputs($outfp, '/*!40014 SET FOREIGN_KEY_CHECKS=@OLD_FOREIGN_KEY_CHECKS */;' . "\n");
-	fputs($outfp, '/*!40014 SET UNIQUE_CHECKS=@OLD_UNIQUE_CHECKS */;' . "\n");
-	fputs($outfp, '/*!40101 SET CHARACTER_SET_CLIENT=@OLD_CHARACTER_SET_CLIENT */;' . "\n");
-	fputs($outfp, '/*!40101 SET CHARACTER_SET_RESULTS=@OLD_CHARACTER_SET_RESULTS */;' . "\n");
-	fputs($outfp, '/*!40101 SET COLLATION_CONNECTION=@OLD_COLLATION_CONNECTION */;' . "\n");
-	fputs($outfp, '/*!40111 SET SQL_NOTES=@OLD_SQL_NOTES */;' . "\n");
+	fputs($outfp, '/*!40101 SET SQL_MODE=@OLD_SQL_MODE */;'."\n");
+	fputs($outfp, '/*!40014 SET FOREIGN_KEY_CHECKS=@OLD_FOREIGN_KEY_CHECKS */;'."\n");
+	fputs($outfp, '/*!40014 SET UNIQUE_CHECKS=@OLD_UNIQUE_CHECKS */;'."\n");
+	fputs($outfp, '/*!40101 SET CHARACTER_SET_CLIENT=@OLD_CHARACTER_SET_CLIENT */;'."\n");
+	fputs($outfp, '/*!40101 SET CHARACTER_SET_RESULTS=@OLD_CHARACTER_SET_RESULTS */;'."\n");
+	fputs($outfp, '/*!40101 SET COLLATION_CONNECTION=@OLD_COLLATION_CONNECTION */;'."\n");
+	fputs($outfp, '/*!40111 SET SQL_NOTES=@OLD_SQL_NOTES */;'."\n");
 
 	printf("Completed! %9d lines   %9d sql chunks\n\n", $linenum, $chunkcount);
 
@@ -250,8 +250,8 @@ 
 	}
 
 	if ($header) {
-		$output = "-- Converted with " . PRODUCT . "-" . VERSION . "\n";
-		$output .= "-- Converted on " . date("r") . "\n";
+		$output = "-- Converted with ".PRODUCT."-".VERSION."\n";
+		$output .= "-- Converted on ".date("r")."\n";
 		$output .= "\n";
 
 		$output .= "/*!40101 SET @OLD_CHARACTER_SET_CLIENT=@@CHARACTER_SET_CLIENT */;\n";
@@ -282,8 +282,8 @@ 
 
 		$reg = array();
 		if (preg_match('/CREATE SEQUENCE (?:public\.)(.*)_(id|rowid|id_comment)_seq/', $line, $reg)) {
-			$outputatend .= '-- Make field ' . $reg[2] . ' auto_increment for table ' . $reg[1] . "\n";
-			$outputatend .= 'ALTER TABLE ' . $reg[1] . ' CHANGE COLUMN ' . $reg[2] . ' ' . $reg[2] . ' INTEGER NOT NULL AUTO_INCREMENT;' . "\n\n";
+			$outputatend .= '-- Make field '.$reg[2].' auto_increment for table '.$reg[1]."\n";
+			$outputatend .= 'ALTER TABLE '.$reg[1].' CHANGE COLUMN '.$reg[2].' '.$reg[2].' INTEGER NOT NULL AUTO_INCREMENT;'."\n\n";
 			// var_dump($outputatend);
 		}
 
@@ -299,7 +299,7 @@ 
 
 			$reg2 = array();
 			if (preg_match('/CREATE TABLE ([^\s]+)/', $line, $reg2)) {
-				$output .= 'DROP TABLE IF EXISTS `' . $reg2[1] . '`;' . "\n";
+				$output .= 'DROP TABLE IF EXISTS `'.$reg2[1].'`;'."\n";
 			}
 			$output .= $line;
 			$linenumber++;
@@ -379,7 +379,7 @@ 
 				$arrayofprimaryalreadyintabledef[$in_create_table] = $in_create_table;
 			}
 
-			$specialfields = array("repeat","status","type","call");
+			$specialfields = array("repeat", "status", "type", "call");
 
 			$field = getfieldname($line);
 			if (in_array($field, $specialfields)) {
@@ -398,7 +398,7 @@ 
 				$lastchr = substr($output, -2, 1);
 				// echo "lastchr=$lastchr";
 				if ($lastchr == ",") {
-					$output = substr($output, 0, -2) . "\n";
+					$output = substr($output, 0, -2)."\n";
 				}
 			}
 
@@ -423,7 +423,7 @@ 
 				$after = str_replace(" (E'", " ('", $after);
 				$after = str_replace(", E'", ", '", $after);
 
-				$output .= $before . " VALUES " . $after;
+				$output .= $before." VALUES ".$after;
 				$linenumber++;
 				continue;
 			} else {
@@ -451,7 +451,7 @@ 
 					$inquotes = false;
 				}
 
-				$output .= $before . " VALUES " . $after;
+				$output .= $before." VALUES ".$after;
 				do {
 					$linenumber++;
 
@@ -501,14 +501,14 @@ 
 						$output .= str_replace("\n", "", $pkey);
 						// the postgres and mysql syntax for this is (at least, in the example im looking at)
 						// identical, so we can just add it as is.
-						$output .= $line . "\n";
+						$output .= $line."\n";
 					} else {
-						$output .= '-- ' . str_replace("\n", "", $pkey);
-						$output .= '-- ' . $line . "\n";
+						$output .= '-- '.str_replace("\n", "", $pkey);
+						$output .= '-- '.$line."\n";
 					}
 				} else {
-					$output .= '-- ' . str_replace("\n", "", $pkey);
-					$output .= '-- ' . $line . "\n";
+					$output .= '-- '.str_replace("\n", "", $pkey);
+					$output .= '-- '.$line."\n";
 				}
 			}
 		}
@@ -522,7 +522,7 @@ 
 				$tablename = str_replace('public.', '', $matches[2]);
 				$columns = $matches[3];
 				if ($tablename && $columns) {
-					$output .= "ALTER TABLE `" . $tablename . "` ADD INDEX " . $indexname . "( {$columns} ) ;\n";
+					$output .= "ALTER TABLE `".$tablename."` ADD INDEX ".$indexname."( {$columns} ) ;\n";
 				}
 			}
 		}
@@ -534,7 +534,7 @@ 
 				$tablename = str_replace('public.', '', $matches[2]);
 				$columns = str_replace('"', '', $matches[3]);
 				if ($tablename && $columns) {
-					$output .= "ALTER TABLE `" . $tablename . "` ADD UNIQUE INDEX " . $indexname . " ( {$columns} ) ;\n";
+					$output .= "ALTER TABLE `".$tablename."` ADD UNIQUE INDEX ".$indexname." ( {$columns} ) ;\n";
 				}
 			}
 		}
@@ -565,16 +565,16 @@ 
 			if ($line == "\\.\n") {
 				$in_insert = false;
 				if ($values) {
-					$output .= "INSERT INTO $heads VALUES\n" . implode(",\n", $values) . ";\n\n";
+					$output .= "INSERT INTO $heads VALUES\n".implode(",\n", $values).";\n\n";
 				}
 			} else {
 				$vals = explode('	', $line);
 				foreach ($vals as $i => $val) {
-					$vals[$i] = ($val == '\\N') ? 'NULL' : "'" . str_replace("'", "\\'", trim($val)) . "'";
+					$vals[$i] = ($val == '\\N') ? 'NULL' : "'".str_replace("'", "\\'", trim($val))."'";
 				}
-				$values[] = '(' . implode(',', $vals) . ')';
+				$values[] = '('.implode(',', $vals).')';
 				if (count($values) >= 1000) {
-					$output .= "INSERT INTO $heads VALUES\n" . implode(",\n", $values) . ";\n";
+					$output .= "INSERT INTO $heads VALUES\n".implode(",\n", $values).";\n";
 					$values = array();
 				}
 			}
@@ -583,5 +583,5 @@ 
 		$linenumber++;
 	}
 
-	return array('output' => $output,'outputatend' => $outputatend);
+	return array('output' => $output, 'outputatend' => $outputatend);
 }

dev/tools/test/namespacemig/bbb.class.php

Spacing +3 added lines, -3 removed lines

@@ -18,7 +18,7 @@ 
  */
 class Bbb
 {
-	const BBB='bbb';
+	const BBB = 'bbb';
 
 	/**
 	 * do
@@ -29,7 +29,7 @@ 
 	{
 		global $globalaaa, $globalbbb;
 		echo 'dobbb'."\n";
-		$globalaaa.='+bbb';
-		$globalbbb.='+bbb';
+		$globalaaa .= '+bbb';
+		$globalbbb .= '+bbb';
 	}
 }

Braces +3 added lines, -1 removed lines

@@ -25,9 +25,11 @@
 	 *
 	 * @return void
 	 */
-	public function do()
+	public function do {
+		()
 	{
 		global $globalaaa, $globalbbb;
+	}
 		echo 'dobbb'."\n";
 		$globalaaa.='+bbb';
 		$globalbbb.='+bbb';

dev/tools/test/namespacemig/aaa.class.php

Spacing +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
  */
 class Aaa
 {
-	const AAA='aaa';
+	const AAA = 'aaa';
 
 	/**
 	 * do

Braces +3 added lines, -1 removed lines

@@ -27,8 +27,10 @@
 	 *
 	 * @return void
 	 */
-	public function do()
+	public function do {
+		()
 	{
 		echo 'doaaa'."\n";
 	}
+	}
 }

dev/tools/test/testtcpdf.php

Spacing +5 added lines, -5 removed lines

@@ -65,11 +65,11 @@
  - To convert pfx certificate to pem: openssl pkcs12 -in tcpdf.pfx -out tcpdf.crt -nodes
 
 */
-$permissions=array('copy');
-$user_pass='aaa';
-$owner_pass=null;
-$mode=0;
-$pubkeys=null;
+$permissions = array('copy');
+$user_pass = 'aaa';
+$owner_pass = null;
+$mode = 0;
+$pubkeys = null;
 $pdf->SetProtection($permissions, $user_pass, $owner_pass, $mode, $pubkeys);
 
 // Example with public-key

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -123,7 +123,7 @@
 Encryption Example
 
 Consult the source code documentation for the SetProtection() method.
-EOD;
+eod;
 
 // print a block of text using Write()
 $pdf->Write(0, $txt, '', 0, 'L', true, 0, false, false, 0);

dev/translation/autotranslator.php

Spacing +10 added lines, -10 removed lines

@@ -28,7 +28,7 @@ 
 
 $sapi_type = php_sapi_name();
 $script_file = basename(__FILE__);
-$path=dirname(__FILE__).'/';
+$path = dirname(__FILE__).'/';
 
 // Test if batch mode
 if (substr($sapi_type, 0, 3) == 'cgi') {
@@ -45,17 +45,17 @@ 
 $langs->load("main");
 
 // Global variables
-$version='1.14';
-$error=0;
+$version = '1.14';
+$error = 0;
 
 
 // -------------------- START OF YOUR CODE HERE --------------------
 @set_time_limit(0);
 print "***** ".$script_file." (".$version.") *****\n";
-$dir=DOL_DOCUMENT_ROOT."/langs";
+$dir = DOL_DOCUMENT_ROOT."/langs";
 
 // Check parameters
-if (! isset($argv[3])) {
+if (!isset($argv[3])) {
 	print "Usage:   ".$script_file."  lang_code_src lang_code_dest|all APIKEY [langfile.lang]\n";
 	print "Example: ".$script_file."  en_US         pt_PT              123456\n";
 	print "Rem:     lang_code to use can be found on https://translate.google.com\n";
@@ -66,18 +66,18 @@ 
 print 'Argument 1='.$argv[1]."\n";
 print 'Argument 2='.$argv[2]."\n";
 print 'Argument 3='.$argv[3]."\n";
-$file='';
+$file = '';
 if (isset($argv[4])) {
-	$file=$argv[4];
+	$file = $argv[4];
 	print 'Argument 4='.$argv[4]."\n";
 }
 print 'Files will be generated/updated in directory '.$dir."\n";
 
 if ($argv[2] != 'all') {
-	if (! is_dir($dir.'/'.$argv[2])) {
+	if (!is_dir($dir.'/'.$argv[2])) {
 		print 'Create directory '.$dir.'/'.$argv[2]."\n";
-		$result=mkdir($dir.'/'.$argv[2]);
-		if (! $result) {
+		$result = mkdir($dir.'/'.$argv[2]);
+		if (!$result) {
 			$db->close();
 			return -1;
 		}

dev/initdata/generate-thirdparty.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -105,7 +105,7 @@
 
 print "Generates ".GEN_NUMBER_SOCIETE." companies\n";
 for ($s = 0; $s < GEN_NUMBER_SOCIETE; $s++) {
-	print "Company $s\n";
+	print "company $s\n";
 	$soc = new Societe($db);
 	$soc->name = "Company num ".time()."$s";
 	$soc->town = $listoftown[mt_rand(0, count($listoftown)-1)];

Spacing +21 added lines, -21 removed lines

@@ -26,7 +26,7 @@ 
 
 $sapi_type = php_sapi_name();
 $script_file = basename(__FILE__);
-$path=dirname(__FILE__).'/';
+$path = dirname(__FILE__).'/';
 
 // Test si mode batch
 $sapi_type = php_sapi_name();
@@ -37,7 +37,7 @@ 
 
 // Recupere root dolibarr
 //$path=preg_replace('/generate-societe.php/i','',$_SERVER["PHP_SELF"]);
-require __DIR__. '/../../htdocs/master.inc.php';
+require __DIR__.'/../../htdocs/master.inc.php';
 include_once DOL_DOCUMENT_ROOT.'/societe/class/societe.class.php';
 include_once DOL_DOCUMENT_ROOT.'/contact/class/contact.class.php';
 include_once DOL_DOCUMENT_ROOT.'/compta/facture/class/facture.class.php';
@@ -45,8 +45,8 @@ 
 include_once DOL_DOCUMENT_ROOT.'/compta/paiement/class/paiement.class.php';
 include_once DOL_DOCUMENT_ROOT.'/contrat/class/contrat.class.php';
 
-$listoftown = array("Auray","Baden","Vannes","Pirouville","Haguenau","Souffelweiersheim","Illkirch-Graffenstaden","Lauterbourg","Picauville","Sainte-Mère Eglise","Le Bono");
-$listoflastname = array("Joe","Marc","Steve","Laurent","Nico","Isabelle","Dorothee","Saby","Brigitte","Karine","Jose-Anne","Celine","Virginie");
+$listoftown = array("Auray", "Baden", "Vannes", "Pirouville", "Haguenau", "Souffelweiersheim", "Illkirch-Graffenstaden", "Lauterbourg", "Picauville", "Sainte-Mère Eglise", "Le Bono");
+$listoflastname = array("Joe", "Marc", "Steve", "Laurent", "Nico", "Isabelle", "Dorothee", "Saby", "Brigitte", "Karine", "Jose-Anne", "Celine", "Virginie");
 
 
 /*
@@ -56,8 +56,8 @@ 
 define('GEN_NUMBER_SOCIETE', $argv[1] ?? 10);
 
 
-$ret=$user->fetch('', 'admin');
-if (! $ret > 0) {
+$ret = $user->fetch('', 'admin');
+if (!$ret > 0) {
 	print 'A user with login "admin" and all permissions must be created to use this script.'."\n";
 	exit;
 }
@@ -65,7 +65,7 @@ 
 
 
 $sql = "SELECT rowid FROM ".MAIN_DB_PREFIX."product"; $productsid = array();
-$resql=$db->query($sql);
+$resql = $db->query($sql);
 if ($resql) {
 	$num = $db->num_rows($resql);
 	$i = 0;
@@ -77,7 +77,7 @@ 
 }
 
 $sql = "SELECT rowid FROM ".MAIN_DB_PREFIX."societe"; $societesid = array();
-$resql=$db->query($sql);
+$resql = $db->query($sql);
 if ($resql) {
 	$num = $db->num_rows($resql);
 	$i = 0;
@@ -91,7 +91,7 @@ 
 }
 
 $sql = "SELECT rowid FROM ".MAIN_DB_PREFIX."commande"; $commandesid = array();
-$resql=$db->query($sql);
+$resql = $db->query($sql);
 if ($resql) {
 	$num = $db->num_rows($resql);
 	$i = 0;
@@ -111,18 +111,18 @@ 
 	print "Company $s\n";
 	$soc = new Societe($db);
 	$soc->name = "Company num ".time()."$s";
-	$soc->town = $listoftown[mt_rand(0, count($listoftown)-1)];
-	$soc->client = mt_rand(1, 2);		// Une societe sur 2 est prospect, l'autre client
-	$soc->fournisseur = mt_rand(0, 1);	// Une societe sur 2 est fournisseur
-	$soc->code_client='CU'.time()."$s";
-	$soc->code_fournisseur='SU'.time()."$s";
-	$soc->tva_assuj=1;
-	$soc->country_id=1;
-	$soc->country_code='FR';
+	$soc->town = $listoftown[mt_rand(0, count($listoftown) - 1)];
+	$soc->client = mt_rand(1, 2); // Une societe sur 2 est prospect, l'autre client
+	$soc->fournisseur = mt_rand(0, 1); // Une societe sur 2 est fournisseur
+	$soc->code_client = 'CU'.time()."$s";
+	$soc->code_fournisseur = 'SU'.time()."$s";
+	$soc->tva_assuj = 1;
+	$soc->country_id = 1;
+	$soc->country_code = 'FR';
 	// Un client sur 3 a une remise de 5%
-	$user_remise=mt_rand(1, 3);
-	if ($user_remise==3) {
-		$soc->remise_percent=5;
+	$user_remise = mt_rand(1, 3);
+	if ($user_remise == 3) {
+		$soc->remise_percent = 5;
 	}
 	print "> client=".$soc->client.", fournisseur=".$soc->fournisseur.", remise=".$soc->remise_percent."\n";
 	$soc->note_private = 'Company created by the script generate-societe.php';
@@ -135,7 +135,7 @@ 
 			$contact = new Contact($db);
 			$contact->socid = $soc->id;
 			$contact->lastname = "Lastname".$c;
-			$contact->firstname = $listoflastname[mt_rand(0, count($listoflastname)-1)];
+			$contact->firstname = $listoflastname[mt_rand(0, count($listoflastname) - 1)];
 			if ($contact->create($user)) {
 			}
 		}