| Conditions | 27 |
| Paths | > 20000 |
| Total Lines | 124 |
| Code Lines | 79 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 119 | public function toVCalendar($calid, $obj) |
||
| 120 | { |
||
| 121 | /*$categ = array(); |
||
| 122 | if($obj->soc_client) |
||
| 123 | { |
||
| 124 | $nick[] = $obj->soc_code_client; |
||
| 125 | $categ[] = $this->langs->transnoentitiesnoconv('Customer'); |
||
| 126 | }*/ |
||
| 127 | |||
| 128 | $location = $obj->location; |
||
| 129 | |||
| 130 | // contact address |
||
| 131 | if (empty($location) && !empty($obj->address)) { |
||
| 132 | $location = trim(str_replace(array("\r", "\t", "\n"), ' ', $obj->address)); |
||
| 133 | $location = trim($location.', '.$obj->zip); |
||
| 134 | $location = trim($location.' '.$obj->town); |
||
| 135 | $location = trim($location.', '.$obj->country_label); |
||
| 136 | } |
||
| 137 | |||
| 138 | // contact address |
||
| 139 | if (empty($location) && !empty($obj->soc_address)) { |
||
| 140 | $location = trim(str_replace(array("\r", "\t", "\n"), ' ', $obj->soc_address)); |
||
| 141 | $location = trim($location.', '.$obj->soc_zip); |
||
| 142 | $location = trim($location.' '.$obj->soc_town); |
||
| 143 | $location = trim($location.', '.$obj->soc_country_label); |
||
| 144 | } |
||
| 145 | |||
| 146 | /* |
||
| 147 | $address = explode("\n", $obj->address, 2); |
||
| 148 | foreach ($address as $kAddr => $vAddr) { |
||
| 149 | $address[$kAddr] = trim(str_replace(array("\r", "\t"), ' ', str_replace("\n", ' | ', trim($vAddr)))); |
||
| 150 | } |
||
| 151 | $address[] = ''; |
||
| 152 | $address[] = ''; |
||
| 153 | */ |
||
| 154 | |||
| 155 | if ($obj->percent == -1 && trim($obj->datep) != '') { |
||
| 156 | $type = 'VEVENT'; |
||
| 157 | } else { |
||
| 158 | $type = 'VTODO'; |
||
| 159 | } |
||
| 160 | |||
| 161 | $timezone = date_default_timezone_get(); |
||
| 162 | |||
| 163 | $caldata = "BEGIN:VCALENDAR\n"; |
||
| 164 | $caldata .= "VERSION:2.0\n"; |
||
| 165 | $caldata .= "METHOD:PUBLISH\n"; |
||
| 166 | $caldata .= "PRODID:-//Dolibarr CDav//FR\n"; |
||
| 167 | $caldata .= "BEGIN:".$type."\n"; |
||
| 168 | $caldata .= "CREATED:".gmdate('Ymd\THis', strtotime($obj->datec))."Z\n"; |
||
| 169 | $caldata .= "LAST-MODIFIED:".gmdate('Ymd\THis', strtotime($obj->lastupd))."Z\n"; |
||
| 170 | $caldata .= "DTSTAMP:".gmdate('Ymd\THis', strtotime($obj->lastupd))."Z\n"; |
||
| 171 | if ($obj->sourceuid == '') { |
||
| 172 | $caldata .= "UID:".$obj->id.'-ev-'.$calid.'-cal-'.constant('CDAV_URI_KEY')."\n"; |
||
| 173 | } else { |
||
| 174 | $caldata .= "UID:".$obj->sourceuid."\n"; |
||
| 175 | } |
||
| 176 | $caldata .= "SUMMARY:".$obj->label."\n"; |
||
| 177 | $caldata .= "LOCATION:".$location."\n"; |
||
| 178 | $caldata .= "PRIORITY:".$obj->priority."\n"; |
||
| 179 | if ($obj->fulldayevent) { |
||
| 180 | $caldata .= "DTSTART;VALUE=DATE:".date('Ymd', strtotime($obj->datep))."\n"; |
||
| 181 | if ($type == 'VEVENT') { |
||
| 182 | if (trim($obj->datep2) != '') { |
||
| 183 | $caldata .= "DTEND;VALUE=DATE:".date('Ymd', strtotime($obj->datep2) + 1)."\n"; |
||
| 184 | } else { |
||
| 185 | $caldata .= "DTEND;VALUE=DATE:".date('Ymd', strtotime($obj->datep) + (25 * 3600))."\n"; |
||
| 186 | } |
||
| 187 | } elseif (trim($obj->datep2) != '') { |
||
| 188 | $caldata .= "DUE;VALUE=DATE:".date('Ymd', strtotime($obj->datep2) + 1)."\n"; |
||
| 189 | } |
||
| 190 | } else { |
||
| 191 | $caldata .= "DTSTART;TZID=".$timezone.":".strtr($obj->datep, array(" "=>"T", ":"=>"", "-"=>""))."\n"; |
||
| 192 | if ($type == 'VEVENT') { |
||
| 193 | if (trim($obj->datep2) != '') { |
||
| 194 | $caldata .= "DTEND;TZID=".$timezone.":".strtr($obj->datep2, array(" "=>"T", ":"=>"", "-"=>""))."\n"; |
||
| 195 | } else { |
||
| 196 | $caldata .= "DTEND;TZID=".$timezone.":".strtr($obj->datep, array(" "=>"T", ":"=>"", "-"=>""))."\n"; |
||
| 197 | } |
||
| 198 | } elseif (trim($obj->datep2) != '') { |
||
| 199 | $caldata .= "DUE;TZID=".$timezone.":".strtr($obj->datep2, array(" "=>"T", ":"=>"", "-"=>""))."\n"; |
||
| 200 | } |
||
| 201 | } |
||
| 202 | $caldata .= "CLASS:PUBLIC\n"; |
||
| 203 | if ($obj->transparency == 1) { |
||
| 204 | $caldata .= "TRANSP:TRANSPARENT\n"; |
||
| 205 | } else { |
||
| 206 | $caldata .= "TRANSP:OPAQUE\n"; |
||
| 207 | } |
||
| 208 | |||
| 209 | if ($type == 'VEVENT') { |
||
| 210 | $caldata .= "STATUS:CONFIRMED\n"; |
||
| 211 | } elseif ($obj->percent == 0) { |
||
| 212 | $caldata .= "STATUS:NEEDS-ACTION\n"; |
||
| 213 | } elseif ($obj->percent == 100) { |
||
| 214 | $caldata .= "STATUS:COMPLETED\n"; |
||
| 215 | } else { |
||
| 216 | $caldata .= "STATUS:IN-PROCESS\n"; |
||
| 217 | $caldata .= "PERCENT-COMPLETE:".$obj->percent."\n"; |
||
| 218 | } |
||
| 219 | |||
| 220 | $caldata .= "DESCRIPTION:"; |
||
| 221 | $caldata .= strtr($obj->note, array("\n"=>"\\n", "\r"=>"")); |
||
| 222 | if (!empty($obj->soc_nom)) { |
||
| 223 | $caldata .= "\\n*DOLIBARR-SOC: ".$obj->soc_nom; |
||
| 224 | } |
||
| 225 | if (!empty($obj->soc_phone)) { |
||
| 226 | $caldata .= "\\n*DOLIBARR-SOC-TEL: ".$obj->soc_phone; |
||
| 227 | } |
||
| 228 | if (!empty($obj->firstname) || !empty($obj->lastname)) { |
||
| 229 | $caldata .= "\\n*DOLIBARR-CTC: ".trim($obj->firstname.' '.$obj->lastname); |
||
| 230 | } |
||
| 231 | if (!empty($obj->phone) || !empty($obj->phone_perso) || !empty($obj->phone_mobile)) { |
||
| 232 | $caldata .= "\\n*DOLIBARR-CTC-TEL: ".trim($obj->phone.' '.$obj->phone_perso.' '.$obj->phone_mobile); |
||
| 233 | } |
||
| 234 | if (strpos($obj->other_users, ',')) { // several |
||
| 235 | $caldata .= "\\n*DOLIBARR-USR: ".$obj->other_users; |
||
| 236 | } |
||
| 237 | $caldata .= "\n"; |
||
| 238 | |||
| 239 | $caldata .= "END:".$type."\n"; |
||
| 240 | $caldata .= "END:VCALENDAR\n"; |
||
| 241 | |||
| 242 | return $caldata; |
||
| 243 | } |
||
| 299 |