Inspection of "Daily Inspection: Better structure of payment page..." - Dolibarr/dolibarr - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop (bd76a0)

unknown

created 2024-03-20 16:49 UTC

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -134,15 +134,15 @@  discard block
 block discarded – undo
 
 		foreach ($object->multilangs as $key => $value) { // enregistrement des nouvelles valeurs dans l'objet
 			if ($key == $current_lang) {
-				$object->label = GETPOST("libelle-" . $key);
-				$object->description = dol_htmlcleanlastbr(GETPOST("desc-" . $key, 'restricthtml'));
-				$object->other = dol_htmlcleanlastbr(GETPOST("other-" . $key, 'restricthtml'));
+				$object->label = GETPOST("libelle-".$key);
+				$object->description = dol_htmlcleanlastbr(GETPOST("desc-".$key, 'restricthtml'));
+				$object->other = dol_htmlcleanlastbr(GETPOST("other-".$key, 'restricthtml'));
 
 				$object->update($object->id, $user);
 			} else {
-				$object->multilangs[$key]["label"] = GETPOST("libelle-" . $key);
-				$object->multilangs[$key]["description"] = dol_htmlcleanlastbr(GETPOST("desc-" . $key, 'restricthtml'));
-				$object->multilangs[$key]["other"] = dol_htmlcleanlastbr(GETPOST("other-" . $key, 'restricthtml'));
+				$object->multilangs[$key]["label"] = GETPOST("libelle-".$key);
+				$object->multilangs[$key]["description"] = dol_htmlcleanlastbr(GETPOST("desc-".$key, 'restricthtml'));
+				$object->multilangs[$key]["other"] = dol_htmlcleanlastbr(GETPOST("other-".$key, 'restricthtml'));
 			}
 		}
 
@@ -235,9 +235,9 @@  discard block
 block discarded – undo
 if (empty($reshook)) {
 	if ($action == '') {
 		if ($user->hasRight('produit', 'creer') || $user->hasRight('service', 'creer')) {
-			print '<a class="butAction" href="' . DOL_URL_ROOT . '/product/traduction.php?action=add&token='.newToken().'&id=' . $object->id . '">' . $langs->trans("Add") . '</a>';
+			print '<a class="butAction" href="'.DOL_URL_ROOT.'/product/traduction.php?action=add&token='.newToken().'&id='.$object->id.'">'.$langs->trans("Add").'</a>';
 			if ($cnt_trans > 0) {
-				print '<a class="butAction" href="' . DOL_URL_ROOT . '/product/traduction.php?action=edit&token='.newToken().'&id=' . $object->id . '">' . $langs->trans("Modify") . '</a>';
+				print '<a class="butAction" href="'.DOL_URL_ROOT.'/product/traduction.php?action=edit&token='.newToken().'&id='.$object->id.'">'.$langs->trans("Modify").'</a>';
 			}
 		}
 	}

Please login to merge, or discard this patch.

htdocs/product/dynamic_price/class/price_parser.class.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -155,7 +155,7 @@
 block discarded – undo
 		));
 
 		// Retrieve all extrafields if not already not know (should not happen)
-		if (! is_object($extrafields)) {
+		if (!is_object($extrafields)) {
 			$extrafields = new ExtraFields($this->db);
 			$extrafields->fetch_name_optionals_label($product->table_element);
 		}

Please login to merge, or discard this patch.

htdocs/product/stats/facture_fournisseur.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -246,7 +246,7 @@
 block discarded – undo
 						$supplierinvoicestatic->id = $objp->facid;
 						$supplierinvoicestatic->ref = $objp->ref;
 						$supplierinvoicestatic->ref_supplier = $objp->ref_supplier;
-						$supplierinvoicestatic->libelle = $objp->label;	// deprecated
+						$supplierinvoicestatic->libelle = $objp->label; // deprecated
 						$supplierinvoicestatic->label = $objp->label;
 						$supplierinvoicestatic->total_ht = $objp->total_ht;
 						$supplierinvoicestatic->total_ttc = $objp->total_ttc;

Please login to merge, or discard this patch.

doctemplates/websites/website_template-noimg/containers/manifest.json.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -1,6 +1,6 @@
 block discarded – undo
 <?php // BEGIN PHP
-$websitekey=basename(__DIR__);
-if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) { require_once __DIR__.'/master.inc.php'; } // Load env if not already loaded
+$websitekey = basename(__DIR__);
+if (!defined('USEDOLIBARRSERVER') && !defined('USEDOLIBARREDITOR')) { require_once __DIR__.'/master.inc.php'; } // Load env if not already loaded
 require_once DOL_DOCUMENT_ROOT.'/core/lib/website.lib.php';
 require_once DOL_DOCUMENT_ROOT.'/core/website.inc.php';
 ob_start();

Please login to merge, or discard this patch.

doctemplates/websites/website_template-noimg/containers/master.inc.php 2 patches

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -1,6 +1,6 @@
 block discarded – undo
 <?php
 // File generated to link to the master file - DO NOT MODIFY - It is just an include
-if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) {
-	if (! defined('USEEXTERNALSERVER')) define('USEEXTERNALSERVER', 1);
+if (!defined('USEDOLIBARRSERVER') && !defined('USEDOLIBARREDITOR')) {
+	if (!defined('USEEXTERNALSERVER')) define('USEEXTERNALSERVER', 1);
 	require_once '/var/www/html/dolibarr_dev/htdocs/master.inc.php';
 }

Please login to merge, or discard this patch.

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,6 +1,8 @@
 block discarded – undo
 <?php
 // File generated to link to the master file - DO NOT MODIFY - It is just an include
 if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) {
-	if (! defined('USEEXTERNALSERVER')) define('USEEXTERNALSERVER', 1);
+	if (! defined('USEEXTERNALSERVER')) {
+		define('USEEXTERNALSERVER', 1);
+	}
 	require_once '/var/www/html/dolibarr_dev/htdocs/master.inc.php';
 }

Please login to merge, or discard this patch.

doctemplates/websites/website_template-noimg/containers/styles.css.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -1,10 +1,10 @@
 block discarded – undo
 <?php // BEGIN PHP
-$websitekey=basename(__DIR__);
-if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) { require_once __DIR__.'/master.inc.php'; } // Load env if not already loaded
+$websitekey = basename(__DIR__);
+if (!defined('USEDOLIBARRSERVER') && !defined('USEDOLIBARREDITOR')) { require_once __DIR__.'/master.inc.php'; } // Load env if not already loaded
 require_once DOL_DOCUMENT_ROOT.'/core/lib/website.lib.php';
 require_once DOL_DOCUMENT_ROOT.'/core/website.inc.php';
 ob_start();
-if (! headers_sent()) {	/* because file is included inline when in edit mode and we don't want warning */
+if (!headers_sent()) {	/* because file is included inline when in edit mode and we don't want warning */
 	header('Cache-Control: max-age=3600, public, must-revalidate');
 	header('Content-type: text/css');
 }

Please login to merge, or discard this patch.

doctemplates/websites/website_template-restaurant/containers/master.inc.php 3 patches

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -1,7 +1,7 @@
 block discarded – undo
 <?php
 // File generated to link to the master file - DO NOT MODIFY - It is just an include
 if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) {
-    if (! defined('USEEXTERNALSERVER')) define('USEEXTERNALSERVER', 1);
-    require_once '/home/ldestailleur/git/dolibarr_dev/htdocs/master.inc.php';
+	if (! defined('USEEXTERNALSERVER')) define('USEEXTERNALSERVER', 1);
+	require_once '/home/ldestailleur/git/dolibarr_dev/htdocs/master.inc.php';
 }
 ?>

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -1,7 +1,7 @@
 block discarded – undo
 <?php
 // File generated to link to the master file - DO NOT MODIFY - It is just an include
-if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) {
-    if (! defined('USEEXTERNALSERVER')) define('USEEXTERNALSERVER', 1);
+if (!defined('USEDOLIBARRSERVER') && !defined('USEDOLIBARREDITOR')) {
+    if (!defined('USEEXTERNALSERVER')) define('USEEXTERNALSERVER', 1);
     require_once '/home/ldestailleur/git/dolibarr_dev/htdocs/master.inc.php';
 }
 ?>

Please login to merge, or discard this patch.

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,7 +1,9 @@
 block discarded – undo
 <?php
 // File generated to link to the master file - DO NOT MODIFY - It is just an include
 if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) {
-    if (! defined('USEEXTERNALSERVER')) define('USEEXTERNALSERVER', 1);
+    if (! defined('USEEXTERNALSERVER')) {
+    	define('USEEXTERNALSERVER', 1);
+    }
     require_once '/home/ldestailleur/git/dolibarr_dev/htdocs/master.inc.php';
 }
 ?>

Please login to merge, or discard this patch.

doctemplates/websites/website_template-restaurant/containers/styles.css.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -1,10 +1,10 @@
 block discarded – undo
 <?php // BEGIN PHP
-$websitekey=basename(__DIR__);
-if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) { require_once __DIR__.'/master.inc.php'; } // Load env if not already loaded
+$websitekey = basename(__DIR__);
+if (!defined('USEDOLIBARRSERVER') && !defined('USEDOLIBARREDITOR')) { require_once __DIR__.'/master.inc.php'; } // Load env if not already loaded
 require_once DOL_DOCUMENT_ROOT.'/core/lib/website.lib.php';
 require_once DOL_DOCUMENT_ROOT.'/core/website.inc.php';
 ob_start();
-if (! headers_sent()) {	/* because file is included inline when in edit mode and we don't want warning */ 
+if (!headers_sent()) {	/* because file is included inline when in edit mode and we don't want warning */ 
 header('Cache-Control: max-age=3600, public, must-revalidate');
 header('Content-type: text/css');
 }

Please login to merge, or discard this patch.

doctemplates/websites/website_template-stellar/containers/master.inc.php 2 patches

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -1,6 +1,6 @@
 block discarded – undo
 <?php
 // File generated to link to the master file - DO NOT MODIFY - It is just an include
-if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) {
-	if (! defined('USEEXTERNALSERVER')) define('USEEXTERNALSERVER', 1);
+if (!defined('USEDOLIBARRSERVER') && !defined('USEDOLIBARREDITOR')) {
+	if (!defined('USEEXTERNALSERVER')) define('USEEXTERNALSERVER', 1);
 	require_once '/home/ldestailleur/git/dolibarr_dev/htdocs/master.inc.php';
 }

Please login to merge, or discard this patch.

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,6 +1,8 @@
 block discarded – undo
 <?php
 // File generated to link to the master file - DO NOT MODIFY - It is just an include
 if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) {
-	if (! defined('USEEXTERNALSERVER')) define('USEEXTERNALSERVER', 1);
+	if (! defined('USEEXTERNALSERVER')) {
+		define('USEEXTERNALSERVER', 1);
+	}
 	require_once '/home/ldestailleur/git/dolibarr_dev/htdocs/master.inc.php';
 }

Please login to merge, or discard this patch.

		@@ -134,15 +134,15 @@ discard block
		block discarded – undo
134	134
135	135	foreach ($object->multilangs as $key => $value) { // enregistrement des nouvelles valeurs dans l'objet
136	136	if ($key == $current_lang) {
137		- $object->label = GETPOST("libelle-" . $key);
138		- $object->description = dol_htmlcleanlastbr(GETPOST("desc-" . $key, 'restricthtml'));
139		- $object->other = dol_htmlcleanlastbr(GETPOST("other-" . $key, 'restricthtml'));
	137	+ $object->label = GETPOST("libelle-".$key);
	138	+ $object->description = dol_htmlcleanlastbr(GETPOST("desc-".$key, 'restricthtml'));
	139	+ $object->other = dol_htmlcleanlastbr(GETPOST("other-".$key, 'restricthtml'));
140	140
141	141	$object->update($object->id, $user);
142	142	} else {
143		- $object->multilangs[$key]["label"] = GETPOST("libelle-" . $key);
144		- $object->multilangs[$key]["description"] = dol_htmlcleanlastbr(GETPOST("desc-" . $key, 'restricthtml'));
145		- $object->multilangs[$key]["other"] = dol_htmlcleanlastbr(GETPOST("other-" . $key, 'restricthtml'));
	143	+ $object->multilangs[$key]["label"] = GETPOST("libelle-".$key);
	144	+ $object->multilangs[$key]["description"] = dol_htmlcleanlastbr(GETPOST("desc-".$key, 'restricthtml'));
	145	+ $object->multilangs[$key]["other"] = dol_htmlcleanlastbr(GETPOST("other-".$key, 'restricthtml'));
146	146	}
147	147	}
148	148
		@@ -235,9 +235,9 @@ discard block
		block discarded – undo
235	235	if (empty($reshook)) {
236	236	if ($action == '') {
237	237	if ($user->hasRight('produit', 'creer') \|\| $user->hasRight('service', 'creer')) {
238		- print '<a class="butAction" href="' . DOL_URL_ROOT . '/product/traduction.php?action=add&token='.newToken().'&id=' . $object->id . '">' . $langs->trans("Add") . '</a>';
	238	+ print '<a class="butAction" href="'.DOL_URL_ROOT.'/product/traduction.php?action=add&token='.newToken().'&id='.$object->id.'">'.$langs->trans("Add").'</a>';
239	239	if ($cnt_trans > 0) {
240		- print '<a class="butAction" href="' . DOL_URL_ROOT . '/product/traduction.php?action=edit&token='.newToken().'&id=' . $object->id . '">' . $langs->trans("Modify") . '</a>';
	240	+ print '<a class="butAction" href="'.DOL_URL_ROOT.'/product/traduction.php?action=edit&token='.newToken().'&id='.$object->id.'">'.$langs->trans("Modify").'</a>';
241	241	}
242	242	}
243	243	}

		@@ -155,7 +155,7 @@
		block discarded – undo
155	155	));
156	156
157	157	// Retrieve all extrafields if not already not know (should not happen)
158		- if (! is_object($extrafields)) {
	158	+ if (!is_object($extrafields)) {
159	159	$extrafields = new ExtraFields($this->db);
160	160	$extrafields->fetch_name_optionals_label($product->table_element);
161	161	}

		@@ -246,7 +246,7 @@
		block discarded – undo
246	246	$supplierinvoicestatic->id = $objp->facid;
247	247	$supplierinvoicestatic->ref = $objp->ref;
248	248	$supplierinvoicestatic->ref_supplier = $objp->ref_supplier;
249		- $supplierinvoicestatic->libelle = $objp->label; // deprecated
	249	+ $supplierinvoicestatic->libelle = $objp->label; // deprecated
250	250	$supplierinvoicestatic->label = $objp->label;
251	251	$supplierinvoicestatic->total_ht = $objp->total_ht;
252	252	$supplierinvoicestatic->total_ttc = $objp->total_ttc;

		@@ -1,6 +1,6 @@
		block discarded – undo
1	1	<?php // BEGIN PHP
2		-$websitekey=basename(__DIR__);
3		-if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) { require_once __DIR__.'/master.inc.php'; } // Load env if not already loaded
	2	+$websitekey = basename(__DIR__);
	3	+if (!defined('USEDOLIBARRSERVER') && !defined('USEDOLIBARREDITOR')) { require_once __DIR__.'/master.inc.php'; } // Load env if not already loaded
4	4	require_once DOL_DOCUMENT_ROOT.'/core/lib/website.lib.php';
5	5	require_once DOL_DOCUMENT_ROOT.'/core/website.inc.php';
6	6	ob_start();

		@@ -1,6 +1,6 @@
		block discarded – undo
1	1	<?php
2	2	// File generated to link to the master file - DO NOT MODIFY - It is just an include
3		-if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) {
4		- if (! defined('USEEXTERNALSERVER')) define('USEEXTERNALSERVER', 1);
	3	+if (!defined('USEDOLIBARRSERVER') && !defined('USEDOLIBARREDITOR')) {
	4	+ if (!defined('USEEXTERNALSERVER')) define('USEEXTERNALSERVER', 1);
5	5	require_once '/var/www/html/dolibarr_dev/htdocs/master.inc.php';
6	6	}

		@@ -1,6 +1,8 @@
		block discarded – undo
1	1	<?php
2	2	// File generated to link to the master file - DO NOT MODIFY - It is just an include
3	3	if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) {
4		- if (! defined('USEEXTERNALSERVER')) define('USEEXTERNALSERVER', 1);
	4	+ if (! defined('USEEXTERNALSERVER')) {
	5	+ define('USEEXTERNALSERVER', 1);
	6	+ }
5	7	require_once '/var/www/html/dolibarr_dev/htdocs/master.inc.php';
6	8	}

		@@ -1,10 +1,10 @@
		block discarded – undo
1	1	<?php // BEGIN PHP
2		-$websitekey=basename(__DIR__);
3		-if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) { require_once __DIR__.'/master.inc.php'; } // Load env if not already loaded
	2	+$websitekey = basename(__DIR__);
	3	+if (!defined('USEDOLIBARRSERVER') && !defined('USEDOLIBARREDITOR')) { require_once __DIR__.'/master.inc.php'; } // Load env if not already loaded
4	4	require_once DOL_DOCUMENT_ROOT.'/core/lib/website.lib.php';
5	5	require_once DOL_DOCUMENT_ROOT.'/core/website.inc.php';
6	6	ob_start();
7		-if (! headers_sent()) { /* because file is included inline when in edit mode and we don't want warning */
	7	+if (!headers_sent()) { /* because file is included inline when in edit mode and we don't want warning */
8	8	header('Cache-Control: max-age=3600, public, must-revalidate');
9	9	header('Content-type: text/css');
10	10	}

		@@ -1,7 +1,7 @@
		block discarded – undo
1	1	<?php
2	2	// File generated to link to the master file - DO NOT MODIFY - It is just an include
3	3	if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) {
4		- if (! defined('USEEXTERNALSERVER')) define('USEEXTERNALSERVER', 1);
5		- require_once '/home/ldestailleur/git/dolibarr_dev/htdocs/master.inc.php';
	4	+ if (! defined('USEEXTERNALSERVER')) define('USEEXTERNALSERVER', 1);
	5	+ require_once '/home/ldestailleur/git/dolibarr_dev/htdocs/master.inc.php';
6	6	}
7	7	?>

		@@ -1,7 +1,9 @@
		block discarded – undo
1	1	<?php
2	2	// File generated to link to the master file - DO NOT MODIFY - It is just an include
3	3	if (! defined('USEDOLIBARRSERVER') && ! defined('USEDOLIBARREDITOR')) {
4		- if (! defined('USEEXTERNALSERVER')) define('USEEXTERNALSERVER', 1);
	4	+ if (! defined('USEEXTERNALSERVER')) {
	5	+ define('USEEXTERNALSERVER', 1);
	6	+ }
5	7	require_once '/home/ldestailleur/git/dolibarr_dev/htdocs/master.inc.php';
6	8	}
7	9	?>

Dolibarr / dolibarr

Branch — develop (bd76a0)

Category

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch