Inspection of "Daily Inspection: Doc" - Dolibarr/dolibarr - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop (83be39)

unknown

created 2024-08-18 16:39 UTC

Status

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -46,7 +46,7 @@  discard block
 block discarded – undo
 
 $action = GETPOST('action', 'aZ09');
 $value = GETPOST('value', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $label = GETPOST('label', 'alpha');
 $scandir = GETPOST('scan_dir', 'alpha');
@@ -356,7 +356,7 @@  discard block
 block discarded – undo
 								print(empty($module->name) ? $name : $module->name);
 								print "</td><td>\n";
 								if (method_exists($module, 'info')) {
-									print $module->info($langs);  // @phan-suppress-current-line PhanUndeclaredMethod
+									print $module->info($langs); // @phan-suppress-current-line PhanUndeclaredMethod
 								} else {
 									print $module->description;
 								}

Please login to merge, or discard this patch.

htdocs/admin/mrp.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -40,7 +40,7 @@  discard block
 block discarded – undo
 
 $action = GETPOST('action', 'aZ09');
 $value = GETPOST('value', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $label = GETPOST('label', 'alpha');
 $scandir = GETPOST('scan_dir', 'alpha');
@@ -363,7 +363,7 @@  discard block
 block discarded – undo
 								print(empty($module->name) ? $name : $module->name);
 								print "</td><td>\n";
 								if (method_exists($module, 'info')) {
-									print $module->info($langs);  // @phan-suppress-current-line PhanUndeclaredMethod
+									print $module->info($langs); // @phan-suppress-current-line PhanUndeclaredMethod
 								} else {
 									print $module->description;
 								}

Please login to merge, or discard this patch.

htdocs/admin/supplier_invoice.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -44,7 +44,7 @@  discard block
 block discarded – undo
 
 $type = GETPOST('type', 'alpha');
 $value = GETPOST('value', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $label = GETPOST('label', 'alpha');
 $scandir = GETPOST('scan_dir', 'alpha');
@@ -380,7 +380,7 @@  discard block
 block discarded – undo
 					require_once $dir.'/'.$file;
 					$module = new $classname($db, $specimenthirdparty);
 					if (method_exists($module, 'info')) {
-						print $module->info($langs);  // @phan-suppress-current-line PhanUndeclaredMethod
+						print $module->info($langs); // @phan-suppress-current-line PhanUndeclaredMethod
 					} else {
 						print $module->description;
 					}

Please login to merge, or discard this patch.

htdocs/admin/invoice.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -46,7 +46,7 @@  discard block
 block discarded – undo
 
 $action = GETPOST('action', 'aZ09');
 $value = GETPOST('value', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $label = GETPOST('label', 'alpha');
 $scandir = GETPOST('scan_dir', 'alpha');
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
 		setEventMessages($langs->trans('Error'), null, 'errors');
 	} else {
 		setEventMessages($langs->trans('SetupSaved'), null, 'mesgs');
-		header("Location: " . $_SERVER["PHP_SELF"]);
+		header("Location: ".$_SERVER["PHP_SELF"]);
 		exit();
 	}
 } elseif (preg_match('/del_(.*)/', $action, $reg)) {
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
 		setEventMessages($langs->trans('Error'), null, 'errors');
 	} else {
 		setEventMessages($langs->trans('SetupSaved'), null, 'mesgs');
-		header("Location: " . $_SERVER["PHP_SELF"]);
+		header("Location: ".$_SERVER["PHP_SELF"]);
 		exit();
 	}
 }
@@ -367,7 +367,7 @@  discard block
 block discarded – undo
 
 							print '<td class="center">';
 							//print "> ".$conf->global->FACTURE_ADDON." - ".$file;
-							if ($conf->global->FACTURE_ADDON == $file || getDolGlobalString('FACTURE_ADDON') . '.php' == $file) {
+							if ($conf->global->FACTURE_ADDON == $file || getDolGlobalString('FACTURE_ADDON').'.php' == $file) {
 								print img_picto($langs->trans("Activated"), 'switch_on');
 							} else {
 								print '<a class="reposition" href="'.$_SERVER["PHP_SELF"].'?action=setmod&token='.newToken().'&value='.preg_replace('/\.php$/', '', $file).'" alt="'.$langs->trans("Default").'">'.img_picto($langs->trans("Disabled"), 'switch_off').'</a>';
@@ -440,7 +440,7 @@  discard block
 block discarded – undo
 							print '<td class="center">';
 							print $form->textwithpicto('', $htmltooltip, 1, 0);
 
-							if (getDolGlobalString('FACTURE_ADDON') . '.php' == $file) {  // If module is the one used, we show existing errors
+							if (getDolGlobalString('FACTURE_ADDON').'.php' == $file) {  // If module is the one used, we show existing errors
 								if (!empty($module->error)) {
 									dol_htmloutput_mesg($module->error, '', 'error', 1);
 								}
@@ -548,7 +548,7 @@  discard block
 block discarded – undo
 								print(empty($module->name) ? $name : $module->name);
 								print "</td><td>\n";
 								if (method_exists($module, 'info')) {
-									print $module->info($langs);  // @phan-suppress-current-line PhanUndeclaredMethod
+									print $module->info($langs); // @phan-suppress-current-line PhanUndeclaredMethod
 								} else {
 									print $module->description;
 								}
@@ -828,8 +828,8 @@  discard block
 block discarded – undo
 print '</form>';
 
 
-print '<tr class="oddeven"><td>'.$langs->trans("InvoiceCheckPosteriorDate"). '&nbsp;' ;
-print $form->textwithpicto('', $langs->trans("InvoiceCheckPosteriorDateHelp"), 1, 'help') . '</td>';
+print '<tr class="oddeven"><td>'.$langs->trans("InvoiceCheckPosteriorDate").'&nbsp;';
+print $form->textwithpicto('', $langs->trans("InvoiceCheckPosteriorDateHelp"), 1, 'help').'</td>';
 print '<td class="left" colspan="2">';
 print ajax_constantonoff('INVOICE_CHECK_POSTERIOR_DATE');
 print '</td></tr>';

Please login to merge, or discard this patch.

htdocs/admin/hrm.php 1 patch

Spacing +21 added lines, -21 removed lines patch added patch discarded remove patch

@@ -53,14 +53,14 @@  discard block
 block discarded – undo
 
 $value = GETPOST('value', 'alpha');
 $label = GETPOST('label', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $scandir = GETPOST('scan_dir', 'alpha');
 $type = 'evaluation';
 
 $arrayofparameters = array(
-	'HRM_MAXRANK' => array('type' => 'integer','enabled' => 1, 'css' => ''),
-	'HRM_DEFAULT_SKILL_DESCRIPTION' => array('type' => 'varchar','enabled' => 1, 'css' => ''),
+	'HRM_MAXRANK' => array('type' => 'integer', 'enabled' => 1, 'css' => ''),
+	'HRM_DEFAULT_SKILL_DESCRIPTION' => array('type' => 'varchar', 'enabled' => 1, 'css' => ''),
 );
 
 $error = 0;
@@ -422,7 +422,7 @@  discard block
 block discarded – undo
 										print(empty($module->name) ? $name : $module->name);
 										print "</td><td>\n";
 										if (method_exists($module, 'info')) {
-											print $module->info($langs);  // @phan-suppress-current-line PhanUndeclaredMethod
+											print $module->info($langs); // @phan-suppress-current-line PhanUndeclaredMethod
 										} else {
 											print $module->description;
 										}
@@ -511,24 +511,24 @@  discard block
 block discarded – undo
 		if ($val['enabled'] == 1) {
 			$setupnotempty++;
 			print '<tr class="oddeven"><td>';
-			$tooltiphelp = (($langs->trans($constname . 'Tooltip') != $constname . 'Tooltip') ? $langs->trans($constname . 'Tooltip') : '');
+			$tooltiphelp = (($langs->trans($constname.'Tooltip') != $constname.'Tooltip') ? $langs->trans($constname.'Tooltip') : '');
 			print '<span id="helplink'.$constname.'" class="spanforparamtooltip">'.$form->textwithpicto($langs->trans($constname), $tooltiphelp, 1, 'info', '', 0, 3, 'tootips'.$constname).'</span>';
 			print '</td><td>';
 
 			if ($val['type'] == 'textarea') {
-				print '<textarea class="flat" name="' . $constname . '" id="' . $constname . '" cols="50" rows="5" wrap="soft">' . "\n";
+				print '<textarea class="flat" name="'.$constname.'" id="'.$constname.'" cols="50" rows="5" wrap="soft">'."\n";
 				print getDolGlobalString($constname);
 				print "</textarea>\n";
 			} elseif ($val['type'] == 'integer') {
-				print '<input  class="flat" name="' . $constname . '" id="' . $constname . '" value="' . getDolGlobalString($constname) . '" type="number" step="1" min="0" max="50" >' . "\n";
+				print '<input  class="flat" name="'.$constname.'" id="'.$constname.'" value="'.getDolGlobalString($constname).'" type="number" step="1" min="0" max="50" >'."\n";
 			} elseif ($val['type'] == 'html') {
-				require_once DOL_DOCUMENT_ROOT . '/core/class/doleditor.class.php';
+				require_once DOL_DOCUMENT_ROOT.'/core/class/doleditor.class.php';
 				$doleditor = new DolEditor($constname, getDolGlobalString($constname), '', 160, 'dolibarr_notes', '', false, false, isModEnabled('fckeditor'), ROWS_5, '90%');
 				$doleditor->Create();
 			} elseif ($val['type'] == 'yesno') {
 				print $form->selectyesno($constname, getDolGlobalString($constname), 1);
 			} elseif (preg_match('/emailtemplate:/', $val['type'])) {
-				include_once DOL_DOCUMENT_ROOT . '/core/class/html.formmail.class.php';
+				include_once DOL_DOCUMENT_ROOT.'/core/class/html.formmail.class.php';
 				$formmail = new FormMail($db);
 
 				$tmp = explode(':', $val['type']);
@@ -540,10 +540,10 @@  discard block
 block discarded – undo
 						//var_dump($modelmail);
 						$moreonlabel = '';
 						if (!empty($arrayofmessagename[$modelmail->label])) {
-							$moreonlabel = ' <span class="opacitymedium">(' . $langs->trans("SeveralLangugeVariatFound") . ')</span>';
+							$moreonlabel = ' <span class="opacitymedium">('.$langs->trans("SeveralLangugeVariatFound").')</span>';
 						}
 						// The 'label' is the key that is unique if we exclude the language
-						$arrayofmessagename[$modelmail->id] = $langs->trans(preg_replace('/\(|\)/', '', $modelmail->label)) . $moreonlabel;
+						$arrayofmessagename[$modelmail->id] = $langs->trans(preg_replace('/\(|\)/', '', $modelmail->label)).$moreonlabel;
 					}
 				}
 				print $form->selectarray($constname, $arrayofmessagename, getDolGlobalString($constname), 'None', 0, 0, '', 0, 0, 0, '', '', 1);
@@ -556,25 +556,25 @@  discard block
 block discarded – undo
 				print img_picto('', 'category', 'class="pictofixedwidth"');
 				print $formother->select_categories($tmp[1], getDolGlobalString($constname), $constname, 0, $langs->trans('CustomersProspectsCategoriesShort'));
 			} elseif (preg_match('/thirdparty_type/', $val['type'])) {
-				require_once DOL_DOCUMENT_ROOT . '/core/class/html.formcompany.class.php';
+				require_once DOL_DOCUMENT_ROOT.'/core/class/html.formcompany.class.php';
 				$formcompany = new FormCompany($db);
 				print $formcompany->selectProspectCustomerType(getDolGlobalString($constname), $constname);
 			} elseif ($val['type'] == 'securekey') {
-				print '<input required="required" type="text" class="flat" id="' . $constname . '" name="' . $constname . '" value="' . (GETPOST($constname, 'alpha') ? GETPOST($constname, 'alpha') : getDolGlobalString($constname)) . '" size="40">';
+				print '<input required="required" type="text" class="flat" id="'.$constname.'" name="'.$constname.'" value="'.(GETPOST($constname, 'alpha') ? GETPOST($constname, 'alpha') : getDolGlobalString($constname)).'" size="40">';
 				if (!empty($conf->use_javascript_ajax)) {
-					print '&nbsp;' . img_picto($langs->trans('Generate'), 'refresh', 'id="generate_token' . $constname . '" class="linkobject"');
+					print '&nbsp;'.img_picto($langs->trans('Generate'), 'refresh', 'id="generate_token'.$constname.'" class="linkobject"');
 				}
 
 				// Add button to autosuggest a key
-				include_once DOL_DOCUMENT_ROOT . '/core/lib/security2.lib.php';
-				print dolJSToSetRandomPassword($constname, 'generate_token' . $constname);
+				include_once DOL_DOCUMENT_ROOT.'/core/lib/security2.lib.php';
+				print dolJSToSetRandomPassword($constname, 'generate_token'.$constname);
 			} elseif ($val['type'] == 'product') {
 				if (isModEnabled('product') || isModEnabled('service')) {
 					$selected = getDolGlobalString($constname);
 					$form->select_produits($selected, $constname, '', 0);
 				}
 			} else {
-				print '<input name="' . $constname . '"  class="flat ' . (empty($val['css']) ? 'minwidth200' : $val['css']) . '" value="' . getDolGlobalString($constname) . '">';
+				print '<input name="'.$constname.'"  class="flat '.(empty($val['css']) ? 'minwidth200' : $val['css']).'" value="'.getDolGlobalString($constname).'">';
 			}
 			print '</td></tr>';
 		}
@@ -596,7 +596,7 @@  discard block
 block discarded – undo
 			if ($val['enabled'] == 1) {
 				$setupnotempty++;
 				print '<tr class="oddeven"><td>';
-				$tooltiphelp = (($langs->trans($constname . 'Tooltip') != $constname . 'Tooltip') ? $langs->trans($constname . 'Tooltip') : '');
+				$tooltiphelp = (($langs->trans($constname.'Tooltip') != $constname.'Tooltip') ? $langs->trans($constname.'Tooltip') : '');
 				print $form->textwithpicto($langs->trans($constname), $tooltiphelp);
 				print '</td><td>';
 
@@ -607,7 +607,7 @@  discard block
 block discarded – undo
 				} elseif ($val['type'] == 'yesno') {
 					print ajax_constantonoff($constname);
 				} elseif (preg_match('/emailtemplate:/', $val['type'])) {
-					include_once DOL_DOCUMENT_ROOT . '/core/class/html.formmail.class.php';
+					include_once DOL_DOCUMENT_ROOT.'/core/class/html.formmail.class.php';
 					$formmail = new FormMail($db);
 
 					$tmp = explode(':', $val['type']);
@@ -626,9 +626,9 @@  discard block
 block discarded – undo
 					$ways = $c->print_all_ways(' &gt;&gt; ', 'none', 0, 1); // $ways[0] = "ccc2 >> ccc2a >> ccc2a1" with html formatted text
 					$toprint = array();
 					foreach ($ways as $way) {
-						$toprint[] = '<li class="select2-search-choice-dolibarr noborderoncategories"' . ($c->color ? ' style="background: #' . $c->color . ';"' : ' style="background: #bbb"') . '>' . $way . '</li>';
+						$toprint[] = '<li class="select2-search-choice-dolibarr noborderoncategories"'.($c->color ? ' style="background: #'.$c->color.';"' : ' style="background: #bbb"').'>'.$way.'</li>';
 					}
-					print '<div class="select2-container-multi-dolibarr" style="width: 90%;"><ul class="select2-choices-dolibarr">' . implode(' ', $toprint) . '</ul></div>';
+					print '<div class="select2-container-multi-dolibarr" style="width: 90%;"><ul class="select2-choices-dolibarr">'.implode(' ', $toprint).'</ul></div>';
 				} elseif (preg_match('/thirdparty_type/', $val['type'])) {
 					if (getDolGlobalString($constname) == 2) {
 						print $langs->trans("Prospect");

Please login to merge, or discard this patch.

htdocs/admin/expensereport.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -46,7 +46,7 @@  discard block
 block discarded – undo
 
 $action = GETPOST('action', 'aZ09');
 $value = GETPOST('value', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $label = GETPOST('label', 'alpha');
 $scandir = GETPOST('scan_dir', 'alpha');
@@ -376,7 +376,7 @@  discard block
 block discarded – undo
 							print(empty($module->name) ? $name : $module->name);
 							print "</td><td>\n";
 							if (method_exists($module, 'info')) {
-								print $module->info($langs);  // @phan-suppress-current-line PhanUndeclaredMethod
+								print $module->info($langs); // @phan-suppress-current-line PhanUndeclaredMethod
 							} else {
 								print $module->description;
 							}

Please login to merge, or discard this patch.

htdocs/admin/bank.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -361,7 +361,7 @@
 block discarded – undo
 								print(empty($module->name) ? $name : $module->name);
 								print "</td><td>\n";
 								if (method_exists($module, 'info')) {
-									print $module->info($langs);  // @phan-suppress-current-line PhanUndeclaredMethod
+									print $module->info($langs); // @phan-suppress-current-line PhanUndeclaredMethod
 								} else {
 									print $module->description;
 								}

Please login to merge, or discard this patch.

htdocs/admin/supplier_proposal.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -41,7 +41,7 @@  discard block
 block discarded – undo
 
 $action = GETPOST('action', 'aZ09');
 $value = GETPOST('value', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $label = GETPOST('label', 'alpha');
 $scandir = GETPOST('scan_dir', 'alpha');
@@ -194,7 +194,7 @@  discard block
 block discarded – undo
 		setEventMessages($langs->trans('Error'), null, 'errors');
 	} else {
 		setEventMessages($langs->trans('SetupSaved'), null, 'mesgs');
-		header("Location: " . $_SERVER["PHP_SELF"]);
+		header("Location: ".$_SERVER["PHP_SELF"]);
 		exit();
 	}
 } elseif (preg_match('/del_(.*)/', $action, $reg)) {
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
 		setEventMessages($langs->trans('Error'), null, 'errors');
 	} else {
 		setEventMessages($langs->trans('SetupSaved'), null, 'mesgs');
-		header("Location: " . $_SERVER["PHP_SELF"]);
+		header("Location: ".$_SERVER["PHP_SELF"]);
 		exit();
 	}
 }
@@ -413,7 +413,7 @@  discard block
 block discarded – undo
 								print(empty($module->name) ? $name : $module->name);
 								print "</td><td>\n";
 								if (method_exists($module, 'info')) {
-									print $module->info($langs);  // @phan-suppress-current-line PhanUndeclaredMethod
+									print $module->info($langs); // @phan-suppress-current-line PhanUndeclaredMethod
 								} else {
 									print $module->description;
 								}

Please login to merge, or discard this patch.

htdocs/admin/supplier_order.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -44,7 +44,7 @@  discard block
 block discarded – undo
 
 $type = GETPOST('type', 'alpha');
 $value = GETPOST('value', 'alpha');
-$modulepart = GETPOST('modulepart', 'aZ09');	// Used by actions_setmoduleoptions.inc.php
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
 
 $label = GETPOST('label', 'alpha');
 $scandir = GETPOST('scan_dir', 'alpha');
@@ -392,7 +392,7 @@  discard block
 block discarded – undo
 					require_once $dir.'/'.$file;
 					$module = new $classname($db, $specimenthirdparty);
 					if (method_exists($module, 'info')) {
-						print $module->info($langs);  // @phan-suppress-current-line PhanUndeclaredMethod
+						print $module->info($langs); // @phan-suppress-current-line PhanUndeclaredMethod
 					} else {
 						print $module->description;
 					}
@@ -553,8 +553,8 @@  discard block
 block discarded – undo
 
 
 // Disallow to classify billed a supplier order without invoice
-print '<tr class="oddeven"><td>'.$langs->trans("SupplierOrderClassifyBilledWithoutInvoice"). '&nbsp;' ;
-print $form->textwithpicto('', $langs->trans("SupplierOrderClassifyBilledWithoutInvoiceHelp"), 1, 'help') . '</td>';
+print '<tr class="oddeven"><td>'.$langs->trans("SupplierOrderClassifyBilledWithoutInvoice").'&nbsp;';
+print $form->textwithpicto('', $langs->trans("SupplierOrderClassifyBilledWithoutInvoiceHelp"), 1, 'help').'</td>';
 print '<td class="left" colspan="2">';
 print ajax_constantonoff('SUPPLIER_ORDER_DISABLE_CLASSIFY_BILLED_FROM_SUPPLIER_ORDER');
 print '</td></tr>';

Please login to merge, or discard this patch.

		@@ -53,14 +53,14 @@ discard block
		block discarded – undo
53	53
54	54	$value = GETPOST('value', 'alpha');
55	55	$label = GETPOST('label', 'alpha');
56		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	56	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
57	57
58	58	$scandir = GETPOST('scan_dir', 'alpha');
59	59	$type = 'evaluation';
60	60
61	61	$arrayofparameters = array(
62		- 'HRM_MAXRANK' => array('type' => 'integer','enabled' => 1, 'css' => ''),
63		- 'HRM_DEFAULT_SKILL_DESCRIPTION' => array('type' => 'varchar','enabled' => 1, 'css' => ''),
	62	+ 'HRM_MAXRANK' => array('type' => 'integer', 'enabled' => 1, 'css' => ''),
	63	+ 'HRM_DEFAULT_SKILL_DESCRIPTION' => array('type' => 'varchar', 'enabled' => 1, 'css' => ''),
64	64	);
65	65
66	66	$error = 0;
		@@ -422,7 +422,7 @@ discard block
		block discarded – undo
422	422	print(empty($module->name) ? $name : $module->name);
423	423	print "</td><td>\n";
424	424	if (method_exists($module, 'info')) {
425		- print $module->info($langs); // @phan-suppress-current-line PhanUndeclaredMethod
	425	+ print $module->info($langs); // @phan-suppress-current-line PhanUndeclaredMethod
426	426	} else {
427	427	print $module->description;
428	428	}
		@@ -511,24 +511,24 @@ discard block
		block discarded – undo
511	511	if ($val['enabled'] == 1) {
512	512	$setupnotempty++;
513	513	print '<tr class="oddeven"><td>';
514		- $tooltiphelp = (($langs->trans($constname . 'Tooltip') != $constname . 'Tooltip') ? $langs->trans($constname . 'Tooltip') : '');
	514	+ $tooltiphelp = (($langs->trans($constname.'Tooltip') != $constname.'Tooltip') ? $langs->trans($constname.'Tooltip') : '');
515	515	print '<span id="helplink'.$constname.'" class="spanforparamtooltip">'.$form->textwithpicto($langs->trans($constname), $tooltiphelp, 1, 'info', '', 0, 3, 'tootips'.$constname).'</span>';
516	516	print '</td><td>';
517	517
518	518	if ($val['type'] == 'textarea') {
519		- print '<textarea class="flat" name="' . $constname . '" id="' . $constname . '" cols="50" rows="5" wrap="soft">' . "\n";
	519	+ print '<textarea class="flat" name="'.$constname.'" id="'.$constname.'" cols="50" rows="5" wrap="soft">'."\n";
520	520	print getDolGlobalString($constname);
521	521	print "</textarea>\n";
522	522	} elseif ($val['type'] == 'integer') {
523		- print '<input class="flat" name="' . $constname . '" id="' . $constname . '" value="' . getDolGlobalString($constname) . '" type="number" step="1" min="0" max="50" >' . "\n";
	523	+ print '<input class="flat" name="'.$constname.'" id="'.$constname.'" value="'.getDolGlobalString($constname).'" type="number" step="1" min="0" max="50" >'."\n";
524	524	} elseif ($val['type'] == 'html') {
525		- require_once DOL_DOCUMENT_ROOT . '/core/class/doleditor.class.php';
	525	+ require_once DOL_DOCUMENT_ROOT.'/core/class/doleditor.class.php';
526	526	$doleditor = new DolEditor($constname, getDolGlobalString($constname), '', 160, 'dolibarr_notes', '', false, false, isModEnabled('fckeditor'), ROWS_5, '90%');
527	527	$doleditor->Create();
528	528	} elseif ($val['type'] == 'yesno') {
529	529	print $form->selectyesno($constname, getDolGlobalString($constname), 1);
530	530	} elseif (preg_match('/emailtemplate:/', $val['type'])) {
531		- include_once DOL_DOCUMENT_ROOT . '/core/class/html.formmail.class.php';
	531	+ include_once DOL_DOCUMENT_ROOT.'/core/class/html.formmail.class.php';
532	532	$formmail = new FormMail($db);
533	533
534	534	$tmp = explode(':', $val['type']);
		@@ -540,10 +540,10 @@ discard block
		block discarded – undo
540	540	//var_dump($modelmail);
541	541	$moreonlabel = '';
542	542	if (!empty($arrayofmessagename[$modelmail->label])) {
543		- $moreonlabel = ' <span class="opacitymedium">(' . $langs->trans("SeveralLangugeVariatFound") . ')</span>';
	543	+ $moreonlabel = ' <span class="opacitymedium">('.$langs->trans("SeveralLangugeVariatFound").')</span>';
544	544	}
545	545	// The 'label' is the key that is unique if we exclude the language
546		- $arrayofmessagename[$modelmail->id] = $langs->trans(preg_replace('/\(\|\)/', '', $modelmail->label)) . $moreonlabel;
	546	+ $arrayofmessagename[$modelmail->id] = $langs->trans(preg_replace('/\(\|\)/', '', $modelmail->label)).$moreonlabel;
547	547	}
548	548	}
549	549	print $form->selectarray($constname, $arrayofmessagename, getDolGlobalString($constname), 'None', 0, 0, '', 0, 0, 0, '', '', 1);
		@@ -556,25 +556,25 @@ discard block
		block discarded – undo
556	556	print img_picto('', 'category', 'class="pictofixedwidth"');
557	557	print $formother->select_categories($tmp[1], getDolGlobalString($constname), $constname, 0, $langs->trans('CustomersProspectsCategoriesShort'));
558	558	} elseif (preg_match('/thirdparty_type/', $val['type'])) {
559		- require_once DOL_DOCUMENT_ROOT . '/core/class/html.formcompany.class.php';
	559	+ require_once DOL_DOCUMENT_ROOT.'/core/class/html.formcompany.class.php';
560	560	$formcompany = new FormCompany($db);
561	561	print $formcompany->selectProspectCustomerType(getDolGlobalString($constname), $constname);
562	562	} elseif ($val['type'] == 'securekey') {
563		- print '<input required="required" type="text" class="flat" id="' . $constname . '" name="' . $constname . '" value="' . (GETPOST($constname, 'alpha') ? GETPOST($constname, 'alpha') : getDolGlobalString($constname)) . '" size="40">';
	563	+ print '<input required="required" type="text" class="flat" id="'.$constname.'" name="'.$constname.'" value="'.(GETPOST($constname, 'alpha') ? GETPOST($constname, 'alpha') : getDolGlobalString($constname)).'" size="40">';
564	564	if (!empty($conf->use_javascript_ajax)) {
565		- print ' ' . img_picto($langs->trans('Generate'), 'refresh', 'id="generate_token' . $constname . '" class="linkobject"');
	565	+ print ' '.img_picto($langs->trans('Generate'), 'refresh', 'id="generate_token'.$constname.'" class="linkobject"');
566	566	}
567	567
568	568	// Add button to autosuggest a key
569		- include_once DOL_DOCUMENT_ROOT . '/core/lib/security2.lib.php';
570		- print dolJSToSetRandomPassword($constname, 'generate_token' . $constname);
	569	+ include_once DOL_DOCUMENT_ROOT.'/core/lib/security2.lib.php';
	570	+ print dolJSToSetRandomPassword($constname, 'generate_token'.$constname);
571	571	} elseif ($val['type'] == 'product') {
572	572	if (isModEnabled('product') \|\| isModEnabled('service')) {
573	573	$selected = getDolGlobalString($constname);
574	574	$form->select_produits($selected, $constname, '', 0);
575	575	}
576	576	} else {
577		- print '<input name="' . $constname . '" class="flat ' . (empty($val['css']) ? 'minwidth200' : $val['css']) . '" value="' . getDolGlobalString($constname) . '">';
	577	+ print '<input name="'.$constname.'" class="flat '.(empty($val['css']) ? 'minwidth200' : $val['css']).'" value="'.getDolGlobalString($constname).'">';
578	578	}
579	579	print '</td></tr>';
580	580	}
		@@ -596,7 +596,7 @@ discard block
		block discarded – undo
596	596	if ($val['enabled'] == 1) {
597	597	$setupnotempty++;
598	598	print '<tr class="oddeven"><td>';
599		- $tooltiphelp = (($langs->trans($constname . 'Tooltip') != $constname . 'Tooltip') ? $langs->trans($constname . 'Tooltip') : '');
	599	+ $tooltiphelp = (($langs->trans($constname.'Tooltip') != $constname.'Tooltip') ? $langs->trans($constname.'Tooltip') : '');
600	600	print $form->textwithpicto($langs->trans($constname), $tooltiphelp);
601	601	print '</td><td>';
602	602
		@@ -607,7 +607,7 @@ discard block
		block discarded – undo
607	607	} elseif ($val['type'] == 'yesno') {
608	608	print ajax_constantonoff($constname);
609	609	} elseif (preg_match('/emailtemplate:/', $val['type'])) {
610		- include_once DOL_DOCUMENT_ROOT . '/core/class/html.formmail.class.php';
	610	+ include_once DOL_DOCUMENT_ROOT.'/core/class/html.formmail.class.php';
611	611	$formmail = new FormMail($db);
612	612
613	613	$tmp = explode(':', $val['type']);
		@@ -626,9 +626,9 @@ discard block
		block discarded – undo
626	626	$ways = $c->print_all_ways(' >> ', 'none', 0, 1); // $ways[0] = "ccc2 >> ccc2a >> ccc2a1" with html formatted text
627	627	$toprint = array();
628	628	foreach ($ways as $way) {
629		- $toprint[] = '<li class="select2-search-choice-dolibarr noborderoncategories"' . ($c->color ? ' style="background: #' . $c->color . ';"' : ' style="background: #bbb"') . '>' . $way . '</li>';
	629	+ $toprint[] = '<li class="select2-search-choice-dolibarr noborderoncategories"'.($c->color ? ' style="background: #'.$c->color.';"' : ' style="background: #bbb"').'>'.$way.'</li>';
630	630	}
631		- print '<div class="select2-container-multi-dolibarr" style="width: 90%;"><ul class="select2-choices-dolibarr">' . implode(' ', $toprint) . '</ul></div>';
	631	+ print '<div class="select2-container-multi-dolibarr" style="width: 90%;"><ul class="select2-choices-dolibarr">'.implode(' ', $toprint).'</ul></div>';
632	632	} elseif (preg_match('/thirdparty_type/', $val['type'])) {
633	633	if (getDolGlobalString($constname) == 2) {
634	634	print $langs->trans("Prospect");

		@@ -46,7 +46,7 @@ discard block
		block discarded – undo
46	46
47	47	$action = GETPOST('action', 'aZ09');
48	48	$value = GETPOST('value', 'alpha');
49		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	49	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
50	50
51	51	$label = GETPOST('label', 'alpha');
52	52	$scandir = GETPOST('scan_dir', 'alpha');
		@@ -356,7 +356,7 @@ discard block
		block discarded – undo
356	356	print(empty($module->name) ? $name : $module->name);
357	357	print "</td><td>\n";
358	358	if (method_exists($module, 'info')) {
359		- print $module->info($langs); // @phan-suppress-current-line PhanUndeclaredMethod
	359	+ print $module->info($langs); // @phan-suppress-current-line PhanUndeclaredMethod
360	360	} else {
361	361	print $module->description;
362	362	}

		@@ -40,7 +40,7 @@ discard block
		block discarded – undo
40	40
41	41	$action = GETPOST('action', 'aZ09');
42	42	$value = GETPOST('value', 'alpha');
43		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	43	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
44	44
45	45	$label = GETPOST('label', 'alpha');
46	46	$scandir = GETPOST('scan_dir', 'alpha');
		@@ -363,7 +363,7 @@ discard block
		block discarded – undo
363	363	print(empty($module->name) ? $name : $module->name);
364	364	print "</td><td>\n";
365	365	if (method_exists($module, 'info')) {
366		- print $module->info($langs); // @phan-suppress-current-line PhanUndeclaredMethod
	366	+ print $module->info($langs); // @phan-suppress-current-line PhanUndeclaredMethod
367	367	} else {
368	368	print $module->description;
369	369	}

		@@ -44,7 +44,7 @@ discard block
		block discarded – undo
44	44
45	45	$type = GETPOST('type', 'alpha');
46	46	$value = GETPOST('value', 'alpha');
47		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	47	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
48	48
49	49	$label = GETPOST('label', 'alpha');
50	50	$scandir = GETPOST('scan_dir', 'alpha');
		@@ -380,7 +380,7 @@ discard block
		block discarded – undo
380	380	require_once $dir.'/'.$file;
381	381	$module = new $classname($db, $specimenthirdparty);
382	382	if (method_exists($module, 'info')) {
383		- print $module->info($langs); // @phan-suppress-current-line PhanUndeclaredMethod
	383	+ print $module->info($langs); // @phan-suppress-current-line PhanUndeclaredMethod
384	384	} else {
385	385	print $module->description;
386	386	}

		@@ -361,7 +361,7 @@
		block discarded – undo
361	361	print(empty($module->name) ? $name : $module->name);
362	362	print "</td><td>\n";
363	363	if (method_exists($module, 'info')) {
364		- print $module->info($langs); // @phan-suppress-current-line PhanUndeclaredMethod
	364	+ print $module->info($langs); // @phan-suppress-current-line PhanUndeclaredMethod
365	365	} else {
366	366	print $module->description;
367	367	}

		@@ -41,7 +41,7 @@ discard block
		block discarded – undo
41	41
42	42	$action = GETPOST('action', 'aZ09');
43	43	$value = GETPOST('value', 'alpha');
44		-$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
	44	+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
45	45
46	46	$label = GETPOST('label', 'alpha');
47	47	$scandir = GETPOST('scan_dir', 'alpha');
		@@ -194,7 +194,7 @@ discard block
		block discarded – undo
194	194	setEventMessages($langs->trans('Error'), null, 'errors');
195	195	} else {
196	196	setEventMessages($langs->trans('SetupSaved'), null, 'mesgs');
197		- header("Location: " . $_SERVER["PHP_SELF"]);
	197	+ header("Location: ".$_SERVER["PHP_SELF"]);
198	198	exit();
199	199	}
200	200	} elseif (preg_match('/del_(.*)/', $action, $reg)) {
		@@ -209,7 +209,7 @@ discard block
		block discarded – undo
209	209	setEventMessages($langs->trans('Error'), null, 'errors');
210	210	} else {
211	211	setEventMessages($langs->trans('SetupSaved'), null, 'mesgs');
212		- header("Location: " . $_SERVER["PHP_SELF"]);
	212	+ header("Location: ".$_SERVER["PHP_SELF"]);
213	213	exit();
214	214	}
215	215	}
		@@ -413,7 +413,7 @@ discard block
		block discarded – undo
413	413	print(empty($module->name) ? $name : $module->name);
414	414	print "</td><td>\n";
415	415	if (method_exists($module, 'info')) {
416		- print $module->info($langs); // @phan-suppress-current-line PhanUndeclaredMethod
	416	+ print $module->info($langs); // @phan-suppress-current-line PhanUndeclaredMethod
417	417	} else {
418	418	print $module->description;
419	419	}

Dolibarr / dolibarr

Branch — develop (83be39)

Status

Category

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +21 added lines, -21 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch