| Conditions | 28 |
| Paths | > 20000 |
| Total Lines | 122 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 125 | public function toVCalendar($calid, $obj) |
||
| 126 | { |
||
| 127 | /*$categ = array(); |
||
| 128 | if($obj->soc_client) |
||
| 129 | { |
||
| 130 | $nick[] = $obj->soc_code_client; |
||
| 131 | $categ[] = $this->langs->transnoentitiesnoconv('Customer'); |
||
| 132 | }*/ |
||
| 133 | |||
| 134 | $location=$obj->location; |
||
| 135 | |||
| 136 | // contact address |
||
| 137 | if(empty($location) && !empty($obj->address)) |
||
| 138 | { |
||
| 139 | $location = trim(str_replace(array("\r","\t","\n"), ' ', $obj->address)); |
||
| 140 | $location = trim($location.', '.$obj->zip); |
||
| 141 | $location = trim($location.' '.$obj->town); |
||
| 142 | $location = trim($location.', '.$obj->country_label); |
||
| 143 | } |
||
| 144 | |||
| 145 | // contact address |
||
| 146 | if(empty($location) && !empty($obj->soc_address)) |
||
| 147 | { |
||
| 148 | $location = trim(str_replace(array("\r","\t","\n"), ' ', $obj->soc_address)); |
||
| 149 | $location = trim($location.', '.$obj->soc_zip); |
||
| 150 | $location = trim($location.' '.$obj->soc_town); |
||
| 151 | $location = trim($location.', '.$obj->soc_country_label); |
||
| 152 | } |
||
| 153 | |||
| 154 | $address=explode("\n", $obj->address, 2); |
||
| 155 | foreach($address as $kAddr => $vAddr) |
||
| 156 | { |
||
| 157 | $address[$kAddr] = trim(str_replace(array("\r","\t"), ' ', str_replace("\n", ' | ', trim($vAddr)))); |
||
| 158 | } |
||
| 159 | $address[]=''; |
||
| 160 | $address[]=''; |
||
| 161 | |||
| 162 | if($obj->percent==-1 && trim($obj->datep)!='') |
||
| 163 | $type='VEVENT'; |
||
| 164 | else |
||
| 165 | $type='VTODO'; |
||
| 166 | |||
| 167 | $timezone = date_default_timezone_get(); |
||
| 168 | |||
| 169 | $caldata ="BEGIN:VCALENDAR\n"; |
||
| 170 | $caldata.="VERSION:2.0\n"; |
||
| 171 | $caldata.="METHOD:PUBLISH\n"; |
||
| 172 | $caldata.="PRODID:-//Dolibarr CDav//FR\n"; |
||
| 173 | $caldata.="BEGIN:".$type."\n"; |
||
| 174 | $caldata.="CREATED:".gmdate('Ymd\THis', strtotime($obj->datec))."Z\n"; |
||
| 175 | $caldata.="LAST-MODIFIED:".gmdate('Ymd\THis', strtotime($obj->lastupd))."Z\n"; |
||
| 176 | $caldata.="DTSTAMP:".gmdate('Ymd\THis', strtotime($obj->lastupd))."Z\n"; |
||
| 177 | if($obj->sourceuid=='') |
||
| 178 | $caldata.="UID:".$obj->id.'-ev-'.$calid.'-cal-'.CDAV_URI_KEY."\n"; |
||
| 179 | else |
||
| 180 | $caldata.="UID:".$obj->sourceuid."\n"; |
||
| 181 | $caldata.="SUMMARY:".$obj->label."\n"; |
||
| 182 | $caldata.="LOCATION:".$location."\n"; |
||
| 183 | $caldata.="PRIORITY:".$obj->priority."\n"; |
||
| 184 | if($obj->fulldayevent) |
||
| 185 | { |
||
| 186 | $caldata.="DTSTART;VALUE=DATE:".date('Ymd', strtotime($obj->datep))."\n"; |
||
| 187 | if($type=='VEVENT') |
||
| 188 | { |
||
| 189 | if(trim($obj->datep2)!='') |
||
| 190 | $caldata.="DTEND;VALUE=DATE:".date('Ymd', strtotime($obj->datep2)+1)."\n"; |
||
| 191 | else |
||
| 192 | $caldata.="DTEND;VALUE=DATE:".date('Ymd', strtotime($obj->datep)+(25*3600))."\n"; |
||
| 193 | } |
||
| 194 | elseif(trim($obj->datep2)!='') |
||
| 195 | $caldata.="DUE;VALUE=DATE:".date('Ymd', strtotime($obj->datep2)+1)."\n"; |
||
| 196 | } |
||
| 197 | else |
||
| 198 | { |
||
| 199 | $caldata.="DTSTART;TZID=".$timezone.":".strtr($obj->datep, array(" "=>"T", ":"=>"", "-"=>""))."\n"; |
||
| 200 | if($type=='VEVENT') |
||
| 201 | { |
||
| 202 | if(trim($obj->datep2)!='') |
||
| 203 | $caldata.="DTEND;TZID=".$timezone.":".strtr($obj->datep2, array(" "=>"T", ":"=>"", "-"=>""))."\n"; |
||
| 204 | else |
||
| 205 | $caldata.="DTEND;TZID=".$timezone.":".strtr($obj->datep, array(" "=>"T", ":"=>"", "-"=>""))."\n"; |
||
| 206 | } |
||
| 207 | elseif(trim($obj->datep2)!='') |
||
| 208 | $caldata.="DUE;TZID=".$timezone.":".strtr($obj->datep2, array(" "=>"T", ":"=>"", "-"=>""))."\n"; |
||
| 209 | } |
||
| 210 | $caldata.="CLASS:PUBLIC\n"; |
||
| 211 | if($obj->transparency==1) |
||
| 212 | $caldata.="TRANSP:TRANSPARENT\n"; |
||
| 213 | else |
||
| 214 | $caldata.="TRANSP:OPAQUE\n"; |
||
| 215 | |||
| 216 | if($type=='VEVENT') |
||
| 217 | $caldata.="STATUS:CONFIRMED\n"; |
||
| 218 | elseif($obj->percent==0) |
||
| 219 | $caldata.="STATUS:NEEDS-ACTION\n"; |
||
| 220 | elseif($obj->percent==100) |
||
| 221 | $caldata.="STATUS:COMPLETED\n"; |
||
| 222 | else |
||
| 223 | { |
||
| 224 | $caldata.="STATUS:IN-PROCESS\n"; |
||
| 225 | $caldata.="PERCENT-COMPLETE:".$obj->percent."\n"; |
||
| 226 | } |
||
| 227 | |||
| 228 | $caldata.="DESCRIPTION:"; |
||
| 229 | $caldata.=strtr($obj->note, array("\n"=>"\\n", "\r"=>"")); |
||
| 230 | if(!empty($obj->soc_nom)) |
||
| 231 | $caldata.="\\n*DOLIBARR-SOC: ".$obj->soc_nom; |
||
| 232 | if(!empty($obj->soc_phone)) |
||
| 233 | $caldata.="\\n*DOLIBARR-SOC-TEL: ".$obj->soc_phone; |
||
| 234 | if(!empty($obj->firstname) || !empty($obj->lastname)) |
||
| 235 | $caldata.="\\n*DOLIBARR-CTC: ".trim($obj->firstname.' '.$obj->lastname); |
||
| 236 | if(!empty($obj->phone) || !empty($obj->phone_perso) || !empty($obj->phone_mobile)) |
||
| 237 | $caldata.="\\n*DOLIBARR-CTC-TEL: ".trim($obj->phone.' '.$obj->phone_perso.' '.$obj->phone_mobile); |
||
| 238 | if(strpos($obj->other_users, ',')) // several |
||
| 239 | $caldata.="\\n*DOLIBARR-USR: ".$obj->other_users; |
||
| 240 | $caldata.="\n"; |
||
| 241 | |||
| 242 | $caldata.="END:".$type."\n"; |
||
| 243 | $caldata.="END:VCALENDAR\n"; |
||
| 244 | |||
| 245 | return $caldata; |
||
| 246 | } |
||
| 247 | |||
| 305 |