Image::getValue() - Code Metrics - Inspection of "A bunch of fixes to make Media actually work" - Divergence/framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f4ebcb...ba1f71 )

by Henry

created 2018-09-25 07:12 UTC

Image::getValue() B

↳ Parent: Image

Complexity

Conditions	10
Paths	10

Size

Total Lines	39
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	10
eloc	25
nc	10
nop	1
dl	0
loc	39
rs	7.6666
c	0
b	0
f	0

How to fix Complexity

<?php
/**
 * This file is part of the Divergence package.
 *
 * @author Henry Paradiz <[email protected]>
 * @copyright 2018 Henry Paradiz <[email protected]>
 * @license MIT For the full copyright and license information, please view the LICENSE file that was distributed with this source code.
 *
 * @since 1.1
 */
namespace Divergence\Models\Media;

use Exception;

/**
 * Image Media Model
 *
 * @author Henry Paradiz <[email protected]>
 * @author Chris Alfano <[email protected]>
 *
 * {@inheritDoc}
 */
class Image extends Media
{
    // configurables
    public static $jpegCompression = 90;

    public function getValue($name)
    {
        switch ($name) {
            case 'ThumbnailMIMEType':
                switch ($this->MIMEType) {
                    case 'application/psd':
                        return 'image/png';
                    case 'image/tiff':
                        return 'image/jpeg';
                    default:
                        return $this->MIMEType;
                }

                // no break
            case 'Extension':

                switch ($this->MIMEType) {
                    case 'application/psd':
                        return 'psd';

                    case 'image/tiff':
                        return 'tif';

                    case 'image/gif':
                        return 'gif';

                    case 'image/jpeg':
                        return 'jpg';

                    case 'image/png':
                        return 'png';

                    default:
                        throw new Exception('Unable to find photo extension for mime-type: '.$this->MIMEType);
                }

                // no break
            default:
                return parent::getValue($name);
        }
    }


    // public methods


    // static methods
    public static function analyzeFile($filename, $mediaInfo = [])
    {
        if (!$mediaInfo['imageInfo'] = @getimagesize($filename)) {
            throw new Exception('Failed to read image file information');
        }

        // store image data
        $mediaInfo['width'] = $mediaInfo['imageInfo'][0];
        $mediaInfo['height'] = $mediaInfo['imageInfo'][1];
        $mediaInfo['duration'] = 0;

        return $mediaInfo;
    }
}


1			<?php
2			/**
3			* This file is part of the Divergence package.
4			*
5			* @author Henry Paradiz <[email protected]>
6			* @copyright 2018 Henry Paradiz <[email protected]>
7			* @license MIT For the full copyright and license information, please view the LICENSE file that was distributed with this source code.
8			*
9			* @since 1.1
10			*/
11			namespace Divergence\Models\Media;
12
13			use Exception;
14
15			/**
16			* Image Media Model
17			*
18			* @author Henry Paradiz <[email protected]>
19			* @author Chris Alfano <[email protected]>
20			*
21			* {@inheritDoc}
22			*/
23			class Image extends Media
24			{
25			// configurables
26			public static $jpegCompression = 90;
27
28			public function getValue($name)
29			{
30			switch ($name) {
31			case 'ThumbnailMIMEType':
32			switch ($this->MIMEType) {
33			case 'application/psd':
34			return 'image/png';
35			case 'image/tiff':
36			return 'image/jpeg';
37			default:
38			return $this->MIMEType;
39			}
40
41			// no break
42			case 'Extension':
43
44			switch ($this->MIMEType) {
45			case 'application/psd':
46			return 'psd';
47
48			case 'image/tiff':
49			return 'tif';
50
51			case 'image/gif':
52			return 'gif';
53
54			case 'image/jpeg':
55			return 'jpg';
56
57			case 'image/png':
58			return 'png';
59
60			default:
61			throw new Exception('Unable to find photo extension for mime-type: '.$this->MIMEType);
62			}
63
64			// no break
65			default:
66			return parent::getValue($name);
67			}
68			}
69
70
71			// public methods
72
73
74			// static methods
75			public static function analyzeFile($filename, $mediaInfo = [])
76			{
77			if (!$mediaInfo['imageInfo'] = @getimagesize($filename)) {
78			throw new Exception('Failed to read image file information');
79			}
80
81			// store image data
82			$mediaInfo['width'] = $mediaInfo['imageInfo'][0];
83			$mediaInfo['height'] = $mediaInfo['imageInfo'][1];
84			$mediaInfo['duration'] = 0;
85
86			return $mediaInfo;
87			}
88			}
89

Divergence / framework

Push — master ( f4ebcb...ba1f71 )

Image::getValue() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like