| Total Complexity | 42 |
| Total Lines | 249 |
| Duplicated Lines | 0 % |
| Changes | 0 | ||
Complex classes like Video often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Video, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 23 | class Video extends Media |
||
| 24 | { |
||
| 25 | // configurables |
||
| 26 | public static $ExtractFrameCommand = 'avconv -ss %2$u -i %1$s -an -vframes 1 -f mjpeg -'; // 1=video path, 2=position |
||
| 27 | public static $ExtractFramePosition = 3; |
||
| 28 | public static $encodingProfiles = [ |
||
| 29 | // from https://www.virag.si/2012/01/web-video-encoding-tutorial-with-ffmpeg-0-9/ |
||
| 30 | 'h264-high-480p' => [ |
||
| 31 | 'enabled' => true, |
||
| 32 | 'extension' => 'mp4', |
||
| 33 | 'mimeType' => 'video/mp4', |
||
| 34 | 'inputOptions' => [], |
||
| 35 | 'videoCodec' => 'h264', |
||
| 36 | 'videoOptions' => [ |
||
| 37 | 'profile:v' => 'high', |
||
| 38 | 'preset' => 'slow', |
||
| 39 | 'b:v' => '500k', |
||
| 40 | 'maxrate' => '500k', |
||
| 41 | 'bufsize' => '1000k', |
||
| 42 | 'vf' => 'scale="trunc(oh*a/2)*2:480"', // http://superuser.com/questions/571141/ffmpeg-avconv-force-scaled-output-to-be-divisible-by-2 |
||
| 43 | ], |
||
| 44 | 'audioCodec' => 'aac', |
||
| 45 | 'audioOptions' => [ |
||
| 46 | 'strict' => 'experimental', |
||
| 47 | ], |
||
| 48 | ], |
||
| 49 | |||
| 50 | // from http://superuser.com/questions/556463/converting-video-to-webm-with-ffmpeg-avconv |
||
| 51 | 'webm-480p' => [ |
||
| 52 | 'enabled' => true, |
||
| 53 | 'extension' => 'webm', |
||
| 54 | 'mimeType' => 'video/webm', |
||
| 55 | 'inputOptions' => [], |
||
| 56 | 'videoCodec' => 'libvpx', |
||
| 57 | 'videoOptions' => [ |
||
| 58 | 'vf' => 'scale=-1:480', |
||
| 59 | ], |
||
| 60 | 'audioCodec' => 'libvorbis', |
||
| 61 | ], |
||
| 62 | ]; |
||
| 63 | |||
| 64 | |||
| 65 | |||
| 66 | public function getValue($name) |
||
| 91 | } |
||
| 92 | } |
||
| 93 | |||
| 94 | |||
| 95 | // public methods |
||
| 96 | public function getImage($sourceFile = null) |
||
| 97 | { |
||
| 98 | if (!isset($sourceFile)) { |
||
| 99 | $sourceFile = $this->FilesystemPath ? $this->FilesystemPath : $this->BlankPath; |
||
| 100 | } |
||
| 101 | |||
| 102 | $cmd = sprintf(self::$ExtractFrameCommand, $sourceFile, min(self::$ExtractFramePosition, floor($this->Duration))); |
||
| 103 | |||
| 104 | if ($imageData = shell_exec($cmd)) { |
||
| 105 | return imagecreatefromstring($imageData); |
||
| 106 | } elseif ($sourceFile != $this->BlankPath) { |
||
| 107 | return static::getImage($this->BlankPath); |
||
| 108 | } |
||
| 109 | |||
| 110 | return null; |
||
| 111 | } |
||
| 112 | |||
| 113 | // static methods |
||
| 114 | public static function analyzeFile($filename, $mediaInfo = []) |
||
| 115 | { |
||
| 116 | // examine media with avprobe |
||
| 117 | $output = shell_exec("avprobe -of json -show_streams -v quiet $filename"); |
||
| 118 | |||
| 119 | if (!$output || !($output = json_decode($output, true)) || empty($output['streams'])) { |
||
| 120 | throw new MediaTypeException('Unable to examine video with avprobe, ensure lib-avtools is installed on the host system'); |
||
| 121 | } |
||
| 122 | |||
| 123 | // extract video streams |
||
| 124 | $videoStreams = array_filter($output['streams'], function ($streamInfo) { |
||
| 125 | return $streamInfo['codec_type'] == 'video'; |
||
| 126 | }); |
||
| 127 | |||
| 128 | if (!count($videoStreams)) { |
||
| 129 | throw new Exception('avprobe did not detect any video streams'); |
||
| 130 | } |
||
| 131 | |||
| 132 | // convert and write interesting information to mediaInfo |
||
| 133 | $mediaInfo['streams'] = $output['streams']; |
||
| 134 | $mediaInfo['videoStream'] = array_shift($videoStreams); |
||
| 135 | |||
| 136 | $mediaInfo['width'] = (int)$mediaInfo['videoStream']['width']; |
||
| 137 | $mediaInfo['height'] = (int)$mediaInfo['videoStream']['height']; |
||
| 138 | $mediaInfo['duration'] = (double)$mediaInfo['videoStream']['duration']; |
||
| 139 | |||
| 140 | return $mediaInfo; |
||
| 141 | } |
||
| 142 | |||
| 143 | public function writeFile($sourceFile) |
||
| 144 | { |
||
| 145 | parent::writeFile($sourceFile); |
||
| 146 | |||
| 147 | |||
| 148 | // determine rotation metadata with exiftool |
||
| 149 | $exifToolOutput = exec("exiftool -S -Rotation $this->FilesystemPath"); |
||
| 150 | |||
| 151 | if (!$exifToolOutput || !preg_match('/Rotation\s*:\s*(?<rotation>\d+)/', $exifToolOutput, $matches)) { |
||
| 152 | throw new Exception('Unable to examine video with exiftool, ensure libimage-exiftool-perl is installed on the host system'); |
||
| 153 | } |
||
| 154 | |||
| 155 | $sourceRotation = intval($matches['rotation']); |
||
| 156 | |||
| 157 | |||
| 158 | // fork encoding job with each configured profile |
||
| 159 | foreach (static::$encodingProfiles as $profileName => $profile) { |
||
| 160 | if (empty($profile['enabled'])) { |
||
| 161 | continue; |
||
| 162 | } |
||
| 163 | |||
| 164 | |||
| 165 | // build paths and create directories if needed |
||
| 166 | $outputPath = $this->getFilesystemPath($profileName); |
||
| 167 | if (!is_dir($outputDir = dirname($outputPath))) { |
||
| 168 | mkdir($outputDir, static::$newDirectoryPermissions, true); |
||
| 169 | } |
||
| 170 | |||
| 171 | $tmpOutputPath = $outputDir.'/'.'tmp-'.basename($outputPath); |
||
| 172 | ; |
||
| 173 | |||
| 174 | |||
| 175 | // build avconv command |
||
| 176 | $cmd = ['avconv', '-loglevel quiet']; |
||
| 177 | |||
| 178 | // -- input options |
||
| 179 | if (!empty($profile['inputOptions'])) { |
||
| 180 | static::_appendAvconvOptions($cmd, $profile['inputOptions']); |
||
| 181 | } |
||
| 182 | $cmd[] = '-i'; |
||
| 183 | $cmd[] = $this->FilesystemPath; |
||
| 184 | |||
| 185 | // -- video output options |
||
| 186 | $cmd[] = '-codec:v'; |
||
| 187 | $cmd[] = $profile['videoCodec']; |
||
| 188 | if (!empty($profile['videoOptions'])) { |
||
| 189 | static::_appendAvconvOptions($cmd, $profile['videoOptions']); |
||
| 190 | } |
||
| 191 | |||
| 192 | // -- audio output options |
||
| 193 | $cmd[] = '-codec:a'; |
||
| 194 | $cmd[] = $profile['audioCodec']; |
||
| 195 | if (!empty($profile['audioOptions'])) { |
||
| 196 | static::_appendAvconvOptions($cmd, $profile['audioOptions']); |
||
| 197 | } |
||
| 198 | |||
| 199 | // -- normalize smartphone rotation |
||
| 200 | $cmd[] = '-metadata:s:v rotate="0"'; |
||
| 201 | |||
| 202 | if ($sourceRotation == 90) { |
||
| 203 | $cmd[] = '-vf "transpose=1"'; |
||
| 204 | } elseif ($sourceRotation == 180) { |
||
| 205 | $cmd[] = '-vf "transpose=1,transpose=1"'; |
||
| 206 | } elseif ($sourceRotation == 270) { |
||
| 207 | $cmd[] = '-vf "transpose=1,transpose=1,transpose=1"'; |
||
| 208 | } |
||
| 209 | |||
| 210 | // -- general output options |
||
| 211 | if (!empty($profile['outputOptions'])) { |
||
| 212 | static::_appendAvconvOptions($cmd, $profile['outputOptions']); |
||
| 213 | } |
||
| 214 | $cmd[] = $tmpOutputPath; |
||
| 215 | |||
| 216 | |||
| 217 | // move to final path after it finished |
||
| 218 | $cmd[] = "&& mv $tmpOutputPath $outputPath"; |
||
| 219 | |||
| 220 | |||
| 221 | // convert command to string and decorate for process control |
||
| 222 | $cmd = '(nohup '.implode(' ', $cmd).') > /dev/null 2>/dev/null & echo $! &'; |
||
| 223 | |||
| 224 | |||
| 225 | // execute command and retrieve the spawned PID |
||
| 226 | $pid = exec($cmd); |
||
| 227 | // TODO: store PID somewhere in APCU cache so we can do something smarter when a video is requested before it's done encoding |
||
| 228 | } |
||
| 229 | } |
||
| 230 | |||
| 231 | public function getFilesystemPath($variant = 'original', $filename = null) |
||
| 232 | { |
||
| 233 | if (!$filename && array_key_exists($variant, static::$encodingProfiles)) { |
||
| 234 | $filename = $this->ID.'.'.static::$encodingProfiles[$variant]['extension']; |
||
| 235 | $variant = 'video-'.$variant; |
||
| 236 | } |
||
| 237 | |||
| 238 | return parent::getFilesystemPath($variant, $filename); |
||
| 239 | } |
||
| 240 | |||
| 241 | public function getMIMEType($variant = 'original') |
||
| 248 | } |
||
| 249 | |||
| 250 | public function isVariantAvailable($variant) |
||
| 251 | { |
||
| 261 | } |
||
| 262 | |||
| 263 | protected static function _appendAvconvOptions(array &$cmd, array $options) |
||
| 272 | } |
||
| 273 | } |
||
| 276 |