Distilleries\Contentful\Http\Controllers\WebhookTrait

Complexity

Total Complexity

5

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	live()	0	3	1
A	preview()	0	5	1
A	handle()	0	13	3

<?php

namespace Distilleries\Contentful\Http\Controllers;

use Illuminate\Http\Request;
use Illuminate\Http\JsonResponse;
use Distilleries\Contentful\Webhook\Manager;

trait WebhookTrait
{
    /**
     * Handle Contentful live webhook.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\JsonResponse
     */
    public function live(Request $request): JsonResponse
    {
        return $this->handle($request, false);
    }

    /**
     * Handle Contentful preview webhook.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\JsonResponse
     */
    public function preview(Request $request): JsonResponse
    {
        use_contentful_preview();

        return $this->handle($request, true);
    }

    /**
     * Handle webhook request.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  boolean  $isPreview
     * @return \Illuminate\Http\JsonResponse
     */
    protected function handle(Request $request, bool $isPreview): JsonResponse
    {
        $headers = $request->header();
        $headers = is_string($headers) ? [$headers] : $headers;
        $payload = $request->all();

        $response = (new Manager)->handle($headers, $payload, $isPreview);

It seems like $headers can also be of type null; however, parameter $headers of Distilleries\Contentful\Webhook\Manager::handle() does only seem to accept array, maybe add an additional type check?

        $responseClass = response();

        if (method_exists($responseClass, 'json')) {
            return $responseClass->json($response['message'], $response['status']);
        } else {
            return response(json_encode($response['message']), $response['status']);

The expression return response(json_encode($response['message']), $response['status']) returns the type Illuminate\Http\Response which is incompatible with the type-hinted return Illuminate\Http\JsonResponse.

        }
    }
}