Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php namespace Distilleries\Expendable\Http\Forms\User; |
||
7 | class UserForm extends FormValidator { |
||
8 | |||
9 | public static $rules = [ |
||
10 | 'email' => 'required|email|unique:users', |
||
11 | 'password' => 'required|min:8', |
||
12 | 'status' => 'required|integer', |
||
13 | 'role_id' => 'required|integer', |
||
14 | ]; |
||
15 | |||
16 | public static $rules_update = [ |
||
17 | 'id' => 'required', |
||
18 | 'email' => 'required|email|unique:users,email', |
||
19 | 'status' => 'required|integer', |
||
20 | 'role_id' => 'required|integer', |
||
21 | ]; |
||
22 | |||
23 | // ------------------------------------------------------------------------------------------------ |
||
24 | |||
25 | |||
26 | public function buildForm() |
||
76 | |||
77 | View Code Duplication | protected function getUpdateRules() |
|
84 | } |