ServiceController - Code Metrics - Inspection of "Change name of folders" - Distilleries/Expendable - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 188ffb...31684b )

by Maxime

created 2017-07-03 09:49 UTC

ServiceController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	5
c	1
b	0
f	0
lcom	1
cbo	3
dl	0
loc	39
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
B	getSynchronize()	0	26	4

<?php namespace Distilleries\Expendable\Http\Controllers\Backend;

use Distilleries\Expendable\Contracts\LayoutManagerContract;
use Distilleries\Expendable\Http\Datatables\Service\ServiceDatatable;
use Distilleries\Expendable\Http\Forms\Service\ServiceForm;
use Distilleries\Expendable\Http\Controllers\Backend\Base\BaseComponent;
use Distilleries\Expendable\Models\Service;
use Illuminate\Contracts\Routing\Registrar;

class ServiceController extends BaseComponent {

    public function __construct(ServiceDatatable $datatable, ServiceForm $form, Service $model, LayoutManagerContract $layoutManager)
    {
        parent::__construct($model, $layoutManager);
        $this->datatable = $datatable;
        $this->form      = $form;
    }


    // ------------------------------------------------------------------------------------------------

    public function getSynchronize(Registrar $router)
    {

        $routes = $router->getRoutes();

        foreach ($routes->getRoutes() as $controller)
        {
            $actions = $controller->getAction();

            if (!empty($actions['controller'])) {
                $service       = $actions['controller'];
                $serviceObject = $this->model->getByAction($service);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

                if ($serviceObject->isEmpty())
                {
                    $model         = new $this->model;
                    $model->action = $service;
                    $model->save();
                }
            }


        }

        return redirect()->back();
    }
}

1			<?php namespace Distilleries\Expendable\Http\Controllers\Backend;
2
3			use Distilleries\Expendable\Contracts\LayoutManagerContract;
4			use Distilleries\Expendable\Http\Datatables\Service\ServiceDatatable;
5			use Distilleries\Expendable\Http\Forms\Service\ServiceForm;
6			use Distilleries\Expendable\Http\Controllers\Backend\Base\BaseComponent;
7			use Distilleries\Expendable\Models\Service;
8			use Illuminate\Contracts\Routing\Registrar;
9
10			class ServiceController extends BaseComponent {
11
12			public function __construct(ServiceDatatable $datatable, ServiceForm $form, Service $model, LayoutManagerContract $layoutManager)
13			{
14			parent::__construct($model, $layoutManager);
15			$this->datatable = $datatable;
16			$this->form = $form;
17			}
18
19
20			// ------------------------------------------------------------------------------------------------
21
22			public function getSynchronize(Registrar $router)
23			{
24
25			$routes = $router->getRoutes();
26
27			foreach ($routes->getRoutes() as $controller)
28			{
29			$actions = $controller->getAction();
30
31			if (!empty($actions['controller'])) {
32			$service = $actions['controller'];
33			$serviceObject = $this->model->getByAction($service);
			0 ignored issues – show Documentation Bug introduced 2016-01-14 16:09 UTC by Report Bug Copy Issue Report The method `getByAction` does not exist on `object<Distilleries\Expendable\Models\BaseModel>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
34
35			if ($serviceObject->isEmpty())
36			{
37			$model = new $this->model;
38			$model->action = $service;
39			$model->save();
40			}
41			}
42
43
44			}
45
46			return redirect()->back();
47			}
48			}

Distilleries / Expendable

Push — master ( 188ffb...31684b )

ServiceController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like