LockableTrait - Code Metrics - Inspection of "Add infinit menu" - Distilleries/Expendable - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5c2d4b...c8c0f9 )

by Maxime

created 2016-06-15 12:17 UTC

LockableTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	47
Duplicated Lines	44.68 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

40%

Importance

Changes	2
Bugs	1	Features	1

Metric	Value
wmc	4
c	2
b	1
f	1
lcom	1
cbo	0
dl	21
loc	47
ccs	8
cts	20
cp	0.4
rs	10

4 Methods

Rating	Name	Duplication	Size	Complexity
A	isLocked()	0	6	1
A	incrementLock()	0	10	1
A	unlock()	11	11	1
A	lock()	10	10	1

How to fix Duplicated Code

<?php namespace Distilleries\Expendable\Models;


trait LockableTrait
{
    protected $config_key_security_lock = 'expendable.auth.nb_of_try';
    protected $column_nb_of_try_name = 'nb_of_try';

    public function isLocked()
    {

        return ($this->{$this->column_nb_of_try_name} >= config($this->config_key_security_lock));

    }

    public function incrementLock()
    {

        $this->{$this->column_nb_of_try_name} += 1;
        \DB::table($this->getTable())
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->where($this->getKeyName(),$this->getKey())
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->increment($this->column_nb_of_try_name);
        return $this;

    }

    public function unlock()
    {

        \DB::table($this->getTable())
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->where($this->getKeyName(),$this->getKey())
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->decrement($this->column_nb_of_try_name,$this->{$this->column_nb_of_try_name});

        $this->{$this->column_nb_of_try_name} = 0;
        return $this;

    }

    public function lock()
    {
        $this->{$this->column_nb_of_try_name} = config($this->config_key_security_lock) + 1;

        \DB::table($this->getTable())
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->where($this->getKeyName(),$this->getKey())
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->increment($this->column_nb_of_try_name,$this->{$this->column_nb_of_try_name} );

        return $this;
    }

} 

1			<?php namespace Distilleries\Expendable\Models;
2
3
4			trait LockableTrait
5			{
6			protected $config_key_security_lock = 'expendable.auth.nb_of_try';
7			protected $column_nb_of_try_name = 'nb_of_try';
8
9	4		public function isLocked()
10			{
11
12	4		return ($this->{$this->column_nb_of_try_name} >= config($this->config_key_security_lock));
13
14			}
15
16			public function incrementLock()
17			{
18
19			$this->{$this->column_nb_of_try_name} += 1;
20			\DB::table($this->getTable())
			0 ignored issues – show Bug introduced 2016-06-15 12:48 UTC by Report Bug Copy Issue Report It seems like `getTable()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
21			->where($this->getKeyName(),$this->getKey())
			0 ignored issues – show Bug introduced 2016-06-15 12:48 UTC by Report Bug Copy Issue Report It seems like `getKeyName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2016-06-15 12:48 UTC by Report Bug Copy Issue Report It seems like `getKey()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
22			->increment($this->column_nb_of_try_name);
23			return $this;
24
25			}
26
27	12	View Code Duplication	public function unlock()
28			{
29
30	12		\DB::table($this->getTable())
			0 ignored issues – show Bug introduced 2016-06-15 12:48 UTC by Report Bug Copy Issue Report It seems like `getTable()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
31	12		->where($this->getKeyName(),$this->getKey())
			0 ignored issues – show Bug introduced 2016-06-15 12:48 UTC by Report Bug Copy Issue Report It seems like `getKeyName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2016-06-15 12:48 UTC by Report Bug Copy Issue Report It seems like `getKey()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
32	12		->decrement($this->column_nb_of_try_name,$this->{$this->column_nb_of_try_name});
33
34	12		$this->{$this->column_nb_of_try_name} = 0;
35	12		return $this;
36
37			}
38
39		View Code Duplication	public function lock()
40			{
41			$this->{$this->column_nb_of_try_name} = config($this->config_key_security_lock) + 1;
42
43			\DB::table($this->getTable())
			0 ignored issues – show Bug introduced 2016-06-15 12:48 UTC by Report Bug Copy Issue Report It seems like `getTable()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
44			->where($this->getKeyName(),$this->getKey())
			0 ignored issues – show Bug introduced 2016-06-15 12:48 UTC by Report Bug Copy Issue Report It seems like `getKeyName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2016-06-15 12:48 UTC by Report Bug Copy Issue Report It seems like `getKey()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
45			->increment($this->column_nb_of_try_name,$this->{$this->column_nb_of_try_name} );
46
47			return $this;
48			}
49
50			}

Distilleries / Expendable

Push — master ( 5c2d4b...c8c0f9 )

LockableTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like