UserListener::handleLockIncrement() - Code Metrics - Inspection of "Merge pull request #3 from Distilleries/feature/us..." - Distilleries/Expendable - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 22caaa...988d36 )

by Maxime

created 2016-01-15 15:16 UTC

UserListener::handleLockIncrement() A

↳ Parent: UserListener

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2.0625

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	10
ccs	6
cts	8
cp	0.75
rs	9.4285
cc	2
eloc	5
nc	2
nop	1
crap	2.0625

<?php namespace Distilleries\Expendable\Listeners;

use Distilleries\Expendable\Contracts\LockableContract;
use Distilleries\Expendable\Helpers\UserUtils;
use Distilleries\Expendable\Models\User;

class UserListener extends BaseListener
{

    /**
     * @var array[
     * 'user.login'=>[
     *      'action'=>'handleLogin',
     *      'priority'=>0
     *  ]
     * ]
     *
     */
    protected $events = [
        'user.login'    => [
            'action'   => 'handleLogin',
            'priority' => 0,
        ],
        'user.logout'   => [
            'action'   => 'handleLogOut',
            'priority' => 0,
        ],
        'user.security' => [
            'action'   => 'handleLockIncrement',
            'priority' => 0,
        ]
    ];

    public function handleLogin(LockableContract $model)
    {


        if($model->email != ''){
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $model->unlock();
        }

        $areaServices = [];

        $role = $model->role;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        if (!empty($role))
        {
            foreach ($model->role->permissions as $permission)
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            {
                $areaServices[] = $permission->service->action;
            }

        }


        UserUtils::setArea($areaServices);
        UserUtils::setIsLoggedIn();
        UserUtils::setDisplayAllStatus();

    }

    public function handleLogOut()
    {
        UserUtils::forgotArea();
        UserUtils::forgotIsLoggedIn();
        UserUtils::forgotDisplayAllStatus();


    }

    public function handleLockIncrement($email)
    {
        $model = app('Distilleries\Expendable\Contracts\LockableContract');
        $user  = $model->where('email', $email)->get()->last();

        if (!empty($user))
        {
            $user->incrementLock();
        }
    }
}


Push — master ( 22caaa...988d36 )

UserListener::handleLockIncrement() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

1		<?php namespace Distilleries\Expendable\Listeners;
2
3		use Distilleries\Expendable\Contracts\LockableContract;
4		use Distilleries\Expendable\Helpers\UserUtils;
5		use Distilleries\Expendable\Models\User;
6
7		class UserListener extends BaseListener
8		{
9
10		/**
11		* @var array[
12		* 'user.login'=>[
13		* 'action'=>'handleLogin',
14		* 'priority'=>0
15		* ]
16		* ]
17		*
18		*/
19		protected $events = [
20		'user.login' => [
21		'action' => 'handleLogin',
22		'priority' => 0,
23		],
24		'user.logout' => [
25		'action' => 'handleLogOut',
26		'priority' => 0,
27		],
28		'user.security' => [
29		'action' => 'handleLockIncrement',
30		'priority' => 0,
31		]
32		];
33
34	16	public function handleLogin(LockableContract $model)
35		{
36
37
38	16	if($model->email != ''){
		0 ignored issues – show Bug introduced 2016-01-15 15:20 UTC by Report Bug Copy Issue Report Accessing `email` on the interface `Distilleries\Expendable\Contracts\LockableContract` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
39	8	$model->unlock();
40	8	}
41
42	16	$areaServices = [];
43
44	16	$role = $model->role;
		0 ignored issues – show Bug introduced 2016-01-15 15:20 UTC by Report Bug Copy Issue Report Accessing `role` on the interface `Distilleries\Expendable\Contracts\LockableContract` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
45
46	16	if (!empty($role))
47	16	{
48	8	foreach ($model->role->permissions as $permission)
		0 ignored issues – show Bug introduced 2016-01-15 15:20 UTC by Report Bug Copy Issue Report Accessing `role` on the interface `Distilleries\Expendable\Contracts\LockableContract` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
49		{
50	8	$areaServices[] = $permission->service->action;
51	8	}
52
53	8	}
54
55
56	16	UserUtils::setArea($areaServices);
57	16	UserUtils::setIsLoggedIn();
58	16	UserUtils::setDisplayAllStatus();
59
60	16	}
61
62	16	public function handleLogOut()
63		{
64	16	UserUtils::forgotArea();
65	16	UserUtils::forgotIsLoggedIn();
66	16	UserUtils::forgotDisplayAllStatus();
67
68
69	16	}
70
71	4	public function handleLockIncrement($email)
72		{
73	4	$model = app('Distilleries\Expendable\Contracts\LockableContract');
74	4	$user = $model->where('email', $email)->get()->last();
75
76	4	if (!empty($user))
77	4	{
78		$user->incrementLock();
79		}
80	4	}
81		}
82

Distilleries / Expendable

Push — master ( 22caaa...988d36 )

UserListener::handleLockIncrement() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like