Distilleries\Expendable\States\OrderStateTrait

Complexity

Total Complexity

4

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getOrder()	0	12	1
A	postOrder()	0	16	3

<?php

namespace Distilleries\Expendable\States;

use Illuminate\Http\Request;

trait OrderStateTrait
{
    /**
     * {@inheritdoc}
     */
    public function getOrder()
    {
        $rows = $this->model->orderBy($this->model->orderFieldName(), 'asc')->get();

The property model does not exist. Did you maybe forget to declare it?

        $this->layoutManager->add([

The property layoutManager does not exist. Did you maybe forget to declare it?

            'content' => view('expendable::admin.form.state.order', [
                'rows' => $rows,
            ]),
        ]);

        return $this->layoutManager->render();
    }

    /**
     * {@inheritdoc}
     */
    public function postOrder(Request $request)
    {
        $ids = $request->input('ids');

        $order = 1;
        foreach ($ids as $id) {

The expression $ids of type string|array|null is not guaranteed to be traversable. How about adding an additional type check?

            $instance = $this->model->find($id);
            if (! empty($instance)) {
                $instance->{$this->model->orderFieldName()} = $order;
                $instance->save();
                $order++;
            }
        }

        return response()->json(['error' => false]);
    }
}