ExportStateTrait - Code Metrics - Inspection of "Merge pull request #29 from intraordinaire/feature..." - Distilleries/Expendable - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 49d50b...c2310d )

by Maxime

created 2019-02-04 09:42 UTC

ExportStateTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	53
Duplicated Lines	37.74 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	8
lcom	1
cbo	3
dl	20
loc	53
ccs	22
cts	22
cp	1
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getExport()	20	20	1
B	postExport()	0	22	7

How to fix Duplicated Code

<?php namespace Distilleries\Expendable\States;

use Carbon\Carbon;
use \FormBuilder;
use Illuminate\Http\Request;
use Distilleries\Expendable\Exports\BaseExport;

trait ExportStateTrait {

    protected $export_form = 'Distilleries\Expendable\Http\Forms\Export\ExportForm';
    // ------------------------------------------------------------------------------------------------
    // ------------------------------------------------------------------------------------------------
    // ------------------------------------------------------------------------------------------------

    public function getExport()
    {
        $form = FormBuilder::create($this->export_form, [
            'model' => $this->model
class MyClass { }

$x = new MyClass();
$x->foo = true;
        ]);

        $form_content = view('expendable::admin.form.components.formgenerator.export', [
            'form' => $form
        ]);
        $content      = view('expendable::admin.form.state.form', [

        ]);

        $this->layoutManager->add([
class MyClass { }

$x = new MyClass();
$x->foo = true;
            'form'=>$form_content,
            'content'=>$content,
        ]);

        return $this->layoutManager->render();
    }

    // ------------------------------------------------------------------------------------------------

    public function postExport(Request $request)
    {

        $form = FormBuilder::create($this->export_form, [
            'model' => $this->model
        ]);


        if ($form->hasError())
        {
            return $form->validateAndRedirectBack();
        }


        $data = $request->all();
        $dateStart = !empty($data['range']) && !empty($data['range']['start']) ? $data['range']['start'] : Carbon::now()->format('Y-m-d');
        $dateEnd = !empty($data['range']) && !empty($data['range']['end']) ? $data['range']['end'] : Carbon::now()->format('Y-m-d');
        $type = !empty($data['type']) ? $data['type'] : 'csv';
        $filename = $dateStart . ' ' . $dateEnd . '.' . $type;

        return (new BaseExport($this->model, $data))->export($filename);
    }
} 

1			<?php namespace Distilleries\Expendable\States;
2
3			use Carbon\Carbon;
4			use \FormBuilder;
5			use Illuminate\Http\Request;
6			use Distilleries\Expendable\Exports\BaseExport;
7
8			trait ExportStateTrait {
9
10			protected $export_form = 'Distilleries\Expendable\Http\Forms\Export\ExportForm';
11			// ------------------------------------------------------------------------------------------------
12			// ------------------------------------------------------------------------------------------------
13			// ------------------------------------------------------------------------------------------------
14
15	2	View Code Duplication	public function getExport()
16			{
17	2		$form = FormBuilder::create($this->export_form, [
18	2		'model' => $this->model
			0 ignored issues – show Bug introduced 2016-01-14 16:09 UTC by Report Bug Copy Issue Report The property `model` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
19			]);
20
21	2		$form_content = view('expendable::admin.form.components.formgenerator.export', [
22	2		'form' => $form
23			]);
24	2		$content = view('expendable::admin.form.state.form', [
25
26	2		]);
27
28	2		$this->layoutManager->add([
			0 ignored issues – show Bug introduced 2016-01-14 16:09 UTC by Report Bug Copy Issue Report The property `layoutManager` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
29	2		'form'=>$form_content,
30	2		'content'=>$content,
31			]);
32
33	2		return $this->layoutManager->render();
34			}
35
36			// ------------------------------------------------------------------------------------------------
37
38	10		public function postExport(Request $request)
39			{
40
41	10		$form = FormBuilder::create($this->export_form, [
42	10		'model' => $this->model
43			]);
44
45
46	10		if ($form->hasError())
47			{
48	6		return $form->validateAndRedirectBack();
49			}
50
51
52	4		$data = $request->all();
53	4		$dateStart = !empty($data['range']) && !empty($data['range']['start']) ? $data['range']['start'] : Carbon::now()->format('Y-m-d');
54	4		$dateEnd = !empty($data['range']) && !empty($data['range']['end']) ? $data['range']['end'] : Carbon::now()->format('Y-m-d');
55	4		$type = !empty($data['type']) ? $data['type'] : 'csv';
56	4		$filename = $dateStart . ' ' . $dateEnd . '.' . $type;
57
58	4		return (new BaseExport($this->model, $data))->export($filename);
59			}
60			}

Distilleries / Expendable

Push — master ( 49d50b...c2310d )

ExportStateTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like