ExportStateTrait - Code Metrics - Inspection of "Update php 7 unit testing" - Distilleries/Expendable - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2c722f...4f3f82 )

by Maxime

created 2016-07-22 16:21 UTC

ExportStateTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	65
Duplicated Lines	30.77 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

93.75%

Importance

Changes	4
Bugs	1	Features	1

Metric	Value
wmc	5
c	4
b	1
f	1
lcom	1
cbo	2
dl	20
loc	65
ccs	30
cts	32
cp	0.9375
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
B	postExport()	0	34	4
A	getExport()	20	20	1

How to fix Duplicated Code

<?php namespace Distilleries\Expendable\States;

use \FormBuilder;
use Illuminate\Http\Request;

trait ExportStateTrait {

    protected $export_form = 'Distilleries\Expendable\Forms\Export\ExportForm';
    // ------------------------------------------------------------------------------------------------
    // ------------------------------------------------------------------------------------------------
    // ------------------------------------------------------------------------------------------------

    public function getExport()
    {
        $form = FormBuilder::create($this->export_form, [
            'model' => $this->model
class MyClass { }

$x = new MyClass();
$x->foo = true;
        ]);

        $form_content = view('expendable::admin.form.components.formgenerator.export', [
            'form' => $form
        ]);
        $content      = view('expendable::admin.form.state.form', [

        ]);

        $this->layoutManager->add([
class MyClass { }

$x = new MyClass();
$x->foo = true;
            'form'=>$form_content,
            'content'=>$content,
        ]);

        return $this->layoutManager->render();
    }

    // ------------------------------------------------------------------------------------------------

    public function postExport(Request $request)
    {

        $form = FormBuilder::create($this->export_form, [
            'model' => $this->model
        ]);


        if ($form->hasError())
        {
            return $form->validateAndRedirectBack();
        }


        $data = $request->all();

        foreach ($data['range'] as $key => $date)
        {
            $data['range'][$key] = date('Y-m-d', strtotime($date));
        }

        $result = $this->model->betweenCreate($data['range']['start'], $data['range']['end'])->get();

        if (!$result->isEmpty())
        {
            $exporter = app($data['type']);
            $file     = $exporter->export($result->toArray(), $data['range']['start'] . ' ' . $data['range']['end']);

            return $file;
        }

        return redirect()->to(action('\\' . get_class($this) . '@getExport'));

    }
} 

1			<?php namespace Distilleries\Expendable\States;
2
3			use \FormBuilder;
4			use Illuminate\Http\Request;
5
6			trait ExportStateTrait {
7
8			protected $export_form = 'Distilleries\Expendable\Forms\Export\ExportForm';
9			// ------------------------------------------------------------------------------------------------
10			// ------------------------------------------------------------------------------------------------
11			// ------------------------------------------------------------------------------------------------
12
13	4	View Code Duplication	public function getExport()
14			{
15	4		$form = FormBuilder::create($this->export_form, [
16	4		'model' => $this->model
			0 ignored issues – show Bug introduced 2016-01-14 16:09 UTC by Report Bug Copy Issue Report The property `model` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
17	3		]);
18
19	4		$form_content = view('expendable::admin.form.components.formgenerator.export', [
20	1		'form' => $form
21	3		]);
22	4		$content = view('expendable::admin.form.state.form', [
23
24	4		]);
25
26	4		$this->layoutManager->add([
			0 ignored issues – show Bug introduced 2016-01-14 16:09 UTC by Report Bug Copy Issue Report The property `layoutManager` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
27	4		'form'=>$form_content,
28	4		'content'=>$content,
29	3		]);
30
31	4		return $this->layoutManager->render();
32			}
33
34			// ------------------------------------------------------------------------------------------------
35
36	12		public function postExport(Request $request)
37			{
38
39	12		$form = FormBuilder::create($this->export_form, [
40	12		'model' => $this->model
41	9		]);
42
43
44	12		if ($form->hasError())
45	9		{
46	4		return $form->validateAndRedirectBack();
47			}
48
49
50	8		$data = $request->all();
51
52	8		foreach ($data['range'] as $key => $date)
53			{
54	8		$data['range'][$key] = date('Y-m-d', strtotime($date));
55	6		}
56
57	8		$result = $this->model->betweenCreate($data['range']['start'], $data['range']['end'])->get();
58
59	8		if (!$result->isEmpty())
60	6		{
61	8		$exporter = app($data['type']);
62	8		$file = $exporter->export($result->toArray(), $data['range']['start'] . ' ' . $data['range']['end']);
63
64			return $file;
65			}
66
67			return redirect()->to(action('\\' . get_class($this) . '@getExport'));
68
69			}
70			}

Distilleries / Expendable

Push — master ( 2c722f...4f3f82 )

ExportStateTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like