Distilleries\Expendable\States\FormStateTrait

Complexity

Total Complexity

36

Size/Duplication

Total Lines	248
Duplicated Lines	0 %

Test Coverage

Coverage

54%

Importance

Changes	9
Bugs	0	Features	0

13 Methods

Rating	Name	Duplication	Size	Complexity
A	postTranslation()	0	30	5
A	isTranslatableModel()	0	3	1
A	dataToSave()	0	3	1
A	getView()	0	21	3
A	getControllerNameForAction()	0	6	1
A	afterSave()	0	3	1
A	getEdit()	0	26	5
A	beforeSave()	0	3	1
A	save()	0	12	3
A	getTranslation()	0	28	4
A	saveTranslation()	0	3	1
A	postEdit()	0	30	6
A	findAutoDetectTranslation()	0	17	4

<?php namespace Distilleries\Expendable\States;

use \FormBuilder;
use Illuminate\Http\Request;

trait FormStateTrait {

    /**
     * @var \Kris\LaravelFormBuilder\Form $form
     * Injected by the constructor
     */
    protected $form;


    // ------------------------------------------------------------------------------------------------
    // ------------------------------------------------------------------------------------------------
    // ------------------------------------------------------------------------------------------------
    protected function isTranslatableModel()
    {
        return method_exists($this->model, 'withoutTranslation');
    }

    protected function findAutoDetectTranslation($id, $orfail = true)
    {
        if ($orfail) {
            if ($this->isTranslatableModel()) {
                return $this->model->withoutTranslation()->findOrFail($id);
            } else {
                return $this->model->findOrFail($id);
            }
        } else {
            if ($this->isTranslatableModel()) {
                return $this->model->withoutTranslation()->find($id);
            } else {
                return $this->model->find($id);
            }
        }

        return null;

return null is not reachable.

    }

    // ------------------------------------------------------------------------------------------------

    public function getEdit($id = '')
    {
        $model = (!empty($id) || $id === "0") ? $this->findAutoDetectTranslation($id) : $this->model;
        $form  = FormBuilder::create(get_class($this->form), [
            'model' => $model
        ]);


        if ($this->isTranslatableModel()) {
            $local_overide = $this->model->getIso($model->getTable(), $model->id);
            if (!empty($local_overide)) {
                $form->add('local_override', 'hidden', ['default_value' => $local_overide]);
            }
        }

        $form_content = view('form-builder::form.components.formgenerator.full', [
            'form' => $form
        ]);

        $this->layoutManager->add([
            'content' => view('expendable::admin.form.state.form', [
                'form' => $form_content
            ])
        ]);

        return $this->layoutManager->render();
    }

    // ------------------------------------------------------------------------------------------------

    public function getTranslation($iso, $id)
    {

        $id_element = $this->model->hasBeenTranslated($this->model->getTable(), $id, $iso);
        if (!empty($id_element)) {
            return redirect()->to(action($this->getControllerNameForAction().'@getEdit', $id_element));
        }

        $model = (!empty($id) || $id === "0") ? $this->model->withoutTranslation()->findOrFail($id) : $this->model;
        $form  = FormBuilder::create(get_class($this->form), [
            'model' => $model
        ])
            ->remove('id')
            ->add('translation_iso', 'hidden', ['default_value' => $iso])
            ->add('translation_id_source', 'hidden', ['default_value' => $id])
            ->add('local_override', 'hidden', ['default_value' => $iso]);

        $form_content = view('form-builder::form.components.formgenerator.full', [
            'form' => $form
        ]);

        $this->layoutManager->add([
            'content' => view('expendable::admin.form.state.form', [
                'form' => $form_content
            ])
        ]);

        return $this->layoutManager->render();
    }

    // ------------------------------------------------------------------------------------------------

    public function postTranslation(Request $request)
    {


        $form = FormBuilder::create(get_class($this->form), [
            'model' => $this->model
        ]);


        if ($form->hasError()) {
            return $form->validateAndRedirectBack();
        }

        $result = $this->beforeSave();

Are you sure the assignment to $result is correct as $this->beforeSave() targeting Distilleries\Expendable\States\FormStateTrait::beforeSave() seems to always return null.

        if ($result != null) {

The condition $result != null is always false.

            return $result;
        }

        $result = $this->save($this->dataToSave($request), $request);

Are you sure the assignment to $result is correct as $this->save($this->dataToSave($request), $request) targeting Distilleries\Expendable\States\FormStateTrait::save() seems to always return null.

        if ($this->isTranslatableModel()) {
            $this->saveTranslation($request->get('translation_iso'), $request->get('translation_id_source'));
        }

        if ($result != null) {

The condition $result != null is always false.

            return $result;
        }

        return redirect()->to(action($this->getControllerNameForAction().'@getIndex'));
    }

    // ------------------------------------------------------------------------------------------------

    public function postEdit(Request $request)
    {

        $form = FormBuilder::create(get_class($this->form), [
            'model' => $this->model
        ]);


        if ($form->hasError()) {
            return $form->validateAndRedirectBack();
        }

        $result = $this->beforeSave();

Are you sure the assignment to $result is correct as $this->beforeSave() targeting Distilleries\Expendable\States\FormStateTrait::beforeSave() seems to always return null.

        if ($result != null) {

The condition $result != null is always false.

            return $result;
        }

        $result = $this->save($this->dataToSave($request), $request);

Are you sure the assignment to $result is correct as $this->save($this->dataToSave($request), $request) targeting Distilleries\Expendable\States\FormStateTrait::save() seems to always return null.

        if ($this->isTranslatableModel() && !$this->model->hasTranslation($this->model->getTable(), $this->model->getKey())) {
            $this->saveTranslation(app()->getLocale());

The method getLocale() does not exist on Illuminate\Container\Container. Are you sure you never get this type here, but always one of the subclasses?

        }

        if ($result != null) {

The condition $result != null is always false.

            return $result;
        }

        return redirect()->to(action($this->getControllerNameForAction().'@getIndex'));

    }

    // ------------------------------------------------------------------------------------------------

    protected function dataToSave(Request $request)
    {
        return $request->only($this->model->getFillable());
    }

    // ------------------------------------------------------------------------------------------------

    protected function beforeSave()
    {
        return null;
    }

    // ------------------------------------------------------------------------------------------------

    protected function afterSave()
    {
        return null;
    }


    // ------------------------------------------------------------------------------------------------

    protected function save($data, Request $request)
    {

        $primary = $request->get($this->model->getKeyName());
        if ($primary !== "0" && empty($primary)) {
            $this->model = $this->model->create($data);

The property model does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        } else {
            $this->model = $this->findAutoDetectTranslation($primary, false);
            $this->model->update($data);
        }

        return $this->afterSave();

Are you sure the usage of $this->afterSave() targeting Distilleries\Expendable\States\FormStateTrait::afterSave() seems to always return null.

    }

    // ------------------------------------------------------------------------------------------------

    protected function saveTranslation($translation_iso, $translation_id_source = 0)
    {
        $this->model->setTranslation($this->model->getKey(), $this->model->getTable(), $translation_id_source, $translation_iso);
    }


    // ------------------------------------------------------------------------------------------------

    public function getView($id)
    {

        $model = (!empty($id) || $id === "0") ? $this->findAutoDetectTranslation($id) : $this->model;
        $form  = FormBuilder::create(get_class($this->form), [
            'model' => $model
        ]);

        $form_content = view('form-builder::form.components.formgenerator.info', [
            'form'  => $form,
            'id'    => $id,
            'route' => $this->getControllerNameForAction().'@',
        ]);

        $this->layoutManager->add([
            'content' => view('expendable::admin.form.state.form', [
                'form' => $form_content
            ])
        ]);

        return $this->layoutManager->render();

    }

    // ------------------------------------------------------------------------------------------------

    protected function getControllerNameForAction()
    {

        $action = explode('@', \Route::currentRouteAction());

        return '\\'.$action[0];
    }
}