for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php namespace Distilleries\Expendable\Http\Controllers\Frontend;
use Distilleries\Expendable\Http\Controllers\Frontend\Base\BaseController;
class AssetController extends BaseController {
public function getIndex($path = '')
{
$directory = explode('/', $path);
$directory = reset($directory);
$white_liste = config('expendable.folder_whitelist');
if (in_array($directory, $white_liste))
$path = storage_path($path);
$filesystem = app('files');
if ($filesystem->isFile($path))
$mimetype = mime_content_type($path);
if (@is_array(getimagesize($path)))
return response()->make($filesystem->get($path), 200, array('content-type' => $mimetype));
} else
$name = explode('/', $path);
$name = end($name);
return response()->download($path, $name, array('content-type' => $mimetype));
}
return abort(404);
abort(404)
null
This check looks for function or method calls that always return null and whose return value is used.
class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) {
The method getObject() can return nothing but null, so it makes no sense to use the return value.
getObject()
The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.
Distilleries /
Expendable
This check looks for function or method calls that always return null and whose return value is used.
The method
getObject()can return nothing but null, so it makes no sense to use the return value.The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.