App\Application\Traits\WorkerAnalyzedTitlesTrait

Complexity

Total Complexity

7

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	initializePastAnalyzedTitles()	0	12	3
A	checkAlreadyAnalyzed()	0	3	2
A	memorizeAndSaveAnalyzedTitle()	0	5	2

<?php
/*
 * This file is part of dispositif/wikibot application (@github)
 * 2019-2023 © Philippe M./Irønie  <dispositif@gmail.com>
 * For the full copyright and MIT license information, view the license file.
 */

declare(strict_types=1);

namespace App\Application\Traits;

use Throwable;

/*
 * todo extract to service/adapter/infra
 */
trait WorkerAnalyzedTitlesTrait
{
    protected function initializePastAnalyzedTitles(): void
    {
        try {
            $analyzed = file(
                static::ARTICLE_ANALYZED_FILENAME,

The constant App\Application\Traits\WorkerAnalyzedTitlesTrait::ARTICLE_ANALYZED_FILENAME was not found. Maybe you did not declare it correctly or list all dependencies?

                FILE_IGNORE_NEW_LINES | FILE_SKIP_EMPTY_LINES
            );
        } catch (Throwable $e) {
            $this->log->critical("Can't parse ARTICLE_ANALYZED_FILENAME : " . $e->getMessage());
            $analyzed = [];
        }
        $this->pastAnalyzed = ($analyzed !== false) ? $analyzed : [];

The condition $analyzed !== false is always true.

The property pastAnalyzed does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    protected function memorizeAndSaveAnalyzedTitle(string $title): void
    {
        if (!$this->checkAlreadyAnalyzed($title)) {
            $this->pastAnalyzed[] = $title; // skip doublon title

The property pastAnalyzed does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            @file_put_contents(static::ARTICLE_ANALYZED_FILENAME, $title . PHP_EOL, FILE_APPEND);

The constant App\Application\Traits\WorkerAnalyzedTitlesTrait::ARTICLE_ANALYZED_FILENAME was not found. Maybe you did not declare it correctly or list all dependencies?

        }
    }

    protected function checkAlreadyAnalyzed(string $title): bool
    {
        return is_array($this->pastAnalyzed) && in_array($title, $this->pastAnalyzed);
    }
}