App\Infrastructure\CirrusSearch::search()

Complexity

Conditions	3
Paths	3

Size

Total Lines	15
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function search(string $url): array
    {
        $json = file_get_contents($url);

        $myArray = json_decode($json, true);
        $result = $myArray['query']['search'];
        if (empty($result)) {
            return [];
        }

        foreach ($result as $res) {
            $titles[] = trim($res['title']);
        }

        return $titles;

The variable $titles seems to be defined by a foreach iteration on line 38. Are you sure the iterator is never empty, otherwise this variable is not defined?

    }